Re: r310776 - PR34163: Don't cache an incorrect key function for a class if queried between

2017-08-17 Thread Hans Wennborg via cfe-commits
Merged in r311105. On Mon, Aug 14, 2017 at 10:07 AM, Hans Wennborg wrote: > Sounds good to me. Let's give it another day and see how it goes. > > On Fri, Aug 11, 2017 at 6:48 PM, Richard Smith wrote: >> Hi Hans, >> >> I'd like to get this into Clang 5, but it's not entirely risk-free. Perhaps >>

Re: r310776 - PR34163: Don't cache an incorrect key function for a class if queried between

2017-08-14 Thread Hans Wennborg via cfe-commits
Sounds good to me. Let's give it another day and see how it goes. On Fri, Aug 11, 2017 at 6:48 PM, Richard Smith wrote: > Hi Hans, > > I'd like to get this into Clang 5, but it's not entirely risk-free. Perhaps > we could leave it in the tree for a little while and then merge if it seems > OK? >

Re: r310776 - PR34163: Don't cache an incorrect key function for a class if queried between

2017-08-11 Thread Richard Smith via cfe-commits
Hi Hans, I'd like to get this into Clang 5, but it's not entirely risk-free. Perhaps we could leave it in the tree for a little while and then merge if it seems OK? On 11 August 2017 at 18:46, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Fri Aug 11

r310776 - PR34163: Don't cache an incorrect key function for a class if queried between

2017-08-11 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Aug 11 18:46:03 2017 New Revision: 310776 URL: http://llvm.org/viewvc/llvm-project?rev=310776&view=rev Log: PR34163: Don't cache an incorrect key function for a class if queried between the class becoming complete and its inline methods being parsed. This replaces the hac