Re: r313082 - [Driver] MinGW: Remove custom linker detection

2017-09-12 Thread Rui Ueyama via cfe-commits
I'm perhaps not the only person who is wondering, so I'll update the original thread instead of replying to this thread. On Tue, Sep 12, 2017 at 4:07 PM, Martell Malone wrote: > cc @rui this is why I reverted it. > > On Wed, Sep 13, 2017 at 12:00 AM, Martell Malone

Re: r313082 - [Driver] MinGW: Remove custom linker detection

2017-09-12 Thread Martell Malone via cfe-commits
cc @rui this is why I reverted it. On Wed, Sep 13, 2017 at 12:00 AM, Martell Malone wrote: > Hi Mike, > > I reverted this for now, I assume it has to do with the argument ordering. > Will try a change and re apply. > > Many Thanks, > Martell > > On Tue, Sep 12, 2017 at

Re: r313082 - [Driver] MinGW: Remove custom linker detection

2017-09-12 Thread Martell Malone via cfe-commits
Hi Mike, I reverted this for now, I assume it has to do with the argument ordering. Will try a change and re apply. Many Thanks, Martell On Tue, Sep 12, 2017 at 11:57 PM, Martell Malone wrote: > Hi Mike, > > I actually posted this in the phab thread a few minutes ago.

Re: r313082 - [Driver] MinGW: Remove custom linker detection

2017-09-12 Thread Martell Malone via cfe-commits
Hi Mike, I actually posted this in the phab thread a few minutes ago. ``` Tests for this pass locally but the build bots are complaining with // CHECK_LLD_32: "{{[^"]*}}ld.lld{{(.exe)?}}" ^ :1:1: note: scanning from here clang version 6.0.0 (trunk 313082) ^ :5:51: note:

Re: r313082 - [Driver] MinGW: Remove custom linker detection

2017-09-12 Thread Mike Edwards via cfe-commits
Hi, Would you please have a look at: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/42380/ it appears this commit is causing some tests to fail on our bots. Any assistance you may provide in getting the bots back green would be greatly appreciated. Respectfully, Mike

r313082 - [Driver] MinGW: Remove custom linker detection

2017-09-12 Thread Martell Malone via cfe-commits
Author: martell Date: Tue Sep 12 15:14:18 2017 New Revision: 313082 URL: http://llvm.org/viewvc/llvm-project?rev=313082=rev Log: [Driver] MinGW: Remove custom linker detection In rL289668 the ability to specify the default linker at compile time was added but because the MinGW driver used custom