Re: r313088 - Revert "[Driver] MinGW: Remove custom linker detection"

2017-09-12 Thread Rui Ueyama via cfe-commits
It is reverted because it broke buildbots: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/42380/testReport/junit/Clang/Driver/mingw_useld_c/ On Tue, Sep 12, 2017 at 4:05 PM, Rui Ueyama wrote: > I wonder why you reverted this change. > > On Tue, Sep 12, 2017 at 4:04 PM, Mar

Re: r313088 - Revert "[Driver] MinGW: Remove custom linker detection"

2017-09-12 Thread Martell Malone via cfe-commits
Just incase anyone comes here wondering why. The thread for the original patch `r313082 - [Driver] MinGW: Remove custom linker detection` here on cfe-commits explains why. On Wed, Sep 13, 2017 at 12:05 AM, Rui Ueyama wrote: > I wonder why you reverted this change. > > On Tue, Sep 12, 2017 at 4:

Re: r313088 - Revert "[Driver] MinGW: Remove custom linker detection"

2017-09-12 Thread Rui Ueyama via cfe-commits
I wonder why you reverted this change. On Tue, Sep 12, 2017 at 4:04 PM, Martell Malone wrote: > Will do in future, thanks Rui. > > On Wed, Sep 13, 2017 at 12:03 AM, Rui Ueyama wrote: > >> When you revert a commit, please explain why you are reverting it in the >> commit message. >> >> On Tue, S

Re: r313088 - Revert "[Driver] MinGW: Remove custom linker detection"

2017-09-12 Thread Martell Malone via cfe-commits
Will do in future, thanks Rui. On Wed, Sep 13, 2017 at 12:03 AM, Rui Ueyama wrote: > When you revert a commit, please explain why you are reverting it in the > commit message. > > On Tue, Sep 12, 2017 at 3:58 PM, Martell Malone via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author:

Re: r313088 - Revert "[Driver] MinGW: Remove custom linker detection"

2017-09-12 Thread Rui Ueyama via cfe-commits
When you revert a commit, please explain why you are reverting it in the commit message. On Tue, Sep 12, 2017 at 3:58 PM, Martell Malone via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: martell > Date: Tue Sep 12 15:58:12 2017 > New Revision: 313088 > > URL: http://llvm.org/viewvc/l

r313088 - Revert "[Driver] MinGW: Remove custom linker detection"

2017-09-12 Thread Martell Malone via cfe-commits
Author: martell Date: Tue Sep 12 15:58:12 2017 New Revision: 313088 URL: http://llvm.org/viewvc/llvm-project?rev=313088&view=rev Log: Revert "[Driver] MinGW: Remove custom linker detection" This reverts rL313082 Modified: cfe/trunk/lib/Driver/ToolChains/MinGW.cpp cfe/trunk/test/Driver/mi