Re: r316268 - [Sema] Fixes for enum handling for tautological comparison diagnostics

2018-01-19 Thread Roman Lebedev via cfe-commits
On Fri, Jan 19, 2018 at 2:22 AM, Alex L wrote: > Hi Roman, Hi. > This commit has caused a regression in LLVM 6 which now triggers > -Wsign-compare for typeof(enum) and typeof(enumConstant). Interesting, first impression is that it appears to be a false-positive. > I filed > https://bugs.llvm.org

Re: r316268 - [Sema] Fixes for enum handling for tautological comparison diagnostics

2018-01-18 Thread Alex L via cfe-commits
Hi Roman, This commit has caused a regression in LLVM 6 which now triggers -Wsign-compare for typeof(enum) and typeof(enumConstant). I filed https://bugs.llvm.org/show_bug.cgi?id=36008. Could you please take a look at it? Thanks, Alex On 21 October 2017 at 09:44, Roman Lebedev via cfe-commits <

Re: r316268 - [Sema] Fixes for enum handling for tautological comparison diagnostics

2017-10-24 Thread Roman Lebedev via cfe-commits
On Tue, Oct 24, 2017 at 3:00 PM, Hans Wennborg wrote: > On Mon, Oct 23, 2017 at 2:02 PM, Roman Lebedev wrote: >> On Mon, Oct 23, 2017 at 2:13 PM, Hans Wennborg wrote: >> Hi. >> >>> This seems to have had the side effect of introducing a new warning in >>> Chromium builds: >>> >>> ../../third_par

Re: r316268 - [Sema] Fixes for enum handling for tautological comparison diagnostics

2017-10-24 Thread Hans Wennborg via cfe-commits
On Mon, Oct 23, 2017 at 2:02 PM, Roman Lebedev wrote: > On Mon, Oct 23, 2017 at 2:13 PM, Hans Wennborg wrote: > Hi. > >> This seems to have had the side effect of introducing a new warning in >> Chromium builds: >> >> ../../third_party/expat/files/lib/xmlparse.c(2429,24): error: >> comparison of

Re: r316268 - [Sema] Fixes for enum handling for tautological comparison diagnostics

2017-10-23 Thread Roman Lebedev via cfe-commits
On Mon, Oct 23, 2017 at 2:13 PM, Hans Wennborg wrote: Hi. > This seems to have had the side effect of introducing a new warning in > Chromium builds: > > ../../third_party/expat/files/lib/xmlparse.c(2429,24): error: > comparison of integers of different signs: 'enum XML_Error' and > 'unsigned in

Re: r316268 - [Sema] Fixes for enum handling for tautological comparison diagnostics

2017-10-23 Thread Hans Wennborg via cfe-commits
This seems to have had the side effect of introducing a new warning in Chromium builds: ../../third_party/expat/files/lib/xmlparse.c(2429,24): error: comparison of integers of different signs: 'enum XML_Error' and 'unsigned int' [-Werror,-Wsign-compare] if (code > 0 && code < sizeof(message)/si

r316268 - [Sema] Fixes for enum handling for tautological comparison diagnostics

2017-10-21 Thread Roman Lebedev via cfe-commits
Author: lebedevri Date: Sat Oct 21 09:44:03 2017 New Revision: 316268 URL: http://llvm.org/viewvc/llvm-project?rev=316268&view=rev Log: [Sema] Fixes for enum handling for tautological comparison diagnostics Summary: As Mattias Eriksson has reported in PR35009, in C, for enums, the underlying typ