Re: r324308 - Fix crash on invalid.

2018-02-22 Thread Richard Trieu via cfe-commits
Thanks, Hans! On Thu, Feb 22, 2018 at 3:27 AM, Hans Wennborg wrote: > Seems safe. Merged in r325766. > > On Thu, Feb 22, 2018 at 1:15 AM, Richard Trieu wrote: > > Hi Hans, > > > > If there's still time for rc3, I'd like to get this crash fix in. This >

Re: r324308 - Fix crash on invalid.

2018-02-22 Thread Hans Wennborg via cfe-commits
Seems safe. Merged in r325766. On Thu, Feb 22, 2018 at 1:15 AM, Richard Trieu wrote: > Hi Hans, > > If there's still time for rc3, I'd like to get this crash fix in. This adds > a null check to prevent a crash on invalid. > > Richard > > On Mon, Feb 5, 2018 at 6:58 PM,

Re: r324308 - Fix crash on invalid.

2018-02-21 Thread Richard Trieu via cfe-commits
Hi Hans, If there's still time for rc3, I'd like to get this crash fix in. This adds a null check to prevent a crash on invalid. Richard On Mon, Feb 5, 2018 at 6:58 PM, Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rtrieu > Date: Mon Feb 5 18:58:21 2018 > New

r324308 - Fix crash on invalid.

2018-02-05 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Mon Feb 5 18:58:21 2018 New Revision: 324308 URL: http://llvm.org/viewvc/llvm-project?rev=324308=rev Log: Fix crash on invalid. Don't call a method when the pointer is null. Modified: cfe/trunk/lib/Sema/SemaExpr.cpp cfe/trunk/test/SemaCXX/lambda-expressions.cpp