Re: r324433 - [NFC] Change odd cast-through-unknown behavior to an Optional

2018-02-12 Thread David Blaikie via cfe-commits
FWIW, you can write "*M" rather than M.getValue() if you reckon that's neater. And you could roll the declaration/initialization of M into the 'if' condition - but I can understand why you might prefer not to, given it's a many-line statement, etc. On Tue, Feb 6, 2018 at 4:39 PM Erich Keane via

r324433 - [NFC] Change odd cast-through-unknown behavior to an Optional

2018-02-06 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Feb 6 16:37:19 2018 New Revision: 324433 URL: http://llvm.org/viewvc/llvm-project?rev=324433=rev Log: [NFC] Change odd cast-through-unknown behavior to an Optional This bit of code in the driver uses '~0U' as a sentinel value. The result is an odd mishmash of casts