Re: r338837 - clang-format: [JS] don't break comments before any '{'

2018-08-03 Thread Martin Probst via cfe-commits
Sorry about that, yes, that was me. Thanks for reverting! Tim Northover schrieb am Fr., 3. Aug. 2018 um 14:19 Uhr: > On Fri, 3 Aug 2018 at 11:47, Tim Northover > wrote: > > On Fri, 3 Aug 2018 at 10:34, Martin Probst via cfe-commits > > wrote: > > > clang-format: [JS] don't break comments

Re: r338837 - clang-format: [JS] don't break comments before any '{'

2018-08-03 Thread Tim Northover via cfe-commits
On Fri, 3 Aug 2018 at 11:47, Tim Northover wrote: > On Fri, 3 Aug 2018 at 10:34, Martin Probst via cfe-commits > wrote: > > clang-format: [JS] don't break comments before any '{' > > This looks like it's triggered a bunch of infinite loops in Clang's > unittests. I've just taken a look at the

Re: r338837 - clang-format: [JS] don't break comments before any '{'

2018-08-03 Thread Tim Northover via cfe-commits
Hi Martin, On Fri, 3 Aug 2018 at 10:34, Martin Probst via cfe-commits wrote: > clang-format: [JS] don't break comments before any '{' This looks like it's triggered a bunch of infinite loops in Clang's unittests. For example:

r338837 - clang-format: [JS] don't break comments before any '{'

2018-08-03 Thread Martin Probst via cfe-commits
Author: mprobst Date: Fri Aug 3 02:34:41 2018 New Revision: 338837 URL: http://llvm.org/viewvc/llvm-project?rev=338837=rev Log: clang-format: [JS] don't break comments before any '{' Summary: Previously, clang-format would avoid breaking before the first `{` found, but then happily break before