Re: r338899 - [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin

2018-08-06 Thread via cfe-commits
That's what I was missing; I should have looked more closely at the buildbot logs, I see the export there now. Thanks! Scott On 2018-08-06 12:51, Vlad Tsyrklevich wrote: Have you tried setting detect_stack_use_after_return in ASAN_OPTIONS? The ASan buildbot sets the following ASAN_OPTIONS prio

Re: r338899 - [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin

2018-08-06 Thread Vlad Tsyrklevich via cfe-commits
Have you tried setting detect_stack_use_after_return in ASAN_OPTIONS? The ASan buildbot sets the following ASAN_OPTIONS prior to running tests: export ASAN_OPTIONS="check_initialization_order=true:detect_stack_use_after_return=1:detect_leaks=1" On Mon, Aug 6, 2018 at 7:34 AM wrote: > I can't see

Re: r338899 - [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin

2018-08-06 Thread via cfe-commits
I can't seem to reproduce the ASan failure locally, even after building a clang with the latest compiler-rt, and then rebuilding my patch with LLVM_USE_SANITIZER=Address I am pretty confident the problem should be fixed with a one-line change to my patch: -auto CreateArrayForSizeVar = [=

Re: r338899 - [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin

2018-08-03 Thread via cfe-commits
Looks like I missed that the inferred types for the returned tuple elements are references; I will rebuild with ASan and confirm my fix is correct, then commit again. Thanks, Scott On 2018-08-03 13:48, Vlad Tsyrklevich wrote: This change is causing ASan failures on the sanitizer bots: http://l

Re: r338899 - [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin

2018-08-03 Thread Vlad Tsyrklevich via cfe-commits
This change is causing ASan failures on the sanitizer bots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/21898/steps/check-clang%20asan/logs/stdio I've reverted it in r338904. On Fri, Aug 3, 2018 at 8:51 AM Scott Linder via cfe-commits < cfe-commits@lists.llvm.org> wrote:

r338899 - [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin

2018-08-03 Thread Scott Linder via cfe-commits
Author: scott.linder Date: Fri Aug 3 08:50:52 2018 New Revision: 338899 URL: http://llvm.org/viewvc/llvm-project?rev=338899&view=rev Log: [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin Ensures the statically sized alloca is not converted to DYNAMIC_STACKALLOC later because