Re: r339428 - Add Windows support for the GNUstep Objective-C ABI V2.

2018-08-13 Thread Galina Kistanova via cfe-commits
Hello David, This commit broke the following test on the expensive check builder: CodeGenObjC/2007-04-03-ObjcEH.m The last green build is for r339427 - http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/11726 r339428 makes it red -

Re: r339428 - Add Windows support for the GNUstep Objective-C ABI V2.

2018-08-13 Thread Hans Wennborg via cfe-commits
>> zeroinitializer, section "__objc_classes$a", comdat, align 1 >> >> I don’t think that the order matters, only that they are actually emitted, >> but if I am wrong, I apologize, and please revert my change and look into >> the problem. >> >> Douglas Yung

Re: r339428 - Add Windows support for the GNUstep Objective-C ABI V2.

2018-08-11 Thread David Chisnall via cfe-commits
: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Tom Weaver via cfe-commits > Sent: Friday, August 10, 2018 10:01 > To: David Chisnall > Cc: cfe-commits@lists.llvm.org > Subject: Re: r339428 - Add Windows support for the GNUstep Objective-C ABI V2. > > Hi Da

Re: r339428 - Add Windows support for the GNUstep Objective-C ABI V2.

2018-08-10 Thread David Chisnall via cfe-commits
Hi Tom, I’ll take a look over the weekend and see if I can reproduce locally. It’s odd that a test for a Windows triple would be behaving differently on a Windows host. David > On 10 Aug 2018, at 18:01, Tom Weaver wrote: > > Hi David, > > revision 339428 seems to have caused failing tests

r339428 - Add Windows support for the GNUstep Objective-C ABI V2.

2018-08-10 Thread David Chisnall via cfe-commits
Author: theraven Date: Fri Aug 10 05:53:13 2018 New Revision: 339428 URL: http://llvm.org/viewvc/llvm-project?rev=339428=rev Log: Add Windows support for the GNUstep Objective-C ABI V2. Summary: Introduces funclet-based unwinding for Objective-C and fixes an issue where global blocks can't have