Thanks for looking Jordan!
On Mon, Sep 17, 2018, 11:16 AM Jordan Rupprecht
wrote:
> > Interesting, what kind of failures?
> >
> > If they are causing you problems, of course feel free to revert.
> >
> > Dave
>
> Turns out they are all real issues which running the test under asan
> mode flags as
> Interesting, what kind of failures?
>
> If they are causing you problems, of course feel free to revert.
>
> Dave
Turns out they are all real issues which running the test under asan
mode flags as global-buffer-overflow. I'm guessing the over-alignment
was hiding the bug as reads there would be
Hello
Interesting, what kind of failures?
If they are causing you problems, of course feel free to revert.
Dave
From: Eric Christopher
Sent: 17 September 2018 18:07:47
To: David Green
Cc: cfe-commits@lists.llvm.org
Subject: Re: r342053 - [CodeGen] Align rtti and vtable data
Hi David,
I&#
Hi David,
I'm seeing test failures after this patch. I'm trying to get a test case
reduced, but can we revert until we figure it out?
Thanks!
-eric
On Wed, Sep 12, 2018 at 7:10 AM David Green via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dmgreen
> Date: Wed Sep 12 07:09:06 201
Author: dmgreen
Date: Wed Sep 12 07:09:06 2018
New Revision: 342053
URL: http://llvm.org/viewvc/llvm-project?rev=342053&view=rev
Log:
[CodeGen] Align rtti and vtable data
Previously the alignment on the newly created rtti/typeinfo data was largely
not set, meaning that DataLayout::getPreferredAli
