Re: r345109 - Debug Info (-gmodules): emit full types for non-anchored template specializations

2018-10-29 Thread David Blaikie via cfe-commits
Fair enough - pity we couldn't readily have a single implementation or at least semantics for modular debug info between implicit and explicit modes (I mean, my fault in part for building a separate/new system when I did modular codegen anyway) but hopefully we'll move to explicit modules across

Re: r345109 - Debug Info (-gmodules): emit full types for non-anchored template specializations

2018-10-29 Thread Adrian Prantl via cfe-commits
> On Oct 29, 2018, at 11:26 AM, David Blaikie wrote: > > Is this a workaround for now with the intent to fix this to allow such > implicit specializations to have their debug info modularized? I believe this > does work correctly in modular debug info with expliict modules, would > probably

Re: r345109 - Debug Info (-gmodules): emit full types for non-anchored template specializations

2018-10-29 Thread David Blaikie via cfe-commits
Is this a workaround for now with the intent to fix this to allow such implicit specializations to have their debug info modularized? I believe this does work correctly in modular debug info with expliict modules, would probably be sort of nice to have these things be consistent/similar? On Tue,

r345109 - Debug Info (-gmodules): emit full types for non-anchored template specializations

2018-10-23 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Tue Oct 23 17:06:02 2018 New Revision: 345109 URL: http://llvm.org/viewvc/llvm-project?rev=345109=rev Log: Debug Info (-gmodules): emit full types for non-anchored template specializations Before this patch, clang would emit a (module-)forward declaration for template