r345748 - Re-land r345676 "[Win64] Handle passing i128 by value"

2018-10-31 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Oct 31 10:43:55 2018 New Revision: 345748 URL: http://llvm.org/viewvc/llvm-project?rev=345748=rev Log: Re-land r345676 "[Win64] Handle passing i128 by value" Fix the unintended switch/case fallthrough to avoid changing long double behavior. Added: cfe/

Re: r345676 - [Win64] Handle passing i128 by value

2018-10-31 Thread Reid Kleckner via cfe-commits
e-commits > *Subject:* Re: r345676 - [Win64] Handle passing i128 by value > > > > I have reverted this in r345691 because it caused test > CodeGen/mingw-long-double.c to start failing. > Thanks! > +case BuiltinType::LongDouble: > + // Mingw64 GCC uses the old 80 bit

RE: r345676 - [Win64] Handle passing i128 by value

2018-10-31 Thread via cfe-commits
Kleckner Cc: cfe-commits Subject: Re: r345676 - [Win64] Handle passing i128 by value I have reverted this in r345691 because it caused test CodeGen/mingw-long-double.c to start failing. Command Output (stderr): -- /usr/local/google/clang/install/llvm/tools/clang/test/CodeGen/mingw-long-double.c:36:11

Re: r345676 - [Win64] Handle passing i128 by value

2018-10-30 Thread Richard Trieu via cfe-commits
I have reverted this in r345691 because it caused test CodeGen/mingw-long-double.c to start failing. Command Output (stderr): -- /usr/local/google/clang/install/llvm/tools/clang/test/CodeGen/mingw-long-double.c:36:11: error: MSC64: expected string not found in input // MSC64: define dso_local

r345676 - [Win64] Handle passing i128 by value

2018-10-30 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Oct 30 16:58:41 2018 New Revision: 345676 URL: http://llvm.org/viewvc/llvm-project?rev=345676=rev Log: [Win64] Handle passing i128 by value For arguments, pass it indirectly, since the ABI doc says pretty clearly that arguments larger than 8 bytes are passed indirectly.