Re: r345866 - Reapply Logging: make os_log buffer size an integer constant expression.

2018-11-01 Thread Jan Vesely via cfe-commits
On Thu, 2018-11-01 at 18:40 +, Tim Northover via cfe-commits wrote: > On 1 Nov 2018, at 18:36, Jan Vesely wrote: > > this patch seems to cause a build failure: > > Ugh. Reverted as r345871. > > Do you know what linker and other options you’re using? The only > failure I’ve been able to

Re: r345866 - Reapply Logging: make os_log buffer size an integer constant expression.

2018-11-01 Thread Tim Northover via cfe-commits
On 1 Nov 2018, at 18:36, Jan Vesely wrote: > this patch seems to cause a build failure: Ugh. Reverted as r345871. Do you know what linker and other options you’re using? The only failure I’ve been able to reproduce locally is when I introduced a circular dependency. Cheers. Tim.

Re: r345866 - Reapply Logging: make os_log buffer size an integer constant expression.

2018-11-01 Thread Jan Vesely via cfe-commits
Hi, this patch seems to cause a build failure: /usr/bin/ld: CMakeFiles/clangAST.dir/OSLog.cpp.o: in function `(anonymous namespace)::OSLogFormatStringHandler::~OSLogFormatStringHandler()': /home/jvesely/llvm/tools/clang/lib/AST/OSLog.cpp:18: undefined reference to

r345866 - Reapply Logging: make os_log buffer size an integer constant expression.

2018-11-01 Thread Tim Northover via cfe-commits
Author: tnorthover Date: Thu Nov 1 11:04:49 2018 New Revision: 345866 URL: http://llvm.org/viewvc/llvm-project?rev=345866=rev Log: Reapply Logging: make os_log buffer size an integer constant expression. The size of an os_log buffer is known at any stage of compilation, so making it a constant