On Mon, Nov 12, 2018 at 5:24 PM David Blaikie wrote:
>
> Thanks!
Thank you for the review feedback, that was a good catch. I've changed
to an assert in r346714.
~Aaron
>
> On Mon, Nov 12, 2018 at 2:14 PM Aaron Ballman wrote:
>>
>> On Mon, Nov 12, 2018 at 1:30 PM David Blaikie wrote:
>> >
>>
Thanks!
On Mon, Nov 12, 2018 at 2:14 PM Aaron Ballman
wrote:
> On Mon, Nov 12, 2018 at 1:30 PM David Blaikie wrote:
> >
> > The previous code didn't have a conditional for Iter != End - was that a
> bug? Should there be a test case for that bug?
> >
> > If that's not an actual change in
On Mon, Nov 12, 2018 at 1:30 PM David Blaikie wrote:
>
> The previous code didn't have a conditional for Iter != End - was that a bug?
> Should there be a test case for that bug?
>
> If that's not an actual change in behavior, could it be an assert instead of
> a condition?
I think an
The previous code didn't have a conditional for Iter != End - was that a
bug? Should there be a test case for that bug?
If that's not an actual change in behavior, could it be an assert instead
of a condition?
On Tue, Nov 6, 2018 at 1:14 PM Aaron Ballman via cfe-commits <
Author: aaronballman
Date: Tue Nov 6 13:12:44 2018
New Revision: 346266
URL: http://llvm.org/viewvc/llvm-project?rev=346266=rev
Log:
Don't use std::next() on an input iterator; NFC.
Instead, advance the old-fashioned way, as std::next() cannot be used on an
input iterator until C++17.
