Got it. Thanks for the review!
Bruno
On 04/12/2018 16:59, David Blaikie wrote:
> Ah, thanks for the explanation! No worries about pre-commit review or
> anything - this is what post-commit review is :) Only note for the future is
> that it might be worth mentioning in the body of the commit mes
Ah, thanks for the explanation! No worries about pre-commit review or
anything - this is what post-commit review is :) Only note for the future
is that it might be worth mentioning in the body of the commit message
(title/first line was fine) so it's clear why this "extra" work is being
done.
Than
There is two reasons for this change:
1.) The first one is that the bit FunctionDeclBits.IsCopyDeductionCandidate
is only used by CXXDeductionGuideDecl and so there is no getter/setter
for it in FunctionDecl, and it would not make sense to add one.
This is a legacy of when these bits w
Why the change from using setter functions to direct assignment?
On Mon, Dec 3, 2018 at 5:06 AM Bruno Ricci via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: brunoricci
> Date: Mon Dec 3 05:04:10 2018
> New Revision: 348131
>
> URL: http://llvm.org/viewvc/llvm-project?rev=348131&vie
Author: brunoricci
Date: Mon Dec 3 05:04:10 2018
New Revision: 348131
URL: http://llvm.org/viewvc/llvm-project?rev=348131&view=rev
Log:
[AST] Fix an uninitialized bug in the bits of FunctionDecl
FunctionDeclBits.IsCopyDeductionCandidate was not initialized.
This caused a warning with valgrind.
