Re: r350768 - [ObjC] Allow the use of implemented unavailable methods from within

2019-01-17 Thread Nico Weber via cfe-commits
For the archives, here's said patch: https://reviews.llvm.org/D56816 (Thanks!) On Wed, Jan 16, 2019 at 5:26 PM Alex L wrote: > Hi, > > We are planning to fix this issue by not checking if the method is > defined. I will post a patch this week. > > Cheers, > Alex > > On Fri, 11 Jan 2019 at

Re: r350768 - [ObjC] Allow the use of implemented unavailable methods from within

2019-01-16 Thread Alex L via cfe-commits
Hi, We are planning to fix this issue by not checking if the method is defined. I will post a patch this week. Cheers, Alex On Fri, 11 Jan 2019 at 10:26, Alex L wrote: > Thanks, we might have similar cases in our code base as well. We'll see if > we can fix that too. > > On Fri, 11 Jan 2019

Re: r350768 - [ObjC] Allow the use of implemented unavailable methods from within

2019-01-11 Thread Alex L via cfe-commits
Thanks, we might have similar cases in our code base as well. We'll see if we can fix that too. On Fri, 11 Jan 2019 at 06:13, Nico Weber wrote: > Here's some user feedback on this new feature. > > It looks like the warning is only suppressed if `init` has a definition in > the @interface block.

Re: r350768 - [ObjC] Allow the use of implemented unavailable methods from within

2019-01-11 Thread Nico Weber via cfe-commits
Here's some user feedback on this new feature. It looks like the warning is only suppressed if `init` has a definition in the @interface block. In the 4 cases where we saw this warning fire after r349841, it still fires after this change because in all 4 cases a class marked init as unavailable

r350768 - [ObjC] Allow the use of implemented unavailable methods from within

2019-01-09 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Wed Jan 9 14:31:37 2019 New Revision: 350768 URL: http://llvm.org/viewvc/llvm-project?rev=350768=rev Log: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context In Objective-C, it's common for some frameworks to mark some methods