[PATCH] D56728: Regression test case for r350891 [Correct the source range returned from preprocessor callbacks]

rupprecht abandoned this revision. rupprecht added a comment. Looks like this test case was submitted as part of rL351209 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56728/new/ https://reviews.llvm.org/D56728

Re: r350891 - Correct the source range returned from preprocessor callbacks.

With this patch some ranges just come back empty. I rolled the change back in r351209, which also includes a test case that shows the empty ranges with this patch. On Thu, Jan 10, 2019 at 10:26 PM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date:

[PATCH] D56728: Regression test case for r350891 [Correct the source range returned from preprocessor callbacks]

rupprecht created this revision. rupprecht added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, jsji, kbarton, nemanjai. r350891 caused some internal failures that this test case exposes. Repository: rC Clang https://reviews.llvm.org/D56728 Files:

Re: r350891 - Correct the source range returned from preprocessor callbacks.

On Thu, Jan 10, 2019 at 6:18 PM Nico Weber wrote: > > ../../clang/lib/Lex/PPExpressions.cpp:852:43: warning: missing field > 'ExprRange' initializer [-Wmissing-field-initializers] > return {false, DT.IncludedUndefinedIds}; > ^ Sorry about that --

Re: r350891 - Correct the source range returned from preprocessor callbacks.

This revision has broken http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/18904. Please take a look. On Thu, Jan 10, 2019 at 3:18 PM Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > ../../clang/lib/Lex/PPExpressions.cpp:852:43: warning: missing field >

Re: r350891 - Correct the source range returned from preprocessor callbacks.

../../clang/lib/Lex/PPExpressions.cpp:852:43: warning: missing field 'ExprRange' initializer [-Wmissing-field-initializers] return {false, DT.IncludedUndefinedIds}; ^ On Thu, Jan 10, 2019 at 4:26 PM Aaron Ballman via cfe-commits <

r350891 - Correct the source range returned from preprocessor callbacks.

Author: aaronballman Date: Thu Jan 10 13:22:13 2019 New Revision: 350891 URL: http://llvm.org/viewvc/llvm-project?rev=350891=rev Log: Correct the source range returned from preprocessor callbacks. This adjusts the source range passed in to the preprocessor callbacks to only include the