Re: r351316 - Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

2019-01-17 Thread Hans Wennborg via cfe-commits
On Wed, Jan 16, 2019 at 7:46 PM Greg Bedwell wrote: > > > > Unfortunately this trips up a variety of buildbots: > > Platform REQUIRES added in r351360, please do revert & fix if this test is > > supposed to work elsewhere. > > Looks like the test fail just made it into the release-8.0.0 branch by

Re: r351316 - Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

2019-01-16 Thread Greg Bedwell via cfe-commits
> > Unfortunately this trips up a variety of buildbots: > Platform REQUIRES added in r351360, please do revert & fix if this test is supposed to work elsewhere. Looks like the test fail just made it into the release-8.0.0 branch by a few commits. I think we'll need Jeremy's fix r351360 or/and any

Re: r351316 - Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

2019-01-16 Thread Jeremy Morse via cfe-commits
Platform REQUIRES added in r351360, please do revert & fix if this test is supposed to work elsewhere. -- Thanks, Jeremy ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r351316 - Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

2019-01-16 Thread Jeremy Morse via cfe-commits
We do rather need this working for our downstream merging to continue, and to clear up the buildbots -- without objection I'll drop the "REQUIRES: system-darwin" line in there. Depending on what's actually supposed to be tested that might be sufficient, but please do follow up. -- Thanks, Jeremy

Re: r351316 - Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

2019-01-16 Thread Sam McCall via cfe-commits
+Ilya who understands the test better... Some are fixed by r351334 with -target, Ilya could you take a look at windows? Otherwise we could use REQUIRES... On Wed, Jan 16, 2019, 15:16 Jeremy Morse Hi Sam, > > Unfortunately this trips up a variety of buildbots: > > http://lab.llvm.org:8011/bui

Re: r351316 - Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

2019-01-16 Thread Jeremy Morse via cfe-commits
Hi Sam, Unfortunately this trips up a variety of buildbots: http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/22376 http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/15053 http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/22376 http://lab.llvm.org:801

r351316 - Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

2019-01-16 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Jan 16 01:41:26 2019 New Revision: 351316 URL: http://llvm.org/viewvc/llvm-project?rev=351316&view=rev Log: Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database. This reverts commit r351282, and re-lands r351222