Re: r362067 - asm goto: fix out-of-bounds read of Constraints after rC362045

2019-05-30 Thread Fāng-ruì Sòng via cfe-commits
You beat me to it.. Reverted On Thu, May 30, 2019 at 5:41 PM Benjamin Kramer wrote: > Is this still necessary after r362062? > > On Thu, May 30, 2019 at 10:00 AM Fangrui Song via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: maskray >> Date: Thu May 30 01:03:02 2019 >> New

Re: r362067 - asm goto: fix out-of-bounds read of Constraints after rC362045

2019-05-30 Thread Benjamin Kramer via cfe-commits
Is this still necessary after r362062? On Thu, May 30, 2019 at 10:00 AM Fangrui Song via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: maskray > Date: Thu May 30 01:03:02 2019 > New Revision: 362067 > > URL: http://llvm.org/viewvc/llvm-project?rev=362067=rev > Log: > asm goto: fix

r362067 - asm goto: fix out-of-bounds read of Constraints after rC362045

2019-05-30 Thread Fangrui Song via cfe-commits
Author: maskray Date: Thu May 30 01:03:02 2019 New Revision: 362067 URL: http://llvm.org/viewvc/llvm-project?rev=362067=rev Log: asm goto: fix out-of-bounds read of Constraints after rC362045 When parsing goto labels, Names and Exprs are expanded but Constraints is not, this may cause a