Re: r365499 - [OpenCL][Sema] Fix builtin rewriting

2019-07-10 Thread Reid Kleckner via cfe-commits
check that adding > '// UNSUPPORTED: system-windows' properly disables the test? And if so, > feel free to commit for now. > > Marco > -- > *From:* Reid Kleckner > *Sent:* 09 July 2019 21:47 > *To:* Marco Antognini > *Cc:* cfe-commits > *Su

Re: r365499 - [OpenCL][Sema] Fix builtin rewriting

2019-07-10 Thread Marco Antognini via cfe-commits
'// UNSUPPORTED: system-windows' properly disables the test? And if so, feel free to commit for now. Marco From: Reid Kleckner Sent: 09 July 2019 21:47 To: Marco Antognini Cc: cfe-commits Subject: Re: r365499 - [OpenCL][Sema] Fix builtin rewriting FYI, your test seems to fail

Re: r365499 - [OpenCL][Sema] Fix builtin rewriting

2019-07-09 Thread Reid Kleckner via cfe-commits
FYI, your test seems to fail on Windows: FAIL: Clang :: CodeGenOpenCL/pipe_builtin.cl (4679 of 15176) TEST 'Clang :: CodeGenOpenCL/pipe_builtin.cl' FAILED Script: -- : 'RUN: at line 1'; c:\b\slave\clang-x64-windows-msvc\build\build\stage1\bin\clang.exe

r365499 - [OpenCL][Sema] Fix builtin rewriting

2019-07-09 Thread Marco Antognini via cfe-commits
Author: mantognini Date: Tue Jul 9 08:04:23 2019 New Revision: 365499 URL: http://llvm.org/viewvc/llvm-project?rev=365499=rev Log: [OpenCL][Sema] Fix builtin rewriting This patch ensures built-in functions are rewritten using the proper parent declaration. Existing tests are modified to run in