Thanks for the fix, Qt does seem to build correctly now again.
// Martin
On Fri, 9 Aug 2019, Reid Kleckner wrote:
Let me know if the problem persists after r368475. Someone else filed
https://bugs.llvm.org/show_bug.cgi?id=42948 as well.
On Thu, Aug 8, 2019 at 11:34 PM Martin Storsjö
Let me know if the problem persists after r368475. Someone else filed
https://bugs.llvm.org/show_bug.cgi?id=42948 as well.
On Thu, Aug 8, 2019 at 11:34 PM Martin Storsjö wrote:
> This change broke compiling Qt.
>
> A repro case looks like this:
>
> mkdir -p fake-qtincl/5.13.1/QtCore/private
>
Thanks for taking care of this.
I think having a list of "allowed" error codes is more robust long-term
than having an explicit list of unexpected error codes, even though if it
requires some short-term whack-a-mole.
The original change landed after the 9.0 branch, so we have some time for
I'll add std::errc::not_a_directory to the list of ignored errors.
On Thu, Aug 8, 2019 at 11:34 PM Martin Storsjö wrote:
> This change broke compiling Qt.
>
> A repro case looks like this:
>
> mkdir -p fake-qtincl/5.13.1/QtCore/private
> touch fake-qtincl/5.13.1/QtCore/private/qglobal_p.h
>
This change broke compiling Qt.
A repro case looks like this:
mkdir -p fake-qtincl/5.13.1/QtCore/private
touch fake-qtincl/5.13.1/QtCore/private/qglobal_p.h
touch fake-qtincl/QtCore
echo "#include " > qtincl.cpp
bin/clang++ -c qtincl.cpp -Ifake-qtincl -Ifake-qtincl/5.13.1
Previously this
Author: rnk
Date: Thu Aug 8 14:35:03 2019
New Revision: 368348
URL: http://llvm.org/viewvc/llvm-project?rev=368348=rev
Log:
Fix up fd limit diagnosis code
Apparently Windows returns the "invalid argument" error code when the
path contains invalid characters such as '<'. The
