Re: r369705 - [Clang][CodeGen] set alias linkage on QualType

2019-09-09 Thread Hans Wennborg via cfe-commits
Merged to release_90 in r371372 (along with the follow-up test fix). On Thu, Aug 22, 2019 at 10:45 PM Nick Desaulniers via cfe-commits wrote: > > Author: nickdesaulniers > Date: Thu Aug 22 13:47:12 2019 > New Revision: 369705 > > URL: http://llvm.org/viewvc/llvm-project?rev=369705=rev > Log: >

Re: r369705 - [Clang][CodeGen] set alias linkage on QualType

2019-08-22 Thread Nick Desaulniers via cfe-commits
Thanks for the report, would you mind reviewing: https://reviews.llvm.org/D66622? On Thu, Aug 22, 2019 at 2:44 PM Erik Pilkington wrote: > > This commit is causing test failures on darwin: > >

Re: r369705 - [Clang][CodeGen] set alias linkage on QualType

2019-08-22 Thread Erik Pilkington via cfe-commits
This commit is causing test failures on darwin: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental/1464/consoleFull#-18314650158254eaf0-7326-4999-85b0-388101f2d404

r369705 - [Clang][CodeGen] set alias linkage on QualType

2019-08-22 Thread Nick Desaulniers via cfe-commits
Author: nickdesaulniers Date: Thu Aug 22 13:47:12 2019 New Revision: 369705 URL: http://llvm.org/viewvc/llvm-project?rev=369705=rev Log: [Clang][CodeGen] set alias linkage on QualType Summary: It seems that CodeGen was always using ExternalLinkage when emitting a GlobalDecl with