Re: r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

2019-10-01 Thread Mikael Holmén via cfe-commits
Hi, On 2019-09-27 10:13, Hans Wennborg wrote: > Committed a fix in r373049, and I'll ask to have it merged for 9.0.1 > as well. Sorry again for the breakage. No worries. Thanks for the fix! /Mikael > > On Thu, Sep 26, 2019 at 7:09 PM Mikael Holmén > wrote: >> >> Hi, >> >> As Karl-Johan said

Re: r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

2019-09-27 Thread Hans Wennborg via cfe-commits
Committed a fix in r373049, and I'll ask to have it merged for 9.0.1 as well. Sorry again for the breakage. On Thu, Sep 26, 2019 at 7:09 PM Mikael Holmén wrote: > > Hi, > > As Karl-Johan said I'll be out of office for a few days so please submit a > fix if you can find the time. > > Thanks, >

Re: r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

2019-09-26 Thread Mikael Holmén via cfe-commits
Hi, As Karl-Johan said I'll be out of office for a few days so please submit a fix if you can find the time. Thanks, Mikael Den 26 sep. 2019 15:39 skrev Hans Wennborg : On Thu, Sep 26, 2019 at 12:55 PM Mikael Holmén via cfe-commits wrote: > > Hi Hans, > > I'm a bit suspicious against the part

Re: r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

2019-09-26 Thread Hans Wennborg via cfe-commits
On Thu, Sep 26, 2019 at 12:55 PM Mikael Holmén via cfe-commits wrote: > > Hi Hans, > > I'm a bit suspicious against the part > > > This also revertes the part of r369938 which checked that > -working-directory works. > > in this revert. > > You do: > > > + SmallString<128> Buf; > > + if

Re: r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

2019-09-26 Thread Mikael Holmén via cfe-commits
Hi Hans, I'm a bit suspicious against the part > This also revertes the part of r369938 which checked that -working-directory works. in this revert. You do: > + SmallString<128> Buf; > + if (!llvm::sys::fs::current_path(Buf)) > +Buf = "."; > + CDB << "{ \"directory\": \"" <<

Re: r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

2019-09-05 Thread Hans Wennborg via cfe-commits
Merged to release_90 in r371060. On Thu, Sep 5, 2019 at 10:41 AM Hans Wennborg via cfe-commits wrote: > > Author: hans > Date: Thu Sep 5 01:43:00 2019 > New Revision: 371027 > > URL: http://llvm.org/viewvc/llvm-project?rev=371027=rev > Log: > Revert r361885 "[Driver] Fix -working-directory

r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

2019-09-05 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Sep 5 01:43:00 2019 New Revision: 371027 URL: http://llvm.org/viewvc/llvm-project?rev=371027=rev Log: Revert r361885 "[Driver] Fix -working-directory issues" This made clang unable to open files using relative paths on network shares on Windows (PR43204). On the bug it