Re: r371663 - Start porting ivfsoverlay tests to Windows

2019-09-12 Thread Reid Kleckner via cfe-commits
Thanks, that seems like the correct fix. The property that makes them fail is the native system path style, not the default target. On Thu, Sep 12, 2019 at 5:03 AM Jeremy Morse wrote: > On Thu, Sep 12, 2019 at 11:24 AM Jeremy Morse > wrote: > > Assuming no-one else is looking at this, I'll comm

Re: r371663 - Start porting ivfsoverlay tests to Windows

2019-09-12 Thread Jeremy Morse via cfe-commits
On Thu, Sep 12, 2019 at 11:24 AM Jeremy Morse wrote: > Assuming no-one else is looking at this, I'll commit a fix in ~30 mins. r371726 -- Thanks, Jeremy ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

Re: r371663 - Start porting ivfsoverlay tests to Windows

2019-09-12 Thread Jeremy Morse via cfe-commits
Hi Reid, On Wed, Sep 11, 2019 at 9:55 PM Reid Kleckner via cfe-commits wrote: > +// XFAIL: windows Looks like this should be system-windows, the PS4 buildbots [0] have a windows host but target x86_64-scei-ps4, and croak on this change. Assuming no-one else is looking at this, I'll commit a fix

r371663 - Start porting ivfsoverlay tests to Windows

2019-09-11 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Sep 11 13:56:25 2019 New Revision: 371663 URL: http://llvm.org/viewvc/llvm-project?rev=371663&view=rev Log: Start porting ivfsoverlay tests to Windows Part of PR43272, the changes are: 1. Use @ as the sed pattern delimiter instead of : so that the drive letter in lit substi