Yeah, I tried to fix even that case but is not so simple so not worth any extra
time/complexivity.
> Dňa 8. 10. 2019 o 19:09 užívateľ Arthur O'Dwyer
> napísal:
>
>
> On Mon, Oct 7, 2019 at 6:58 PM Dávid Bolvanský
> wrote:
> >> FWIW I found the "always evaluates to 'true'" bit important
On Mon, Oct 7, 2019 at 6:58 PM Dávid Bolvanský
wrote:
>> FWIW I found the "always evaluates to 'true'" bit important to
>> understand the warning.
>
> Yeah. I moved this check somewhere else, so we can print precise message:
> r373973 should emit "bitwise negation of a boolean expression always
>
Hm, there is no "bitwise negation of a boolean expression always
evaluates to 'true'; did you mean logical negation?" for chromium
case. I will try to fix it.
ut 8. 10. 2019 o 0:03 Dávid Bolvanský napísal(a):
>
> "FWIW I found the "always evaluates to 'true'" bit important to
> understand the
"FWIW I found the "always evaluates to 'true'" bit important to
understand the warning."
Yeah. I moved this check somewhere else, so we can print precise message:
r373973 should emit "bitwise negation of a boolean expression always
evaluates to 'true'; did you mean logical negation?" where
Typo was fixed some days ago :)
Odoslané z iPhonu
> Dňa 7. 10. 2019 o 17:22 užívateľ Arthur O'Dwyer
> napísal:
>
>
>> On Mon, Oct 7, 2019 at 10:59 AM Dávid Bolvanský via cfe-commits
>> wrote:
>
>> Okey, I will see what I can do (I know I need to move checking code
>> somewhere else).
>>
Okey, I will see what I can do (I know I need to move checking code somewhere
else).
> Dňa 7. 10. 2019 o 16:54 užívateľ Nico Weber napísal:
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
FWIW I found the "always evaluates to 'true'" bit important to understand
the warning.
We did hit this (at least once) in Chromium after all [1] (looks like a
real bug – nothing for you to do about that, and thanks for the warning),
and I don't think I would've understood what the warning wanted
Author: xbolva00
Date: Fri Oct 4 05:55:13 2019
New Revision: 373743
URL: http://llvm.org/viewvc/llvm-project?rev=373743=rev
Log:
[NFCI] Improve the -Wbool-operation's warning message
Based on the request from the post commit review. Also added one new test.
Modified:
