Re: r281278 - [DebugInfo] Deduplicate debug info limiting logic

2016-09-12 Thread David Blaikie via cfe-commits
On Mon, Sep 12, 2016 at 5:09 PM Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Mon Sep 12 19:01:23 2016 > New Revision: 281278 > > URL: http://llvm.org/viewvc/llvm-project?rev=281278=rev > Log: > [DebugInfo] Deduplicate debug info limiting logic > > We

Re: [PATCH] D24426: DebugInfo: Pass non-zero alignment to DIBuilder only if aligment was forced

2016-09-12 Thread Reid Kleckner via cfe-commits
rnk added a subscriber: rnk. Comment at: lib/CodeGen/CGDebugInfo.cpp:608 @@ -608,2 +607,3 @@ uint64_t Size = CGM.getContext().getTypeSize(Ty); + uint64_t Align = 0; IMO this is what we should be doing everywhere, rather than manually checking AlignedAttr:

r281294 - clang-format: Add Java detection to git-clang-format.

2016-09-12 Thread Stephen Hines via cfe-commits
Author: srhines Date: Tue Sep 13 00:00:20 2016 New Revision: 281294 URL: http://llvm.org/viewvc/llvm-project?rev=281294=rev Log: clang-format: Add Java detection to git-clang-format. Summary: This change adds "java" to the list of known extensions that clang-format supports. Patch by Luis

Re: [PATCH] D24401: clang-format: Add Java detection to git-clang-format.

2016-09-12 Thread Stephen Hines via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281294: clang-format: Add Java detection to git-clang-format. (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D24401?vs=71104=71107#toc Repository: rL LLVM

r281293 - Reapply r281276 with passing -emit-llvm in one of the tests

2016-09-12 Thread Adam Nemet via cfe-commits
Author: anemet Date: Mon Sep 12 23:32:40 2016 New Revision: 281293 URL: http://llvm.org/viewvc/llvm-project?rev=281293=rev Log: Reapply r281276 with passing -emit-llvm in one of the tests Original commit message: Add -fdiagnostics-show-hotness Summary: I've recently added the ability for

Re: [PATCH] D24401: clang-format: Add Java detection to git-clang-format.

2016-09-12 Thread Luis Héctor Chávez via cfe-commits
lhchavez updated this revision to Diff 71104. lhchavez added a comment. Rebased to r281293 https://reviews.llvm.org/D24401 Files: tools/clang-format/git-clang-format Index: tools/clang-format/git-clang-format === ---

Re: [PATCH] D24005: [compiler-rt cmake] Support overriding llvm-config query results

2016-09-12 Thread Michał Górny via cfe-commits
mgorny added inline comments. Comment at: cmake/Modules/CompilerRTUtils.cmake:200 @@ -199,5 +199,3 @@ string(REGEX REPLACE "[ \t]*[\r\n]+[ \t]*" ";" CONFIG_OUTPUT ${CONFIG_OUTPUT}) - list(GET CONFIG_OUTPUT 0 LLVM_BINARY_DIR) - list(GET CONFIG_OUTPUT 1 LLVM_TOOLS_BINARY_DIR)

Re: [PATCH] D24383: Add addOrMerge interface to tooling::Replacements.

2016-09-12 Thread Eric Liu via cfe-commits
ioeric added a comment. @djasper Thanks for the insight into the problem. For the cases you listed, I have added some test cases. Case 1-3 can be handled as expected. And you are right, the behavior for case 4 is interesting. But I still agree that `addOrMerge` is confusing. As you said, the

Re: [PATCH] D24383: Add addOrMerge interface to tooling::Replacements.

2016-09-12 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 71006. ioeric added a comment. - Also cleanup comments around redundant colons/commas in format::cleanup. https://reviews.llvm.org/D24383 Files: include/clang/Tooling/Core/Replacement.h lib/Tooling/Core/Replacement.cpp

Re: [PATCH] D24383: Add addOrMerge interface to tooling::Replacements.

2016-09-12 Thread Eric Liu via cfe-commits
Somehow the commit message was wrong...should be "Added more test cases" instead. On Mon, Sep 12, 2016 at 4:38 PM Eric Liu wrote: > ioeric updated this revision to Diff 71006. > ioeric added a comment. > > - Also cleanup comments around redundant colons/commas in

<    1   2