This revision was automatically updated to reflect the committed changes.
Closed by commit rL286823: Protect std::ios tests under libcpp-no-exceptions
(authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D26512?vs=77789&id=77797#toc
Repository:
rL LLVM
https://reviews.l
Author: rogfer01
Date: Mon Nov 14 07:44:50 2016
New Revision: 286823
URL: http://llvm.org/viewvc/llvm-project?rev=286823&view=rev
Log:
Protect std::ios tests under libcpp-no-exceptions
Skip tests that expect an exception be thrown. Also add
some missing asserts in the original test.
Differential
rogfer01 created this revision.
rogfer01 added reviewers: EricWF, mclow.lists, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Skip tests that expect an exception be thrown.
https://reviews.llvm.org/D26606
Files:
test/std/utilities/memory/specialized.algorithms/uninitialized.copy/uniniti
hokein updated this revision to Diff 77803.
hokein marked 2 inline comments as done.
hokein added a comment.
Address remaining comments.
https://reviews.llvm.org/D26515
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
Index: clang-move/ClangMove.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286825: [clang-move] Abstract a ClassMather for matching
class declarations. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D26515?vs=77803&id=77804#toc
Repository:
rL LLVM
Author: hokein
Date: Mon Nov 14 08:15:44 2016
New Revision: 286825
URL: http://llvm.org/viewvc/llvm-project?rev=286825&view=rev
Log:
[clang-move] Abstract a ClassMather for matching class declarations.
Summary:
No functionality change.
This is a refactoring patch, which makes the code more reada
nkakuev added a comment.
Ping.
Ignoring note locations is a coarse-grained solution that will suppress both
false and //true// positives. Suppress-checks-filter is a finer-grained
instrument that can be targetted on particular false positives precisely.
My sympathies are with suppress-checks-f
ioeric added a comment.
Lg with one nit.
Comment at: clang-move/ClangMove.cpp:280
assert(It < CurrentNamespaces.rend());
- NewCode += "} // namespace " + *It + "\n";
+ NewCode += "} // namespace " + *It + "\n\n";
}
Wouldn't this create som
rogfer01 created this revision.
rogfer01 added reviewers: EricWF, mclow.lists, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Skip tests that expect an exception be thrown and/or disable
unreachable catch handlers.
https://reviews.llvm.org/D26608
Files:
test/std/strings/basic.string/stri
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
Fix an incorrect range for the functions whose returned value is a macro
(e.g. `bool`). This incorrect range can lead to modifications of an unexpected
file where the macro is in.
We should use
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg.
Nice! Now I realize what I really meant was "ExpansionLoc" when I said
"SpellingLoc" :P
https://reviews.llvm.org/D26609
___
cfe-commits mai
Author: marshall
Date: Mon Nov 14 08:41:33 2016
New Revision: 286828
URL: http://llvm.org/viewvc/llvm-project?rev=286828&view=rev
Log:
Update C++1z status with C++17 issues from Issaquah. Still to come: LFTS issues
and papers
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/tru
Author: sfertile
Date: Mon Nov 14 08:43:27 2016
New Revision: 286830
URL: http://llvm.org/viewvc/llvm-project?rev=286830&view=rev
Log:
[PPC] add extract sig/exp test data class for vec float and vec double.
Add vector extract exponent/significand functions to altivec.h, as well as
functions (an
Author: hokein
Date: Mon Nov 14 08:46:48 2016
New Revision: 286833
URL: http://llvm.org/viewvc/llvm-project?rev=286833&view=rev
Log:
[clang-move] Fix an incorrect range for the functions whose returned value is a
macro
Summary:
Fix an incorrect range for the functions whose returned value is a m
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286833: [clang-move] Fix an incorrect range for the
functions whose returned value is a… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D26609?vs=77806&id=77810#toc
Repository:
Author: marshall
Date: Mon Nov 14 08:53:07 2016
New Revision: 286834
URL: http://llvm.org/viewvc/llvm-project?rev=286834&view=rev
Log:
Update C++1z status with LFTS issues from Issaquah.
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://ll
rogfer01 created this revision.
rogfer01 added reviewers: EricWF, mclow.lists, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Skip tests that expect an exception be thrown and/or disable
unreachable catch handlers.
https://reviews.llvm.org/D26612
Files:
test/std/strings/basic.string/stri
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM with the change for the summary. Thanks!
https://reviews.llvm.org/D26509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
Author: marshall
Date: Mon Nov 14 09:09:45 2016
New Revision: 286835
URL: http://llvm.org/viewvc/llvm-project?rev=286835&view=rev
Log:
Update C++1z status with LWG papers from Issaquah.
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llv
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
looks good.
Comment at: unittests/change-namespace/ChangeNamespaceTests.cpp:829
"void f() {\n"
- " using na::CA;\n"
-
ioeric marked an inline comment as done.
ioeric added inline comments.
Comment at: unittests/change-namespace/ChangeNamespaceTests.cpp:829
"void f() {\n"
- " using na::CA;\n"
- " CA ca;\n"
+ " us
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:280
assert(It < CurrentNamespaces.rend());
- NewCode += "} // namespace " + *It + "\n";
+ NewCode += "} // namespace " + *It + "\n\n";
}
ioeric wrote:
> Wouldn't this create
Author: stulova
Date: Mon Nov 14 09:34:01 2016
New Revision: 286836
URL: http://llvm.org/viewvc/llvm-project?rev=286836&view=rev
Log:
[OpenCL] Change to clk_event parameter in enqueue_kernel.
- Accept NULL pointer as a valid parameter value for clk_event.
- Generate clk_event_t arguments of inter
Anastasia closed this revision.
Anastasia added a comment.
Committed in r286836.
https://reviews.llvm.org/D26507
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:280
assert(It < CurrentNamespaces.rend());
- NewCode += "} // namespace " + *It + "\n";
+ NewCode += "} // namespace " + *It + "\n\n";
}
hokein wrote:
> ioeric wrote:
> > Wou
On Sun, Nov 13, 2016 at 1:30 PM Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> EricWF created this revision.
> EricWF added reviewers: mclow.lists, chandlerc.
> EricWF added a subscriber: cfe-commits.
>
> The title says it all.
>
> I just want to check that we agree on the ge
Can you add some non-trivial test cases that exercise double-rounding,
especially near the overflow boundary?
e.g. What is the expected value of x if the target does not support fp64?:
float x = 340282356779733661637539395458142568447.0;
– Steve
> On Nov 14, 2016, at 6:15 AM, Neil Hick
Author: tstellar
Date: Mon Nov 14 10:06:33 2016
New Revision: 286839
URL: http://llvm.org/viewvc/llvm-project?rev=286839&view=rev
Log:
Fix build since r286752.
Modified:
libclc/trunk/utils/prepare-builtins.cpp
Modified: libclc/trunk/utils/prepare-builtins.cpp
URL:
http://llvm.org/viewvc/llv
dougk updated this revision to Diff 77815.
dougk marked an inline comment as done.
dougk added a comment.
add a sentence about the change in AddressSanitizer.rst
https://reviews.llvm.org/D26454
Files:
docs/AddressSanitizer.rst
lib/CodeGen/SanitizerMetadata.cpp
lib/Sema/SemaDeclAttr.cpp
sfertile closed this revision.
sfertile added a comment.
committed https://reviews.llvm.org/rL286830
Repository:
rL LLVM
https://reviews.llvm.org/D26271
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
hokein updated this revision to Diff 77820.
hokein marked an inline comment as done.
hokein added a comment.
Fix a corner case, and add a test.
https://reviews.llvm.org/D26493
Files:
clang-move/ClangMove.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTests
hokein updated this revision to Diff 77821.
hokein added a comment.
Remove a trailing blank line.
https://reviews.llvm.org/D26493
Files:
clang-move/ClangMove.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTests.cpp
=
Author: sgundapa
Date: Mon Nov 14 11:09:39 2016
New Revision: 286842
URL: http://llvm.org/viewvc/llvm-project?rev=286842&view=rev
Log:
Fix the unit test darwin-multiarch-arm.c for windows
Modified:
cfe/trunk/test/Driver/darwin-multiarch-arm.c
Modified: cfe/trunk/test/Driver/darwin-multiarch-
Anastasia updated the summary for this revision.
Anastasia updated this revision to Diff 77825.
Anastasia added a comment.
1. Corrected typos in CodeGen test.
2. Improved description.
https://reviews.llvm.org/D26509
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/CGBuiltin.cpp
Author: mgrang
Date: Mon Nov 14 11:31:24 2016
New Revision: 286846
URL: http://llvm.org/viewvc/llvm-project?rev=286846&view=rev
Log:
[clang docs] Minor fix in ClangCheck.rst
Reviewers: djasper, rengolin
Subscribers: Eugene.Zelenko
Tags: #clang-c
Differential Revision: https://reviews.llvm.org/
Author: stl_msft
Date: Mon Nov 14 11:35:14 2016
New Revision: 286847
URL: http://llvm.org/viewvc/llvm-project?rev=286847&view=rev
Log:
[libcxx] [test] D26314: Fix MSVC warning C4189 "local variable is initialized
but not referenced".
test/std/depr/depr.c.headers/inttypes_h.pass.cpp
test/std/inpu
STL_MSFT closed this revision.
STL_MSFT added a comment.
Checked in as r286847.
https://reviews.llvm.org/D26314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin added a comment.
Hi Krzysztof!
This change seems useful: I can imagine the situation where we want to ask
current `LocationContext` in this callback. The change looks pretty intrusive
but I mostly agree with it. Initially, I have some questions about the
implementation of `getArgSVal
Author: stulova
Date: Mon Nov 14 11:39:58 2016
New Revision: 286849
URL: http://llvm.org/viewvc/llvm-project?rev=286849&view=rev
Log:
[OpenCL] Fix for integer parameters of enqueue_kernel
Make handling integer parameters more flexible:
- For the number of events argument allow to pass larger
int
Anastasia closed this revision.
Anastasia added a comment.
Committed in r286849.
https://reviews.llvm.org/D26509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: stulova
Date: Mon Nov 14 12:11:09 2016
New Revision: 286856
URL: http://llvm.org/viewvc/llvm-project?rev=286856&view=rev
Log:
Fix OpenCL test for buildbot by removing extra (erroneous) RUN line
Modified:
cfe/trunk/test/SemaOpenCL/cl20-device-side-enqueue.cl
Modified: cfe/trunk/test/
Author: marshall
Date: Mon Nov 14 12:22:19 2016
New Revision: 286858
URL: http://llvm.org/viewvc/llvm-project?rev=286858&view=rev
Log:
Fixes for LWG 2598, 2686, 2739, 2742, 2747, and 2759, which were adopted last
week in Issaquah
Added:
libcxx/trunk/test/std/diagnostics/syserr/syserr.hash/e
Author: sfertile
Date: Mon Nov 14 12:47:15 2016
New Revision: 286863
URL: http://llvm.org/viewvc/llvm-project?rev=286863&view=rev
Log:
[PPC] altivec.h functions for converting half precision to single precision.
Adds 2 vector functions for converting from a vector of unsigned short to a
vector of
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286863: [PPC] altivec.h functions for converting half
precision to single precision. (authored by sfertile).
Changed prior to commit:
https://reviews.llvm.org/D26534?vs=77581&id=77842#toc
Repository:
Author: marshall
Date: Mon Nov 14 12:56:24 2016
New Revision: 286864
URL: http://llvm.org/viewvc/llvm-project?rev=286864&view=rev
Log:
Implement P0510 'Make future_error Constructible' adopted in Issaquah
Modified:
libcxx/trunk/include/future
libcxx/trunk/test/std/thread/futures/futures.f
NoQ added a comment.
Welcome to phabricator! I agree that having the location context in this
callback is useful, and i'm all for reducing boilerplate in various checkers
through better API.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:231
P
NoQ added a comment.
Thank you for working on this! The overall approach is good. Because alpha
checkers are disabled by default, false positives can be addressed later in
subsequent commits.
Comment at: lib/StaticAnalyzer/Checkers/RecursionChecker.cpp:2
+// InfiniteRecursion
Author: marshall
Date: Mon Nov 14 13:35:34 2016
New Revision: 286872
URL: http://llvm.org/viewvc/llvm-project?rev=286872&view=rev
Log:
Make one of the new tests fail correctly on pre-C++17 systems
Modified:
libcxx/trunk/test/std/utilities/memory/specialized.algorithms/specialized.addressof/a
Author: ioeric
Date: Mon Nov 14 13:37:55 2016
New Revision: 286873
URL: http://llvm.org/viewvc/llvm-project?rev=286873&view=rev
Log:
[change-namespace] consider typedef/using alias decls in the moved namespace.
Summary: If a TypeLoc refers to a type alias defined in the moved namespace, we
do no
101 - 149 of 149 matches
Mail list logo
