[libcxx] r288735 - Add module definitions for headers

Author: ericwf Date: Mon Dec 5 17:55:34 2016 New Revision: 288735 URL: http://llvm.org/viewvc/llvm-project?rev=288735&view=rev Log: Add module definitions for headers Modified: libcxx/trunk/include/module.modulemap Modified: libcxx/trunk/include/module.modulemap URL: http://llvm.org/viewv

[libcxx] r288736 - Allow enabling/disabling testing with module using env LIBCXX_USE_MODULES=1

Author: ericwf Date: Mon Dec 5 18:01:04 2016 New Revision: 288736 URL: http://llvm.org/viewvc/llvm-project?rev=288736&view=rev Log: Allow enabling/disabling testing with module using env LIBCXX_USE_MODULES=1 The Clang modules implementation breaks enough that libc++ needs an easy way to enable/d

Re: [PATCH] D27429: [Chrono][Darwin] On Darwin use CLOCK_UPTIME_RAW instead of CLOCK_MONOTONIC

From a Darwin perspective, this LGTM (it's what we're shipping on macOS 10.12 and iOS 10). Eric, do you have a good idea for how to test this? > On 2016-Dec-05, at 14:36, Bruno Cardoso Lopes via Phabricator > wrote: > > bruno created this revision. > bruno added reviewers: mclow.lists, dexons

r288737 - [modules] Use the "redundant #include" diagnostic rather than the "module

Author: rsmith Date: Mon Dec 5 18:12:39 2016 New Revision: 288737 URL: http://llvm.org/viewvc/llvm-project?rev=288737&view=rev Log: [modules] Use the "redundant #include" diagnostic rather than the "module import can't appear here" diagnostic if an already-visible module is textually entered (bec

r288738 - Additional test file missed from r288737.

Author: rsmith Date: Mon Dec 5 18:14:22 2016 New Revision: 288738 URL: http://llvm.org/viewvc/llvm-project?rev=288738&view=rev Log: Additional test file missed from r288737. Added: cfe/trunk/test/Modules/redundant-include.mm Added: cfe/trunk/test/Modules/redundant-include.mm URL: http://ll

r288740 - Add test for r288732, warn on unsigned zero in std::max

Author: rtrieu Date: Mon Dec 5 18:27:21 2016 New Revision: 288740 URL: http://llvm.org/viewvc/llvm-project?rev=288740&view=rev Log: Add test for r288732, warn on unsigned zero in std::max Added: cfe/trunk/test/SemaCXX/warn-max-unsigned-zero.cpp Added: cfe/trunk/test/SemaCXX/warn-max-unsigne

r288741 - Revert r288626, which reverts r288449. Original commit message:

Author: rsmith Date: Mon Dec 5 18:40:17 2016 New Revision: 288741 URL: http://llvm.org/viewvc/llvm-project?rev=288741&view=rev Log: Revert r288626, which reverts r288449. Original commit message: Recover better from an incompatible .pcm file being provided by -fmodule-file=. We try to include t

Re: r288626 - Revert "Recover better from an incompatible .pcm file being provided by -fmodule-file=. We try to include the headers of the module textually in this case, still enforcing the modules se

On 4 December 2016 at 20:44, Richard Smith wrote: > On 4 Dec 2016 2:44 pm, "Daniel Jasper via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > > Author: djasper > Date: Sun Dec 4 16:34:37 2016 > New Revision: 288626 > > URL: http://llvm.org/viewvc/llvm-project?rev=288626&view=rev > Log: > R

[PATCH] D27434: [libc++abi] Disable failing test on Darwin

smeenai created this revision. smeenai added reviewers: EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. The macOS thread-local variable finalizer routines do not handle the case where a termination function registers another termination function correctly, causing this test to fail.

[PATCH] D27023: [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 10/12.

STL_MSFT updated this revision to Diff 80347. STL_MSFT added a comment. Changed loop indices to int as requested. https://reviews.llvm.org/D27023 Files: test/std/algorithms/alg.modifying.operations/alg.move/move.pass.cpp test/std/algorithms/alg.modifying.operations/alg.move/move_backward.pa

[PATCH] D27268: [libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 2/4.

STL_MSFT updated this revision to Diff 80348. STL_MSFT added a comment. Changed data members to size_t as requested (also changed parameters for consistency). https://reviews.llvm.org/D27268 Files: test/std/utilities/optional/optional.specalg/make_optional_explicit_initializer_list.pass.cpp

[libcxx] r288743 - Add support for writing -verify shell tests

Author: ericwf Date: Mon Dec 5 19:02:15 2016 New Revision: 288743 URL: http://llvm.org/viewvc/llvm-project?rev=288743&view=rev Log: Add support for writing -verify shell tests Modified: libcxx/trunk/test/libcxx/compiler.py libcxx/trunk/test/libcxx/test/config.py libcxx/trunk/test/lib

[PATCH] D27436: [libcxx] [test] std::get<0>([std::variant constant expression]) *is* noexcept

CaseyCarter created this revision. CaseyCarter added reviewers: EricWF, mclow.lists. CaseyCarter added a subscriber: cfe-commits. noexcept(foo) is true when foo is a constant expression. https://reviews.llvm.org/D27436 Files: test/std/utilities/variant/variant.get/get_index.pass.cpp Index:

[libcxx] r288747 - [libcxx] [test] D27023: Fix MSVC warning C4389 "signed/unsigned mismatch", part 10/12.

Author: stl_msft Date: Mon Dec 5 19:13:29 2016 New Revision: 288747 URL: http://llvm.org/viewvc/llvm-project?rev=288747&view=rev Log: [libcxx] [test] D27023: Fix MSVC warning C4389 "signed/unsigned mismatch", part 10/12. Add static_cast. In these cases, the values are guaranteed to be small-ish

[libcxx] r288746 - [libcxx] [test] D27022: Fix MSVC warning C4389 "signed/unsigned mismatch", part 9/12.

Author: stl_msft Date: Mon Dec 5 19:13:14 2016 New Revision: 288746 URL: http://llvm.org/viewvc/llvm-project?rev=288746&view=rev Log: [libcxx] [test] D27022: Fix MSVC warning C4389 "signed/unsigned mismatch", part 9/12. Add static_cast to more comparisons. (Performed manually, unlike part 8/12

[libcxx] r288748 - [libcxx] [test] D27024: Fix MSVC warning C4389 "signed/unsigned mismatch", part 11/12.

Author: stl_msft Date: Mon Dec 5 19:13:40 2016 New Revision: 288748 URL: http://llvm.org/viewvc/llvm-project?rev=288748&view=rev Log: [libcxx] [test] D27024: Fix MSVC warning C4389 "signed/unsigned mismatch", part 11/12. Change "unsigned n = 0;" to "int n = 0;". It's being compared to int eleme

[libcxx] r288749 - [libcxx] [test] D27025: Fix MSVC warning C4389 "signed/unsigned mismatch", part 12/12.

Author: stl_msft Date: Mon Dec 5 19:13:51 2016 New Revision: 288749 URL: http://llvm.org/viewvc/llvm-project?rev=288749&view=rev Log: [libcxx] [test] D27025: Fix MSVC warning C4389 "signed/unsigned mismatch", part 12/12. Various changes: test/std/algorithms/alg.sorting/alg.merge/inplace_merge.

[libcxx] r288750 - [libcxx] [test] D27266: Remove spurious semicolons.

Author: stl_msft Date: Mon Dec 5 19:14:06 2016 New Revision: 288750 URL: http://llvm.org/viewvc/llvm-project?rev=288750&view=rev Log: [libcxx] [test] D27266: Remove spurious semicolons. Modified: libcxx/trunk/test/std/containers/unord/unord.multimap/unord.multimap.cnstr/range_size_hash_equa

[PATCH] D27436: [libcxx] [test] std::get<0>([std::variant constant expression]) *is* noexcept

CaseyCarter added inline comments. Comment at: test/std/utilities/variant/variant.get/get_index.pass.cpp:39 constexpr V v(42); -ASSERT_NOT_NOEXCEPT(std::get<0>(v)); +#ifndef __clang__ +ASSERT_NOEXCEPT(std::get<0>(v)); THAT'S RIGHT, A CLANG BUG (https

[libcxx] r288751 - [libcxx] [test] D27267: Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 1/4.

Author: stl_msft Date: Mon Dec 5 19:14:29 2016 New Revision: 288751 URL: http://llvm.org/viewvc/llvm-project?rev=288751&view=rev Log: [libcxx] [test] D27267: Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 1/4. Replace "int n = str

[libcxx] r288752 - [libcxx] [test] D27268: Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 2/4.

Author: stl_msft Date: Mon Dec 5 19:14:43 2016 New Revision: 288752 URL: http://llvm.org/viewvc/llvm-project?rev=288752&view=rev Log: [libcxx] [test] D27268: Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 2/4. Use static_cast when

[libcxx] r288753 - [libcxx] [test] D27269: Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 3/4.

Author: stl_msft Date: Mon Dec 5 19:14:51 2016 New Revision: 288753 URL: http://llvm.org/viewvc/llvm-project?rev=288753&view=rev Log: [libcxx] [test] D27269: Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 3/4. test/std/containers/

[PATCH] D27021: [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 8/12.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r288745. https://reviews.llvm.org/D27021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27022: [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 9/12.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r288746. https://reviews.llvm.org/D27022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27023: [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 10/12.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r288747. https://reviews.llvm.org/D27023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25686: [Driver] Improve support for Gentoo arm*-hardfloat-*-*eabi triples

compnerd added a comment. Please don't canonicalize the triple that way. The behavior of `armv7-unknown-linux-gnueabi` is different from `armv7-unknown-linux-gnueabihf` which is different from `armv7-unknown-linux-gnueabihf -mfloat-abi=hard`. I agree that this is absolutely terrible and unexp

[PATCH] D27024: [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 11/12.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r288748. https://reviews.llvm.org/D27024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27266: [libcxx] [test] Remove spurious semicolons.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r288750. https://reviews.llvm.org/D27266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27267: [libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 1/4.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r288751. https://reviews.llvm.org/D27267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27025: [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 12/12.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r288749. https://reviews.llvm.org/D27025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27268: [libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 2/4.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r288752. https://reviews.llvm.org/D27268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27269: [libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 3/4.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r288753. https://reviews.llvm.org/D27269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26623: [libcxx] [test] Swapping non-equal non-POCS allocators is UB.

STL_MSFT updated this revision to Diff 80352. STL_MSFT added a comment. Merged with the recent addition of static_cast to various lines in the unordered container tests. No actual changes to the diff, only to the context. https://reviews.llvm.org/D26623 Files: test/std/containers/associativ

[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

amaiorano created this revision. amaiorano added reviewers: klimek, hans, zturner. amaiorano added a subscriber: cfe-commits. Herald added a subscriber: mgorny. Presently, the version number of the VSIX matches the LLVM version number. However, as this number doesn't change often, it means that a

[PATCH] D27439: [libcxx][modules] Fix 's module definition

EricWF created this revision. EricWF added reviewers: rsmith, manmanren, bruno. EricWF added subscribers: cfe-commits, rsmith. Currently libc++'s `stddef.h` is treated as a textual header by the module map, and technically this is correct because the header is non-modular (at least during normal

[PATCH] D27440: clang-format-vsix: fail when clang-format outputs to stderr

amaiorano created this revision. amaiorano added reviewers: klimek, hans, zturner. amaiorano added a subscriber: cfe-commits. When clang-format outputs to stderr but returns 0, the extension will format the code anyway. This happens, for instance, when there's a syntax error or unknown value in

[PATCH] D27436: [libcxx] [test] std::get<0>([std::variant constant expression]) *is* noexcept

STL_MSFT added a comment. I also saw get_type.pass.cpp failing. I would recommend commenting the ifndef with the clang bug URL you found. https://reviews.llvm.org/D27436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[libcxx] r288755 - Fix C++03 modules build

Author: ericwf Date: Mon Dec 5 19:34:24 2016 New Revision: 288755 URL: http://llvm.org/viewvc/llvm-project?rev=288755&view=rev Log: Fix C++03 modules build Modified: libcxx/trunk/include/module.modulemap Modified: libcxx/trunk/include/module.modulemap URL: http://llvm.org/viewvc/llvm-proje

[PATCH] D27440: clang-format-vsix: fail when clang-format outputs to stderr

amaiorano added a comment. With this change, I now get the following message box when my .clang-format has an invalid field named "SomeInvalidField": F2652560: 0.png I do have to wonder whether the real bug is the fact that clang-format returns a success stat

Re: clang-format-vsix: versioning patch and show stderrors patch

I've created the two reivews on phabricator: https://reviews.llvm.org/D27438 https://reviews.llvm.org/D27440 Thanks! On Mon, 5 Dec 2016 at 11:01 Manuel Klimek wrote: > On Mon, Dec 5, 2016 at 3:53 PM Antonio Maiorano > wrote: > > Hi Manuel, > > Okay, I'll submit both patches via phabricator as

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai updated this revision to Diff 80361. smeenai added a comment. Addressing @compnerd's comments https://reviews.llvm.org/D26949 Files: src/abort_message.cpp src/abort_message.h src/cxa_exception.cpp src/cxa_exception.hpp src/cxa_handlers.cpp src/cxa_handlers.hpp src/cxa_new_

[PATCH] D27436: [libcxx] [test] std::get<0>([std::variant constant expression]) *is* noexcept

EricWF accepted this revision. EricWF added inline comments. This revision is now accepted and ready to land. Comment at: test/std/utilities/variant/variant.get/get_index.pass.cpp:39 constexpr V v(42); -ASSERT_NOT_NOEXCEPT(std::get<0>(v)); +#ifndef __clang__ +ASSERT_

r288756 - Clean up some Sema checking code. NFC

Author: rtrieu Date: Mon Dec 5 19:42:28 2016 New Revision: 288756 URL: http://llvm.org/viewvc/llvm-project?rev=288756&view=rev Log: Clean up some Sema checking code. NFC - Rename CheckMinZero to CheckMaxUnsignedZero to reflect its actual purpose. - Remove unused parameters from CheckAbsoluteVal

[PATCH] D25435: Add -femit-accurate-debug-info to emit more debug info for sample pgo profile collection

echristo added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2743-2745 if (LinkageName == Name || (!CGM.getCodeGenOpts().EmitGcovArcs && !CGM.getCodeGenOpts().EmitGcovNotes && + !CGM.getCodeGenOpts().Profil

[PATCH] D27436: [libcxx] [test] std::get<0>([std::variant constant expression]) *is* noexcept

CaseyCarter updated this revision to Diff 80365. CaseyCarter added a comment. Address review comments: - Annotate the clang bug which the conditional compilation is avoiding. - Assure the expression in question is not noexcept when not a constant expression. - Cover get_type https://reviews.ll

[libcxx] r288760 - std::get<0>([std::variant constant expression]) *is* noexcept.

Author: caseycarter Date: Mon Dec 5 20:28:19 2016 New Revision: 288760 URL: http://llvm.org/viewvc/llvm-project?rev=288760&view=rev Log: std::get<0>([std::variant constant expression]) *is* noexcept. Differential review: http://reviews.llvm.org/D27436 Modified: libcxx/trunk/test/std/utiliti

[PATCH] D27360: [clang] Fix D26214: Move error handling out of MC and to the callers.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Im not the biggest fan of this. However, having some validation is probably better than not. We can come up with a better way to address this in the future when needed I suppose. https

[PATCH] D25435: Add -femit-accurate-debug-info to emit more debug info for sample pgo profile collection

danielcdh added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2743-2745 if (LinkageName == Name || (!CGM.getCodeGenOpts().EmitGcovArcs && !CGM.getCodeGenOpts().EmitGcovNotes && + !CGM.getCodeGenOpts().Profi

r288762 - [clang] Fix D26214: Move error handling out of MC and to the callers.

Author: mgrang Date: Mon Dec 5 20:49:16 2016 New Revision: 288762 URL: http://llvm.org/viewvc/llvm-project?rev=288762&view=rev Log: [clang] Fix D26214: Move error handling out of MC and to the callers. Summary: Related llvm patch: https://reviews.llvm.org/D27359 Reviewers: echristo, t.p.northov

[PATCH] D27360: [clang] Fix D26214: Move error handling out of MC and to the callers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288762: [clang] Fix D26214: Move error handling out of MC and to the callers. (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D27360?vs=80314&id=80369#toc Repository: rL LLVM

[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. When building the snapshots and releases, I usually put the SVN revision number in there to avoid this same problem: http://llvm-cs.pcc.me.uk/utils/release/build_llvm_package.bat#25 Your patch se

[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

amaiorano added a comment. In https://reviews.llvm.org/D27438#614219, @hans wrote: > When building the snapshots and releases, I usually put the SVN revision > number in there to avoid this same problem: > http://llvm-cs.pcc.me.uk/utils/release/build_llvm_package.bat#25 Ah, right, I was wonde

[PATCH] D27424: Add the diagnose_if attribute to clang.

EricWF added a comment. Awesome, this is exactly what I was hoping for! Thanks for working on this! I'm a bit surprised that the attribute fails to evaluate the condition as a constant expression during the evaluation of constexpr functions. Ex: #define DIAG(...) __attribute__((diagnose_if(_

[PATCH] D27436: [libcxx] [test] std::get<0>([std::variant constant expression]) *is* noexcept

mclow.lists accepted this revision. mclow.lists added a comment. I'd appreciate it if someone made a note to revisit this test when the clang bug is fixed, and change the `#ifndef __clang__ ` to something like `#ifndef __clang__ || clang_version < `". This LGTM. https://reviews.llvm.org/D

[PATCH] D26244: [Driver] Prefer libraries installed next to Clang over those from GCC

Hahnfeld added a comment. Ping! https://reviews.llvm.org/D26244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25669: [Driver] Simplify ToolChain::GetCXXStdlibType (NFC)

Hahnfeld added a comment. Ping! https://reviews.llvm.org/D25669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r288778 - Fix stdio module build on OS X

Author: ericwf Date: Tue Dec 6 01:40:46 2016 New Revision: 288778 URL: http://llvm.org/viewvc/llvm-project?rev=288778&view=rev Log: Fix stdio module build on OS X Modified: libcxx/trunk/include/module.modulemap Modified: libcxx/trunk/include/module.modulemap URL: http://llvm.org/viewvc/llv

<    1   2