r315959 - [libclang] Add support for querying cursor availability

2017-10-16 Thread Jonathan Coe via cfe-commits
Author: jbcoe Date: Mon Oct 16 16:46:02 2017 New Revision: 315959 URL: http://llvm.org/viewvc/llvm-project?rev=315959&view=rev Log: [libclang] Add support for querying cursor availability Summary: This patch allows checking the availability of cursors through libclang and clang.cindex (Python).

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

2017-10-16 Thread Howard Hinnant via Phabricator via cfe-commits
howard.hinnant added a comment. Fwiw, I wrote this code. All of that "fallback" stuff was written to make customer code that was incorrect, but working on OS X -version-that-used-libsupc++ continue to work. I.e. to be a crutch for incorrect code. It should all be removed if you no longer wan

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

2017-10-16 Thread Dan Albert via Phabricator via cfe-commits
danalbert added a comment. In https://reviews.llvm.org/D38599#899196, @howard.hinnant wrote: > Fwiw, I wrote this code. All of that "fallback" stuff was written to make > customer code that was incorrect, but working on OS X > -version-that-used-libsupc++ continue to work. I.e. to be a crutch

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

2017-10-16 Thread Howard Hinnant via Phabricator via cfe-commits
howard.hinnant added a comment. Ok. Well that's why it is under a #define: to make it easier to include or not, depending on the needs of the platform. https://reviews.llvm.org/D38599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D38978: [OpenMP] Enable the lowering of implicitly shared variables in OpenMP GPU-offloaded target regions to the GPU shared memory

2017-10-16 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. Please add tests for the cases where such local->shaed conversion should and should not happen. I would appreciate if you could add details on what exactly your passes are supposed to move to shared memory. Considering that device-side code tends to be heavily inlined, it m

[PATCH] D38985: [refactor] Add support for editor commands that connect IDEs/editors to the refactoring actions

2017-10-16 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. Herald added subscribers: ilya-biryukov, mgorny. This patch adds support for editor commands that allow refactoring to be used in editor clients like libclang or clangd. An editor command can be bound to an refactoring action rule. Once it is bound, it's available

[PATCH] D38986: [Analyzer] Better unreachable message in enumeration

2017-10-16 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov created this revision. Herald added subscribers: szepet, xazax.hun. @dcoughlin I'm curious whether you'd like such a change: in general, I think it is much better when the assert failure tells the developer _what_ value is failing, rather than saying "oops we are dead". I would

r315968 - Basic: make the nan family pure

2017-10-16 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Oct 16 20:30:25 2017 New Revision: 315968 URL: http://llvm.org/viewvc/llvm-project?rev=315968&view=rev Log: Basic: make the nan family pure The nan family of math routines do not rely on global state. They do however depend on their parameter. This fits the descriptio

[PATCH] D38770: AMDGPU: Use stricter bounds for workitem builtins

2017-10-16 Thread Tony Tye via Phabricator via cfe-commits
t-tye added inline comments. Comment at: include/clang/Basic/TargetInfo.h:1060 + /// \returns Maximum device supported OpenCL workgroup size. + virtual unsigned getOpenCLMaxWorkGroupSize(unsigned Dim) const { +return 0; Is this specifically tied to OpenCL o

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

2017-10-16 Thread John Baldwin via Phabricator via cfe-commits
bsdjhb updated this revision to Diff 119245. bsdjhb added a comment. - Save all of the general purpose registers. https://reviews.llvm.org/D38110 Files: include/__libunwind_config.h include/libunwind.h src/Registers.hpp src/UnwindCursor.hpp src/UnwindRegistersRestore.S src/UnwindReg

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

2017-10-16 Thread John Baldwin via Phabricator via cfe-commits
bsdjhb marked 2 inline comments as done. bsdjhb added inline comments. Comment at: src/UnwindRegistersSave.S:100 +# +DEFINE_LIBUNWIND_FUNCTION(unw_getcontext) + .set push sdardis wrote: > After looking at another implementation of libunwind and the other platfor

[PATCH] D38945: [CodeGen] Pass TBAA info along with lvalue base info everywhere

2017-10-16 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D38945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D38796: [CodeGen] EmitPointerWithAlignment() to generate TBAA info along with LValue base info

2017-10-16 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Ok. https://reviews.llvm.org/D38796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D38966: CodeGen: Fix invalid bitcasts for atomic builtins

2017-10-16 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D38966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D38947: [CodeGen] Refine generation of TBAA info for bit-field lvalues

2017-10-16 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:3665 -LValue CodeGenFunction::EmitLValueForField(LValue base, - const FieldDecl *field) { - LValueBaseInfo BaseInfo = base.getBaseInfo(); - AlignmentSource fieldAlignS

[PATCH] D38947: [CodeGen] Refine generation of TBAA info for bit-field lvalues

2017-10-16 Thread Ivan Kosarev via Phabricator via cfe-commits
kosarev updated this revision to Diff 119257. kosarev added a comment. - Removed renamings that complicate reviewing. https://reviews.llvm.org/D38947 Files: lib/CodeGen/CGExpr.cpp Index: lib/CodeGen/CGExpr.cpp === --- lib/CodeGe

[PATCH] D38947: [CodeGen] Refine generation of TBAA info for bit-field lvalues

2017-10-16 Thread Ivan Kosarev via Phabricator via cfe-commits
kosarev added a comment. Yes, some preparation code moved past the isBitField() block and generation of TBAA info moved before creating the bit-field lvalue. Thanks for catching the BaseExpr renaming. https://reviews.llvm.org/D38947 ___ cfe-commit

[PATCH] D38578: [preamble] Also record the "skipping" state of the preprocessor

2017-10-16 Thread Nikolai Kosjar via Phabricator via cfe-commits
nik added a comment. This fixes the reported bug for me :) There is another related issue that is not addressed by this change. I've reported it as [preamble] Skipped ranges vanish after reparse (#ifdef with #include) https://bugs.llvm.org/show_bug.cgi?id=34971 https://reviews.llvm.org/D385

[PATCH] D38947: [CodeGen] Refine generation of TBAA info for bit-field lvalues

2017-10-16 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, thanks. https://reviews.llvm.org/D38947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

r315979 - [Coverage] Explicitly mark the l.h.s of && and || (fixes PR33465)

2017-10-16 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Mon Oct 16 23:51:54 2017 New Revision: 315979 URL: http://llvm.org/viewvc/llvm-project?rev=315979&view=rev Log: [Coverage] Explicitly mark the l.h.s of && and || (fixes PR33465) This makes it possible to view sub-line region counts for the l.h.s of && and || expressions in c

<    1   2