[PATCH] D44964: Change order of libclang_rt.profile link for freebsd

trixirt created this revision. trixirt added reviewers: emaste, rsmith. Herald added a subscriber: cfe-commits. clang -static -coverage foo.c fails because the -lclang_rt.profile-*.a has a dependency on libc but is placed after libc in the link line. This change place -lclang_rt.profile before -

[PATCH] D44901: [Diag] Avoid emitting a redefinition note if no location is available.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D44901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option)

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This looks good with a super tiny nit regarding comments about signed integers. George, are you happy with the changes? (: Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOp

[PATCH] D44948: Add diagnostic -Waggregate-ctors, "aggregate type has user-declared constructors"

Eugene.Zelenko added a comment. Please mention new diagnostics in documentation and Release Notes. Repository: rC Clang https://reviews.llvm.org/D44948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D44948: Add diagnostic -Waggregate-ctors, "aggregate type has user-declared constructors"

Quuxplusone planned changes to this revision. Quuxplusone added a comment. This is related to an upcoming C++ paper, definitely not ready for prime time (e.g. no tests), and quite possibly never will be ready (although if people thought it would be useful, I'd be happy to clean it up and add tes

[PATCH] D43667: [clang-doc] Implement a YAML generator

juliehockett updated this revision to Diff 140021. juliehockett added a comment. Updating to for adjustments to the internal representation & cleaning up duplication. https://reviews.llvm.org/D43667 Files: clang-doc/CMakeLists.txt clang-doc/Representation.h clang-doc/generators/CMakeList

r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

Author: ahatanak Date: Tue Mar 27 17:12:08 2018 New Revision: 328680 URL: http://llvm.org/viewvc/llvm-project?rev=328680&view=rev Log: [ObjC] Make C++ triviality type traits available to non-trivial C structs. r326307 and r327870 made changes that allowed using non-trivial C structs with fields q

[PATCH] D44801: Add the -fsanitize=shadow-call-stack flag

kcc accepted this revision. kcc added a comment. LGTM modulo prolog vs prlogue and epilog vs epilogue https://en.wiktionary.org/wiki/epilog says these are alternative spellings, so up to you. Comment at: docs/ShadowCallStack.rst:14 +buffer overflows. It works by saving a func

[PATCH] D44913: [ObjC] Enable using C++ triviality type traits for non-trivial C structs

This revision was automatically updated to reflect the committed changes. Closed by commit rC328680: [ObjC] Make C++ triviality type traits available to non-trivial C (authored by ahatanak, committed by ). Repository: rC Clang https://reviews.llvm.org/D44913 Files: include/clang/Basic/Token

[PATCH] D44913: [ObjC] Enable using C++ triviality type traits for non-trivial C structs

This revision was automatically updated to reflect the committed changes. Closed by commit rL328680: [ObjC] Make C++ triviality type traits available to non-trivial C (authored by ahatanak, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

dschuff added inline comments. Comment at: lib/CodeGen/CGCXXABI.h:610 +struct CatchRetScope final : EHScopeStack::Cleanup { + llvm::CatchPadInst *CPI; Should be `public`? Comment at: lib/CodeGen/CGCleanup.h:630 static const EHPersonality

[PATCH] D44921: [PowerPC] Option for secure plt mode

nemanjai added a comment. I'll let Justin give the actual ACK, but this looks fine to me. The only question that I have (since I don't know anything about secure PLT) is whether this is a PPC-specific thing (since the option is a PPC option). Comment at: include/clang/Driver/

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Sema/Sema.h:3827 bool isCopyElisionCandidate(QualType ReturnType, const VarDecl *VD, - bool AllowParamOrMoveCons

[PATCH] D44865: [libc++] Implement P0608R1 - A sane variant converting constructor

lichray updated this revision to Diff 140029. lichray added a comment. Macro-free Repository: rCXX libc++ https://reviews.llvm.org/D44865 Files: include/variant test/std/utilities/variant/variant.variant/variant.assign/T.pass.cpp test/std/utilities/variant/variant.variant/variant.ctor/

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h:75 +/// \brief Deduplicate, check for conflicts, and convert all Repla

[PATCH] D44968: [ObjC] Generalize NRVO to cover non-trivial C structs

ahatanak created this revision. ahatanak added reviewers: rjmccall, doug.gregor, rsmith. r326307 and r327870 made changes that allowed using non-trivial C structs with fields qualified with __strong or __weak. This commit generalizes NRVO, which could only be applied to C++ structs, to cover non-

[PATCH] D44968: [ObjC] Generalize NRVO to cover non-trivial C structs

rjmccall added a comment. Is it possible to just do this for all structs? I don't think it hurts anything to do it for structs that are trivial and returned indirectly, and it would certainly be nice to construct C return values in-place even if they're guilty of nothing more than being, y'kno

r328688 - Fix some handling of AST nodes with diagnostics.

Author: rtrieu Date: Tue Mar 27 21:16:13 2018 New Revision: 328688 URL: http://llvm.org/viewvc/llvm-project?rev=328688&view=rev Log: Fix some handling of AST nodes with diagnostics. The diagnostic system for Clang can already handle many AST nodes. Instead of converting them to strings first, ju

[PATCH] D44888: [RISCV] Default enable linker relaxation and add -mrelax, -mno-relax flags

shiva0217 updated this revision to Diff 140038. shiva0217 retitled this revision from "[RISCV] Default enable linker relaxation and add -mno-relax flag to disable it" to "[RISCV] Default enable linker relaxation and add -mrelax, -mno-relax flags". shiva0217 edited the summary of this revision. sh

[PATCH] D44970: [XRay][clang] Add flag to choose instrumentation bundles

dberris created this revision. dberris added reviewers: echristo, kpw, eizan, pelikan. This change addresses http://llvm.org/PR36926 by allowing users to pick which instrumentation bundles to use, when instrumenting with XRay. In particular, the flag `-fxray-instrumentation-bundle=` has four valid

[PATCH] D44786: Lowering x86 adds/addus/subs/subus intrinsics (clang)

craig.topper added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:7897 + Value *MaxVec = CGF.Builder.CreateVectorSplat(NumElements, Max); + Value *ExtMaxVec = Signed ? CGF.Builder.CreateSExt(MaxVec, ExtType) +: CGF.Builder.CreateZExt(MaxVec,

<    1   2