Re: [PATCH] D45454: Make __gcov_flush visible outside a shared library

Should we have two versions of `__gcov_flush`? One version is visible outside a .so file, we use dlsym to find and call it to dump profile data of .so files, like Android. One version is hidden and must be called from another wrapper function in a .so file. An application that wants to flush .so

[PATCH] D44130: Driver: Add gcc search path for RHEL devtoolset-7

This revision was automatically updated to reflect the committed changes. Closed by commit rL329854: Driver: Add gcc search path for RHEL devtoolset-7 (authored by tstellar, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44130 Files:

r329854 - Driver: Add gcc search path for RHEL devtoolset-7

Author: tstellar Date: Wed Apr 11 15:29:35 2018 New Revision: 329854 URL: http://llvm.org/viewvc/llvm-project?rev=329854=rev Log: Driver: Add gcc search path for RHEL devtoolset-7 Reviewers: bruno Reviewed By: bruno Subscribers: bruno, cfe-commits Differential Revision:

[PATCH] D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option)

NoQ added a comment. We've found a crash on our internal buildbot, would you like to have a look?: **`$ cat repro.c`** int foo(int x, int y) { short a = x - 1U; return a - y; } **`$ clang -cc1 -analyze -analyzer-checker=core repro.c`** Assertion failed: (APSIntType(LInt) ==

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

vsapsai added a comment. Another approach is `__has_feature` but I don't think it is applicable in this case. Is there a way right now to detect that aligned allocation is supported by clang, regardless of link time? Asking to make sure we are consistent. Repository: rC Clang

[PATCH] D43817: [x86] wbnoinvd intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rC329848: [x86] wbnoinvd intrinsic (authored by GBuella, committed by ). Repository: rC Clang https://reviews.llvm.org/D43817 Files: docs/ClangCommandLineReference.rst

r329843 - [OPENMP] Code cleanup, NFC.

Author: abataev Date: Wed Apr 11 12:21:00 2018 New Revision: 329843 URL: http://llvm.org/viewvc/llvm-project?rev=329843=rev Log: [OPENMP] Code cleanup, NFC. Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp URL:

Re: [PATCH] D45454: Make __gcov_flush visible outside a shared library

On Wed, Apr 11, 2018 at 11:31 AM, Chih-Hung Hsieh via Phabricator via llvm-commits wrote: > chh added a comment. > > Yes, calling `__gcov_flush` within .so files are different, > but it's a revert of https://reviews.llvm.org/D38124. > I think

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

NoQ added a comment. In https://reviews.llvm.org/D45532#1064685, @Szelethus wrote: > In https://reviews.llvm.org/D45532#1064670, @Szelethus wrote: > > > I wasn't too clear on this one: unknown fields are regarded as > > uninitialized, what I wrote was a temporary change in the code so I could

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist added a comment. As far as I know, there are no updates required from me for this pull request-- I rebased on the main trunk recently, and will do it again tonight to be sure. So it should be compiling/working just fine. I believe it is just awaiting final approval from somebody.

r329851 - [Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Wed Apr 11 13:57:28 2018 New Revision: 329851 URL: http://llvm.org/viewvc/llvm-project?rev=329851=rev Log: [Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified:

r329866 - Lex: make `clang::Preprocessor::macros` work on MSVC

Author: compnerd Date: Wed Apr 11 16:47:25 2018 New Revision: 329866 URL: http://llvm.org/viewvc/llvm-project?rev=329866=rev Log: Lex: make `clang::Preprocessor::macros` work on MSVC The order of argument construction is reversed on MS ABI on Windows. When `macros` was invoked, the `end` call is

[PATCH] D45544: [AAch64] Add the __ARM_FEATURE_DOTPROD macro definition

flyingforyou created this revision. flyingforyou added a reviewer: SjoerdMeijer. Herald added subscribers: kristof.beyls, javed.absar. This matches what GCC does. https://github.com/gcc-mirror/gcc/blob/master/gcc/config/aarch64/aarch64-c.c https://reviews.llvm.org/D45544 Files:

r329780 - [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option)

Author: baloghadamsoftware Date: Tue Apr 10 23:21:12 2018 New Revision: 329780 URL: http://llvm.org/viewvc/llvm-project?rev=329780=rev Log: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option) Since the range-based constraint manager (default) is weak in

[PATCH] D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option)

This revision was automatically updated to reflect the committed changes. Closed by commit rL329780: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer… (authored by baloghadamsoftware, committed by ). Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D45500: [MinGW] Look for libc++ headers in a triplet prefixed path as well

mstorsjo added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:459 addSystemInclude(DriverArgs, CC1Args, + Base + Arch + llvm::sys::path::get_separator() + + "include" + llvm::sys::path::get_separator() +

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle added a comment. In https://reviews.llvm.org/D44882#1064196, @sammccall wrote: > (BTW @hokein has https://reviews.llvm.org/D45513 to add row/col to the index, > which will allow all the file-reading stuff to be cleaned up, but no need to > wait on that since it's all working now).

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle updated this revision to Diff 142112. malaperle marked 2 inline comments as done. malaperle added a comment. Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44882 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

smeenai added a comment. This LGTM given that Eric accepted your previous change. I'm happy to accept it in a day or two if he hasn't gotten the chance to take a look by then. Comment at: libcxx/CMakeLists.txt:101 +if (FUCHSIA) + set(ABI_VERSION_DEFAULT 2) +else()

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

phosek added a comment. ping? Repository: rCXX libc++ https://reviews.llvm.org/D45529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45305: ObjCGNU: Fix empty v3 protocols being emitted two fields short

DHowett-MSFT added a comment. Hi! Is there anything else holding up this patch? Thanks! Repository: rC Clang https://reviews.llvm.org/D45305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r329869 - [ODRHash] Skip more types hashing TypedefType

Author: rtrieu Date: Wed Apr 11 19:26:49 2018 New Revision: 329869 URL: http://llvm.org/viewvc/llvm-project?rev=329869=rev Log: [ODRHash] Skip more types hashing TypedefType To get the underlying type for TypedefType's, also skip ElaboratedType's. Modified: cfe/trunk/lib/AST/ODRHash.cpp

[clang-tools-extra] r329873 - [clang-tidy] [modernize-use-auto] Get only a length of token, not the token itself

Author: zinovy.nis Date: Wed Apr 11 22:41:24 2018 New Revision: 329873 URL: http://llvm.org/viewvc/llvm-project?rev=329873=rev Log: [clang-tidy] [modernize-use-auto] Get only a length of token, not the token itself Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseAutoCheck.cpp

[clang-tools-extra] r329875 - [Documentation] Fix options order for Release Notes in modernize-use-auto.

Author: zinovy.nis Date: Wed Apr 11 22:45:16 2018 New Revision: 329875 URL: http://llvm.org/viewvc/llvm-project?rev=329875=rev Log: [Documentation] Fix options order for Release Notes in modernize-use-auto. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-auto.rst

<    1   2