[PATCH] D52074: [PowerPC] [Clang] Add vector int128 pack/unpack builtins

steven.zhang added a comment. I will commit the patch for you. Repository: rC Clang https://reviews.llvm.org/D52074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52021: Fix Bug 38926: don't merge short case labels if followed by a block

owenpan added a comment. This fix has become obvious, but I still prefer that it gets reviewed before I commit it. Repository: rC Clang https://reviews.llvm.org/D52021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D50850: clang: Add triples support for MIPS r6

wzssyqa updated this revision to Diff 166219. Repository: rC Clang https://reviews.llvm.org/D50850 Files: lib/Driver/ToolChains/Arch/Mips.cpp lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Linux.cpp test/CodeGen/atomics-inlining.c test/CodeGen/mips-zero-sized-struct.c test/Cod

[PATCH] D51464: clang: fix MIPS/N32 triple and paths

wzssyqa updated this revision to Diff 166220. wzssyqa added a comment. remove mips64(el)-linux-gnu from path search. Repository: rC Clang https://reviews.llvm.org/D51464 Files: lib/Basic/Targets/Mips.h lib/Driver/ToolChains/Arch/Mips.cpp lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolC

[PATCH] D52267: [AST] Various optimizations + refactoring in DeclarationName(Table)

rjmccall added a comment. Conceptually, this change looks great. And it should be fine to require extra alignment on `IdentifierInfo` on 32-bit hosts; I doubt that will have measurable impact. I believe it's possible to eliminate the need for most, perhaps all, of these `static_asserts` by ju

[PATCH] D52271: [Sema] Ensure that we retain __restrict qualifiers when substituting a reference type.

rjmccall added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:4268 +Quals.removeVolatile(); + } `restrict` is unique in being able to be applied to reference types. You should just rebuild `Quals` from scratch, preserving only `restrict`.

[PATCH] D52074: [PowerPC] [Clang] Add vector int128 pack/unpack builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL342614: [PowerPC] [Clang] Add vector int128 pack/unpack builtins (authored by qshanz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52074?vs

[PATCH] D52271: [Sema] Ensure that we retain __restrict qualifiers when substituting a reference type.

erik.pilkington updated this revision to Diff 166224. erik.pilkington added a comment. Sure, the new patch just preserves __restrict qualifiers. Thanks! https://reviews.llvm.org/D52271 Files: clang/lib/Sema/TreeTransform.h clang/test/SemaCXX/subst-restrict.cpp Index: clang/test/SemaCXX/su

[PATCH] D52219: [analyzer] (1/n) Support pointee mutation analysis in ExprMutationAnalyzer.

shuaiwang marked 5 inline comments as done. shuaiwang added inline comments. Comment at: unittests/Analysis/ExprMutationAnalyzerTest.cpp:67 +if (const auto *DRE = dyn_cast(E)) { + if (DRE->getNameInfo().getAsString()[0] == 'p') +Finder = PointeeMutationFinder; --

[PATCH] D52271: [Sema] Ensure that we retain __restrict qualifiers when substituting a reference type.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. https://reviews.llvm.org/D52271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D52281: [clang-tidy] Add modernize check to use std::invoke in generic code

lebedev.ri added inline comments. Comment at: clang-tidy/modernize/ReplaceGenericFunctorCallCheck.cpp:27-32 + // template + // void f(T func) { + // func(); + // ^~~ + // ::std::invoke(func, 1) + Finder->addMatcher(callExpr(has(declRefExpr())).bind("functor"), thi

[PATCH] D52261: [Sema] Generate completion fix-its for C code as well

yvvan added a comment. I tried that first but did not I find a way just to copy an expression (we basically need the same expr for such case). Do you know how to properly generate a copy of expression or some other way to get the same expression? https://reviews.llvm.org/D52261

<    1   2