[PATCH] D51211: [Sema] Emit -Wformat properly for bitfield promotions.

aaron.ballman added inline comments. Comment at: test/Sema/format-strings-bitfield-promotion.c:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -verify %s + ebevhan wrote: > ebevhan wrote: > > aaron.ballman wrote: > > > aaron.ballman wrote: > >

Re: [PATCH] D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap

I don’t think we really need this. isn’t Ilya’s solution in the other patch already sufficient? On Mon, Dec 3, 2018 at 7:34 AM Ivan Donchevskii via Phabricator < revi...@reviews.llvm.org> wrote: > yvvan added a comment. > > @ilya-biryukov > > Hm. What about another way around? - We have user inclu

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet added a comment. Thank you both for the review ! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https://reviews.llvm.org/D54903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check

JonasToth added inline comments. Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:605 + return strncmp(SM.getCharacterData(T1.getLocation()), + SM.getCharacterData(T2.getLocation()), T1.getLength()) == 0; +} This operation could overflow

[PATCH] D55221: [AST] Make ArrayTypeTraitExpr non-polymorphic.

riccibruno created this revision. riccibruno added a reviewer: aaron.ballman. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. `ArrayTypeTraitExpr` is the only expression class which is polymorphic. As far as I can tell this is completely pointless. Repository: rC Cla

[PATCH] D55222: [AST] Assert that no statement/expression class is polymorphic

riccibruno created this revision. riccibruno added a reviewer: aaron.ballman. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Add a `static_assert` checking that no statement/expression class is polymorphic. People should use LLVM style RTTI instead. Repository: rC

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

donat.nagy updated this revision to Diff 176408. donat.nagy added a comment. Minor correction in documentation Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54757/new/ https://reviews.llvm.org/D54757 Files: clang-tidy/bugprone/BranchCloneCheck.cp

[PATCH] D54796: [clangd] C++ API for emitting file status

ilya-biryukov added a comment. Sorry for the delays. Not sure about emitting `Queued` on the main thread, see the corresponding comment. Otherwise looks very good. Comment at: clangd/ClangdServer.h:49 + /// Called whenever the file status is updated. + virtual void onFileUpd

[PATCH] D55212: Handle alloc_size attribute on function pointers

arichardson marked 5 inline comments as done. arichardson added inline comments. Comment at: include/clang/Basic/Attr.td:1072 def AllocSize : InheritableAttr { let Spellings = [GCC<"alloc_size">]; + let Subjects = SubjectList<[HasFunctionProto]>; aaron.ballm

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. Whenever a change happens on a CDB, load shards associated with that CDB before issuing re-index actions. Repository: rCTE Clang Tools Extra htt

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

uweigand added a comment. In D53157#1309743 , @cameron.mcinally wrote: > Digressing a bit, but has anyone given thought to how this implementation > will play out with libraries? When running with traps enabled, libraries must > be compiled for trap-saf

[PATCH] D55212: Handle alloc_size attribute on function pointers

arichardson updated this revision to Diff 176413. arichardson added a comment. - address review comments - add test that we can assign between function pointers with and without alloc_size attribute. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55212/new/ https

[PATCH] D55225: [AST] Assert that no type class is polymorphic

riccibruno created this revision. riccibruno added a reviewer: aaron.ballman. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Add a `static_assert` checking that no type class is polymorphic. People should use LLVM style RTTI instead. Repository: rC Clang https://re

[PATCH] D53768: Add VerboseOutputStream to CompilerInstance

scott.linder added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53768/new/ https://reviews.llvm.org/D53768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

r348150 - [Serialization][NFC] Remove pointless "+ 0" in ASTReader

Author: brunoricci Date: Mon Dec 3 08:17:45 2018 New Revision: 348150 URL: http://llvm.org/viewvc/llvm-project?rev=348150&view=rev Log: [Serialization][NFC] Remove pointless "+ 0" in ASTReader Remove the pointless "+ 0" which I added for some reason when modifying these statement/expression clas

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

donat.nagy marked 2 inline comments as done. donat.nagy added a comment. I applied this check to the llvm + clang codebase, and I was surprised to see that it produced about 600 results (for comparison, the clang-tidy checks which are enabled by default produce approximately 6000 results togethe

[PATCH] D55062: [clangd] Partition include graph on auto-index.

kadircet updated this revision to Diff 176415. kadircet marked 3 inline comments as done. kadircet added a comment. - Addresss comments - Make sure there are no uninitialized values in IncludeGraphNode. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

JonasToth added a comment. In D54757#1316899 , @donat.nagy wrote: > I applied this check to the llvm + clang codebase, and I was surprised to see > that it produced about 600 results (for comparison, the clang-tidy checks > which are enabled by default p

[PATCH] D55188: Extract TextChildDumper class

steveire marked 2 inline comments as done. steveire added inline comments. Comment at: include/clang/AST/ASTDumperUtils.h:22 + +namespace ast_dumper { +// Colors used for various parts of the AST dump aaron.ballman wrote: > steveire wrote: > > aaron.ballman wrote

[PATCH] D55057: [Headers] Make max_align_t match GCC's implementation.

uweigand added inline comments. Comment at: lib/Headers/__stddef_max_align_t.h:40 __attribute__((__aligned__(__alignof__(long double; +#ifdef __i386__ + __float128 __clang_max_align_nonce3 jyknight wrote: > uweigand wrote: > > jyknight wrote: > > > Ca

[PATCH] D55188: Extract TextChildDumper class

steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/ASTDumperUtils.h:96 + +struct TextChildDumper { + raw_ostream &OS; steveire wrote: > aaron.ballman wrote: > > I'm not sold on the name for this class. It's a

[PATCH] D55085: Avoid emitting redundant or unusable directories in DIFile metadata entries

davide accepted this revision. davide added a comment. LGTM, sorry. for the delay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55085/new/ https://reviews.llvm.org/D55085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D55134: [CTU] Add triple/lang mismatch handling

martong updated this revision to Diff 176417. martong marked 13 inline comments as done. martong added a comment. - Address review comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55134/new/ https://reviews.llvm.org/D55134 Files: include/clang/Basic/Diag

[PATCH] D55134: [CTU] Add triple/lang mismatch handling

martong added a comment. Thanks for the review! I have updated the patch according to your comments. Comment at: lib/CrossTU/CrossTranslationUnit.cpp:31 +namespace llvm { +// Same as Triple's equality operator, but we check a field only if that is a_sidorin w

[PATCH] D55134: [CTU] Add triple/lang mismatch handling

martong added a comment. > Hah. Do we support CTU for other languages, like ObjC and ObjC++? Can this be > an issue there? I really don't know. We never tried it, our focus is on C and C++ for now. Unfortunately, there is nobody with ObjC/C++ knowledge and (more importantly) with interest to t

[PATCH] D32950: Support C++1z features in `__has_extension`

EricWF added a comment. I don't mind picking it up again, but it won't be until next week. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32950/new/ https://reviews.llvm.org/D32950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D54657: [clang] Do not dump compilation-database entries for -E.

tmroeder abandoned this revision. tmroeder added a comment. I found a better way to do this in the Linux kernel build. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54657/new/ https://reviews.llvm.org/D54657 ___ cfe-

r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

Author: adrian Date: Mon Dec 3 09:55:27 2018 New Revision: 348154 URL: http://llvm.org/viewvc/llvm-project?rev=348154&view=rev Log: Avoid emitting redundant or unusable directories in DIFile metadata entries. As discussed on llvm-dev recently, Clang currently emits redundant directories in DIFil

[PATCH] D55085: Avoid emitting redundant or unusable directories in DIFile metadata entries

This revision was automatically updated to reflect the committed changes. Closed by commit rC348154: Avoid emitting redundant or unusable directories in DIFile metadata entries. (authored by adrian, committed by ). Changed prior to commit: https://reviews.llvm.org/D55085?vs=176152&id=176422#toc

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

JonasToth added a comment. from my side no objections, mailing list did not react AFAIK (just in case your waiting for me until you recommit). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55006/new/ https://reviews.llvm.org/D55006 ___ cfe

r348156 - Adding tests for -ast-dump; NFC.

Author: aaronballman Date: Mon Dec 3 10:00:31 2018 New Revision: 348156 URL: http://llvm.org/viewvc/llvm-project?rev=348156&view=rev Log: Adding tests for -ast-dump; NFC. This adds tests for struct and union declarations in C++. Added: cfe/trunk/test/AST/ast-dump-records.cpp Added: cfe/tru

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

Pierre-vh created this revision. Pierre-vh added reviewers: dcoughlin, MaskRay. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, a.sidorin, szepet, baloghadamsoftware. Herald added a reviewer: george.karpenkov. Fix for the bug n°39792: False positive on strcpy targeting struc

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

JonasToth added a comment. Hi russell thank you for the patch! As I am not a clang-format reviewers these are only general things, and Nits anyway ;) Hope the reviewers I added will evaluate better. Comment at: lib/Format/WhitespaceManager.cpp:54 Tok.Decision = (Newlines >

[PATCH] D55221: [AST] Make ArrayTypeTraitExpr non-polymorphic.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55221/new/ https://reviews.llvm.org/D55221 ___

[PATCH] D55225: [AST] Assert that no type class is polymorphic

aaron.ballman added inline comments. Comment at: lib/AST/Type.cpp:299 + static_assert(!std::is_polymorphic::value, \ +#CLASS "Type should not be polymorphic!"); +#include "clang/AST/TypeNodes.def" This will squish your class name and error text t

[clang-tools-extra] r348161 - [clang-tidy] Add the abseil-duration-comparison check

Author: jonastoth Date: Mon Dec 3 10:35:56 2018 New Revision: 348161 URL: http://llvm.org/viewvc/llvm-project?rev=348161&view=rev Log: [clang-tidy] Add the abseil-duration-comparison check Summary: This check finds instances where Duration values are being converted to a numeric value in a comp

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

This revision was automatically updated to reflect the committed changes. Closed by commit rL348161: [clang-tidy] Add the abseil-duration-comparison check (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54737?vs

[PATCH] D55225: [AST] Assert that no type class is polymorphic

riccibruno marked 2 inline comments as done. riccibruno added inline comments. Comment at: lib/AST/Type.cpp:299 + static_assert(!std::is_polymorphic::value, \ +#CLASS "Type should not be polymorphic!"); +#include "clang/AST/TypeNodes.def" aaron.b

[PATCH] D55225: [AST] Assert that no type class is polymorphic

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lib/AST/Type.cpp:299 + static_assert(!std::is_polymorphic::value, \ +#CLASS "Type should not be polymorphic!"); +#include "cl

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn updated this revision to Diff 176432. kpn added a comment. I've changed the patch so that calls to CreateFAdd() et al will give you constrained intrinsics if they are enabled. This required adding functions to enable/disable constrained-as-default plus calls to deal with the rounding mode a

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. Thank you for the fix, but how far can the pattern matching go? Seems easy enough to think of cases not covered by the above. In any case, the fix looks good. Repository:

[clang-tools-extra] r348165 - Revert "[clang-tidy] Add the abseil-duration-comparison check"

Author: jonastoth Date: Mon Dec 3 10:59:27 2018 New Revision: 348165 URL: http://llvm.org/viewvc/llvm-project?rev=348165&view=rev Log: Revert "[clang-tidy] Add the abseil-duration-comparison check" This commit broke buildbots and needs adjustments. Removed: clang-tools-extra/trunk/clang-tid

[PATCH] D55222: [AST] Assert that no statement/expression class is polymorphic

riccibruno updated this revision to Diff 176435. riccibruno added a comment. Forgot a space in the error message Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55222/new/ https://reviews.llvm.org/D55222 Files: lib/AST/Stmt.cpp Index: lib/AST/Stmt.cpp

[PATCH] D55212: Handle alloc_size attribute on function pointers

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:1072 def AllocSize : InheritableAttr { let Spellings = [GCC<"alloc_size">]; + let Subjects = SubjectList<[HasFunctionProto]>; arichardson wrote: > aaron.ballman wrote: > > Does GCC

[PATCH] D55222: [AST] Assert that no statement/expression class is polymorphic

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55222/new/ https://reviews.llvm.org/D55222 ___

[PATCH] D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap

zturner added a comment. Assuming this patch were to go in as-is (which it probably won't, based on the feedback, but let's just pretend), that would avoid having to explicitly update how many callsites? What I'm wondering is, how hard would it be to just update the call-sites? It looks like w

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

Pierre-vh added a comment. In D55226#1317083 , @george.karpenkov wrote: > Thank you for the fix, but how far can the pattern matching go? Seems easy > enough to think of cases not covered by the above. > In any case, the fix looks good. Hey, Sadly I'

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

cameron.mcinally added a comment. In D53157#1316860 , @uweigand wrote: > In my reading of the standard text, there is no special provision for library > code. This means that in general, calling any library function while running > with nondefault trap

[clang-tools-extra] r348169 - [clang-tidy] Recommit: Add the abseil-duration-comparison check

Author: jonastoth Date: Mon Dec 3 11:22:08 2018 New Revision: 348169 URL: http://llvm.org/viewvc/llvm-project?rev=348169&view=rev Log: [clang-tidy] Recommit: Add the abseil-duration-comparison check Summary: This check finds instances where Duration values are being converted to a numeric value

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

JonasToth added a comment. I had to revert and recommitted in rCTE348169 . `std::unordered_map` does not work, as `std::hash` is not specialized for it. This behaviour seems to work for some compilers, but some not. I had to google myself a bit for the best

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

riccibruno added a comment. In D54737#1317128 , @JonasToth wrote: > I had to revert and recommitted in rCTE348169 > . `std::unordered_map Something, ...>` does not work, as `std::hash` is not specialized for it. > Thi

[clang-tools-extra] r348172 - [clang-tidy] Fix unordered_map failure with specializing std::hash<> and remove previous wrong attempt at doing so

Author: jonastoth Date: Mon Dec 3 11:41:04 2018 New Revision: 348172 URL: http://llvm.org/viewvc/llvm-project?rev=348172&view=rev Log: [clang-tidy] Fix unordered_map failure with specializing std::hash<> and remove previous wrong attempt at doing so Modified: clang-tools-extra/trunk/clang-t

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

JonasToth added a comment. > `int8` ? Did you mean `int8_t` or am I missing somthing ? Your right, but the solution I wrote did actually not work anyway.. I just specialized `std::hash<>` now. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54737/new/ https://revi

[clang-tools-extra] r348176 - Fix compilation failure on Windows.

Author: zturner Date: Mon Dec 3 11:59:00 2018 New Revision: 348176 URL: http://llvm.org/viewvc/llvm-project?rev=348176&view=rev Log: Fix compilation failure on Windows. This was introduced earlier but apparently used an incorrect class name so it doesn't compile on Windows. Modified: clang-

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

cameron.mcinally added inline comments. Comment at: include/llvm/IR/IRBuilder.h:1244 } /// Copy fast-math-flags from an instruction rather than using the builder's I think you can forgo the `else {` in these functions since the if branch returns immediat

[PATCH] D55229: [COFF, ARM64] Make -flto-visibility-public-std a driver and cc1 flag

mgrang created this revision. mgrang added reviewers: rnk, mstorsjo, efriedma, TomTan. Herald added subscribers: dexonsmith, kristof.beyls, inglorion, javed.absar, mehdi_amini. Clang currently imports certain functions (like __imp__CxxThrowException) even when statically linking. Whereas MSVC st

[PATCH] D55229: [COFF, ARM64] Make -flto-visibility-public-std a driver and cc1 flag

mgrang added a comment. I wonder why this flag is called -flto-visibility-public-std. It has nothing to do with -flto. While we are at it, does it make sense to rename this flag? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55229/new/ https://reviews.llvm.org/D

[PATCH] D55188: Extract TextChildDumper class

aaron.ballman added inline comments. Comment at: include/clang/AST/ASTDumperUtils.h:22 + +namespace ast_dumper { +// Colors used for various parts of the AST dump steveire wrote: > aaron.ballman wrote: > > steveire wrote: > > > aaron.ballman wrote: > > > > I'm no

[PATCH] D55229: [COFF, ARM64] Make -flto-visibility-public-std a driver and cc1 flag

mstorsjo added a comment. FWIW, I don't see how this patch is related to ARM64 (the subject/tag of the patch). Using that for the test probably is fine as it can use any architecture, although an x86 one probably would increase the chances of it getting run by everyone. I don't have much input

r348182 - Portable Python script across Python version

Author: serge_sans_paille Date: Mon Dec 3 12:12:34 2018 New Revision: 348182 URL: http://llvm.org/viewvc/llvm-project?rev=348182&view=rev Log: Portable Python script across Python version Python2 supports both backticks and `repr` to access the __repr__ slot. Python3 only supports `repr`. Diff

[PATCH] D55229: [COFF, ARM64] Make -flto-visibility-public-std a driver and cc1 flag

pcc added a comment. The reason why it has that name is that it was originally added to support the logic here: http://llvm-cs.pcc.me.uk/tools/clang/lib/CodeGen/CGVTables.cpp#991 It looks like it was later repurposed as a "was /MT passed to the driver" flag when the logic was added to mark runt

[PATCH] D55212: Handle alloc_size attribute on function pointers

arichardson marked an inline comment as done. arichardson added a comment. Thanks for the review! I'll write a C++ test tomorrow. Comment at: include/clang/Basic/Attr.td:1072 def AllocSize : InheritableAttr { let Spellings = [GCC<"alloc_size">]; + let Subjects = SubjectLis

[PATCH] D55189: Extract TextNodeDumper class

aaron.ballman added a comment. Basically looking good, modulo namespace questions from D55188 and a few other organizational questions. Comment at: include/clang/AST/ASTTextNodeDumper.h:1 +//===--- ASTTextNodeDumper.h - Printing of AST nodes

[PATCH] D55229: [COFF, ARM64] Make -flto-visibility-public-std a driver and cc1 flag

mgrang added a comment. In D55229#1317232 , @pcc wrote: > The reason why it has that name is that it was originally added to support > the logic here: > http://llvm-cs.pcc.me.uk/tools/clang/lib/CodeGen/CGVTables.cpp#991 > > It looks like it was later rep

r348184 - Portable Python script across Python version

Author: serge_sans_paille Date: Mon Dec 3 12:26:51 2018 New Revision: 348184 URL: http://llvm.org/viewvc/llvm-project?rev=348184&view=rev Log: Portable Python script across Python version Workaround naming and hierarchy changes in BaseHTTPServer and SimpleHTTPServer module. Differential Revisi

[PATCH] D55134: [CTU] Add triple/lang mismatch handling

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55134/new/ https://reviews.llvm.org/D55134 ___

[PATCH] D55212: Handle alloc_size attribute on function pointers

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:1072 def AllocSize : InheritableAttr { let Spellings = [GCC<"alloc_size">]; + let Subjects = SubjectList<[HasFunctionProto]>; arichardson wrote: > aaron.ballman wrote: > > arichards

[PATCH] D55190: Move dump of individual comment nodes to NodeDumper

aaron.ballman added a comment. Looks reasonable, but similar to D55189 , can more of the implementation be pushed into a .cpp file rather than left in a header? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55190/new/ https://re

r348187 - [gcov/Darwin] Ensure external symbols are exported when using an export list

Author: vedantk Date: Mon Dec 3 12:53:58 2018 New Revision: 348187 URL: http://llvm.org/viewvc/llvm-project?rev=348187&view=rev Log: [gcov/Darwin] Ensure external symbols are exported when using an export list Make sure that symbols needed to implement runtime support for gcov are exported when

[PATCH] D55151: [gcov/Darwin] Ensure external symbols are exported when using an export list

This revision was automatically updated to reflect the committed changes. Closed by commit rL348187: [gcov/Darwin] Ensure external symbols are exported when using an export list (authored by vedantk, committed by ). Herald added subscribers: llvm-commits, delcypher. Changed prior to commit: htt

Re: r347588 - Revert "[clang][slh] add attribute for speculative load hardening"

Also, including the SVN revision (llvm's util/git-svn/git-svnrevert script can help with this) is helpful for other folks following along who may not be using git. On Mon, Nov 26, 2018 at 12:19 PM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Nov 26, 2018 at 3:13 PM

[PATCH] D55229: [COFF, ARM64] Make -flto-visibility-public-std a driver and cc1 flag

rnk added a comment. I think @compnerd arranged things this way. I don't know why -flto-visibility-public-std is involved, I have no idea what that does. I think we should do what MSVC does here, which is to leave _CxxThrowException unannotated and let the linker synthesize import thunks. Here

[PATCH] D54017: [analyzer] NullabilityChecker: Invariant violation should only be triggered for symbols.

NoQ added a comment. Wasn't me: rC347970 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54017/new/ https://reviews.llvm.org/D54017 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1304 +RHSTy = ResultTy; + } + ebevhan wrote: > rjmccall wrote: > > leonardchan wrote: > > > rjmccall wrote: > > > > ebevhan wrote: > > > > > rjmccall wrote: > > > > > > Hmm. So adding a

[PATCH] D55066: [ASan] Minor documentation fix: remove static linking limitation.

eugenis added a comment. How about "Static linking of executables is not supported"? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55066/new/ https://reviews.llvm.org/D55066 ___ cfe-commits mailing list cfe-commits@l

r348188 - Re-apply r347954 "[analyzer] Nullability: Don't detect post factum violation..."

Author: dergachev Date: Mon Dec 3 13:04:30 2018 New Revision: 348188 URL: http://llvm.org/viewvc/llvm-project?rev=348188&view=rev Log: Re-apply r347954 "[analyzer] Nullability: Don't detect post factum violation..." Buildbot failures were caused by an unrelated UB that was introduced in r347943

[PATCH] D54017: [analyzer] NullabilityChecker: Invariant violation should only be triggered for symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rL348188: Re-apply r347954 "[analyzer] Nullability: Don't detect post factum violation..." (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:

r348189 - NFC: Simplify dumpStmt child handling

Author: steveire Date: Mon Dec 3 13:05:52 2018 New Revision: 348189 URL: http://llvm.org/viewvc/llvm-project?rev=348189&view=rev Log: NFC: Simplify dumpStmt child handling Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55068 Modified: cf

[PATCH] D40218: [Clang] Add __builtin_launder

rsmith added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:1425-1426 + + // FIXME: We either have an incomplete class type, or we have a class template + // whose instantiation has not been forced. Example: + // I think it's a bug that `launder` does

[PATCH] D55068: NFC: Simplify dumpStmt child handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL348189: NFC: Simplify dumpStmt child handling (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn updated this revision to Diff 176464. kpn added a comment. Address review comment: Shrink the diff by eliminating unneeded use of else. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53157/new/ https://reviews.llvm.org/D53157 Files: include/llvm/IR/IRBuilder.h unittests/IR/IRBui

[PATCH] D55188: Extract TextChildDumper class

steveire updated this revision to Diff 176466. steveire added a comment. Rename class. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55188/new/ https://reviews.llvm.org/D55188 Files: include/clang/AST/ASTDumperUtils.h lib/AST/ASTDumper.cpp Index: lib/AST/AS

[PATCH] D54457: [AST] Generate unique identifiers for CXXCtorInitializer objects.

NoQ updated this revision to Diff 176465. NoQ added a comment. Rebase on top of D54486 ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54457/new/ https://reviews.llvm.org/D54457 Files: include/clang/AST/DeclCXX.h lib/AST/DeclBase.cpp lib/AST/DeclC

[PATCH] D54905: [AddressSanitizer] Add flag to disable linking with CXX runtime

eugenis added a comment. Linux linkers won't include a member of an archive only because it resolves a weak symbol, so in your example the answer is none. ASan uses -Wl,-whole-archive to pull all its members, this will resolve operator new to ASan definition unless there is another definition i

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

This change appears to have broken a number of compiler-rt coverage tests, e.g. in this run . The source of the error appears to be that llvm-cov is now trying to use a relative p

[PATCH] D55188: Extract TextChildDumper class

steveire updated this revision to Diff 176467. steveire added a comment. Remove namespace Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55188/new/ https://reviews.llvm.org/D55188 Files: include/clang/AST/ASTDumperUtils.h lib/AST/ASTDumper.cpp Index: lib/AST

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

I'll take a look right away. Thanks for letting me know! -- adrian > On Dec 3, 2018, at 1:26 PM, Vlad Tsyrklevich wrote: > > This change appears to have broken a number of compiler-rt coverage tests, > e.g. in this run >

r348192 - Typo correction; NFC.

Author: aaronballman Date: Mon Dec 3 13:27:15 2018 New Revision: 348192 URL: http://llvm.org/viewvc/llvm-project?rev=348192&view=rev Log: Typo correction; NFC. Modified: cfe/trunk/include/clang/AST/DeclCXX.h Modified: cfe/trunk/include/clang/AST/DeclCXX.h URL: http://llvm.org/viewvc/llvm-p

[PATCH] D55127: [OpenCL] Diagnose conflicting address spaces between template definition and its instantiation

rjmccall added a comment. Okay. What you're saying is that the current OpenCL C++ compiler is implicitly adding an address-space qualifier at the top level to explicit template arguments. I agree that it should not be doing that. Can you explain why the changes to `TreeTransform` are required

[PATCH] D55229: [COFF, ARM64] Make -flto-visibility-public-std a driver and cc1 flag

mgrang added a comment. In D55229#1317333 , @rnk wrote: > I think @compnerd arranged things this way. I don't know why > -flto-visibility-public-std is involved, I have no idea what that does. I > think we should do what MSVC does here, which is to leave

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54630/new/ https://reviews.llvm.org/D54630 ___ cfe-commit

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

arphaman added a comment. Please mention this change in the release notes though. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54630/new/ https://reviews.llvm.org/D54630 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D54457: [AST] Generate unique identifiers for CXXCtorInitializer objects.

NoQ updated this revision to Diff 176470. NoQ added a comment. Wait, i already did that in D54488 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54457/new/ https://reviews.llvm.org/D54457 Files: include/clang/AST/DeclCXX.h lib/AST/DeclCXX.cpp Ind

[PATCH] D53153: [OpenCL] Mark kernel functions with default visibility

scott.linder added a comment. In D53153#1315109 , @rjmccall wrote: > Okay. So it's still the case that all symbols will be defined within the > linkage unit; it's just that some things might need to get exposed outside of > it. > > LLVM does provide a `

Re: r348131 - [AST] Fix an uninitialized bug in the bits of FunctionDecl

Why the change from using setter functions to direct assignment? On Mon, Dec 3, 2018 at 5:06 AM Bruno Ricci via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: brunoricci > Date: Mon Dec 3 05:04:10 2018 > New Revision: 348131 > > URL: http://llvm.org/viewvc/llvm-project?rev=348131&vie

[PATCH] D55016: Correctly support -shared-libgcc.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. -eric Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55016/new/ https://reviews.llvm.org/D55016 ___ cf

r348198 - [AST] Generate unique identifiers for CXXCtorInitializer objects.

Author: dergachev Date: Mon Dec 3 14:15:34 2018 New Revision: 348198 URL: http://llvm.org/viewvc/llvm-project?rev=348198&view=rev Log: [AST] Generate unique identifiers for CXXCtorInitializer objects. This continues the work started in r342309 and r342315 to provide identifiers to AST objects th

[PATCH] D54457: [AST] Generate unique identifiers for CXXCtorInitializer objects.

This revision was automatically updated to reflect the committed changes. Closed by commit rL348198: [AST] Generate unique identifiers for CXXCtorInitializer objects. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D55189: Extract TextNodeDumper class

steveire updated this revision to Diff 176478. steveire added a comment. Herald added a subscriber: mgorny. Move implementation to cpp file Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55189/new/ https://reviews.llvm.org/D55189 Files: include/clang/AST/TextNo

r348199 - [AST] [analyzer] NFC: Reuse code in stable ID dumping methods.

Author: dergachev Date: Mon Dec 3 14:19:05 2018 New Revision: 348199 URL: http://llvm.org/viewvc/llvm-project?rev=348199&view=rev Log: [AST] [analyzer] NFC: Reuse code in stable ID dumping methods. Use the new fancy method introduced in r348197 to simplify some code. Differential Revision: http

<    1   2   3   >