[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

nathanchance added a comment. > Could it be an issue with python? What is the version you are using? I would assume so... $ /usr/bin/python --version Python 3.7.4 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 ___

[PATCH] D66652: [libTooling] Transformer: refine `SourceLocation` specified as anchor of changes.

ymandel updated this revision to Diff 216921. ymandel marked 2 inline comments as done. ymandel added a comment. comments tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66652/new/ https://reviews.llvm.org/D66652 Files: clang/include/clang

[PATCH] D66676: [clang-tidy] TransformerClangTidyCheck: change choice of location for diagnostic message.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a subscriber: xazax.hun. Herald added a project: clang. This patch changes the location specified to the `ClangTidyCheck::diag()`. Currently, the beginning of the matched range is used. This patch uses the beginning o

[PATCH] D66486: [LifetimeAnalysis] Detect more cases when the address of a local variable escapes

mgehre added a comment. When I understand you correctly, you are thinking about the cases OwningArrayRef getRef(); ArrayRef f() { ArrayRef r = getRef(); // warning: r points into temporary owner return r; } and ArrayRef getRef() { OwningArrayRef r; return r; // warni

[PATCH] D66486: [LifetimeAnalysis] Detect more cases when the address of a local variable escapes

xazax.hun added a comment. Yeah, the analysis would work fine in this case. But that would mean that we should not propagate the Pointer annotations to derived classes as some of them in the wild do not follow the same ownership model. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D66564: [clang-tidy] new FPGA struct pack align check

ffrankies updated this revision to Diff 216928. ffrankies added a comment. Implemented changes requested by Eugene.Zelenko CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66564/new/ https://reviews.llvm.org/D66564 Files: clang-tidy/fpga/CMakeLists.txt clang-tidy/fpga/FPGATidyModule.c

r369801 - [OPENMP5]Use nonmonotonic modifier by default for non-static and

Author: abataev Date: Fri Aug 23 12:52:05 2019 New Revision: 369801 URL: http://llvm.org/viewvc/llvm-project?rev=369801&view=rev Log: [OPENMP5]Use nonmonotonic modifier by default for non-static and non-ordered loops. According to OpenMP 5.0, 2.9.2 Worksharing-Loop Construct, Desription, If the

r369803 - Do a sweep of symbol internalization. NFC.

Author: d0k Date: Fri Aug 23 12:59:23 2019 New Revision: 369803 URL: http://llvm.org/viewvc/llvm-project?rev=369803&view=rev Log: Do a sweep of symbol internalization. NFC. Modified: cfe/trunk/lib/CodeGen/CGNonTrivialStruct.cpp cfe/trunk/lib/Frontend/InterfaceStubFunctionsConsumer.cpp

Re: r369591 - [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

On Thu, 22 Aug 2019 at 13:05, Matthias Gehre via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Diana, > hi Richard, > > thank you for the feedback! > > Diana, > I remember that some gcc version had issues with raw string literals > inside macros. I'll fix that to use normal > string litera

[PATCH] D66486: [LifetimeAnalysis] Detect more cases when the address of a local variable escapes

mgehre added a comment. Yes, it means that the automatic inference of Pointer/Owner from base classes has the same issues as all of those automatic inferences: Once can construct a case where they are not true. So for having no false-positives at all, we should avoid this inference by default a

Re: r369616 - [analyzer] Enable control dependency condition tracking by default

I had a look and i don't observe any regressions here. Both this test alone and the whole test suite in general take as much time as on r369520 for me. Additionally, -analyzer-stats doesn't indicate that any significant amount of time was spent in bug report post-processing. On 8/23/19 11:41 A

[PATCH] D66564: [clang-tidy] new FPGA struct pack align check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/fpga/StructPackAlignCheck.h:1 +//===--- StructPackAlignCheck.h - clang-tidy-*- C++ -*-===// +// Please add space after clang-tidy. Same in source file. Comment at

[PATCH] D66673: [OPENMP][NVPTX]Fix critical region codegen.

jdoerfert added a comment. I guess IR test should be affected already and it would be good to have the run time test that breaks with barriers. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66673/new/ https://reviews.llvm.org/D66673 __

[PATCH] D66673: [OPENMP][NVPTX]Fix critical region codegen.

ABataev added a comment. In D66673#1643544 , @jdoerfert wrote: > I guess IR test should be affected already and it would be good to have the > run time test that breaks with barriers. Runtime test is libomptarget/deviceRTLs/nvptx/test/parallel/spmd_par

[PATCH] D66673: [OPENMP][NVPTX]Fix critical region codegen.

ABataev updated this revision to Diff 216934. ABataev added a comment. Fix the test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66673/new/ https://reviews.llvm.org/D66673 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp test/OpenMP/nvptx_parallel_codegen.cpp

[PATCH] D66486: [LifetimeAnalysis] Detect more cases when the address of a local variable escapes

xazax.hun added a comment. Sounds good! Let's do that :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66486/new/ https://reviews.llvm.org/D66486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r369591 - [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

Hi Richard, I'll move these behind a flag today. Moving forward, it would be great to have a way to dogfood those warnings without blocking you. We do run them over ~340 open source projects regularly, but clearly that is not enough :) Thanks, Gabor On Fri, 23 Aug 2019 at 13:03, Richard Smith w

[PATCH] D66681: [clang-doc] Bump BitcodeWriter max line number to 32U

juliehockett created this revision. juliehockett added a reviewer: phosek. juliehockett added a project: clang-tools-extra. b43039 reports hitting the assert on a very large file, so bumping this to allow for larger files. https://reviews.llvm.org/D66681 Files: clang-tools-extra/clang-doc/Bi

[PATCH] D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations

arphaman added a comment. In D65907#1643364 , @JamesNagurne wrote: > @arphaman you disabled this test on Windows, but did not specify exactly how > it fails. > My team works on an embedded ARM compiler (most similar to arm-none-eabi), > and we're now s

[PATCH] D66681: [clang-doc] Bump BitcodeWriter max line number to 32U

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM (small nit, people usually use PRXXX rather than bXXX to refer to issues) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66681/new/ https://reviews.llvm.org/D66681

[clang-tools-extra] r369811 - [clang-doc] Bump BitcodeWriter max line number to 32U

Author: juliehockett Date: Fri Aug 23 14:14:05 2019 New Revision: 369811 URL: http://llvm.org/viewvc/llvm-project?rev=369811&view=rev Log: [clang-doc] Bump BitcodeWriter max line number to 32U PR43039 reports hitting the assert on a very large file, so bumping this to allow for larger files. Dif

[PATCH] D66681: [clang-doc] Bump BitcodeWriter max line number to 32U

This revision was automatically updated to reflect the committed changes. Closed by commit rL369811: [clang-doc] Bump BitcodeWriter max line number to 32U (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D66686: [LifetimeAnalysis] Make it possible to disable the new warnings

xazax.hun created this revision. xazax.hun added reviewers: rsmith, mgehre. xazax.hun added a project: clang. Herald added subscribers: llvm-commits, Szelethus, Charusso, gamesh411, jfb, dkrupp, rnkovacs, hiraditya, javed.absar. Herald added a project: LLVM. This patch introduces quite a bit of p

[PATCH] D66686: [LifetimeAnalysis] Make it possible to disable the new warnings

xazax.hun updated this revision to Diff 216962. xazax.hun added a comment. - Add the actual diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66686/new/ https://reviews.llvm.org/D66686 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKi

Re: r369591 - [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

Hi Richard, Sorry for the slow response, unfortunately the compile times are not great on the machine I have access to at the moment. Here is a patch, I'll commit it if you agree with the approach: https://reviews.llvm.org/D66686 Basically, the idea is to not run the new warning related code at a

[PATCH] D66686: [LifetimeAnalysis] Make it possible to disable the new warnings

xazax.hun updated this revision to Diff 216964. xazax.hun added a comment. - Added a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66686/new/ https://reviews.llvm.org/D66686 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td

r369817 - [LifetimeAnalysis] Make it possible to disable the new warnings

Author: xazax Date: Fri Aug 23 15:21:33 2019 New Revision: 369817 URL: http://llvm.org/viewvc/llvm-project?rev=369817&view=rev Log: [LifetimeAnalysis] Make it possible to disable the new warnings Added: cfe/trunk/test/Sema/warn-lifetime-analysis-nocfg-disabled.cpp Modified: cfe/trunk/incl

[PATCH] D66364: Diagnose use of _Thread_local as an extension when appropriate

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. In D66364#1638026 , @aaron.ballman wrote: > @rsmith are you fine with implementing the diagnostic for these keywords > piecemeal based on the pattern

r369820 - Fix a test to test what the name suggest.

Author: xazax Date: Fri Aug 23 15:26:49 2019 New Revision: 369820 URL: http://llvm.org/viewvc/llvm-project?rev=369820&view=rev Log: Fix a test to test what the name suggest. Modified: cfe/trunk/test/Sema/warn-lifetime-analysis-nocfg-disabled.cpp Modified: cfe/trunk/test/Sema/warn-lifetime-an

Re: r369591 - [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

I committed this in r369817 to keep things moving. If you have any suggestion, complaints let me know and I will do my best to solve it post-commit ASAP. On Fri, 23 Aug 2019 at 14:51, Gábor Horváth wrote: > Hi Richard, > > Sorry for the slow response, unfortunately the compile times are not grea

Re: r369591 - [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

Thank you for the fast turnaround here! On Fri, 23 Aug 2019 at 15:26, Gábor Horváth via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I committed this in r369817 to keep things moving. If you have any > suggestion, complaints let me know and I will do my best to solve it > post-commit ASAP.

[PATCH] D66686: [LifetimeAnalysis] Make it possible to disable the new warnings

xazax.hun abandoned this revision. xazax.hun added a comment. Committed in https://reviews.llvm.org/rG6379e5c8a441 due to it was urgent for some users. Will address any comments post-commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66686/new/ https://reviews.llvm.org/D66686 ___

[PATCH] D66662: [clang-format] [PR43100] clang-format C# support does not add a space between "using" and paren

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2618 +// using (FileStream fs... +if (Style.isCSharp() && Left.is(tok::kw_using) && Right.is(tok::l_paren)) + return true; `if (Style.isCSharp() && Left.is(tok::kw_using))

r369822 - [libclang][index][NFC] Fix test for skipping already parsed function bodies

Author: jkorous Date: Fri Aug 23 15:51:23 2019 New Revision: 369822 URL: http://llvm.org/viewvc/llvm-project?rev=369822&view=rev Log: [libclang][index][NFC] Fix test for skipping already parsed function bodies Modified: cfe/trunk/test/Index/skip-parsed-bodies/compile_commands.json Modified:

[PATCH] D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations

JamesNagurne added a comment. In D65907#1643650 , @arphaman wrote: > No the windows test failure was different, there were no Deps at all. I'm > currently investigating it on a windows VM. > > @JamesNagurne I think there's some issue with the working dire

Re: r369591 - [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

On Thu, Aug 22, 2019 at 4:05 PM Matthias Gehre via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Diana, > hi Richard, > > thank you for the feedback! > > Diana, > I remember that some gcc version had issues with raw string literals > inside macros. I'll fix that to use normal > string lite

[PATCH] D66572: [analyzer] BugReporter Separation Ep.I.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:223 + using visitor_iterator = VisitorList::iterator; + using visitor_range = llvm::iterator_range; + Szelethus wrote

Re: [clang-tools-extra] r369763 - [clang-tidy] Possibility of displaying duplicate warnings

Hello Kristof, This commit broke test to few builders: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/53703 http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast . . . Failing Tests (1): Clang Tools :: clang-tidy/duplicate-rep

r369829 - PR40674: fix assertion failure if a structured binding declaration has a

Author: rsmith Date: Fri Aug 23 18:23:57 2019 New Revision: 369829 URL: http://llvm.org/viewvc/llvm-project?rev=369829&view=rev Log: PR40674: fix assertion failure if a structured binding declaration has a tuple-like decomposition that produces value-dependent reference bindings. Modified: cf

r369830 - NFC: Rename some sanitizer related lifetime checks

Author: vitalybuka Date: Fri Aug 23 18:31:38 2019 New Revision: 369830 URL: http://llvm.org/viewvc/llvm-project?rev=369830&view=rev Log: NFC: Rename some sanitizer related lifetime checks Added: cfe/trunk/test/CodeGen/lifetime-sanitizer.c cfe/trunk/test/CodeGenCXX/lifetime-sanitizer.cpp R

[PATCH] D66695: msan, codegen, instcombine: Keep more lifetime markers used for msan

vitalybuka created this revision. vitalybuka added a reviewer: eugenis. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, hiraditya. Herald added projects: clang, Sanitizers, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66695 Files: clang/lib/CodeGen/CGE

r369832 - Re-enable DependencyScannerTest on windows with the right fixes

Author: arphaman Date: Fri Aug 23 18:53:40 2019 New Revision: 369832 URL: http://llvm.org/viewvc/llvm-project?rev=369832&view=rev Log: Re-enable DependencyScannerTest on windows with the right fixes It should now pass. Modified: cfe/trunk/unittests/Tooling/DependencyScannerTest.cpp Modified

[PATCH] D66695: msan, codegen, instcombine: Keep more lifetime markers used for msan

vitalybuka updated this revision to Diff 216991. vitalybuka added a comment. return hwasan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66695/new/ https://reviews.llvm.org/D66695 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CodeGenFu

[PATCH] D66695: msan, codegen, instcombine: Keep more lifetime markers used for msan

vitalybuka updated this revision to Diff 216992. vitalybuka added a comment. fix compilation error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66695/new/ https://reviews.llvm.org/D66695 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/C

[PATCH] D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

vsapsai created this revision. vsapsai added reviewers: erik.pilkington, ahatanak. Herald added subscribers: ributzka, dexonsmith, jkorous. When a category/extension doesn't repeat a type bound, corresponding type parameter is substituted with `id` when used as a type argument. As a result, in the

[PATCH] D66695: msan, codegen, instcombine: Keep more lifetime markers used for msan

vitalybuka updated this revision to Diff 216994. vitalybuka added a comment. update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66695/new/ https://reviews.llvm.org/D66695 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CodeGenF

[PATCH] D66697: hwasan, codegen: Keep more lifetime markers used for hwasan

vitalybuka created this revision. vitalybuka added a reviewer: eugenis. Herald added a project: clang. Herald added a subscriber: cfe-commits. vitalybuka added a parent revision: D66695: msan, codegen, instcombine: Keep more lifetime markers used for msan. Repository: rG LLVM Github Monorepo h

r369834 - PR42513: Enter the proper DeclContext before substituting into an

Author: rsmith Date: Fri Aug 23 19:30:00 2019 New Revision: 369834 URL: http://llvm.org/viewvc/llvm-project?rev=369834&view=rev Log: PR42513: Enter the proper DeclContext before substituting into an default template argument expression. We already did this for type template parameters and templat

[PATCH] D66662: [clang-format] [PR43100] clang-format C# support does not add a space between "using" and paren

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:169 +TEST_F(FormatTestCSharp, CSharpUsing) { + verifyFormat("using (StreamWriter sw = new StreamWriter(filename) { }"); +} owenpan wrote: > Maybe set `SpaceBeforeParens` to `A

[PATCH] D66699: [PowerPC][Altivec] Fix constant argument for vec_dss

jsji created this revision. jsji added reviewers: nemanjai, hfinkel. Herald added subscribers: cfe-commits, shchenz, MaskRay, kbarton. Herald added a project: clang. jsji added a reviewer: PowerPC. Herald added a subscriber: wuzish. This is similar to vec_ct* in https://reviews.llvm.org/rL304205.

[PATCH] D66621: [clang] Devirtualization for classes with destructors marked as 'final'

logan-5 updated this revision to Diff 217009. logan-5 added a comment. Add a missing null check. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66621/new/ https://reviews.llvm.org/D66621 Files: clang/lib/AST/DeclCXX.cpp clang/test/CodeGenCXX/devirtualize-virt

[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

cvenegas added a comment. I'm testing this patch on our codebase and it is working pretty well. We use the Allman style and the lambda problem has been an issue for many years. One thing to note in this patch is that some of the files have CRLF line endings but should be LF endings, which is wh

[PATCH] D66695: msan, codegen, instcombine: Keep more lifetime markers used for msan

lebedev.ri added inline comments. Comment at: llvm/test/Transforms/InstCombine/lifetime-sanitizer.ll:37-50 +define void @msan() sanitize_memory { +entry: + ; CHECK-LABEL: @msan( + %text = alloca i8, align 1 + + call void @llvm.lifetime.start.p0i8(i64 1, i8* %text) + call void

<    1   2