[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang updated this revision to Diff 286467. weiwang added a comment. coding style change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/include/clang/Driver/Driver.h

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang marked 5 inline comments as done. weiwang added inline comments. Comment at: clang/include/clang/Driver/Driver.h:638 +/// This checks for clang specific R-value ('-Rpass-*') group. +bool hasRpassOptions(const llvm::opt::ArgList ); + bruno wrote: >

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#2225202 , @rjmccall wrote: > I think that, if we want to do this, we need to think carefully about what > exactly we want the ABI to be. I agree with this very much. Open to suggestions and ideas. Already started

[clang] d9ff48d - WCharType and WIntType are always signed int on OpenBSD.

Author: Brad Smith Date: 2020-08-18T19:59:54-04:00 New Revision: d9ff48d03817f83d4059b610a776c797308de2e5 URL: https://github.com/llvm/llvm-project/commit/d9ff48d03817f83d4059b610a776c797308de2e5 DIFF: https://github.com/llvm/llvm-project/commit/d9ff48d03817f83d4059b610a776c797308de2e5.diff

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

rjmccall added a comment. I think that, if we want to do this, we need to think carefully about what exactly we want the ABI to be. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049

[PATCH] D60620: [HIP] Support target id by --offload-arch

This revision was automatically updated to reflect the committed changes. Closed by commit rG7546b29e7616: [HIP] Support target id by --offload-arch (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60620?vs=285482=286469#toc Repository:

[clang] 7546b29 - [HIP] Support target id by --offload-arch

Author: Yaxun (Sam) Liu Date: 2020-08-18T23:43:53-04:00 New Revision: 7546b29e761687eeeaefcd8d963c19a2dac98d37 URL: https://github.com/llvm/llvm-project/commit/7546b29e761687eeeaefcd8d963c19a2dac98d37 DIFF:

[PATCH] D84886: Create LoopNestPass

TaWeiTu added a comment. Hi @Whitney, @fhahn, @ychen, thank you all for your comments and suggestions! Sorry about the late reply. I was trying to convert the `LoopInterchange` pass into a loop-nest pass. However, there seems to be no corresponding loop pass for the NPM. Any particular reason

[PATCH] D86187: [X86] Add support 'tune' in target attribute

craig.topper created this revision. craig.topper added reviewers: echristo, erichkeane, spatel, RKSimon. Herald added a reviewer: aaron.ballman. craig.topper requested review of this revision. This adds parsing and codegen support for tune in target attribute. I've implemented this so that arch

[PATCH] D83154: clang: Add -fcoverage-prefix-map

phosek added a comment. @keith do you plan on finishing this? I think we should change the name from `-fcoverage-prefix-map` to `-fprofile-prefix-map`, but otherwise it might be good to go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83154/new/

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith added a comment. Yes I do, sorry I've been a bit busy, I will try to get to this later this week Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83154/new/ https://reviews.llvm.org/D83154 ___

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang updated this revision to Diff 286468. weiwang marked an inline comment as done. weiwang added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files:

[clang] a11ab6e - Fix test hip-target-id.hip

Author: Yaxun (Sam) Liu Date: 2020-08-19T00:41:14-04:00 New Revision: a11ab6e04c199c2a33d81c451e9e26bf18636dfc URL: https://github.com/llvm/llvm-project/commit/a11ab6e04c199c2a33d81c451e9e26bf18636dfc DIFF:

[PATCH] D75045: [analyzer] Improved check of `fgetc` in StreamChecker.

balazske planned changes to this revision. balazske added a comment. Herald added subscribers: ASDenysPetrov, whisperity. Something like this can be added to StreamChecker but it has changed in many places so a new review would be needed. The main problem is with this `fgetc` check is that it

[PATCH] D84932: [builtins] Add more test cases for __div[sdt]f3 LibCalls

sepavloff added a comment. In D84932#2223559 , @atrosinenko wrote: > @sepavloff > > Thank you for the test cases. Looks like it is worth completely rewriting the > three tests as table-driven tests Tests are not required to be compact. It is more

[PATCH] D71510: [clang][checkers] Added new checker 'error-return-checker'.

balazske planned changes to this revision. balazske added a comment. Herald added subscribers: martong, Charusso. This patch is here for code reference only. Although the whole checker does not work safe in this way the idea behind this approach can be useful. Repository: rG LLVM Github

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

craig.topper added a subscriber: ddunbar. craig.topper added a comment. In D85384#2225434 , @phosek wrote: > This seems to have broken our Mac builders with the following error: > > -- Testing: 25226 tests, 24 workers -- > Testing: 0.. 10.. 20. >

[PATCH] D83088: Introduce CfgTraits abstraction

dblaikie added a comment. In D83088#2224297 , @nhaehnle wrote: >> Not sure that's the best place to be designing this fairly integral and >> complicated piece of infrastructure from, but hoping we can find some good >> places/solutions/etc. > > I sent

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks

hoy created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang, laytonio, asbirlea, hiraditya, mgorny. Herald added projects: clang, LLVM. hoy requested review of this revision. Herald added a subscriber: jdoerfert. Repository: rG LLVM Github Monorepo

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

phosek added a comment. This seems to have broken our Mac builders with the following error: -- Testing: 25226 tests, 24 workers -- Testing: 0.. 10.. 20. FAIL: Clang :: Frontend/ast-main.c (6834 of 25226) TEST 'Clang :: Frontend/ast-main.c' FAILED

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks

hoy updated this revision to Diff 286476. hoy added a comment. Updating D86193 : [CSSPGO] Pseudo probe instrumentation for basic blocks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86193/new/

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

craig.topper added a comment. In D85384#2225459 , @echristo wrote: > This would be because at that point the default cpu was that and it > probably had something to do with fallbacks. > > At this point it can be changed I imagine to whatever makes sense.

<    1   2