[PATCH] D88603: [WebAssembly] Add support for DWARF type units

dschuff updated this revision to Diff 301133. dschuff added a comment. use GenericSectionID instead of ~0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88603/new/ https://reviews.llvm.org/D88603 Files: llvm/lib/MC/MCObjectFileInfo.cpp Index: l

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

njames93 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6763 +/// (but not "nodiscard" or "clang::warn_unused_result"). +AST_MATCHER_P(Attr, hasAttrName, llvm::StringRef, Name) { + return Node.getAttrName() && Node.getAttrName()->isStr(Name); --

[clang] 739d4bf - Unbreak build with gcc5.3 after 917acac

Author: Nico Weber Date: 2020-10-27T20:10:48-04:00 New Revision: 739d4bf8f43d0a5a3a99e07b1647ded1ce1d81b3 URL: https://github.com/llvm/llvm-project/commit/739d4bf8f43d0a5a3a99e07b1647ded1ce1d81b3 DIFF: https://github.com/llvm/llvm-project/commit/739d4bf8f43d0a5a3a99e07b1647ded1ce1d81b3.diff LO

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

aeubanks added a comment. In D89158#2357850 , @ychen wrote: > IIUC, this is the NPM version of EP_EarlyAsPossible in legacy PM for O0, > right? Between the choice of (1) [this patch and ] reusing all existing EP > callbacks and letting optnone filtering

[clang] b1a90e1 - [OpenMP][CUDA] Add missing overload for `remquo(float,float,int*)`

Author: Johannes Doerfert Date: 2020-10-27T19:12:51-05:00 New Revision: b1a90e1599a65bccf9af985603e198af3876b59a URL: https://github.com/llvm/llvm-project/commit/b1a90e1599a65bccf9af985603e198af3876b59a DIFF: https://github.com/llvm/llvm-project/commit/b1a90e1599a65bccf9af985603e198af3876b59a.d

[PATCH] D89971: [OpenMP][CUDA] Add missing overload for `remquo(float,float,int*)`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1a90e1599a6: [OpenMP][CUDA] Add missing overload for `remquo(float,float,int*)` (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHA

[clang] bcb8a11 - [WebAssembly] Add support for DWARF type units

Author: Derek Schuff Date: 2020-10-27T17:13:41-07:00 New Revision: bcb8a119df210753c5f1a3ac346d49597fef0f51 URL: https://github.com/llvm/llvm-project/commit/bcb8a119df210753c5f1a3ac346d49597fef0f51 DIFF: https://github.com/llvm/llvm-project/commit/bcb8a119df210753c5f1a3ac346d49597fef0f51.diff

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbcb8a119df21: [WebAssembly] Add support for DWARF type units (authored by dschuff). Changed prior to commit: https://reviews.llvm.org/D88603?vs=30

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang updated this revision to Diff 301140. weiwang added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/opt-re

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

ychen added inline comments. Comment at: llvm/include/llvm/Passes/PassBuilder.h:626 + /// typically run at the very beginning. + void runRegisteredO0EPCallbacks(ModulePassManager &MPM, bool DebugLogging); + invokeO0EPCallbacks? I saw there is `PassBuilder::invo

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, jdoerfert, steven_wu, hiraditya. Herald added a reviewer: aaron.ballman. Herald added projects: clang, LLVM. gulfem requested review of this revision. GCC supports __attribute__((leaf)) as an optimizati

[PATCH] D89834: FileManager: Improve the FileEntryRef API and customize Optional

dexonsmith updated this revision to Diff 301138. dexonsmith retitled this revision from "FileManager: Improve the FileEntryRef API and add MaybeFileEntryRef" to "FileManager: Improve the FileEntryRef API and customize Optional". dexonsmith edited the summary of this revision. dexonsmith added a c

[PATCH] D90275: [clang][IR] Add support for leaf attribute

jdoerfert added a comment. Tests missing (on all levels), was there an RFC? What is the expected usage of this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275 _

[clang] c486870 - [clang] Pass-through remarks options to linker

Author: Wei Wang Date: 2020-10-27T17:23:32-07:00 New Revision: c4868700c58078d0f4c71fab5af2bb73270d2d9f URL: https://github.com/llvm/llvm-project/commit/c4868700c58078d0f4c71fab5af2bb73270d2d9f DIFF: https://github.com/llvm/llvm-project/commit/c4868700c58078d0f4c71fab5af2bb73270d2d9f.diff LOG:

[PATCH] D90275: [clang][IR] Add support for leaf attribute

jdoerfert added a comment. (To clarify, I am not opposing this, my comment before was brief but not meant to be negative. I'm generally for new attributes and this one is already in existing source so that is even better.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

aeubanks updated this revision to Diff 301145. aeubanks added a comment. run -> invoke Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/ https://reviews.llvm.org/D89158 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/bpf-O0.

[PATCH] D90275: [clang][IR] Add support for leaf attribute

mcgrathr added a comment. There is an RFC going out with this prototype as reference. When there is consensus on the RFC, this will get in shape for landing with complete tests and all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ ht

[PATCH] D90253: [WebAssembly] Prototype extending multiplication SIMD instructions

tlively updated this revision to Diff 301147. tlively added a comment. - Use V8 encodings: https://chromium-review.googlesource.com/c/v8/v8/+/2469156/4/src/wasm/wasm-opcodes.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90253/new/ https://review

[PATCH] D89836: Change Module::ASTFile and ModuleFile::File => Optional, NFC

dexonsmith updated this revision to Diff 301146. dexonsmith retitled this revision from "Change Module::ASTFile and ModuleFile::File => MaybeFileEntryRef, NFC" to "Change Module::ASTFile and ModuleFile::File => Optional, NFC". dexonsmith edited the summary of this revision. dexonsmith added a com

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang closed this revision. weiwang added a comment. Diff was committed, but did not close automatically. Manual close it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 _

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:1659 + bool DebugLogging) { + for (auto &C : PipelineStartEPCallbacks) +C(MPM); ychen wrote: >

[PATCH] D90053: Serialization: Change InputFile to use FileEntryRef and add getVirtualFileRef, NFC

dexonsmith updated this revision to Diff 301148. dexonsmith edited the summary of this revision. dexonsmith added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90053/new/ https://reviews.llvm.org/D90053 Files: clang/include/clang/Basic/FileManager.h clang/include

[PATCH] D90275: [clang][IR] Add support for leaf attribute

jdoerfert added a comment. In D90275#2357931 , @mcgrathr wrote: > There is an RFC going out with this prototype as reference. When there is > consensus on the RFC, this will get in shape for landing with complete tests > and all. Great. I didn't find a

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

asbirlea added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:1659 + bool DebugLogging) { + for (auto &C : PipelineStartEPCallbacks) +C(MPM); aeubanks wrote: > ychen wrote: > > What I have in mind is

[PATCH] D89488: FileManager: Shrink FileEntryRef to the size of a pointer

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/FileManager.h:101 + /// Type used in the StringMap. + using MapEntry = llvm::StringMapEntry>; + thakis wrote: > thakis wrote: > > It looks like this is too clever for gcc5.3: > > https://b

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem added a comment. In D90275#2357945 , @jdoerfert wrote: > In D90275#2357931 , @mcgrathr wrote: > >> There is an RFC going out with this prototype as reference. When there is >> consensus on the RFC, this wil

[PATCH] D90275: [clang][IR] Add support for leaf attribute

jdoerfert added a comment. In D90275#2357951 , @gulfem wrote: > In D90275#2357945 , @jdoerfert wrote: > >> In D90275#2357931 , @mcgrathr wrote: >> >>> There is an RFC going o

[PATCH] D90099: [Clang][OpenMP][WIP] Added the support for target data nowait

tianshilei1992 updated this revision to Diff 301150. tianshilei1992 added a comment. Rebased and fixed one test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90099/new/ https://reviews.llvm.org/D90099 Files: clang/lib/CodeGen/CGOpenMPRuntim

[clang] af2f5f9 - Remove unused variable name. NFC.

Author: Richard Smith Date: 2020-10-27T17:48:50-07:00 New Revision: af2f5f99bd144ae2f70e21d53b23fc18a3d9d7d0 URL: https://github.com/llvm/llvm-project/commit/af2f5f99bd144ae2f70e21d53b23fc18a3d9d7d0 DIFF: https://github.com/llvm/llvm-project/commit/af2f5f99bd144ae2f70e21d53b23fc18a3d9d7d0.diff

[PATCH] D90099: [Clang][OpenMP][WIP] Added the support for target data nowait

tianshilei1992 updated this revision to Diff 301151. tianshilei1992 added a comment. Fixed a rebase error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90099/new/ https://reviews.llvm.org/D90099 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp cla

Re: [clang] e97e985 - [c++20] For P0732R2: permit class template argument deduction for non-type template parameters.

On Tue, 27 Oct 2020 at 17:08, Nico Weber wrote: > gcc points out that DTST is unused in > > +if (auto *DTST = > dyn_cast(DeducedT)) { > > Should it be used? Or should we delete the lhs of that assignment? > The latter. Done in af2f5f99bd144ae2f70e21d53b23fc18a3d9d7d0. > On Wed, Oct 21, 202

[PATCH] D90275: [clang][IR] Add support for leaf attribute

leonardchan added a comment. I'd recommend splitting this into two patches, one for LLVM changes and another for Clang changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275 _

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend

pengfei added a comment. I agreed with Craig. Emitting constrained intrinsics on an unsupported target may result in problems. It's better to check if it is supported and prevent from the front end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87

[clang] 44eea0b - Revert "[WebAssembly] Add support for DWARF type units"

Author: Derek Schuff Date: 2020-10-27T17:57:32-07:00 New Revision: 44eea0b1a7301de4c284afed1c023014c391372f URL: https://github.com/llvm/llvm-project/commit/44eea0b1a7301de4c284afed1c023014c391372f DIFF: https://github.com/llvm/llvm-project/commit/44eea0b1a7301de4c284afed1c023014c391372f.diff

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

dschuff added a comment. This broke the bots for some strange reason that didn't reproduce locally. But because it was ~all of them, I probably just did something stupid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88603/new/ https://reviews.llv

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

ychen added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:1659 + bool DebugLogging) { + for (auto &C : PipelineStartEPCallbacks) +C(MPM); asbirlea wrote: > aeubanks wrote: > > ychen wrote: > > > What

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

aeubanks added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:1659 + bool DebugLogging) { + for (auto &C : PipelineStartEPCallbacks) +C(MPM); ychen wrote: > asbirlea wrote: > > aeubanks wrote: > > > y

[PATCH] D90278: [ThinLTO] Fix .llvmcmd emission

mtrofin created this revision. mtrofin added a reviewer: tejohnson. Herald added subscribers: llvm-commits, cfe-commits, steven_wu, hiraditya, inglorion. Herald added projects: clang, LLVM. mtrofin requested review of this revision. llvm::EmbedBitcodeInModule needs (what used to be called) EmbedM

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

ychen added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:1659 + bool DebugLogging) { + for (auto &C : PipelineStartEPCallbacks) +C(MPM); aeubanks wrote: > ychen wrote: > > asbirlea wrote: > > > aeub

[PATCH] D90129: Source location for -Wignored-qualifiers on lambda trailing return type

aaronpuchert updated this revision to Diff 301161. aaronpuchert marked an inline comment as done. aaronpuchert added a comment. Collect location of a trailing return type in the parser, use that for the warning. I resisted clang-format's urge to reflow the large parameter lists, I hope that's t

Re: Upcoming upgrade of LLVM buildbot

Hello everyone, The LLVM buildbot is upgraded. Thanks for your patience and support! llvm-zorg source code has been updated, and now is open for new changes. If you have pending patches, please rebase them on top of the llvm-zorg master and update your reviews on the Phabricator. I'll start revi

Re: [llvm-dev] Upcoming upgrade of LLVM buildbot

Hello Florian, Thanks for pointing to the problem. Appreciate this. It has been fixed and now failed builds reported with the blamelist. Thanks Galina On Wed, Oct 21, 2020 at 5:30 AM Florian Hahn wrote: > > > On Oct 20, 2020, at 03:35, Galina Kistanova via llvm-dev < > llvm-...@lists.llvm.or

[PATCH] D90099: [Clang][OpenMP][WIP] Added the support for target data nowait

tianshilei1992 updated this revision to Diff 301164. tianshilei1992 added a comment. Fixed a rebase issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90099/new/ https://reviews.llvm.org/D90099 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp cla

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 301167. jhuber6 added a comment. Updating after D90172 and D89802 landed. I don't see it failing the tests anymore but I'll look into it more. I should probably make a test for the source l

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 301172. LuoYuanke added a comment. Herald added a subscriber: dexonsmith. Rebase and Model tile configure register. Configure register is the user of all the amx instruction. Add X86PreTileConfig pass to insert psuedo ldtilecfg and build the data depenedcy b

[clang] 17c8251 - [OpenMP][CUDA][FIX] Use the new `remquo` overload only for OpenMP

Author: Johannes Doerfert Date: 2020-10-27T23:52:59-05:00 New Revision: 17c8251bca83072d2f3e00f936d6ce24500e6b02 URL: https://github.com/llvm/llvm-project/commit/17c8251bca83072d2f3e00f936d6ce24500e6b02 DIFF: https://github.com/llvm/llvm-project/commit/17c8251bca83072d2f3e00f936d6ce24500e6b02.d

[PATCH] D87981: [X86] AMX programming model prototype.

pengfei added inline comments. Comment at: clang/lib/Headers/amxintrin.h:69 +#undef __DEFAULT_FN_ATTRS + Better to use `__DEFAULT_FN_ATTRS_TILE`, `__DEFAULT_FN_ATTRS_INT8`, then you don't need to undef it in the middle. Comment at: clang/lib

<    1   2   3