[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

hokein added a comment. don't dig into details, first round of comments. I think the scope is a bit ambiguous, my reading is that it 1) removes old clang-rename API usage *and* 2) fixes some existing bugs. I would suggest just scoping it on 1). Comment at: clang-tools-extra/

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 304736. LuoYuanke added a comment. Fix clang-tidy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/clang/Basic/BuiltinsX86_64.def clang/lib/H

[PATCH] D88987: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88987/new/ https://reviews.llvm.org/D88987 ___ cfe-commits mailing list cfe

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

sdmitriev added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:4554 + + // Language rules define if it is legal to cast from one address space + // to another, and which address space we should use as a "common bader wrote: > Anastasia wrote:

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban created this revision. yrouban added reviewers: skatkov, kuhar, asbirlea, fedor.sergeev. Herald added subscribers: cfe-commits, wenlei, steven_wu, hiraditya. Herald added projects: clang, LLVM. yrouban requested review of this revision. Please see the reason for this redesign in the patch

[clang-tools-extra] 6484aa1 - [clangd] Simplify relations deserialization loop, NFC.

Author: Kadir Cetinkaya Date: 2020-11-12T10:33:39+01:00 New Revision: 6484aa1add41e6483b60ad281b663968c2b68180 URL: https://github.com/llvm/llvm-project/commit/6484aa1add41e6483b60ad281b663968c2b68180 DIFF: https://github.com/llvm/llvm-project/commit/6484aa1add41e6483b60ad281b663968c2b68180.dif

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, wenlei, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monore

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet added a comment. As a side note, I've tested with a clangd-indexer before https://github.com/llvm/llvm-project/commit/71064b02701dd65065dd412fb01afe81ff83f746 and we got the failure (malformed/truncated refs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke added inline comments. Comment at: llvm/test/CodeGen/X86/statepoint-fixup-invoke.mir:94 ; CHECK: ADJCALLSTACKDOWN64 0, 0, 0, implicit-def dead $rsp, implicit-def dead $eflags, implicit-def dead $ssp, implicit $rsp, implicit $ssp - ; CHECK: STATEPOINT 0, 0, 1, @

[PATCH] D91333: [clang][SveEmitter] Fix enum declarations. [NFCI]

fpetrogalli created this revision. fpetrogalli added reviewers: peterwaller-arm, paulwalker-arm, joechrisellis, efriedma. Herald added subscribers: cfe-commits, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. fpetrogalli requested review of this revision.

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304776. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. - Handle VarDecl - Handle FunctionTemplateDecl - Remove FieldDecl handling (leave for the future patches) - Simplify code - Prevent regressions by adding more tests Repository: r

[clang] b9d3654 - [dllexport] Avoid assert for explicitly defaulted methods in explicit instantiation definitions (PR47683)

Author: Hans Wennborg Date: 2020-11-12T13:19:29+01:00 New Revision: b9d36540a85b859ff1189c6c2c3acbc59033ae49 URL: https://github.com/llvm/llvm-project/commit/b9d36540a85b859ff1189c6c2c3acbc59033ae49 DIFF: https://github.com/llvm/llvm-project/commit/b9d36540a85b859ff1189c6c2c3acbc59033ae49.diff

[PATCH] D90849: [dllexport] Avoid multiple codegen assert for explicitly defaulted methods in explicit instantiation definitions (PR47683)

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9d36540a85b: [dllexport] Avoid assert for explicitly defaulted methods in explicit… (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90849/

[PATCH] D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811)

hans added a comment. >> I don't think it makes sense to try to emit the closure until we have the >> ctor definition. I'll update the patch to handle this. > > Ok. That's a bit different than what MSVC is doing. It generates a closure > constructor even if there is only a declaration. But I gue

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 304780. njames93 marked 4 inline comments as done. njames93 added a comment. Reworked large chunks of this: - Renamed ClangdTidyProvider->TidyProvider. - Removed the obselete interface mirroring ClangTidyOptionsProvider, it wasn't needed. - Incorporated the

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 added a comment. Thanks for the comments, I agree it was a little too much. Likely due in part to how I first tried to mirror the interface of ClangTidyOptionsProvider. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:250 if (Preamble && Preamble->StatCache) -

[clang] a088766 - [dllexport] Instantiate default ctor default args for explicit specializations (PR45811)

Author: Hans Wennborg Date: 2020-11-12T13:29:34+01:00 New Revision: a088766508aa1a5b6e655a239546f1a64e96eb11 URL: https://github.com/llvm/llvm-project/commit/a088766508aa1a5b6e655a239546f1a64e96eb11 DIFF: https://github.com/llvm/llvm-project/commit/a088766508aa1a5b6e655a239546f1a64e96eb11.diff

[PATCH] D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811)

This revision was automatically updated to reflect the committed changes. Closed by commit rGa088766508aa: [dllexport] Instantiate default ctor default args for explicit specializations… (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304783. kbobyrev added a comment. Add missing user-defined conversion test and a couple of missing cases with ctor/dtor out-of-line implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ http

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-redundant-branch-condition.cpp:1092 + // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: redundant condition 'isSet' [bugprone-redundant-branch-condition] + // CHECK-FIXES: {

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304784. kbobyrev added a comment. Add a test with static class member. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/refactor/Renam

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304785. kbobyrev added a comment. Remove (now) outdated comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/refactor/Rename.cpp

[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

njames93 added a reviewer: aaron.ballman. njames93 added a comment. Should this be a NamingStyle option instead. `{key: readability-identifier-naming.ParameterShortSizeThreshold, value: 2}` WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90282/n

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304787. kbobyrev added a comment. Completely remove new tests from this patch (to be provided in a different one). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 File

[PATCH] D91337: [clangd] Add missing tests to rename feature

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This adds a couple of missed tests f

[PATCH] D90750: [clangd] Introduce ProjectAwareIndex

kadircet updated this revision to Diff 304795. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90750/new/ https://reviews.llvm.org/D90750 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/

[PATCH] D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

joechrisellis updated this revision to Diff 304796. joechrisellis marked 2 inline comments as done. joechrisellis added a comment. Address @c-rhodes's comments. - Only allow casting between VLATs and VLSTs. - Add C test. - Move C++ test to the correct directory. - Remove superfluous test. Repos

[PATCH] D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

joechrisellis added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:-2227 +// Allow bitcasting if either the source or destination is a scalable +// vector. +if (SrcType->isSizelessBuiltinType() || DestType->isSizelessBuiltinType()) { + Kind = CK_Bi

[PATCH] D91311: Add new 'preferred_name' attribute.

aaron.ballman added a comment. I really like this attribute, thank you for working on this! Comment at: clang/include/clang/Basic/Attr.td:2367 +def PreferredName : InheritableAttr { + let Spellings = [Clang<"preferred_name">]; + let Subjects = SubjectList<[ClassTmpl]>; --

[clang] 79105e4 - [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry.

Author: Sylvain Audi Date: 2020-11-12T08:48:17-05:00 New Revision: 79105e464429d2220c81b38bf5339b9c41da1d21 URL: https://github.com/llvm/llvm-project/commit/79105e464429d2220c81b38bf5339b9c41da1d21 DIFF: https://github.com/llvm/llvm-project/commit/79105e464429d2220c81b38bf5339b9c41da1d21.diff

[PATCH] D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry

This revision was automatically updated to reflect the committed changes. Closed by commit rG79105e464429: [clang-scan-deps] Fix for input file given as relative path in compilation… (authored by saudi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D91341: [clangd][NFC] Don't store symbolmap on the heap

njames93 created this revision. njames93 added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. njames93 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Storing this on the heap doesn't mak

[PATCH] D91184: [clang-tidy] Merge options inplace instead of copying

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91184/new/ https://reviews.llvm.org/D91184 __

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

david-arm added a comment. Hi @SjoerdMeijer I think that given we now support scalable vectors we thought it made sense to be able to specify whether the user wants 'fixed' or 'scalable' vectorisation along with the vector width, although without specifying the additional property the default c

[PATCH] D91342: WIP: Frontend: Handle PreprocessorOptions::RemappedFiles in createVFSFromCompilerInvocation

dexonsmith created this revision. dexonsmith added reviewers: JDevlieghere, jansvoboda11, akyrtzi. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Instead of threading `PreprocessorOptions::RemappedFiles` through to the `SourceManager`, handle it in `createVFSFro

[PATCH] D91067: [AArch64][SVE] Support implicit lax vector conversions for SVE types

joechrisellis updated this revision to Diff 304811. joechrisellis marked an inline comment as done. joechrisellis added a comment. - Support C lax vector conversions. - Test C lax vector conversions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D910

[PATCH] D91300: WIP: Frontend: Use an InMemoryFileSystem for the RemappedFiles parameter in ASTUnit

dexonsmith added a comment. Note, I just discovered this patch changes behaviour in the ASTReader that was only indirectly tested previously via the file-to-file remapping command-line options. I've blocked this on https://reviews.llvm.org/D91342 for now, since that patch reimplements the file-

[PATCH] D90622: clang: Don't assert on no_unique_address fields in @encode()

thakis added inline comments. Comment at: clang/test/CodeGenObjCXX/encode.mm:91 - // CHECK: @_ZN11rdar93574002ggE = constant [49 x i8] c"{vector >=[4f]}\00" + // FIXME: This difference is due to D76801. It was probably an unintentional change. Maybe we want to undo it? + //

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

aaron.ballman added a comment. In D90042#2390203 , @flx wrote: > Thanks for the suggestion, I had never hear of creduce! Glad to have introduced you to it -- it's a great tool! > After a bit of trial an error I seem to have found a more minimal example:

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

SjoerdMeijer added a comment. In D89031#2391160 , @david-arm wrote: > Hi @SjoerdMeijer I think that given we now support scalable vectors we > thought it made sense to be able to specify whether the user wants 'fixed' or > 'scalable' vectorisation along

[PATCH] D91348: [OpenCL] Warn about side effects for unevaluated vec_step arg

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added a subscriber: yaxunl. Herald added a project: clang. svenvh requested review of this revision. The argument to the `vec_step` builtin is not evaluated. Hoist the diagnostic for this in `Sema::CheckUnaryExprOrTypeTraitO

[PATCH] D91350: [VE] Disable -fsigaddr option for VE

kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: clang, VE. Herald added a subscriber: cfe-commits. kaz7 requested review of this revision. VE needs to support integrated assembler and "nas". This "nas" doesn't recognize ".sigaddr" pseudo mnemonics, so ne

[PATCH] D91351: [tooling] Implement determinsitic ordering of CompilationDatabasePlugins

njames93 created this revision. njames93 added reviewers: klimek, nridge. Herald added subscribers: cfe-commits, usaxena95, kadircet, mgrang. Herald added a project: clang. njames93 requested review of this revision. Herald added a subscriber: ilya-biryukov. Right now plugins appear to be registed

[clang] 62ed69b - [clang][docs] Remove wrongly spaced \brief in Doxygen comment (NFC)

Author: Jean-Michel Gorius Date: 2020-11-12T15:44:43+01:00 New Revision: 62ed69b01d38044a6d7b90b18c2271e2d71a9bcd URL: https://github.com/llvm/llvm-project/commit/62ed69b01d38044a6d7b90b18c2271e2d71a9bcd DIFF: https://github.com/llvm/llvm-project/commit/62ed69b01d38044a6d7b90b18c2271e2d71a9bcd.

[PATCH] D91200: [PowerPC] Prevent the use of MMA with P9 and earlier

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. Overall LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91200/new/ https://reviews.llvm.org/D91200 ___

[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

aaron.ballman added a comment. In D90282#2391005 , @njames93 wrote: > Should this be a NamingStyle option instead. > `{key: readability-identifier-naming.ParameterShortSizeThreshold, value: 2}` > WDYT? I think that makes a lot of sense -- I can imagine wa

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

flx updated this revision to Diff 304831. flx added a comment. Fixed definition of fake std::function which now makes the bug fixed by this change reproducible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90042/new/ https://reviews.llvm.org/D900

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

flx updated this revision to Diff 304833. flx added a comment. Remove unnecessary test code that is not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90042/new/ https://reviews.llvm.org/D90042 Files: clang-tools-extra/clang-tidy/utils/De

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

flx added a comment. In D90042#2391246 , @aaron.ballman wrote: > In D90042#2390203 , @flx wrote: > >> Thanks for the suggestion, I had never hear of creduce! > > Glad to have introduced you to it -- it's a great to

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

flx updated this revision to Diff 304834. flx added a comment. Updated change description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90042/new/ https://reviews.llvm.org/D90042 Files: clang-tools-extra/clang-tidy/utils/DeclRefExprUtils.cpp

[PATCH] D91333: [clang][SveEmitter] Fix enum declarations. [NFCI]

joechrisellis added a comment. Thanks for the patch @fpetrogalli! One small comment from me, but not a blocker for me, so approved. Comment at: clang/test/Sema/aarch64-sve-enums.c:14-15 +#include +enum svpattern a1 = SV_ALL; +svpattern b1 = {1.0f}; +enum svprfop a2 = SV_PLDL1

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

Xiangling_L created this revision. Xiangling_L added reviewers: daltenty, hubert.reinterpretcast, stevewan, xingxue. Herald added a project: clang. Herald added a subscriber: cfe-commits. Xiangling_L requested review of this revision. In order to support __attribute__((__constructor__)) and __at

[PATCH] D91200: [PowerPC] Prevent the use of MMA with P9 and earlier

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG170e45ae186b: [PowerPC] Prevent the use of MMA with P9 and earlier (authored by bsaleil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 170e45a - [PowerPC] Prevent the use of MMA with P9 and earlier

Author: Baptiste Saleil Date: 2020-11-12T10:36:50-06:00 New Revision: 170e45ae186b3eed16898db933c94a85ac623933 URL: https://github.com/llvm/llvm-project/commit/170e45ae186b3eed16898db933c94a85ac623933 DIFF: https://github.com/llvm/llvm-project/commit/170e45ae186b3eed16898db933c94a85ac623933.dif

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

zinovy.nis added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-redundant-branch-condition.cpp:1092 + // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: redundant condition 'isSet' [bugprone-redundant-branch-condition] + // CHECK-FIXES: {{is

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-redundant-branch-condition.cpp:1092 + // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: redundant condition 'isSet' [bugprone-redundant-branch-condition] + // CHECK-FIXES: {

[clang] ac523d2 - [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point

Author: Kevin P. Neal Date: 2020-11-12T12:51:35-05:00 New Revision: ac523d2de51c4119ae6233200af07599d61de1fc URL: https://github.com/llvm/llvm-project/commit/ac523d2de51c4119ae6233200af07599d61de1fc DIFF: https://github.com/llvm/llvm-project/commit/ac523d2de51c4119ae6233200af07599d61de1fc.diff

[PATCH] D88987: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point

This revision was automatically updated to reflect the committed changes. Closed by commit rGac523d2de51c: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict… (authored by kpn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8898

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

zinovy.nis marked an inline comment as done. zinovy.nis added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-redundant-branch-condition.cpp:1092 + // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: redundant condition 'isSet' [bugprone-redundant-

[clang] b336826 - Non-implicit attribute creation requires a source range; NFC

Author: Aaron Ballman Date: 2020-11-12T10:06:30-08:00 New Revision: b336826c1dd92adabef682f9b013b2e36bce066c URL: https://github.com/llvm/llvm-project/commit/b336826c1dd92adabef682f9b013b2e36bce066c DIFF: https://github.com/llvm/llvm-project/commit/b336826c1dd92adabef682f9b013b2e36bce066c.diff

[PATCH] D91366: Serialization: Hoist the check for in-flight diagnostics in ASTReader::getInputFile, NFC

dexonsmith created this revision. dexonsmith added a reviewer: jansvoboda11. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. This logic seems easier to follow without the `Error()` helper, and checking `DiagnosticsEngine::isDiagnosticInFlight` just once up front.

[PATCH] D91367: Serialization: Merge three diagnostics to simplify ASTReader::getInputFile, NFC

dexonsmith created this revision. dexonsmith added a reviewer: jansvoboda11. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Clean up the logic for `err_fe_{pch,module,ast}_file_modified` to use a `select` like other ASTReader diagnostics. There should be no func

[PATCH] D91184: [clang-tidy] Merge options inplace instead of copying

This revision was automatically updated to reflect the committed changes. Closed by commit rG06db8f984f1a: [clang-tidy] Merge options inplace instead of copying (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D91184?vs=304237&id=304892#toc Repository: rG LLVM Github

[clang-tools-extra] 06db8f9 - [clang-tidy] Merge options inplace instead of copying

Author: Nathan James Date: 2020-11-12T18:19:12Z New Revision: 06db8f984f1a31e299af7d9ea584061d244caad6 URL: https://github.com/llvm/llvm-project/commit/06db8f984f1a31e299af7d9ea584061d244caad6 DIFF: https://github.com/llvm/llvm-project/commit/06db8f984f1a31e299af7d9ea584061d244caad6.diff LOG:

[PATCH] D91368: Frontend: Split out addVFSOverlays from createVFSFromCompilerInvocation, NFC

dexonsmith created this revision. dexonsmith added reviewers: JDevlieghere, jansvoboda11, akyrtzi. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. This is a prep patch to reduce noise in a follow-up, which will add another layer. https://reviews.llvm.org/D91368

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304893. kbobyrev added a comment. Remove unused header (was added for llvm_unreachable). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/cla

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L updated this revision to Diff 304896. Xiangling_L added a comment. Fix minor issues in the testcase; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https://reviews.llvm.org/D90892 Files: clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CodeGenFunction.h cla

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-redundant-branch-condition.cpp:1092 + // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: re

[PATCH] D90870: [NFC][NewPM] Reuse PassBuilder callbacks with -O0

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. This is NFC and looks like a nice cleaup. So LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90870/new/ https://reviews.llvm.org/D90870 _

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Need to check if there are map types for the components before trying to ac

[PATCH] D90622: clang: Don't assert on no_unique_address fields in @encode()

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90622/new/ https://reviews.llvm.org/D90622 ___ cfe-commits mailing list cfe-commits

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

Anastasia added a comment. In D89869#2388499 , @azabaznov wrote: > Addressed all concerns except replacing //__opencl_c_int64 //definition into > header. The reason for this as follows: this macro should be predefined > regardless if clang includes defau

[PATCH] D89980: [hip] Remove the coercion on aggregate kernel arguments.

arsenm added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:55 struct S { int *x; Should also have a case with a single element struct, which will be treated like a scalar Repository: rG LLVM Github Monorepo CHAN

[PATCH] D91372: Some updates/fixes to the creduce script.

akhuang created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. This was motivated by changes to llvm's `not --crash` disabling symbolization but I ended up removing `not` from the script entirely because it returns d

[PATCH] D91034: [Frontend] Treat CUDA header files as CUDA source files

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7c7a1982632: [Frontend] Treat .cuh files as CUDA source files (authored by tomilov, committed by MaskRay). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D910

[clang] e7c7a19 - [Frontend] Treat .cuh files as CUDA source files

Author: Anatoliy Tomilov Date: 2020-11-12T11:42:53-08:00 New Revision: e7c7a1982632270ae655c7ec8e490ca2c44193a0 URL: https://github.com/llvm/llvm-project/commit/e7c7a1982632270ae655c7ec8e490ca2c44193a0 DIFF: https://github.com/llvm/llvm-project/commit/e7c7a1982632270ae655c7ec8e490ca2c44193a0.di

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 added a comment. This stops it from crashing Clang, but I'm not sure if it's fixing the underlying problem. When I compile and run this program it crashes in libomptarget. If you get rid of the `float f[50]` in the struct it works as expected. `$ clang++ -fopenmp -fopenmp-targets=nvptx

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

ABataev added a comment. In D91370#2392107 , @jhuber6 wrote: > This stops it from crashing Clang, but I'm not sure if it's fixing the > underlying problem. When I compile and run this program it crashes in > libomptarget. If you get rid of the `float f[5

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

jacobdweightman created this revision. jacobdweightman added a reviewer: ABataev. jacobdweightman added a project: OpenMP. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. jacobdweightman requested review of this revision. Herald added a reviewer: jdoerfert. H

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

nikic added a comment. In D87188#2385619 , @spatel wrote: > D90554 / f7eac51b9b > > I think that change makes this patch ready to try again. If we do s

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM then. Any clue what the cause of the other problem is? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91370/new/ https://reviews.llvm.org

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

ABataev added a comment. In D91370#2392171 , @jhuber6 wrote: > LGTM then. > > Any clue what the cause of the other problem is? Will investigate it and prepare a new patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D91376: [OPENMP]Fix PR47790: segfault in frontend while parsing Objective-C with OpenMP.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Need to check if the sema is actually finishing a function decl. Reposito

[clang] 3c6b457 - [OPENMP]Fix PR48076: Check map types array before accessing its front.

Author: Alexey Bataev Date: 2020-11-12T12:00:29-08:00 New Revision: 3c6b457bee0c66294637d50bca1cff7231647249 URL: https://github.com/llvm/llvm-project/commit/3c6b457bee0c66294637d50bca1cff7231647249 DIFF: https://github.com/llvm/llvm-project/commit/3c6b457bee0c66294637d50bca1cff7231647249.diff

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c6b457bee0c: [OPENMP]Fix PR48076: Check map types array before accessing its front. (authored by ABataev). Repository: rG LLVM Github Monorepo C

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

ABataev added a comment. In D91370#2392171 , @jhuber6 wrote: > LGTM then. > > Any clue what the cause of the other problem is? Could you try your test with the patch from https://reviews.llvm.org/D86119? Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D91376: [OPENMP]Fix PR47790: segfault in frontend while parsing Objective-C with OpenMP.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91376/new/ https://reviews.llvm.org/D91376 ___

[PATCH] D91380: [clang] Fix an assertion crash in delayed access check.

hokein created this revision. hokein added a reviewer: adamcz. Herald added a project: clang. hokein requested review of this revision. TD-getTemplatedDecl() might not be a DeclContext variant, which can trigger an assertion inside `isa<>`. Repository: rG LLVM Github Monorepo https://reviews.

[PATCH] D90870: [NFC][NewPM] Reuse PassBuilder callbacks with -O0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a7b57b7cad3: [NFC][NewPM] Reuse PassBuilder callbacks with -O0 (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] 3a7b57b - [NFC][NewPM] Reuse PassBuilder callbacks with -O0

Author: Arthur Eubanks Date: 2020-11-12T12:42:59-08:00 New Revision: 3a7b57b7cad32a4b59700e029d80a06c35f0a1a3 URL: https://github.com/llvm/llvm-project/commit/3a7b57b7cad32a4b59700e029d80a06c35f0a1a3 DIFF: https://github.com/llvm/llvm-project/commit/3a7b57b7cad32a4b59700e029d80a06c35f0a1a3.diff

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 304940. njames93 added a comment. - Small tweaks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://reviews.llvm.org/D91029 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/c

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 added a comment. In D91370#2392267 , @ABataev wrote: > In D91370#2392171 , @jhuber6 wrote: > >> LGTM then. >> >> Any clue what the cause of the other problem is? > > Could you try your test with the patch fr

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

ABataev added a comment. In D91370#2392310 , @jhuber6 wrote: > In D91370#2392267 , @ABataev wrote: > >> In D91370#2392171 , @jhuber6 wrote: >> >>> LGTM then. >>> >>> Any clue

[PATCH] D91333: [clang][SveEmitter] Fix enum declarations. [NFCI]

fpetrogalli updated this revision to Diff 304941. fpetrogalli added a comment. Improve comment in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91333/new/ https://reviews.llvm.org/D91333 Files: clang/test/Sema/aarch64-sve-enums.c clang/u

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 added a comment. In D91370#2392313 , @ABataev wrote: > In D91370#2392310 , @jhuber6 wrote: > >> In D91370#2392267 , @ABataev wrote: >> >>> In D91370#2392171

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

ABataev added a comment. In D91370#2392317 , @jhuber6 wrote: > In D91370#2392313 , @ABataev wrote: > >> In D91370#2392310 , @jhuber6 wrote: >> >>> In D91370#2392267

[PATCH] D91337: [clangd] Add missing tests to rename feature

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:203 }; +struct D : B { + void [[f^oo]]() override {} hmm, I'm not sure this is needed, I think it is identical with `C`. Comm

[PATCH] D91372: Some updates/fixes to the creduce script.

george.burgess.iv accepted this revision. george.burgess.iv added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang/utils/creduce-clang-crash.py:156 + def skip_function(func_name): +for name in filters: + if name in func

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 added a comment. In D91370#2392319 , @ABataev wrote: > From libomptarget. It must be different. Could you copy it here? Yeah, I think there's some extra information looking at it again. Target CUDA RTL --> Start initializing CUDA Libomptarget

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:137 -if (D.CCCIsCXX()) +if (D.CCCIsCXX() || D.CCCIsCC()) CmdArgs.push_back(Args.MakeArgString( I think that rather that adding CC, we should just pull the if and unc

  1   2   >