[PATCH] D94503: [clangd] Explicitly avoid background-indexing the same file twice.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thank, as discussed offline this looks like the right thing to do before the branch cut. we might re-evaluate our decision around re-indexing on cmd changes and canonicalization one day ..

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

saiislam added a comment. In D93525#2493752 , @t-tye wrote: > In D93525#2493024 , @yaxunl wrote: > >> can you document this in ClangOffloadBundler.rst ? I think we need a clear >> description about how clang-offloa

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938 ___ cfe-commits mailing list cfe-commi

[clang] cbea673 - [clang][driver] Restore the original help text for `-I`

Author: Andrzej Warzynski Date: 2021-01-13T09:19:50Z New Revision: cbea6737d5130724c7c8cf8ee4ccf1c3dd099450 URL: https://github.com/llvm/llvm-project/commit/cbea6737d5130724c7c8cf8ee4ccf1c3dd099450 DIFF: https://github.com/llvm/llvm-project/commit/cbea6737d5130724c7c8cf8ee4ccf1c3dd099450.diff

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

This revision was automatically updated to reflect the committed changes. Closed by commit rGcbea6737d513: [clang][driver] Restore the original help text for `-I` (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D94169?vs=316074&id=316342#toc Repository: rG LLVM Gi

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

awarzynski added a comment. I have now merged this into `main`. I updated the commit message based on the discussion here, but kept the original **SUMMARY** above (just in case people are confused by the inconsistency). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

steakhal added a comment. In D93224#2493710 , @steakhal wrote: > In D93224#2493515 , @xazax.hun wrote: > >> Could you validate that this solution works for the latter [ctu-on-demand]? > > Sure, I suspect that will h

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

miyuki added a comment. In D94237#2493844 , @dblaikie wrote: > Do you need to run the destructor before placement new in these situations? No, because there is no active union member in any of those situations. And if even if there was an active member,

[PATCH] D94554: [clangd][WIP] Add a Filesystem that overlays Dirty files.

njames93 updated this revision to Diff 316357. njames93 added a comment. Remove some unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94554/new/ https://reviews.llvm.org/D94554 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D93101: [Clang][Codegen] Truncate initializers of union bitfield members

joechrisellis added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9803-9804 + (Field->isBitField() && +truncateBitfieldValue(Info, InitExpr, Result.getUnionValue(), + Field)); } nit: I would

[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

xazax.hun added a comment. In D93224#2495404 , @steakhal wrote: > Do we really promise ABI compatibility for AST dumps? If we support it to > some extent, then we would have a problem - which would mean that we can not > target clang-12 anymore with this

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

MyDeveloperDay added a comment. I think I would remove the code examples from the "AlignConsecutive style" to avoid confusion (that would be the first change) then perhaps regenerate and update the documentation so we can then see, its seems most have a "code block", can the specific examples n

[PATCH] D94596: [clang][AST] Encapsulate DeclarationNameLoc, NFCI

miyuki created this revision. miyuki added reviewers: aprantl, dexonsmith, rsmith, faisalv. Herald added a subscriber: arphaman. miyuki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change makes `DeclarationNameLoc` a proper class an

[PATCH] D69903: [Basic] Introduce PODSourceLocation, NFCI

miyuki abandoned this revision. miyuki added a comment. Abandoning in favor of D94237 and D94596 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69903/new/ https://reviews.llvm.org/D69903 __

[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj added a comment. This fixes https://bugs.llvm.org/show_bug.cgi?id=48569, amongst other things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://reviews.llvm.org/D94500 ___ cfe-comm

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

usaxena95 updated this revision to Diff 316379. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94424/new/ https://reviews.llvm.org/D94424 Files: clang-tool

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp:720 + #include "foo.h" + namespace ns1 { + namespace ns2 { adamcz wrote: > Can you add anonymous namespaces as well? Good point. Avoided capturing anonymous na

[clang] 7c77b53 - [OpenCL] Improve OpenCL operator tests

Author: Sven van Haastregt Date: 2021-01-13T14:50:49Z New Revision: 7c77b536efdd953d6d97bffbd9ca320c517b26d7 URL: https://github.com/llvm/llvm-project/commit/7c77b536efdd953d6d97bffbd9ca320c517b26d7 DIFF: https://github.com/llvm/llvm-project/commit/7c77b536efdd953d6d97bffbd9ca320c517b26d7.diff

[PATCH] D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

miyuki created this revision. miyuki added reviewers: aprantl, dexonsmith, arphaman. miyuki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The class `SymbolOccurrences` can store either a single `SourceRange` in-place or multiple `SourceRa

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. Ping @njames93 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ https://reviews.llvm.org/D86671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang-tools-extra] 90164ba - [clangd] Split out a base class for delegating GlobalCompilationDatabases. NFC

Author: Sam McCall Date: 2021-01-13T16:20:33+01:00 New Revision: 90164ba957a2532daef6515d7114af69eca025a7 URL: https://github.com/llvm/llvm-project/commit/90164ba957a2532daef6515d7114af69eca025a7 DIFF: https://github.com/llvm/llvm-project/commit/90164ba957a2532daef6515d7114af69eca025a7.diff LO

[PATCH] D94601: [clang-tidy] Use DenseSet in UpgradeDurationConversionsCheck, NFCI

miyuki created this revision. miyuki added reviewers: aprantl, dexonsmith, EricWF. Herald added a subscriber: xazax.hun. miyuki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change replaces `unordered_set` (which used to store intern

[PATCH] D94603: [clangd] Allow CDBs to have background work to block on.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. In preparation for moving DirectoryBasedC

[clang] f0abe2a - [Frontend] Add pragma align natural and sort out pragma pack stack effect

Author: Xiangling Liao Date: 2021-01-13T10:53:24-05:00 New Revision: f0abe2aeaca76a24b1e17295ab797068c057a15d URL: https://github.com/llvm/llvm-project/commit/f0abe2aeaca76a24b1e17295ab797068c057a15d DIFF: https://github.com/llvm/llvm-project/commit/f0abe2aeaca76a24b1e17295ab797068c057a15d.diff

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

This revision was automatically updated to reflect the committed changes. Xiangling_L marked 8 inline comments as done. Closed by commit rGf0abe2aeaca7: [Frontend] Add pragma align natural and sort out pragma pack stack effect (authored by Xiangling_L). Changed prior to commit: https://reviews.

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai added a comment. @liaolucy RISC-V vector types are sizeless types. Sizeless is kind of characteristic for builtin types. If we use attribute to declare RISC-V vector types, the frontend does not know anything about it. I still think to define RISC-V vector types as builtin types is a

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

t-tye added a comment. In D93525#2495374 , @saiislam wrote: > In D93525#2493752 , @t-tye wrote: > >> In D93525#2493024 , @yaxunl wrote: >> >>> can you document this in ClangO

[PATCH] D94606: [clangd] Move DirBasedCDB broadcasting onto its own thread.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, jfb, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This is on the critical path (it blo

[clang-tools-extra] 66d5994 - [clangd] Explicitly avoid background-indexing the same file twice.

Author: Sam McCall Date: 2021-01-13T17:29:30+01:00 New Revision: 66d5994bd38a9be4a0c05de2b69f88b64e6845ce URL: https://github.com/llvm/llvm-project/commit/66d5994bd38a9be4a0c05de2b69f88b64e6845ce DIFF: https://github.com/llvm/llvm-project/commit/66d5994bd38a9be4a0c05de2b69f88b64e6845ce.diff LO

[PATCH] D94503: [clangd] Explicitly avoid background-indexing the same file twice.

This revision was automatically updated to reflect the committed changes. sammccall marked 5 inline comments as done. Closed by commit rG66d5994bd38a: [clangd] Explicitly avoid background-indexing the same file twice. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D9

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

miyuki updated this revision to Diff 316414. miyuki added a comment. Refactored `SLocEntry` in a similar way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94237/new/ https://reviews.llvm.org/D94237 Files: clang/include/clang/AST/DependentDiagno

[clang-tools-extra] 466acd6 - [clangd] Avoid reallocating buffers for each message read:

Author: Sam McCall Date: 2021-01-13T17:40:33+01:00 New Revision: 466acd694861138997d668a3f9cb29aa87bd316e URL: https://github.com/llvm/llvm-project/commit/466acd694861138997d668a3f9cb29aa87bd316e DIFF: https://github.com/llvm/llvm-project/commit/466acd694861138997d668a3f9cb29aa87bd316e.diff LO

[PATCH] D93653: [clangd] Avoid reallocating buffers for each message read:

This revision was automatically updated to reflect the committed changes. Closed by commit rG466acd694861: [clangd] Avoid reallocating buffers for each message read: (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D93653?vs=313159&id=316416#toc Repository: rG LLVM

[clang-tools-extra] a4f3866 - [clangd] Remove "decision-forest-base" experimental flag.

Author: Utkarsh Saxena Date: 2021-01-13T17:54:38+01:00 New Revision: a4f386688239b06e09f28fd31f93bf761aa9c76f URL: https://github.com/llvm/llvm-project/commit/a4f386688239b06e09f28fd31f93bf761aa9c76f DIFF: https://github.com/llvm/llvm-project/commit/a4f386688239b06e09f28fd31f93bf761aa9c76f.diff

[PATCH] D94513: [clangd] Remove "decision-forest-base" experimental flag.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4f386688239: [clangd] Remove "decision-forest-base" experimental flag. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94513/new/ ht

[clang-tools-extra] 0bbc6a6 - [clangd] Remove some old CodeCompletion options that are never (un)set. NFC

Author: Sam McCall Date: 2021-01-13T18:01:48+01:00 New Revision: 0bbc6a6bb643af69baaf85f7f380dbcfe1f5ad54 URL: https://github.com/llvm/llvm-project/commit/0bbc6a6bb643af69baaf85f7f380dbcfe1f5ad54 DIFF: https://github.com/llvm/llvm-project/commit/0bbc6a6bb643af69baaf85f7f380dbcfe1f5ad54.diff LO

[PATCH] D93453: [flang][driver] Add support for `-I`

FarisRehman updated this revision to Diff 316423. FarisRehman added a comment. Add a new test Update the regression test to check the behaviour of multiple `-I`'s specified. Summary of changes: - Update regression test with new checks - Fix regression tests that broke when patch D93712

[PATCH] D93453: [flang][driver] Add support for `-I`

tskeith added inline comments. Comment at: flang/test/Flang-Driver/include-header.f90:59 +#endif +end `-I` also is supposed to affect INCLUDE lines so it would be good to have a test for that too. They are handled during preprocessing and so can be tested the s

[PATCH] D94614: [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins

kpn created this revision. kpn added reviewers: craig.topper, andrew.w.kaylor. kpn added a project: clang. Herald added a subscriber: pengfei. kpn requested review of this revision. Herald added a subscriber: cfe-commits. Currently clang is not correctly retrieving from the AST the metadata for c

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

thezbyg updated this revision to Diff 316446. thezbyg added a comment. Rebased changes on master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93846/new/ https://reviews.llvm.org/D93846 Files: clang/docs/ClangFormatStyleOptions.rst clang/incl

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added a comment. In D89909#2448443 , @Anastasia wrote: > If you prefer to continue this route then you should just document your > dialect sematic somewhere publicly accessible and avoid aliasing to OpenCL, > or target address spaces. So it would b

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 316447. bader added a comment. Re-base patch and fix lit test failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 Files: clang/include/clang/AST/Type.h clang/in

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:235 +IO.enumCase(Value, "Never", FormatStyle::ELBAMS_Never); +IO.enumCase(Value, "DontModify", FormatStyle::ELBAMS_DontModify); +IO.enumCase(Value, "LogicalBlock", FormatStyle::ELBAMS_Logica

[PATCH] D93101: [Clang][Codegen] Truncate initializers of union bitfield members

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9801-9804 +return EvaluateInPlace(Result.getUnionValue(), Info, Subobject, InitExpr) || + (Field->isBitField() && +truncateBitfieldValue(Info, InitExpr, Result.getUnionValue(), +

[PATCH] D94617: [RISCV] Add Zba feature and move add.uw and slli.uw to it.

craig.topper created this revision. craig.topper added reviewers: asb, lenary, frasercrmck, luismarques, kito-cheng. Herald added subscribers: NickHung, evandro, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D94337: Add cuda header type for cuh files

tra added a comment. In D94337#2492108 , @rgreenblatt wrote: > In D94337#2491825 , @tra wrote: > >> 'Works' is not exactly the same as 'works correctly'. This example makes >> `a()` look like a regular host functio

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. I'm sorry that it's taking a while to find time to review the implementation; I'll try to get to it this week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344

[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:13707 WhitesmithsBraceStyle); verifyFormat("enum X\n" any reason why this is being removed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D94621: docs

segoon created this revision. segoon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94621 Files: clang-tools-extra/docs/clang-tidy/checks/concurrency-async-fs.rst Index:

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon updated this revision to Diff 316460. segoon retitled this revision from "docs" to "[clang-tidy] add concurrency-async-fs". segoon edited the summary of this revision. segoon added a comment. Herald added subscribers: ormris, xazax.hun, mgorny. fix CHANGES SINCE LAST ACTION https://rev

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query

tomrittervg created this revision. tomrittervg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. My first attempt was to figure out how to plumb the --use-color command line argument to the DiagnosticEngine that gets referenced in AST->getDia

[PATCH] D93585: [AArch64] Enable out-of-line atomics by default.

ilinpv updated this revision to Diff 316471. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93585/new/ https://reviews.llvm.org/D93585 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/ToolChai

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit P10 instructions from stubs

Conanap created this revision. Conanap added reviewers: stefanp, nemanjai, PowerPC. Conanap added projects: LLVM, clang, PowerPC. Herald added subscribers: dang, kbarton, arichardson, emaste. Herald added a reviewer: espindola. Herald added a reviewer: MaskRay. Conanap requested review of this revi

[PATCH] D93585: [AArch64] Enable out-of-line atomics by default.

ilinpv marked 2 inline comments as done. ilinpv added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:1087 FeatureNEON, + FeatureOutlineAtomics, FeaturePerfMon, t.p.northover wrote: >

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

HazardyKnusperkeks added a comment. Apart from that last naming issue looks good to me. Comment at: clang/lib/Format/Format.cpp:235 +IO.enumCase(Value, "Never", FormatStyle::ELBAMS_Never); +IO.enumCase(Value, "DontModify", FormatStyle::ELBAMS_DontModify); +IO.enumCa

[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnalyzer.cpp:71 Env.getFirstStartColumn(), Style, Encoding, Allocator, - IdentTable); Unrelated change (although I think it's good one).

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

thakis added a comment. Do we emit a warning if we see `-gsplit-dwarf` alone? Should we? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80391/new/ https://reviews.llvm.org/D80391 ___ cfe-commits mailing l

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

thakis added inline comments. Comment at: clang/docs/ReleaseNotes.rst:120 `nonnull` attribute on `this` for configurations that need it to be nullable. +- ``-gsplit-dwarf`` no longer implies ``-g2``. This apparently bit us (chromium) in thinlto configs. Coul

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

sammccall added a comment. Thanks, this looks pretty solid! I want to be pretty careful about APIs/naming/code organization here (even moreso than usual!) because TUScheduler is a big complex beast as it is, and it's easy to get lost. Comment at: clang-tools-extra/clangd/TUS

[PATCH] D94337: Add cuda header type for cuh files

rgreenblatt added a comment. In D94337#2496329 , @tra wrote: > We were talking about the case where clang can't expand CUDA-specific macros. Somehow I totally forgot about or missed this context. > I think this kind of compilation pipeline restructuring

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94237/new/ https://reviews.llvm.org/D94237 __

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

MaskRay added a comment. In D80391#2496583 , @thakis wrote: > Do we emit a warning if we see `-gsplit-dwarf` alone? Should we? `{gcc,clang} -gcolumn-info -c a.c` does not warn about unused -gcolumn-info. Not having a warning makes such toggle flags more

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

dblaikie added inline comments. Comment at: clang/docs/ReleaseNotes.rst:120 `nonnull` attribute on `this` for configurations that need it to be nullable. +- ``-gsplit-dwarf`` no longer implies ``-g2``. thakis wrote: > This apparently bit us (chromium) in thi

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:120 `nonnull` attribute on `this` for configurations that need it to be nullable. +- ``-gsplit-dwarf`` no longer implies ``-g2``. dblaikie wrote: > thakis wrote: > > This apparently bit u

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

dblaikie added inline comments. Comment at: clang/docs/ReleaseNotes.rst:120 `nonnull` attribute on `this` for configurations that need it to be nullable. +- ``-gsplit-dwarf`` no longer implies ``-g2``. MaskRay wrote: > dblaikie wrote: > > thakis wrote: > > >

[PATCH] D94337: Add cuda header type for cuh files

tra added a comment. In D94337#2496627 , @rgreenblatt wrote: >> `...` The goal of `__clang_cuda_standalone_defs.h` is to make it possible to >> parse CUDA sources at all w/o having to rely on CUDA SDK. `...` > > Should `__clang_cuda_standalone_defs.h` dep

[clang-tools-extra] fb98a1b - Fix the warnings on unused variables (NFC)

Author: Kazu Hirata Date: 2021-01-13T13:32:40-08:00 New Revision: fb98a1be43645c87fff089c4cc9555ca2400268c URL: https://github.com/llvm/llvm-project/commit/fb98a1be43645c87fff089c4cc9555ca2400268c DIFF: https://github.com/llvm/llvm-project/commit/fb98a1be43645c87fff089c4cc9555ca2400268c.diff L

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

thezbyg updated this revision to Diff 316511. thezbyg added a comment. Renamed DontModify enum to Leave. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93846/new/ https://reviews.llvm.org/D93846 Files: clang/docs/ClangFormatStyleOptions.rst cla

[PATCH] D94381: [test] Add Clang side tests for -fdebug-info-for-profiling

MaskRay added a comment. Verified with @wmi offline this is good. Committing... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94381/new/ https://reviews.llvm.org/D94381 ___ cfe-commits mailing list cfe-c

[clang] 74a42ae - [test] Add Clang side tests for -fdebug-info-for-profiling

Author: Fangrui Song Date: 2021-01-13T14:27:39-08:00 New Revision: 74a42aedfe14938e01d128456c76cede2ccbc26c URL: https://github.com/llvm/llvm-project/commit/74a42aedfe14938e01d128456c76cede2ccbc26c DIFF: https://github.com/llvm/llvm-project/commit/74a42aedfe14938e01d128456c76cede2ccbc26c.diff

[PATCH] D94381: [test] Add Clang side tests for -fdebug-info-for-profiling

This revision was automatically updated to reflect the committed changes. Closed by commit rG74a42aedfe14: [test] Add Clang side tests for -fdebug-info-for-profiling (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94381/new/ htt

[PATCH] D94639: [DebugInfo][CodeView] Change in line tables only mode to emit type information for function scopes, rather than using the qualified name.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. Herald added a subscriber: hiraditya. akhuang requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In line-tables-only mode, we used to emit qualified funct

[PATCH] D94639: [DebugInfo][CodeView] Change in line tables only mode to emit type information for function scopes, rather than using the qualified name.

dblaikie added a comment. What parts of this are motivated by CodeView requirements (do functions have to have unique names in CV?)? It'd be a bit unfortunate if we have divergence in -gmlt behavior between DWARF and CodeView due to different usage requirements, rather than format requirements

[PATCH] D94639: [DebugInfo][CodeView] Change in line tables only mode to emit type information for function scopes, rather than using the qualified name.

akhuang added a comment. In D94639#2496892 , @dblaikie wrote: > What parts of this are motivated by CodeView requirements (do functions have > to have unique names in CV?)? > It'd be a bit unfortunate if we have divergence in -gmlt behavior between > DWA

[PATCH] D94639: [DebugInfo][CodeView] Change in line tables only mode to emit type information for function scopes, rather than using the qualified name.

dblaikie added a comment. In D94639#2496923 , @akhuang wrote: > In D94639#2496892 , @dblaikie wrote: > >> What parts of this are motivated by CodeView requirements (do functions have >> to have unique names in CV?)

[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj added inline comments. Comment at: clang/lib/Format/TokenAnalyzer.cpp:71 Env.getFirstStartColumn(), Style, Encoding, Allocator, - IdentTable); HazardyKnusperkeks wrote: > Unrelated change (although I think it

[libunwind] c82deed - [libunwind] Unwind through aarch64/Linux sigreturn frame

Author: Ryan Prichard Date: 2021-01-13T16:38:36-08:00 New Revision: c82deed6764cbc63966374baf9721331901ca958 URL: https://github.com/llvm/llvm-project/commit/c82deed6764cbc63966374baf9721331901ca958 DIFF: https://github.com/llvm/llvm-project/commit/c82deed6764cbc63966374baf9721331901ca958.diff

[PATCH] D94639: [DebugInfo][CodeView] Change in line tables only mode to emit type information for function scopes, rather than using the qualified name.

akhuang added a comment. In D94639#2496950 , @dblaikie wrote: > In D94639#2496923 , @akhuang wrote: > >> In D94639#2496892 , @dblaikie wrote: >> >>> What parts of this are mo

[clang] cd4c55c - Fix grammar in diagnostic for wrong arity in a structured binding.

Author: Richard Smith Date: 2021-01-13T17:41:09-08:00 New Revision: cd4c55c97402246099ae865a66517a36af5c3a7c URL: https://github.com/llvm/llvm-project/commit/cd4c55c97402246099ae865a66517a36af5c3a7c DIFF: https://github.com/llvm/llvm-project/commit/cd4c55c97402246099ae865a66517a36af5c3a7c.diff

[PATCH] D94639: [DebugInfo][CodeView] Change in line tables only mode to emit parent/context scopes for functions, using declarations for types

rnk added a comment. In D94639#2496969 , @akhuang wrote: > In D94639#2496950 , @dblaikie wrote: > >> How does any of this deal with overloading? I guess for either solution >> (qualified name or real scopes) you ha

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

inglorion added a comment. For Chrome on Chrome OS, this is https://crbug.com/1158215 Here, we saw our links fail with "output file too large". Investigation revealed that debug info was being included in the binary, instead of in .dwo files as expected. That turned out to be caused by this cha

[PATCH] D94639: [DebugInfo][CodeView] Change in line tables only mode to emit parent/context scopes for functions, using declarations for types

rnk added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1050-1052 + // Don't include a linkage name in line tables only. + if (CGM.getCodeGenOpts().hasReducedDebugInfo()) +Identifier = getTypeIdentifier(Ty, CGM, TheCU); I see Amy included t

[PATCH] D94639: [DebugInfo][CodeView] Change in line tables only mode to emit parent/context scopes for functions, using declarations for types

dblaikie added a comment. (I'm generally good with this - llvm & clang changes should be committed separately & maybe the linkage part too) I'll leave the rest of the review/final approval up to @rnk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

dblaikie added a comment. In D80391#2497018 , @inglorion wrote: > For Chrome on Chrome OS, this is https://crbug.com/1158215 > > Here, we saw our links fail with "output file too large". Investigation > revealed that debug info was being included in the b

[PATCH] D94403: [RISCV] Implement new architecture extension macros

HsiangKai added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94403/new/ https://reviews.llvm.org/D94403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D93452: [clangd] Trim memory periodically

njames93 added a comment. A little follow up, but I've noticed if I have a lot of tabs open in my editor (usually happens as I forget to close them). When clangd starts (or restarts) , in the first minute, memory usage will shoot right up as it starts to do its thing. I've regularly seen it go o

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

MaskRay added a comment. In D80391#2497018 , @inglorion wrote: > For Chrome on Chrome OS, this is https://crbug.com/1158215 > > Here, we saw our links fail with "output file too large". Investigation > revealed that debug info was being included in the bi

[PATCH] D94364: [clang] Allow specifying the aapcs and aapcs-vfp for windows on arm

rnk added a comment. I don't see how supporting this attribute would break interop with MSVC. MSVC doesn't support these attributes, only GCC and Clang do. Presumably in the wine environment, some headers using these _GNUC extensions are being included somewhere, and IMO we should accept the at

Re: [PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

On Wed, Jan 13, 2021 at 6:26 PM Fangrui Song via Phabricator < revi...@reviews.llvm.org> wrote: > MaskRay added a comment. > > In D80391#2497018 , @inglorion > wrote: > > > For Chrome on Chrome OS, this is https://crbug.com/1158215 > > > > Here, we saw our

[PATCH] D94614: [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins

pengfei added a comment. Hi Kevin, what's the intention of adding constrained FP metadata for target dependent builtins? I believe the middle-end passes always ignore these builtins. What's more, will it imply user these builtins have different behaviors under different FP model? But it's not t

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

MaskRay added a comment. From @dblaikie's email reply: > ^ this I would consider to be a bug. -g should be needed to generate debug > info into the IR, and -gsplit-dwarf should be needed to choose how debug info > already in the IR should be placed into object files or dwo files. > > Usually (n

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

dblaikie added a comment. In D80391#2497073 , @MaskRay wrote: > From @dblaikie's email reply: > >> ^ this I would consider to be a bug. -g should be needed to generate debug >> info into the IR, and -gsplit-dwarf should be needed to choose how debug >> i

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

aeubanks created this revision. Herald added subscribers: wenlei, steven_wu, hiraditya, eraman. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. And revert much of D91567 . D91567 <

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

aeubanks updated this revision to Diff 316550. aeubanks added a comment. test fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94644/new/ https://reviews.llvm.org/D94644 Files: clang/test/CodeGen/thinlto-distributed-newpm.ll clang/test/Fronte

[PATCH] D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

zequanwu created this revision. zequanwu added a reviewer: rnk. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix PR48687. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94646 Files: clang/lib/Sema/SemaTemp

[PATCH] D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

zequanwu added inline comments. Comment at: clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp:151-159 +namespace pr48687 { +template struct A { + T value; + static constexpr auto address = &A::value; +}; +extern template class A; +template class A; I tri

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

mtrofin added a comment. Would running the function simplification pipeline after the always inline pass address the issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94644/new/ https://reviews.llvm.org/D94644 _

[PATCH] D94647: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN if -fthinlto-index= is specified

MaskRay created this revision. MaskRay added reviewers: dblaikie, inglorion, thakis. Herald added a subscriber: arphaman. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. -g is an IR generation option while -gsplit-dwarf is an object

[PATCH] D94647: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN if -fthinlto-index= is specified

MaskRay updated this revision to Diff 316558. MaskRay added a comment. improve code comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94647/new/ https://reviews.llvm.org/D94647 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver

[PATCH] D94647: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN if -fthinlto-index= is specified

dblaikie added a comment. In implicit thinlto this seemed to work for me without any changes: $ clang++-tot -flto=thin test.cpp -g -c $ clang++-tot -flto=thin -fuse-ld=lld -gsplit-dwarf test.o && llvm-dwarfdump-tot a.out a.out: file format elf64-x86-64 .debug_info contents: 0x0

  1   2   >