[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny updated this revision to Diff 353765. jdenny added a comment. Fixed the reported test failure. (Sorry, I had accidentally put that fix in a later patch even though the associated test is in this patch.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://reviews.l

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny added a comment. In D104714#2833238 , @jdoerfert wrote: > LG, cool :) Thanks for the reviews. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://reviews.llvm.org/D104714 ___ cf

[PATCH] D104742: [UpdateCCTestChecks] Implement --global-value-regex

jdenny created this revision. jdenny added reviewers: arichardson, ggeorgakoudis, jdoerfert, MaskRay, mtrofin, greened. jdenny requested review of this revision. Herald added a subscriber: sstefan1. Herald added projects: clang, LLVM. `--check-globals` activates checks for all global values, and

[PATCH] D104743: [UpdateCCTestChecks] Implement --global-hex-value-regex

jdenny created this revision. jdenny added reviewers: arichardson, ggeorgakoudis, jdoerfert, MaskRay, mtrofin, greened. jdenny requested review of this revision. Herald added a subscriber: sstefan1. Herald added projects: clang, LLVM. For example, in OpenMP offload codegen tests, global variables

[clang-tools-extra] 544d20e - [clangd] Dont index ObjCCategoryDecls for completion

Author: Kadir Cetinkaya Date: 2021-06-22T22:42:25+02:00 New Revision: 544d20eab662e29640c8435033e7458e5ee1857e URL: https://github.com/llvm/llvm-project/commit/544d20eab662e29640c8435033e7458e5ee1857e DIFF: https://github.com/llvm/llvm-project/commit/544d20eab662e29640c8435033e7458e5ee1857e.dif

[PATCH] D104540: [clangd] Dont index ObjCCategoryDecls for completion

This revision was automatically updated to reflect the committed changes. Closed by commit rG544d20eab662: [clangd] Dont index ObjCCategoryDecls for completion (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104540/new/ https:/

[PATCH] D104677: [OpenMP][AMDGCN] Apply fix for isnan, isinf and isfinite for amdgcn.

estewart08 updated this revision to Diff 353773. estewart08 added a comment. Add test_isnan function to hip-header.hip. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104677/new/ https://reviews.llvm.org/D104677 Files: clang/lib/Headers/__clang

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

thakis added a comment. This breaks check-clang: http://45.33.8.238/linux/49502/step_7.txt Please take a look and revert for now if it takes a while to fix. It's been a pretty rough day for the tree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D104744: [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility

NeHuang created this revision. NeHuang added reviewers: nemanjai, stefanp, PowerPC. NeHuang added projects: LLVM, clang. Herald added subscribers: shchenz, kbarton. NeHuang requested review of this revision. Herald added a subscriber: cfe-commits. This patch is in a series of patches to provide bu

[clang] b259740 - [PowerPC][NFC] Clean up builtin sema checks

Author: Lei Huang Date: 2021-06-22T16:06:28-05:00 New Revision: b259740801d3515810ecc15bf0c24b0d476a1608 URL: https://github.com/llvm/llvm-project/commit/b259740801d3515810ecc15bf0c24b0d476a1608 DIFF: https://github.com/llvm/llvm-project/commit/b259740801d3515810ecc15bf0c24b0d476a1608.diff LOG

[PATCH] D104664: [PowerPC][NFC] Clean up builtin sema checks

This revision was automatically updated to reflect the committed changes. Closed by commit rGb259740801d3: [PowerPC][NFC] Clean up builtin sema checks (authored by lei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104664/new/ https://reviews.llvm.

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA updated this revision to Diff 353787. ZarkoCA added a comment. Use `--implicit-check-not` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/ https://reviews.llvm.org/D102094 Files: clang/include/clang/Basic/DiagnosticDriverKinds.t

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: clang/test/Driver/aix-vec-extabi.c:12 +/ +// NOEXTABI-NOT: "-mabi=vec-extabi" jsji wrote: > Why not use `--implicit-check-not`? Thank you, I wasn't aware of this option before

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

jsji added inline comments. Comment at: clang/test/Driver/aix-vec-extabi.c:2 +// RUN: %clang -### -target powerpc-unknown-aix -S %s 2>&1 | \ +// RUN: FileCheck %s --implicit-check-not=-mabi=vec-extabi +// RUN: %clang -### -target powerpc-unknown-aix -S -maltivec %s 2>&1 | \ --

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

thakis added a comment. Probably the "need to bump AST serialization Version after adding a langopt" thing again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104484/new/ https://reviews.llvm.org/D104484 _

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen updated this revision to Diff 353797. samitolvanen added a comment. Fix a use-of-uninitialized-value error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104058/new/ https://reviews.llvm.org/D104058 Files: llvm/lib/Transforms/IPO/Th

[PATCH] D104753: [Driver] Stop linking _p libs for -pg on FreeBSD 14

emaste created this revision. emaste added a reviewer: dim. Herald added subscribers: krytarowski, arichardson. emaste requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In FreeBSD 14 we plan to deprecate the _p.a special profiling libraries -

[clang] a8bf33a - [clang] unbreak Index/preamble-reparse-changed-module.m with LLVM_APPEND_VC_REV=NO after 7942ebdf01b3

Author: Nico Weber Date: 2021-06-22T17:56:17-04:00 New Revision: a8bf33ad36837b398d3dabfd5fff1142660a1dca URL: https://github.com/llvm/llvm-project/commit/a8bf33ad36837b398d3dabfd5fff1142660a1dca DIFF: https://github.com/llvm/llvm-project/commit/a8bf33ad36837b398d3dabfd5fff1142660a1dca.diff LO

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

mizvekov updated this revision to Diff 353805. mizvekov added a comment. Implement 2/3 of Arthur's suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104680/new/ https://reviews.llvm.org/D104680 Files: clang/include/clang/Basic/Diagnosti

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA updated this revision to Diff 353806. ZarkoCA marked an inline comment as done. ZarkoCA added a comment. check for `vec-extabi` instead of `-mabi=vec-extabi` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/ https://reviews.llvm.org

[PATCH] D104505: [HIP] Defer operator overloading errors

tra added a comment. In D104505#2833943 , @yaxunl wrote: > We don't defer such diags by default. We only defer them under option > -fgpu-defer-diags, which users have to specify explicitly. Thank you for pointing this out. I've missed that all the test

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

thakis added a comment. a8bf33ad36837b398d3dabfd5fff1142660a1dca fixed this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104484/new/ https://reviews.llvm.org/D104484 ___

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA added a comment. > --implicit-check-not=vec-extabi maybe better? @jsji had to rename the test file because the filename was tripping the error 😆 but this is better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/ https://review

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

arichardson accepted this revision. arichardson added a comment. Thanks for working on this! We have some tests downstream that check globals and currently have to use `// UTC_ARGS: --disable` to manually retain them. The other update script tests compare to an expected output file instead of u

[PATCH] D103501: [clang][AIX] Enable inlined quadword atomic operations

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/ppc64-quadword-atomics.c:10 + +// CHECK-NOT: call void @__atomic_exchange +// CHECK: +quadword-atomics Can you add a link to something that demonstrates that the implementation of `__at

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

NoQ added a comment. In D104616#2830349 , @xazax.hun wrote: > In D104616#2829705 , @RedDocMD > wrote: > >> If `(ptr1 == ptr2)` is false, we can't say anything really. > > Well, I think it depends. If one of the p

[PATCH] D104753: [Driver] Stop linking _p libs for -pg on FreeBSD 14

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. I mostly agree with this, but for the "silent ignoring" of `-pg` which this achieves. What would be the consequence of producing an error instead, like `-pg not supported for FreeBSD >= 14` ? Too m

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

mizvekov added inline comments. Comment at: clang/test/SemaTemplate/resolve-single-template-id.cpp:73-75 + oneT < oneT; // expected-warning {{self-comparison always evaluates to false}} \ + // expected-warning {{relational comparison result unused}}

[PATCH] D103131: support debug info for alias variable

dblaikie added a comment. Huh, that surprises me - guess gdb favors checking the symbol first. I guess maybe it is using something that determines that that symbol comes from the file with debug info - because on a similar test case (one file without debug info, defining some global variable `i

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

xazax.hun added a comment. In D104616#2834714 , @NoQ wrote: > Why not simply delegate this job to `assume(evalBinOp(...))` over raw pointer > values, which already has all this logic written down nicely? This is what I had in mind, I just did not want t

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

jonpa added a comment. In D96568#2832781 , @thopre wrote: > In D96568#2569296 , @jonpa wrote: > >>> Sounds good to me. Hopefully I'll get round to __builtin_isinf soon and a >>> single hook will make the patch slig

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny added a comment. In D104714#2834696 , @arichardson wrote: > Thanks for working on this! Thanks for the review. > We have some tests downstream that check globals and currently have to use > `// UTC_ARGS: --disable` to manually retain them. Doe

[PATCH] D104553: [compiler-rt][hwasan] Add InitState options to thread initialization

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104553/new/ https://reviews.llvm.org/D104553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D104553: [compiler-rt][hwasan] Add InitState options to thread initialization

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104553/new/ https://reviews.llvm.org/D104553 _

[PATCH] D102730: [clang-format] Support custom If macros

vlovich updated this revision to Diff 353823. vlovich added a comment. Rebase onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102730/new/ https://reviews.llvm.org/D102730 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/Releas

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas updated this revision to Diff 353825. manas added a comment. Added updated logic for reasoning using number of overflows. Also, changed a couple of tests which were leading to unwanted constriants being propagated further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added a comment. Regarding the tweakings in `constant-folding.c`, I have refrained from using cases which were resulting in `UNKNOWN` assertions as they were the primary reason for constraints being propagated. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintMa

[PATCH] D104753: [Driver] Stop linking _p libs for -pg on FreeBSD 14

emaste added a comment. `-pg` is still supported (see the `OPT_pg` at line 253), gprof just won't be able to "see into" libc, libm, etc. For example a trivial test case calling snprintf and strcmp in a loop, on FreeBSD 11 with _p libs: % cumulative self self total

[clang] c9aaf34 - [SemaCXX] Handle lack of TypeSourceInfo on special member functions in templated lambdas

Author: Bruno Cardoso Lopes Date: 2021-06-22T17:26:05-07:00 New Revision: c9aaf34b8db884faa3d3ced4d2fb88fd45697408 URL: https://github.com/llvm/llvm-project/commit/c9aaf34b8db884faa3d3ced4d2fb88fd45697408 DIFF: https://github.com/llvm/llvm-project/commit/c9aaf34b8db884faa3d3ced4d2fb88fd45697408

[PATCH] D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9aaf34b8db8: [SemaCXX] Handle lack of TypeSourceInfo on special member functions in… (authored by bruno). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:58-80 +std::string OldName = Name.str(); std::string NewName = (Name + ModuleId).str(); if (const auto *C = ExportGV.getComdat()) if (C->getName() == Name)

[PATCH] D103501: [clang][AIX] Enable inlined quadword atomic operations

lkail added inline comments. Comment at: clang/test/CodeGen/ppc64-quadword-atomics.c:10 + +// CHECK-NOT: call void @__atomic_exchange +// CHECK: +quadword-atomics hubert.reinterpretcast wrote: > Can you add a link to something that demonstrates that the implement

[PATCH] D103131: support debug info for alias variable

kamleshbhalui added a comment. In D103131#2834744 , @dblaikie wrote: > Huh, that surprises me - guess gdb favors checking the symbol first. I guess > maybe it is using something that determines that that symbol comes from the > file with debug info - be

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD added a comment. In D104616#2834770 , @xazax.hun wrote: > In D104616#2834714 , @NoQ wrote: > >> Why not simply delegate this job to `assume(evalBinOp(...))` over raw >> pointer values, which already has

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan updated this revision to Diff 353844. TaoPan added a comment. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. Make clang option -fbasic-block-sections and -funique-basic-block-section-names available on Windows COFF. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

xazax.hun added a comment. In D104616#2835030 , @RedDocMD wrote: > Looks like I have wasted a good deal of effort. :( Sorry about that! :( If we learned anything new in the process it was not wasted effort though. Repository: rG LLVM Github Monorepo

[clang] f681fd9 - Revert "[CodeGen] Don't create fake FunctionDecls when generating block/byref"

Author: Zequan Wu Date: 2021-06-22T21:48:00-07:00 New Revision: f681fd927e883301658dcac9a78109ee0aba12a8 URL: https://github.com/llvm/llvm-project/commit/f681fd927e883301658dcac9a78109ee0aba12a8 DIFF: https://github.com/llvm/llvm-project/commit/f681fd927e883301658dcac9a78109ee0aba12a8.diff LOG

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

zequanwu added a comment. Hi, this caused compiler crash on error "!dbg attachment points at wrong subprogram for function". So, I reverted it. I'm working on a reduced repro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104082/new/ https://revi

[PATCH] D103131: support debug info for alias variable

dblaikie added a comment. In D103131#2835004 , @kamleshbhalui wrote: > In D103131#2834744 , @dblaikie > wrote: > >> Huh, that surprises me - guess gdb favors checking the symbol first. I guess >> maybe it is us

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:579 + return true; +// A single property expr can reference both a getter and setter, but we can +// only provide a single semantic token, so prefer the getter. ---

[PATCH] D104716: [analyzer] Fix assertion failure on code with transparent unions

NoQ added a comment. Thx a lot for the fix! Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:482-483 +// them with parameters. This function incapsulates such cases. +static SVal process(SVal Value, const ParmVarDecl *Parameter, +SValBuilder &SVB) {

<    1   2