[PATCH] D128645: Update developer policy.

vext01 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:87-91 -#. Patches should be made with ``git format-patch``, or similar (see special - commands for `Requesting Phabricator review via the web interface - `_ ). If you use a - different tool, make sure i

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 440261. cor3ntin marked 5 inline comments as done. cor3ntin added a comment. - Address Aaron's and Erich's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 F

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:821 + llvm::UTF32 CodepointValue; + llvm::UTF32 *CpPtr = &CodepointValue; + const unsigned char *CodepointBegin = Begin; aaron.ballman wrote: > We don't really need this var

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

clementval added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:185 {"flang", "--driver-mode=flang"}, + {"flang-new", "--driver-mode=flang"}, {"clang-dxc", "--driver-mode=dxc"}, Why do we need two lines here? Shouldn't we have a si

[PATCH] D128663: Removed old test file.

abrahamcd created this revision. Herald added a project: All. abrahamcd requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D128663 Files: clang-tools-extra/test/cla

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 440264. fhahn added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def clang/include/clang/Basic/Sanitiz

[PATCH] D128604: [WIP][RISCV] Support Zbpbo extension

sunshaoce updated this revision to Diff 440267. sunshaoce added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files: clang/include/clang/Basic/BuiltinsRISCV.def clang/test/

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits mail

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 440270. vaibhav.y added a comment. Factor dependency on `Lexer::MeasureTokenLength` into externally provided functor Introduces a type: `TokenLengthMetric` which measures the length of a token starting at the given SLoc Repository: rG LLVM Github Monor

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

LegalizeAdulthood added a comment. I pushed this change, but for some reason phabricator doesn't show it and close the review... I wonder if it's because I rebased it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128157/new/ https://reviews.llvm.

[PATCH] D108469: Improve handling of static assert messages.

erichkeane added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:793 + OutStr.reserve(OutStr.size() + Str.size()); + auto it = reinterpret_cast(Str.data()); + auto end = it + Str.size(); aaron.ballman wrote: > Please fix the clang-tidy and clang-fo

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16592 +StringLiteral *MsgStr = cast(AssertMessage); +if (MsgStr->getCharByteWidth() == 1) + Msg << MsgStr->getString(); cor3ntin wrote: > aaron.ballman wrote: > >

[PATCH] D128649: [clang-cl] Accept a pragma alloc_text corner case accepted by MSVC

steplong updated this revision to Diff 440268. steplong added a comment. - Use `getCanonicalDecl()`. This does make us reject (MSVC rejects it already because of conflicting declarations): static void f(); extern "C" { static void f(); } static void f() {} - Error if not function decl

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added inline comments. Comment at: clang/lib/Basic/Sarif.cpp:161 +Region["endColumn"] = adjustColumnPos( +R.getEnd(), Lexer::MeasureTokenLength(R.getEnd().getLocWithOffset(0), + R.getEnd().getManager(), LO));

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

bmahjour added a comment. The description should explain why this change is necessary. Comment at: clang/test/CodeGen/lower-mass-end-to-end.c:1 +// RUN: %clang -mllvm -enable-ppc-gen-scalar-mass -O3 -fapprox-func --target=powerpc64le-unknown-linux-gnu -S %s -o -| FileCheck %s

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 440279. vaibhav.y added a comment. Discard unused includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 Files: clang/include/clang/Basic/Sarif.h clang/includ

[PATCH] D128649: [clang-cl] Handle some pragma alloc_text corner cases handled by MSVC

hans added a comment. In D128649#3612626 , @steplong wrote: > I think we have to use `isInExternCContext()` to accept the following (MSVC > accepts this): > > extern "C" { static void f(); } > static void f() {} I'm probably missing something. Is th

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

jspam closed this revision. jspam added a comment. No idea, I'll just close this then :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128157/new/ https://reviews.llvm.org/D128157 ___ cfe-commits mailing

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:185 {"flang", "--driver-mode=flang"}, + {"flang-new", "--driver-mode=flang"}, {"clang-dxc", "--driver-mode=dxc"}, clementval wrote: > Why do we need two lines here? Sh

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski updated this revision to Diff 440283. awarzynski added a comment. Incorporate @clementval 's suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125788/new/ https://reviews.llvm.org/D125788 Files: clang/lib/Driver/Driver.cpp c

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

myhsu added a comment. > I pushed this change, but for some reason phabricator doesn't show it and > close the review... I wonder if it's because I rebased it? You forgot to add "Differential Revison: https:

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 440286. abrahamcd added a comment. Removed old test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTid

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:51-57 +auto Methods = MemberCall->getRecordDecl()->methods(); +auto Clear = llvm::find_if(Methods, [](const CXXMethodDecl *F) { + return F->getDeclName().getAs

[PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 440288. ckissane added a comment. Fix missing cmake findZstd, remove unused crc32 from compression namespaces and simplify some code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.l

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane created this revision. Herald added subscribers: hiraditya, arichardson, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: rupprecht. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. Herald added a project: All. ckissane requested revie

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane updated this revision to Diff 440296. ckissane added a comment. simplifed codeflow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128667/new/ https://reviews.llvm.org/D128667 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Drive

[PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 440298. ckissane added a comment. fix type for FindZstd cmake usage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D128649: [clang-cl] Handle some pragma alloc_text corner cases handled by MSVC

steplong added a comment. > Isn't the question whether `f` is considered "extern C" in the end or not? I > thought `isExternC()` checks that? Are you saying it would return false for > `f` in your example? Yup, `isExternC()` is returning false for that case because there's "static". > I'm prob

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Type.h:4064 bool HasTrailingReturn : 1; +unsigned AArch64SMEAttributes : 8; Qualifiers TypeQuals; If we're taking up space in the extra bitfields, why do we need to also take u

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 440301. cor3ntin marked an inline comment as done. cor3ntin added a comment. - Add a comment to pushEscapedString - Use a stream interface which turns out to be simpler and cleaner, thanks Erich! - Fix typos and small nits Repository: rG LLVM Github Mon

[PATCH] D128645: Update developer policy.

.llvm.org/pipermail/cfe-commits/ (as an example, there's also commits list for LLVM and others), and it's existed for a *long time*. It used to be that your commits were written to the commits list as though they came from you directly (e.g., https://lists.llvm.org/pipermail/cfe-c

[PATCH] D128658: [clang][dataflow] Ensure atomic boolean values representing true and false are not replaced in `buildAndSubstituteFlowCondition`

wyt updated this revision to Diff 440304. wyt added a comment. Assert that user does not try to substitute true/false booleans. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128658/new/ https://reviews.llvm.org/D128658 Files: clang/lib/Analysis/

[PATCH] D128659: [clang][dataflow] Add `buildAndSubstituteFlowCondition` to `DataflowEnvironment`

wyt updated this revision to Diff 440305. wyt added a comment. Fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128659/new/ https://reviews.llvm.org/D128659 Files: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h clan

[PATCH] D128465: Zstandard as a second compression method to LLVM

phosek added a comment. I think this patch should be broken into at least two: 1. Refactor `llvm/include/llvm/Support/Compression.h` and `llvm/lib/Support/Compression.cpp` to introduce a generic interface and use it throughout the codebase. 2. zstd support in `llvm/include/llvm/Support/Compress

[clang] ee0dd2e - [Docs] Update clang & llvm release notes for HLSL

Author: Chris Bieneman Date: 2022-06-27T12:41:14-05:00 New Revision: ee0dd2ec112b3fa727f199709a0d8992eaa13b3b URL: https://github.com/llvm/llvm-project/commit/ee0dd2ec112b3fa727f199709a0d8992eaa13b3b DIFF: https://github.com/llvm/llvm-project/commit/ee0dd2ec112b3fa727f199709a0d8992eaa13b3b.diff

[PATCH] D128667: [WIP] Add Zstd ELF support

MaskRay added a comment. The lld/ change should be separate. And it needs tests. We should have several tests like mixed zlib and zstd input. OutputSections should not have a new member. I can handle the lld/ELF part. > Context not available. See https://llvm.org/docs/Phabricator.html#request

[PATCH] D127890: [Docs] Update clang & llvm release notes for HLSL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee0dd2ec112b: [Docs] Update clang & llvm release notes for HLSL (authored by beanz). Changed prior to commit: https://reviews.llvm.org/D127890?vs=

[PATCH] D128672: Update DynInit generation for ASan globals.

hctim created this revision. hctim added a reviewer: vitalybuka. Herald added a project: All. hctim requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address a follow-up TODO for Sanitizer Metadata. Repository: rG LLVM Github Monorepo ht

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim marked 3 inline comments as done. hctim added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:67-72 + if (FsanitizeArgument.has(SanitizerKind::Address) && !Meta.NoAddress) { IsDynInit &= !CGM.isInNoSanitizeList(SanitizerKind::Address |

[PATCH] D128556: Make Objective-C++ match Objective-C's behavior on implicit ivar access when `self` is shadowed

mwyman updated this revision to Diff 440311. mwyman added a comment. Added codegen test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128556/new/ https://reviews.llvm.org/D128556 Files: clang/lib/Sema/SemaLookup.cpp clang/test/CodeGenObjC/ivar-implicit-self-shadow.m Index: clang

[PATCH] D128556: Make Objective-C++ match Objective-C's behavior on implicit ivar access when `self` is shadowed

mwyman added a comment. Unit test passes both pre- and post- this change for `-x objective-c`, fails pre-change with `-x objective-c++` and passes post-change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128556/new/ https://reviews.llvm.org/D128556 __

[PATCH] D128182: [NFC] Switch FloatModeKind enum class to use bitmask enums

aaron.ballman requested changes to this revision. aaron.ballman added a subscriber: shafik. aaron.ballman added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/TargetInfo.h:225-226 unsigned HasAlignMac68kSupport : 1; - uns

[PATCH] D123952: [FPEnv] Allow CompoundStmt to keep FP options

sepavloff added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:214 +OverrideMask |= NAME##Mask; +#include "clang/Basic/FPOptions.def" + return FPOptionsOverride(*this, OverrideMask); rjmccall wrote: > Hmm. If we can assume that all of the opti

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane updated this revision to Diff 440321. ckissane added a comment. remove extra struct member Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128667/new/ https://reviews.llvm.org/D128667 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/l

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane updated this revision to Diff 440323. ckissane added a comment. add more diff context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128667/new/ https://reviews.llvm.org/D128667 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/ToolChains/CommonArgs.cpp clang/

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane added a comment. In D128667#3612956 , @MaskRay wrote: > The lld/ change should be separate. And it needs tests. We should have > several tests such as mixed zlib and zstd input, malformed zstd input, > compressed level, etc. `OutputSections` sh

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers

ASDenysPetrov marked 4 inline comments as done. ASDenysPetrov added a comment. @martong Just FYI. I've been working on reworking this solution to using `EquivalenceClasses` for several weeks. It turned out that this is an extremely hard task to acomplish. There a lot of cast cases like: `(int8)x

[PATCH] D128604: [RISCV] Support Zbpbo extension

sunshaoce added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:352 MinorStr = In.take_while(isDigit); -In = In.substr(MajorStr.size() + 1); +In = In.substr(MajorStr.size() + MinorStr.size() - 1); Modifications here have been submitt

[PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 440325. ckissane added a comment. more context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/Serialization.cpp clang-t

[PATCH] D128667: [WIP] Add Zstd ELF support

MaskRay added a comment. Tips: you may run `git diff -U0 --no-color --relative 'HEAD^' -- | path/to/llvm-project/clang/tools/clang-format/clang-format-diff.py -p1 -i` to clang-format your local change. Comment at: lld/ELF/Driver.cpp:957 +if (compression::zlib::isAvailable

[PATCH] D128604: [WIP][RISCV] Support Zbpbo extension

sunshaoce updated this revision to Diff 440324. sunshaoce added a comment. Herald added a subscriber: jdoerfert. Fully supported Zbpbo v0.9.11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files: clan

[PATCH] D128465: Zstandard as a second compression method to LLVM

MaskRay added a comment. In D128465#3612948 , @phosek wrote: > I think this patch should be broken into at least two: > > 1. Refactor `llvm/include/llvm/Support/Compression.h` and > `llvm/lib/Support/Compression.cpp` to introduce a generic interface and

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Sarif.h:296-297 +/// The SourceLocation provided must point at the beginning of the token. +typedef std::function +TokenLenMetric; + I worry about the performance aspects of using a ca

[PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 440327. ckissane added a comment. format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/Serialization.cpp clang-tools-e

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen updated this revision to Diff 440329. ychen marked an inline comment as done. ychen added a comment. Update LangRef. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115844/new/ https://reviews.llvm.org/D115844 Files: clang/lib/CodeGen/CodeGe

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane updated this revision to Diff 440330. ckissane added a comment. format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128667/new/ https://reviews.llvm.org/D128667 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/Tool

[PATCH] D128658: [clang][dataflow] Do not allow substitution of true/false boolean literals in `buildAndSubstituteFlowCondition`

wyt updated this revision to Diff 440333. wyt added a comment. Add macro for only testing asserts in debug mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128658/new/ https://reviews.llvm.org/D128658 Files: clang/lib/Analysis/FlowSensitive/D

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

masoud.ataei updated this revision to Diff 440334. masoud.ataei added a comment. Add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128653/new/ https://reviews.llvm.org/D128653 Files: clang/test/CodeGen/lower-mass-end-to-end.c llvm/

[PATCH] D128659: [clang][dataflow] Add `buildAndSubstituteFlowCondition` to `DataflowEnvironment`

wyt updated this revision to Diff 440336. wyt added a comment. Propagate change from parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128659/new/ https://reviews.llvm.org/D128659 Files: clang/include/clang/Analysis/FlowSensitive/Dataf

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added a comment. @LegalizeAdulthood Thanks! I don't have commit rights to the repository, can you commit it on my behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits

[PATCH] D128658: [clang][dataflow] Do not allow substitution of true/false boolean literals in `buildAndSubstituteFlowCondition`

wyt updated this revision to Diff 440341. wyt added a comment. Add assert message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128658/new/ https://reviews.llvm.org/D128658 Files: clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp c

[PATCH] D128256: [Clang][AArch64] Limit arm_locally_streaming to function definitions only.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9835-9839 + if (D.isFunctionDefinition()) { +NewFD->setWillHaveBody(); +ProcessDeclAttributes(S, NewFD, D); +NewFD->setWillHaveBody(false); + } else sdesmalen wrote: > aaro

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane updated this revision to Diff 440343. ckissane added a comment. improve style on ELFWriter::maybeWriteCompression fix typo in comment on zstd value for elf enum CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128667/new/ https://reviews.llvm.org/D128667 Files: clang/lib/Driver

[PATCH] D128649: [clang-cl] Handle some pragma alloc_text corner cases handled by MSVC

steplong updated this revision to Diff 440344. steplong added a comment. - Error for c also Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128649/new/ https://reviews.llvm.org/D128649 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clan

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 440346. abrahamcd marked 7 inline comments as done. abrahamcd added a comment. Addressed review edits and clarity feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D

[PATCH] D128667: [WIP] Add Zstd ELF support

MaskRay added a comment. `llvm-objcopy --decompress-debug-sections clang.zstd clang.zstd.uncompress` doesn't work. % /tmp/out/custom1/bin/llvm-objcopy --decompress-debug-sections clang.zstd clang.zstd.uncompress /tmp/out/custom1/bin/llvm-objcopy: error: 'clang.zstd': '.debug_loc': zlib err

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added inline comments. Comment at: clang/lib/Basic/Sarif.cpp:161 +Region["endColumn"] = adjustColumnPos( +R.getEnd(), Lexer::MeasureTokenLength(R.getEnd().getLocWithOffset(0), + R.getEnd().getManager(), LO));

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y marked an inline comment as not done. vaibhav.y added a comment. Comment isn't done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 ___ cfe-commits m

[clang] fa34210 - [clang][dataflow] Do not allow substitution of true/false boolean literals in `buildAndSubstituteFlowCondition`

Author: Wei Yi Tee Date: 2022-06-27T21:04:52+02:00 New Revision: fa34210fa69f64a96dc64983b3de00ddd21e55e1 URL: https://github.com/llvm/llvm-project/commit/fa34210fa69f64a96dc64983b3de00ddd21e55e1 DIFF: https://github.com/llvm/llvm-project/commit/fa34210fa69f64a96dc64983b3de00ddd21e55e1.diff LO

[PATCH] D128658: [clang][dataflow] Do not allow substitution of true/false boolean literals in `buildAndSubstituteFlowCondition`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa34210fa69f: [clang][dataflow] Do not allow substitution of true/false boolean literals in… (authored by wyt, committed by gribozavr). Repository:

[PATCH] D128659: [clang][dataflow] Add `buildAndSubstituteFlowCondition` to `DataflowEnvironment`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae90bc846758: [clang][dataflow] Add `buildAndSubstituteFlowCondition` to `DataflowEnvironment` (authored by wyt, committed by gribozavr). Repositor

[clang] ae90bc8 - [clang][dataflow] Add `buildAndSubstituteFlowCondition` to `DataflowEnvironment`

Author: Wei Yi Tee Date: 2022-06-27T21:09:05+02:00 New Revision: ae90bc8467589cbc2079b93fae2b6ceec0821e27 URL: https://github.com/llvm/llvm-project/commit/ae90bc8467589cbc2079b93fae2b6ceec0821e27 DIFF: https://github.com/llvm/llvm-project/commit/ae90bc8467589cbc2079b93fae2b6ceec0821e27.diff LO

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6678f8e505b1: [ubsan] Using metadata instead of prologue data for function sanitizer (authored by ychen). Repository: rG LLVM Github Monorepo CHA

[clang] 6678f8e - [ubsan] Using metadata instead of prologue data for function sanitizer

Author: Yuanfang Chen Date: 2022-06-27T12:09:13-07:00 New Revision: 6678f8e505b19069a9dbdc3e3ee088d543752412 URL: https://github.com/llvm/llvm-project/commit/6678f8e505b19069a9dbdc3e3ee088d543752412 DIFF: https://github.com/llvm/llvm-project/commit/6678f8e505b19069a9dbdc3e3ee088d543752412.diff

[PATCH] D108469: Improve handling of static assert messages.

erichkeane added a comment. I'm generally OK with this. BUT Aaron/JF/Tom should review it. Comment at: clang/lib/Basic/Diagnostic.cpp:817 +if (isPrintable(*Begin) || isWhitespace(*Begin)) { + OutStr.push_back(*Begin); + ++Begin; OutStream << *Beg

[PATCH] D128372: [Clang-Tidy] Empty Check

denik added a comment. Thanks for adding a check! Please check my comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:76 + +auto Methods = Arg->getType()->getAsCXXRecordDecl()->methods(); +auto Clear = llvm::find_if(Methods, [](const CXX

[PATCH] D123952: [FPEnv] Allow CompoundStmt to keep FP options

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/ScopeInfo.h:77-78 - CompoundScopeInfo(bool IsStmtExpr) : IsStmtExpr(IsStmtExpr) {} + /// FP options at the beginning of the compound statement, prior to + /// any pragma. + FPOptions FPFeatures; -

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille updated this revision to Diff 440352. serge-sans-paille marked 3 inline comments as done. serge-sans-paille added a comment. Take review into account + add C++ test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128449/new/ https://reviews.llvm.org/D128449 Files:

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille added inline comments. Comment at: clang/test/Sema/array-parameter.c:2 +// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -fsyntax-only -Warray-parameter -verify %s + +void f0(int a[]); aaron.ballman wrote: > aaron.ballman wrote: > > I'd like to s

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman added inline comments. Comment at: clang/lib/Basic/Sarif.cpp:161 +Region["endColumn"] = adjustColumnPos( +R.getEnd(), Lexer::MeasureTokenLength(R.getEnd().getLocWithOffset(0), + R.getEnd().getManager(), LO));

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 440354. cor3ntin added a comment. - Add release note - Address Erich's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 Files: clang/docs/ReleaseNotes.rst

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:837 + llvm::sys::unicode::isFormatting(CodepointValue)) { +OutStr.append(CodepointBegin, CodepointEnd); +continue; erichkeane wrote: > Something here that uses the

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane added a comment. In D128667#3613222 , @MaskRay wrote: > `llvm-objcopy --decompress-debug-sections clang.zstd clang.zstd.uncompress` > doesn't work. > > % /tmp/out/custom1/bin/llvm-objcopy --decompress-debug-sections clang.zstd > clang.zstd.un

[PATCH] D108469: Improve handling of static assert messages.

erichkeane added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:837 + llvm::sys::unicode::isFormatting(CodepointValue)) { +OutStr.append(CodepointBegin, CodepointEnd); +continue; What about...? Repository: rG LLVM Github

[PATCH] D128677: [clangd] Support #import insertions

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:837 + llvm::sys::unicode::isFormatting(CodepointValue)) { +OutStr.append(CodepointBegin, CodepointEnd); +continue; erichkeane wrote: > What about...? I doesn't see

[clang] 8f7cca9 - Revert "[X86] Support `_Float16` on SSE2 and up"

Author: Vitaly Buka Date: 2022-06-27T12:43:29-07:00 New Revision: 8f7cca90af6e06daab4ce23cb0f894380ca7a6a1 URL: https://github.com/llvm/llvm-project/commit/8f7cca90af6e06daab4ce23cb0f894380ca7a6a1 DIFF: https://github.com/llvm/llvm-project/commit/8f7cca90af6e06daab4ce23cb0f894380ca7a6a1.diff L

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:837 + llvm::sys::unicode::isFormatting(CodepointValue)) { +OutStr.append(CodepointBegin, CodepointEnd); +continue; cor3ntin wrote: > erichkeane wrote: > > What abo

[PATCH] D108469: Improve handling of static assert messages.

erichkeane added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:837 + llvm::sys::unicode::isFormatting(CodepointValue)) { +OutStr.append(CodepointBegin, CodepointEnd); +continue; cor3ntin wrote: > cor3ntin wrote: > > erichkea

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added inline comments. Comment at: clang/lib/Basic/Sarif.cpp:161 +Region["endColumn"] = adjustColumnPos( +R.getEnd(), Lexer::MeasureTokenLength(R.getEnd().getLocWithOffset(0), + R.getEnd().getManager(), LO));

[PATCH] D108469: Improve handling of static assert messages.

erichkeane added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:837 + llvm::sys::unicode::isFormatting(CodepointValue)) { +OutStr.append(CodepointBegin, CodepointEnd); +continue; erichkeane wrote: > cor3ntin wrote: > > cor3nt

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo marked an inline comment as done. abidmalikwaterloo added inline comments. Comment at: clang/lib/Testing/CMakeLists.txt:29 llvm_gtest + clangBasic + clangFrontend shraiysh wrote: > abidmalikwaterloo wrote: > > shraiysh wrote: > > > abidmali

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

t-rasmud updated this revision to Diff 440359. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128103/new/ https://reviews.llvm.org/D128103 Files: clang/include/clang/ASTMatchers/ASTMatchers.h clang/lib/ASTMatchers/ASTMatchersInternal.cpp clang/lib/ASTMatchers/Dynamic/Registry.cpp

[PATCH] D126549: [Clang][OpenMP] Don't overload "extension" in status doc

jdenny added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126549/new/ https://reviews.llvm.org/D126549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D126549: [Clang][OpenMP] Don't overload "extension" in status doc

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126549/new/ https://reviews.llvm.org/D126549 ___

[PATCH] D128501: [CodeGen] Make uninitialized Lvalue bit-field stores poison compatible

efriedma added a comment. > No, you can still link those. There's no ABI change nor any interference at > IR level. The scenario I was thinking of with -ffine-grained-bitfield-accesses is something like the following: File A: struct X { int a : 8; int b : 24; }; void f(struct X*); int g

[PATCH] D128679: [pseudo] Define a clangPseudoCLI library.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: mgorny. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. - define a common data structure ParseLang

[PATCH] D128501: [CodeGen] Make uninitialized Lvalue bit-field stores poison compatible

nlopes added a comment. In D128501#3613420 , @efriedma wrote: >> No, you can still link those. There's no ABI change nor any interference at >> IR level. > > The scenario I was thinking of with -ffine-grained-bitfield-accesses is > something like the fo

[PATCH] D128679: [pseudo] Define a clangPseudoCLI library.

hokein updated this revision to Diff 440366. hokein added a comment. remove a dependency from pseudoCLI lib Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128679/new/ https://reviews.llvm.org/D128679 Files: clang-tools-extra/pseudo/benchmarks/Ben

[PATCH] D128449: [clang] Introduce -Warray-parameter

shafik added inline comments. Comment at: clang/test/Sema/array-parameter.c:17 + +void f5(int a[restrict 2]); +void f5(int a[2]); // no warning Since we are covering `static`, `const` and `restict` we should also cover `volatile` for completeness. CHANGES SIN

<    1   2   3   >