[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e218026f8d5: [clang] [MinGW] Fix paths on Gentoo (authored by maharmstone, committed by mstorsjo). Herald added a project: clang. Repository: rG

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

phosek added inline comments. Comment at: llvm/cmake/modules/FindZSTD.cmake:1 +# Copyright (c) Meta Platforms, Inc. and affiliates. +# MaskRay wrote: > How did you derive this? > > The file seems contributed by you (I don't think facebook/zstd has such a >

[clang] eee6a12 - [clang-repl][NFC] Split weak symbol test to a new test

Author: Jun Zhang Date: 2022-07-08T09:17:11+08:00 New Revision: eee6a12227a608e4c9aa4d9428d3fe55071f2d64 URL: https://github.com/llvm/llvm-project/commit/eee6a12227a608e4c9aa4d9428d3fe55071f2d64 DIFF: https://github.com/llvm/llvm-project/commit/eee6a12227a608e4c9aa4d9428d3fe55071f2d64.diff

[PATCH] D129250: [clang-repl][NFC] Split weak symbol test to a new test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeee6a12227a6: [clang-repl][NFC] Split weak symbol test to a new test (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D129068: [AST] Profiling on constraint expression instead of arguments for TypeConstraint in ASTContext::isSameTemplateParameter

vsapsai added a comment. After looking at this change more, I was thinking about changing the title from **how** to **what** you are doing. For example, something like "[AST] Accept identical TypeConstraint referring to other template parameters." You can tweak it as you know better what's

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane updated this revision to Diff 443006. ckissane added a comment. - chore: delete an excess blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128953/new/ https://reviews.llvm.org/D128953 Files:

[PATCH] D128816: [OpenMP] Add loop tripcount argument to kernel launch and remove push function

jhuber6 updated this revision to Diff 443013. jhuber6 added a comment. Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128816/new/ https://reviews.llvm.org/D128816 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D128372: [Clang-Tidy] Empty Check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:146 +CXXRecordDecl *ArgRecordDecl = Arg->getType()->getAsCXXRecordDecl(); +if (ArgRecordDecl == NULL) + return; `nullptr`. Repository:

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

aaron.ballman added a comment. In D129277#3636596 , @mstorsjo wrote: > In D129277#3636567 , @aaron.ballman > wrote: > >> Thanks for catching this! Is it really an NFC change though (it seems like >> it would

[PATCH] D119296: KCFI sanitizer

MaskRay added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:63 SanitizerKind::Unreachable | SanitizerKind::Return; -static const SanitizerMask AlwaysRecoverable = -SanitizerKind::KernelAddress | SanitizerKind::KernelHWAddress; +static const

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5400-5401 +SourceLocation KWLoc) { + if (!S.getLangOpts().CPlusPlus11) +return; + erichkeane wrote: > royjacobson wrote: > >

[PATCH] D129250: [clang-repl][NFC] Split weak symbol test to a new test

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129250/new/ https://reviews.llvm.org/D129250

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

shafik added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:5174 std::string ) override { - return checkPreprocessorOptions(ExistingPPOpts, PPOpts, nullptr, FileMgr, + return checkPreprocessorOptions(PPOpts,

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 443056. abrahamcd marked 3 inline comments as done. abrahamcd added a comment. Adds argument 0 test case and refactoring based on feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. In D102107#3633705 , @jdoerfert wrote: > Also, make sure to remove all deviceRTL files and probably reset the > autogenerated tests to upstream (and re-generate) before you merge (or > reupload). > > In D102107#3633678

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

MaskRay added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:27 +static constexpr std::string AlgorithmName = "zlib"; static constexpr int NoCompression = 0; Is it still used? Prefer StringRef if the string is backed from some storage.

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

MaskRay accepted this revision. MaskRay added inline comments. Comment at: llvm/unittests/Support/CompressionTest.cpp:21 using namespace llvm; +using namespace llvm::compression; Delete blank line between two `using` CHANGES SINCE LAST ACTION

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath created this revision. sridhar_gopinath added reviewers: curdeius, owenpan. Herald added a project: All. sridhar_gopinath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In diff and diffstat modes, the return code is != 0

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane marked 5 inline comments as done. ckissane added a comment. mark some handled comments done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128953/new/ https://reviews.llvm.org/D128953 ___

[PATCH] D128754: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib namespace

ckissane marked 4 inline comments as done. ckissane added a comment. mark handled comments as done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754 ___

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 443017. abrahamcd edited the summary of this revision. abrahamcd added a comment. Adds functionality for only warning on the case of unused return value of the call to `empty()` and removes using-directive. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

dyung added a comment. This change is causing a build failure on the Windows PS4 bot, can you please take a look and revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/216/builds/7026 FAILED:

[clang] 63fac42 - Revert "[clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`."

Author: Dmitri Gribenko Date: 2022-07-07T21:50:52+02:00 New Revision: 63fac424e674bbd77f63e2c76cda9ae28552916a URL: https://github.com/llvm/llvm-project/commit/63fac424e674bbd77f63e2c76cda9ae28552916a DIFF:

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

yaxunl added a comment. I feel it is better to do the refactoring in one patch, since it is difficult to maintain the integrity of 4 patches. It would be easier to revert or cherry-pick the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129100: [clangd] Support external throttler for preamble builds

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp:1499 + +S.remove(Filenames.back()); +// Now shut down the TU Scheduler. kadircet wrote: > sequencing is hard here but it'd be nice to ensure release is

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

aaron.ballman added a comment. Thanks for catching this! Is it really an NFC change though (it seems like it would change some of the diagnostic behavior and the list of suggested predefines)? Can you add test coverage for the change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane updated this revision to Diff 443005. ckissane added a comment. - Merge branch 'ckissane.refactor-compression.part-0' of github.com:ckissane/llvm-project into ckissane.refactor-compression.part-0 - Merge branch 'main' into ckissane.refactor-compression.part-0 - compression refactor:

[clang] 81e6400 - [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

Author: Wei Yi Tee Date: 2022-07-07T20:21:19Z New Revision: 81e6400d8c03b74d3d6b1db2cf2746cff5de91d7 URL: https://github.com/llvm/llvm-project/commit/81e6400d8c03b74d3d6b1db2cf2746cff5de91d7 DIFF: https://github.com/llvm/llvm-project/commit/81e6400d8c03b74d3d6b1db2cf2746cff5de91d7.diff LOG:

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

Meinersbur accepted this revision. Meinersbur added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129149/new/ https://reviews.llvm.org/D129149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:27 +static constexpr std::string AlgorithmName = "zlib"; static constexpr int NoCompression = 0; MaskRay wrote: > Is it still used? > > Prefer StringRef if the string is

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. SO I've been playing with this for a while and all the libcxx issues. I THINK we really need to just bit the bullet and figure out how to correctly re-add things to the instantiation scope (after making the CheckFunctionConstraints LocalInstantiationScope 'false'

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3636830 , @erichkeane wrote: > SO I've been playing with this for a while and all the libcxx issues. I THINK > we really need to just bit the bullet and figure out how to correctly re-add > things to the

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane marked 2 inline comments as done. ckissane added a comment. mark outdated comments done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___

[PATCH] D128816: [OpenMP] Add loop tripcount argument to kernel launch and remove push function

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, but rename the function. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:890 + /// the int64 value for the number of iterations of the associated loop. +

[PATCH] D129220: [clang] Cleanup ASTContext before output files in crash recovery for modules

steven_wu accepted this revision. steven_wu added a comment. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129220/new/ https://reviews.llvm.org/D129220 ___ cfe-commits mailing list

[clang-tools-extra] b15127d - [clangd] Disable flaky test

Author: Sam McCall Date: 2022-07-07T19:17:09+02:00 New Revision: b15127d0562cd6e1fc65abc1e967c56fa18391a7 URL: https://github.com/llvm/llvm-project/commit/b15127d0562cd6e1fc65abc1e967c56fa18391a7 DIFF: https://github.com/llvm/llvm-project/commit/b15127d0562cd6e1fc65abc1e967c56fa18391a7.diff

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/gen/Main.cpp:114 + const clang::pseudo::Rule = G.table().Rules[RID]; + // lhs$$rhs$rhs$rhs + std::string EnumName = symbolName(R.Target, G) + "$"; so the dollar signs are a

[PATCH] D129308: [mlir] Remove VectorToROCDL

krzysz00 created this revision. Herald added subscribers: bzcheeseman, kosarev, sdasgup3, wenzhicui, wrengr, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, csigg, antiagainst, shauheen, rriddle,

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

mstorsjo added a comment. In D129277#3636567 , @aaron.ballman wrote: > Thanks for catching this! Is it really an NFC change though (it seems like it > would change some of the diagnostic behavior and the list of suggested > predefines)? Can you add

[PATCH] D128754: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib namespace

ckissane updated this revision to Diff 443009. ckissane edited the summary of this revision. ckissane added a comment. - remove crc32 from zlib compression namespace - Merge branch 'ckissane.refactor-compression.part-0' into ckissane.refactor-compression.part-1 - Merge branch

[clang] 19e2188 - [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

Author: Wei Yi Tee Date: 2022-07-07T20:53:47+02:00 New Revision: 19e21887eb18aa019000c2384ea7f2c91d937489 URL: https://github.com/llvm/llvm-project/commit/19e21887eb18aa019000c2384ea7f2c91d937489 DIFF: https://github.com/llvm/llvm-project/commit/19e21887eb18aa019000c2384ea7f2c91d937489.diff

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19e21887eb18: [clang][dataflow] Return a solution from the solver when `Constraints` are… (authored by wyt, committed by gribozavr). Changed prior

[PATCH] D128372: [Clang-Tidy] Empty Check

cjdb added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:128 + << FixItHint::CreateReplacement(ReplacementRange, "clear"); +} else { + diag(MemberLoc, "ignoring the result of 'empty()'"); Let's

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5184 - // FIXME: This mimics what GCC implements, but doesn't match up with the - // proposed resolution for core issue 692. This area needs to be sorted out, ychen

[PATCH] D128372: [Clang-Tidy] Empty Check

cjdb accepted this revision. cjdb added a comment. Thanks for working on this! I'll merge this on your behalf once there's maintainer approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372

[PATCH] D129220: [clang] Cleanup ASTContext before output files in crash recovery for modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67a84ec8105e: [clang] Cleanup ASTContext before output files in crash recovery for modules (authored by benlangmuir). Repository: rG LLVM Github

[clang] 67a84ec - [clang] Cleanup ASTContext before output files in crash recovery for modules

Author: Ben Langmuir Date: 2022-07-07T10:23:57-07:00 New Revision: 67a84ec8105e590159b6303a1f0e3cb77c02b5fe URL: https://github.com/llvm/llvm-project/commit/67a84ec8105e590159b6303a1f0e3cb77c02b5fe DIFF: https://github.com/llvm/llvm-project/commit/67a84ec8105e590159b6303a1f0e3cb77c02b5fe.diff

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

MaskRay added a comment. I think this can be pushed now. You need to remove the variable > In file included from > /var/lib/buildkite-agent/builds/llvm-project/llvm/lib/MC/ELFObjectWriter.cpp:41: > /var/lib/buildkite-agent/builds/llvm-project/llvm/include/llvm/Support/Compression.h:27:30: >

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 updated this revision to Diff 443011. jhuber6 added a comment. Moving version field to struct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D119296: KCFI sanitizer

samitolvanen marked an inline comment as done. samitolvanen added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:63 SanitizerKind::Unreachable | SanitizerKind::Return; -static const SanitizerMask AlwaysRecoverable = -SanitizerKind::KernelAddress |

[PATCH] D129202: [clang] Add a fixit for warn-self-assign if LHS is a field with the same name as parameter on RHS

aaron.ballman added a comment. In D129202#3634646 , @njames93 wrote: > In D129202#3633618 , @aaron.ballman > wrote: > >> Thank you for working on this, I think it's a nice new diagnostic. You >> should add a

[PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 443035. ckissane added a comment. start breaking this up further, this is now the add cmake config patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files:

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/gen/Main.cpp:114 + const clang::pseudo::Rule = G.table().Rules[RID]; + // lhs$$rhs$rhs$rhs + std::string EnumName = symbolName(R.Target, G) + "$"; sammccall wrote: > so the dollar

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

rsmith added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:10733-10736 // For enums, get the underlying integer type of the enum, and let the general // integer type signchanging code handle it. if (const auto *ETy = T->getAs()) T =

[PATCH] D127626: [docs] Add document "Debugging C++ Coroutines"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1934b3ae59a7: [docs] Add document Debugging C++ Coroutines (authored by ChuanqiXu). Herald added a project: clang. Herald added a subscriber:

[clang] 1934b3a - [docs] Add document "Debugging C++ Coroutines"

Author: Chuanqi Xu Date: 2022-07-08T11:29:00+08:00 New Revision: 1934b3ae59a7869d324bb34218310cae55acb140 URL: https://github.com/llvm/llvm-project/commit/1934b3ae59a7869d324bb34218310cae55acb140 DIFF: https://github.com/llvm/llvm-project/commit/1934b3ae59a7869d324bb34218310cae55acb140.diff

[PATCH] D129068: [AST] Accept identical TypeConstraint referring to other template parameters.

ChuanqiXu updated this revision to Diff 443141. ChuanqiXu retitled this revision from "[AST] Profiling on constraint expression instead of arguments for TypeConstraint in ASTContext::isSameTemplateParameter" to "[AST] Accept identical TypeConstraint referring to other template parameters.".

[PATCH] D129280: [analyzer] PlacementNewChecker, properly handle array overhead (cookie)

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:157 "Storage provided to placement new is only {0} bytes, " -"whereas the allocated array type requires more space for " -"internal needs", -

[clang-tools-extra] 011d2bf - [clang-tidy] Fix confusable identifier interaction with unavailable class def

Author: serge-sans-paille Date: 2022-07-07T08:02:29+02:00 New Revision: 011d2bf86487520c3515f16e0b1d32994bf2b48f URL: https://github.com/llvm/llvm-project/commit/011d2bf86487520c3515f16e0b1d32994bf2b48f DIFF:

[PATCH] D129250: [clang-repl][NFC] Split weak symbol test to a new test

junaire created this revision. junaire added a reviewer: v.g.vassilev. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Windows has some issues when we try to use `__attribute__((weak))` in JIT, so we

[PATCH] D129202: [clang] Add a fixit for warn-self-assign if LHS is a field with the same name as parameter on RHS

njames93 marked 3 inline comments as done. njames93 added a comment. In D129202#3633618 , @aaron.ballman wrote: > Thank you for working on this, I think it's a nice new diagnostic. You should > add a release note to describe it. One question I have is

[PATCH] D129202: [clang] Add a fixit for warn-self-assign if LHS is a field with the same name as parameter on RHS

njames93 updated this revision to Diff 442788. njames93 marked an inline comment as done. njames93 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129202/new/ https://reviews.llvm.org/D129202 Files:

[PATCH] D128974: [AST] [Modules] Handle full cases of DefaultArgStorage::setInherited

ChuanqiXu updated this revision to Diff 442791. ChuanqiXu added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128974/new/ https://reviews.llvm.org/D128974 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/DeclTemplate.h

[PATCH] D129068: [AST] Profiling on constraint expression instead of arguments for TypeConstraint in ASTContext::isSameTemplateParameter

ChuanqiXu updated this revision to Diff 442792. ChuanqiXu added a comment. Minor changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129068/new/ https://reviews.llvm.org/D129068 Files: clang/lib/AST/ASTContext.cpp clang/test/Modules/concept.cppm Index:

[PATCH] D128974: [AST] [Modules] Handle full cases of DefaultArgStorage::setInherited

ChuanqiXu updated this revision to Diff 442795. ChuanqiXu added a comment. Update tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128974/new/ https://reviews.llvm.org/D128974 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/DeclTemplate.h

<    1   2