[clang] f6ace23 - [amdgpu-arch] Dynamically load the HSA runtime if not found during the build

Author: Joseph Huber Date: 2023-01-16T13:13:45-06:00 New Revision: f6ace23172e5930be0e7cc602f50e1e9c54d7a9a URL: https://github.com/llvm/llvm-project/commit/f6ace23172e5930be0e7cc602f50e1e9c54d7a9a DIFF: https://github.com/llvm/llvm-project/commit/f6ace23172e5930be0e7cc602f50e1e9c54d7a9a.diff

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

xazax.hun added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:81 + FromPointeeTy->getUnqualifiedDesugaredType(); + const Type *ToPointeeUQTy = ToPointeeTy->getUnqualifiedDesugaredType(); + Here I am also

[PATCH] D141528: [Clang][OpenMP] Fix loop directive nested inside a parallel

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141528/new/ https://reviews.llvm.org/D141528 ___ cfe-commits mailing list

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4056825 , @barannikov88 wrote: > clangBasic and clangDriver already have a dependency on TargetParser (see > LLVM_LINK_COMPONENTS at the beginning of corresponding files). Is that not > enough? > Will it build

[PATCH] D141873: [Clang][OpenMP] Fix the issue that a functor is not captured properly in a task region

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141873/new/ https://reviews.llvm.org/D141873

[clang] fd15cb9 - [clang] [MinGW] Avoid adding /include and /lib when cross compiling

Author: Martin Storsjö Date: 2023-01-17T00:39:12+02:00 New Revision: fd15cb935d7aae25ad62bfe06fe9f17cea585978 URL: https://github.com/llvm/llvm-project/commit/fd15cb935d7aae25ad62bfe06fe9f17cea585978 DIFF:

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd15cb935d7a: [clang] [MinGW] Avoid adding base/include and base/lib when cross compiling (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu added a comment. In D137058#4056647 , @Jake-Egan wrote: > Hi, this new test fails on AIX > https://lab.llvm.org/buildbot/#/builders/214/builds/5351/steps/6/logs/FAIL__Clang__module-output_cppm > Could you take a look? I added `// REQUIRES:

[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

fahadnayyar created this revision. Herald added a subscriber: arphaman. Herald added a project: All. fahadnayyar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Disabled an invalid fix-it which suggested fixes to be applied in system

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:5780 + /// Iterator modifier + Expr *IteratorModifierExpr = nullptr; + We're using tail allocation for such objects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D131938: [C++20] [Coroutines] Disable to take the address of labels in coroutines

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Oh, sorry, I forgot this. Given D132084 is not updated recently, I think we can merge this first. And it should be fine to remove this one after

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

yaxunl added a comment. The intention of -emit-llvm -S is usually to get LLVM assembly for all targets for inspection or modification. HIP emits a bundled LLVM assembly in textual format in this case. Users can modify it directly, or extract assembly for each device and bundle them together

[PATCH] D141859: [amdgpu-arch] Dynamically load the HSA runtime if not found during the build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6ace23172e5: [amdgpu-arch] Dynamically load the HSA runtime if not found during the build (authored by jhuber6). Changed prior to commit:

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9954516ffb10: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build (authored by jhuber6). Changed prior to commit:

[clang] 9954516 - [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

Author: Joseph Huber Date: 2023-01-16T13:13:47-06:00 New Revision: 9954516ffb10a39ae0c8517f4865eec24e07d56e URL: https://github.com/llvm/llvm-project/commit/9954516ffb10a39ae0c8517f4865eec24e07d56e DIFF: https://github.com/llvm/llvm-project/commit/9954516ffb10a39ae0c8517f4865eec24e07d56e.diff

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D140628: [flang] Add driver install directory to AIX toolchain program paths list

pscoro added a comment. Herald added a subscriber: sunshaoce. Ping. This is a needed fix for AIX, the code is trivial and used similarly on other targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140628/new/ https://reviews.llvm.org/D140628

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

isuckatcs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:95 + + if (P1->isArrayType() && P2->isArrayType()) { +// At every level that array type is involved in, at least xazax.hun wrote: > isuckatcs wrote: > >

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

ChuanqiXu updated this revision to Diff 489665. ChuanqiXu added a comment. Address comments and refine the wording from "use `-std=c++20`" to "use `-std=c++20` or higher". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141572/new/ https://reviews.llvm.org/D141572 Files:

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

nridge added a comment. In D139926#4056478 , @kadircet wrote: > This will only make sure we have a distinction between `<<` and `>>` used as > operators vs `<`/`>` Note that `<<` and `>>` are not the only (or even the primary, in my mind) issue: there

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

nridge added a comment. Sorry, that was a bad example as it's not actually valid. Here's a slightly modified one: template class a {}; constexpr int b = 2; constexpr int c = 3; constexpr int d = 4; a e; The parser knows the first `<` opens a template-param-list because the

[PATCH] D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified

daltenty added a comment. Needs a test, I think we should add a couple of `-fopenmp=foo` run lines to `clang/test/Driver/aix-ld.c` to verify that the correct linker options are produced for each. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136554: Implement CWG2631

cebowleratibm added a comment. In D136554#4056862 , @cor3ntin wrote: > Yes please! However the warning looks correct to me in that case. A > constructs x which constructs A etc. https://github.com/llvm/llvm-project/issues/60082 Please set the

[PATCH] D141528: [Clang][OpenMP] Fix loop directive nested inside a parallel

doru1004 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141528/new/ https://reviews.llvm.org/D141528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 created this revision. doru1004 added reviewers: jdoerfert, ABataev, carlo.bertolli, ronl, gregrodgers, jhuber6. doru1004 added a project: OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a project: All. doru1004 requested review of this revision. Herald added

[PATCH] D141803: [Clang] Reject in-class defaulting of previously declared comparison operators

royjacobson updated this revision to Diff 489607. royjacobson added a comment. rebase on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141803/new/ https://reviews.llvm.org/D141803 Files: clang/docs/ReleaseNotes.rst

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 489626. isuckatcs marked 7 inline comments as done. isuckatcs added a comment. Addressed comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files:

[PATCH] D141814: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides

jloser added inline comments. Comment at: lldb/source/Host/common/NativeProcessProtocol.cpp:652 auto data = + llvm::MutableArrayRef(static_cast(buf), bytes_read); serge-sans-paille wrote: > random nit: This could be rewritten as > > ``` >

[PATCH] D141873: [Clang][OpenMP] Fix the issue that a functor is not captured properly in a task region

tianshilei1992 created this revision. tianshilei1992 added reviewers: ABataev, jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

jdoerfert added a comment. FWIW, creating CUBIN from C/C++ directly would be really useful when debugging (and in combination with our soon to be available JIT object loader). @tra Can we get this in somehow? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 61fa12d - [NFC][X86] clang-format change for avx512vlbwintrin.h

Author: Freddy Ye Date: 2023-01-17T10:43:51+08:00 New Revision: 61fa12d0c78b5624914b8bd7937eba03f8973434 URL: https://github.com/llvm/llvm-project/commit/61fa12d0c78b5624914b8bd7937eba03f8973434 DIFF: https://github.com/llvm/llvm-project/commit/61fa12d0c78b5624914b8bd7937eba03f8973434.diff

[PATCH] D71734: [ODRHash] Hash `RecordDecl` and diagnose discovered mismatches.

vsapsai added a comment. Ping. Also checked the change on a bunch of internal Objective-C/C code using modules - no new errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71734/new/ https://reviews.llvm.org/D71734

[PATCH] D141892: Implement modernize-use-constraints

ccotter added a comment. For the sake of demonstration, https://github.com/llvm/llvm-project/commit/9c556ce59edf5a4293d4497d5815544afc0eb878 is the result of running this tool on all headers under clang/include/clang and llvm/include/llvm. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D141759: [7/15][Clang][RISCV][NFC] Correct the default value for Policy to TAMU

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luke. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141759/new/ https://reviews.llvm.org/D141759

[PATCH] D141886: [Clang][Test] Avoid matching version numbers

hzq created this revision. Herald added a project: All. hzq requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the version number starts with cc1, such as: clang-cc1514432c58 In the test case the `-cc1` option will match the version number

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer added a comment. (If anyone knows what's going on with the (unrelated seeming?) testing timeouts please do say.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138546/new/ https://reviews.llvm.org/D138546 ___ cfe-commits mailing list

[PATCH] D141575: [3/15][Clang][RISCV][NFC] Clarify edge cases of RVVIntrinsic::getSupportedMaskedPolicies for clarity

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luke. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141575/new/ https://reviews.llvm.org/D141575

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

hzq updated this revision to Diff 489705. hzq retitled this revision from "[Clang][Test] Avoid matching version numbers" to "[Clang][test] Avoid FileCheck error when matching `-cc1`". hzq added a comment. Add `-###` to the command line and update the check content. Repository: rG LLVM Github

[PATCH] D141754: [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

kito-cheng added inline comments. Herald added a subscriber: luke. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:388 + bool HasVL, PolicyScheme Scheme, const bool HasTailPolicy, + const bool HasMaskPolicy, bool SupportOverloading,

[PATCH] D141803: [Clang] Reject in-class defaulting of previously declared comparison operators

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141803/new/ https://reviews.llvm.org/D141803

[PATCH] D141768: [11/15][Clang][RISCV][NFC] Remove Policy::PolicyType::Omit

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luke. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141768/new/ https://reviews.llvm.org/D141768

[PATCH] D141754: [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

kito-cheng added a comment. Wait, I fell HasTailPolicy and HasMaskPolicy should be part of Policy object, and then it's the Omit to present it's no policy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141754/new/ https://reviews.llvm.org/D141754

[PATCH] D141886: [Clang][Test] Avoid matching version numbers

bryanpkc added a comment. Thanks for the patch. I just have some simple suggestions. Comment at: clang/test/Driver/modules-ts.cpp:23 // -// CHECK-USE: -cc1 +// CHECK-USE: -cc1{{[^[:xdigit:]]}} // CHECK-USE-SAME: -emit-obj An easier-to-understand fix is to

[PATCH] D141892: Implement modernize-use-constraints

ccotter created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Add new check to replace enable_if

Re: [clang] 931d04b - [ADT] Make StringRef::compare like std::string_view::compare

Nice! On Sun, Jan 15, 2023 at 12:10 PM Benjamin Kramer via cfe-commits wrote: > > > Author: Benjamin Kramer > Date: 2023-01-15T20:59:21+01:00 > New Revision: 931d04be2fc8f3f0505b43e64297f75d526cb42a > > URL: > https://github.com/llvm/llvm-project/commit/931d04be2fc8f3f0505b43e64297f75d526cb42a

[PATCH] D141574: [2/15][Clang][RISCV][NFC] Rename Policy::IsPolicyNone to IsUnspecifed

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luke. LGTM, this made the code more expressive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141574/new/

[PATCH] D141764: [9/15][Clang][RISCV][NFC] Use correct type for `RVVTypeCache::computeTypes` under RISCVVEmitter.cpp

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luke. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141764/new/ https://reviews.llvm.org/D141764

[PATCH] D141762: [8/15][Clang][RISCV][NFC] Always emit PolicyAttr in riscv_vector_builtin_cg.inc

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luke. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141762/new/ https://reviews.llvm.org/D141762

[PATCH] D71734: [ODRHash] Hash `RecordDecl` and diagnose discovered mismatches.

ChuanqiXu added inline comments. Comment at: clang/lib/AST/Decl.cpp:4881-4882 + // For RecordDecl the ODRHash is stored in the remaining 26 + // bit of RecordDeclBits, adjust the hash to accomodate. + setODRHash(Hash.CalculateHash() >> 6); + return RecordDeclBits.ODRHash;

[clang] cc526e3 - [C++20] [Coroutines] Disable to take the address of labels in coroutines

Author: Chuanqi Xu Date: 2023-01-17T11:35:32+08:00 New Revision: cc526e346debbaf1d2d32a59230288a4e98294c7 URL: https://github.com/llvm/llvm-project/commit/cc526e346debbaf1d2d32a59230288a4e98294c7 DIFF: https://github.com/llvm/llvm-project/commit/cc526e346debbaf1d2d32a59230288a4e98294c7.diff

[PATCH] D141873: [Clang][OpenMP] Fix the issue that a functor is not captured properly in a task region

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae53c7f4a211: [Clang][OpenMP] Fix the issue that a functor is not captured properly in a task… (authored by tianshilei1992). Repository: rG LLVM

[clang] ae53c7f - [Clang][OpenMP] Fix the issue that a functor is not captured properly in a task region

Author: Shilei Tian Date: 2023-01-16T22:35:05-05:00 New Revision: ae53c7f4a21104e2eb84139f3ce4c468e2632590 URL: https://github.com/llvm/llvm-project/commit/ae53c7f4a21104e2eb84139f3ce4c468e2632590 DIFF: https://github.com/llvm/llvm-project/commit/ae53c7f4a21104e2eb84139f3ce4c468e2632590.diff

[PATCH] D140874: [clang][Interp] Support pointer types in compound assignment operations

tbaeder updated this revision to Diff 489694. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140874/new/ https://reviews.llvm.org/D140874 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h

[PATCH] D131938: [C++20] [Coroutines] Disable to take the address of labels in coroutines

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc526e346deb: [C++20] [Coroutines] Disable to take the address of labels in coroutines (authored by ChuanqiXu). Changed prior to commit: https://reviews.llvm.org/D131938?vs=452925=489677#toc

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder updated this revision to Diff 489693. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/Context.cpp

[PATCH] D141892: Implement modernize-use-constraints

ccotter added a comment. Overall, we could eventually upgrade code in three stages, each a separate reusable check. 1. enable_if -> requires clauses 2. replace the non `_v` templates to the `_v` variants `is_same` -> `is_same_v` or the equivalent concept `same_as` 3. replace requires clause on

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

hzq marked an inline comment as done. hzq added a comment. In D141886#4057549 , @bryanpkc wrote: > Thanks for the patch. I just have some simple suggestions. Thanks a lot, modified. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141756: [6/15][Clang][RISCV][NFC] Instructions with a mask destination register is always tail agnostic

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luke. LGTM, the condition of those predictor function more reasonable now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141767: [10/15][Clang][RISCV][NFC] Don't need to check for `MaskPolicy` in `isTAPolicy` and `isTUPolicy`

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luke. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141767/new/ https://reviews.llvm.org/D141767

<    1   2