[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

2023-02-08 Thread Tom Praschan via Phabricator via cfe-commits
tom-anders added a comment. In D142014#4106088 , @v1nh1shungry wrote: > Thanks for the review! @kadircet > > Would you mind having a look at if there're any concerns about the current > code change, @nridge, @tom-anders, and @adamcz? Thanks a lot! Noth

[clang] ea2c144 - [clang][cli] Simplify repetitive macro invocations

2023-02-08 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-02-08T14:54:21-08:00 New Revision: ea2c144e85c7a6c29104c059b4b08aa9f9221a32 URL: https://github.com/llvm/llvm-project/commit/ea2c144e85c7a6c29104c059b4b08aa9f9221a32 DIFF: https://github.com/llvm/llvm-project/commit/ea2c144e85c7a6c29104c059b4b08aa9f9221a32.diff L

[clang] 8529b38 - [Lex] Fix -Wunused-variable for LLVM_ENABLE_ASSERTIONS=off builds after D140179

2023-02-08 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2023-02-08T15:08:10-08:00 New Revision: 8529b38f6027e698a37dd24234e1c658c8bd412a URL: https://github.com/llvm/llvm-project/commit/8529b38f6027e698a37dd24234e1c658c8bd412a DIFF: https://github.com/llvm/llvm-project/commit/8529b38f6027e698a37dd24234e1c658c8bd412a.diff

[PATCH] D143613: [clang][deps] Migrate ModuleDepCollector to LexedFileChanged NFCI

2023-02-08 Thread Ben Langmuir via Phabricator via cfe-commits
benlangmuir created this revision. benlangmuir added reviewers: akyrtzi, jansvoboda11. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LexedFileChanged has the semantics we want of ignoring #line/etc

[PATCH] D143615: [clang][deps] NFC: Refactor inferred modules test

2023-02-08 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch squashes two tests wit

[PATCH] D143615: [clang][deps] NFC: Refactor inferred modules test

2023-02-08 Thread Ben Langmuir via Phabricator via cfe-commits
benlangmuir accepted this revision. benlangmuir added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/ClangScanDeps/modules-inferred.m:54 +// CHECK-NEXT: { +// CHECK-NEXT: "context-hash": "{{.*}}", +// CHECK-NEXT:

[PATCH] D143615: [clang][deps] NFC: Refactor inferred modules test

2023-02-08 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 495986. jansvoboda11 added a comment. Remove unused CDB file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143615/new/ https://reviews.llvm.org/D143615 Files: clang/test/ClangScanDeps/Inputs/frameworks

[PATCH] D143615: [clang][deps] NFC: Refactor inferred modules test

2023-02-08 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/modules-inferred.m:54 +// CHECK-NEXT: { +// CHECK-NEXT: "context-hash": "{{.*}}", +// CHECK-NEXT: "module-name": "Inferred" benlangmuir wrote: > Why d

[clang] 29b95f0 - [clang][deps] NFC: Refactor inferred modules test

2023-02-08 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-02-08T16:57:41-08:00 New Revision: 29b95f05738fed5bf9777e285ccb084ada54b9b1 URL: https://github.com/llvm/llvm-project/commit/29b95f05738fed5bf9777e285ccb084ada54b9b1 DIFF: https://github.com/llvm/llvm-project/commit/29b95f05738fed5bf9777e285ccb084ada54b9b1.diff L

[PATCH] D143615: [clang][deps] NFC: Refactor inferred modules test

2023-02-08 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29b95f05738f: [clang][deps] NFC: Refactor inferred modules test (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 03cc52d - [-Wunsafe-buffer-usage] To disable a test on Windows systems.

2023-02-08 Thread Ziqing Luo via cfe-commits
Author: Ziqing Luo Date: 2023-02-08T17:38:19-08:00 New Revision: 03cc52dfd1dbb4a59b479da55e87838fb93d2067 URL: https://github.com/llvm/llvm-project/commit/03cc52dfd1dbb4a59b479da55e87838fb93d2067 DIFF: https://github.com/llvm/llvm-project/commit/03cc52dfd1dbb4a59b479da55e87838fb93d2067.diff LO

[PATCH] D143617: [Clang][CMake] Break out Instrument from CLANG_BOLT option

2023-02-08 Thread Amir Ayupov via Phabricator via cfe-commits
Amir created this revision. Amir added a reviewer: bolt. Herald added a project: All. Amir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Split up and refactor CLANG_BOLT_INSTRUMENT into pieces that would work with other profiling modes, n

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

2023-02-08 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. In D143546#4113730 , @rsmith wrote: > I wonder if this can be fixed more generally by using > `TokenConcatenation::AvoidConcat` to determine whether `clang-format` should > require a space between two tokens. Probabtly not as c

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

2023-02-08 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. In D143546#4113721 , @rymiel wrote: > In D143546#4112077 , @owenpan wrote: > >> As this one is an invalid-code-generation bug, I wanted it fixed ASAP. > > Do you intend to backport it to t

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

2023-02-08 Thread Mark Danial via Phabricator via cfe-commits
madanial updated this revision to Diff 496027. madanial added a comment. Rebase, as well as bug fix relating to the ExternalNameConversion pass option that was exposed by the requested fir-opt test case. The pass option was being overwritten by default value whenever it was called through fir-op

[PATCH] D143630: [clang] update test case

2023-02-08 Thread Chunyang, Dai via Phabricator via cfe-commits
cdai2 created this revision. Herald added a subscriber: pengfei. Herald added a project: All. cdai2 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D143630 Files: clang/test

[PATCH] D143472: [clang] Cast the pointer to right type with different address space

2023-02-08 Thread Chunyang, Dai via Phabricator via cfe-commits
cdai2 updated this revision to Diff 496033. cdai2 added a comment. [clang] update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143472/new/ https://reviews.llvm.org/D143472 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/X8

<    1   2