[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 532800. eopXD added a comment. Fix ManualCodegen for vfadd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/include/clang/Basic/riscv_vector.td clang/i

[clang-tools-extra] ab32cc6 - [include-cleaner] Bailout on invalid code for the command-line tool

Author: Haojian Wu Date: 2023-06-20T09:07:27+02:00 New Revision: ab32cc6c02f539bc87e71fefc9670f28a7fc7f56 URL: https://github.com/llvm/llvm-project/commit/ab32cc6c02f539bc87e71fefc9670f28a7fc7f56 DIFF: https://github.com/llvm/llvm-project/commit/ab32cc6c02f539bc87e71fefc9670f28a7fc7f56.diff LO

[PATCH] D153271: [include-cleaner] Bailout on invalid code for the command-line tool

This revision was automatically updated to reflect the committed changes. Closed by commit rGab32cc6c02f5: [include-cleaner] Bailout on invalid code for the command-line tool (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153271/

[PATCH] D152696: Prevent deadlocks in death tests.

mboehme added a comment. In D152696#4430238 , @mgorny wrote: > This change is causing a lot of unittests to fail on Gentoo. I've tested both > on amd64 and arm64; on amd64 additionally the test suite seems to hang. > ... Sorry, only just saw this now. I

[PATCH] D153321: [OpenMP] Fix lvalue reference type generation in untied task loop

eastb233 created this revision. eastb233 added a reviewer: ABataev. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. eastb233 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald add

[PATCH] D153251: [clangd] Index the type of a non-type template parameter

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153251/new/ https://reviews.llvm.org/D153251

[PATCH] D153251: [clangd] Index the type of a non-type template parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3075023850b: [clangd] Index the type of a non-type template parameter (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153251/new/ https

[clang] c307502 - [clangd] Index the type of a non-type template parameter

Author: Nathan Ridge Date: 2023-06-20T03:22:52-04:00 New Revision: c3075023850bbb7276085198d42b69938d48380d URL: https://github.com/llvm/llvm-project/commit/c3075023850bbb7276085198d42b69938d48380d DIFF: https://github.com/llvm/llvm-project/commit/c3075023850bbb7276085198d42b69938d48380d.diff

[PATCH] D152696: Prevent deadlocks in death tests.

mgorny added a comment. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152696/new/ https://reviews.llvm.org/D152696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

mstorsjo added a comment. This change triggers failed asserts when compiling code for at least arm and aarch64. It is reproducible with this reduced testcase: $ cat repro.c typedef long long a; typedef int b(); int c, d; long e, f; short g, j; void *h; short i[]; char k; a l,

[PATCH] D153314: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

nikic added inline comments. Comment at: clang/lib/CodeGen/CGNonTrivialStruct.cpp:370 llvm::Value *DstArrayEnd = CGF.Builder.CreateInBoundsGEP(CGF.Int8Ty, BC.getPointer(), SizeInBytes); DstArrayEnd = CGF.Builder.CreateBitCast( Only `BC.getPoin

[PATCH] D153006: [clang][dataflow] Perform deep copies in copy and move operations.

mboehme updated this revision to Diff 532812. mboehme added a comment. Now that integer literals are associated with `Value`s, use them in tests instead of using a helper variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153006/new/ https://r

[PATCH] D153282: [clang][DebugInfo] Emit DW_AT_deleted on any deleted member function

This revision was automatically updated to reflect the committed changes. Closed by commit rGc146df961876: [clang][DebugInfo] Emit DW_AT_deleted on any deleted member function (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[clang] c146df9 - [clang][DebugInfo] Emit DW_AT_deleted on any deleted member function

Author: Michael Buch Date: 2023-06-20T09:19:19+01:00 New Revision: c146df9618764d5548c38ce61edc45147094b26f URL: https://github.com/llvm/llvm-project/commit/c146df9618764d5548c38ce61edc45147094b26f DIFF: https://github.com/llvm/llvm-project/commit/c146df9618764d5548c38ce61edc45147094b26f.diff

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added a comment. There are some test failures. I believe there is one bug with the handling of unnamed globals. Previously we produced this: ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --check-globals --version 2 ; RUN: opt -S < %s | FileCheck

[PATCH] D153197: [AVR] Expand shifts during AVRISelLowering

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRISelLowering.cpp:2207 + MF->push_back(LoopBB); + MachineBasicBlock *ExitBB = EntryBB->splitAt(MI, false); + Patryk27 wrote: > Alright, this is wrong, after all - I've just tested it on a more e

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

eopXD updated this revision to Diff 532828. eopXD added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151397 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Sema/SemaChecking.c

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

eopXD updated this revision to Diff 532830. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152879/new/ https://reviews.llvm.org/D152879 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Sema/SemaChecking.

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

Fznamznon updated this revision to Diff 532831. Fznamznon added a comment. Rebase, fix nit, expand the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153294/new/ https://reviews.llvm.org/D153294 Files: clang/docs/ReleaseNotes.rst clang/lib

[PATCH] D153292: [Driver][BareMetal] Error if no matching multilib

simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. LGTM. One of the thoughts I mentioned offline before this patch was written was that maybe the error would need to be conditional, via a directive inside `multilib.yaml` itself –

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 532836. eopXD added a comment. Rebase: Add `sew` parameter that other templates have added too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/include/c

[PATCH] D153292: [Driver][BareMetal] Error if no matching multilib

michaelplatings marked an inline comment as done. michaelplatings added a comment. Thanks @simon_tatham. I agree there's definitely scope to improve this. The behaviour is quite specific so I kept the code in the BareMetal toolchain rather than as part of the core Multilib class. Other toolchain

[PATCH] D153314: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:1474 Address AtomicInfo::emitCastToAtomicIntPointer(Address addr) const { llvm::IntegerType *ty = as it no longer emits anything. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 532837. abel-bernabeu added a comment. I just this flashback... For code coverage of one of the Lex() calls in ParseInstruction we needed one case where an instruction has no operands. We had, not one, but three. Am keeping just the "nop" case, which

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 532839. eopXD added a comment. Add SemaChecking and corresponding test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/include/clang/Basic/riscv_ve

[PATCH] D144970: [llvm-c] Remove bindings for creating legacy passes

yamt added a comment. at least some of these stuff is used by wasm-micro-runtime. do you have a suggestion about how to adapt it? https://github.com/bytecodealliance/wasm-micro-runtime/blob/72fc872afe9a51228b2a32bc7b08475b176f187f/core/iwasm/compilation/aot_compiler.c#L2666-L2670 Repository:

[PATCH] D144970: [llvm-c] Remove bindings for creating legacy passes

nikic added a comment. In D144970#4434305 , @yamt wrote: > at least some of these stuff is used by wasm-micro-runtime. do you have a > suggestion about how to adapt it? > https://github.com/bytecodealliance/wasm-micro-runtime/blob/72fc872afe9a51228b2a32b

[PATCH] D153176: [Frontend] Remove ShowIncludesPretendHeader

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153176/new/ https://reviews.llvm.org/D153176 ___ cfe

[clang] 1c64c41 - [clang][index] Fix cast warning

Author: Jan Svoboda Date: 2023-06-20T12:22:18+02:00 New Revision: 1c64c414ed6a7ba2973f881a380d322adb5767a2 URL: https://github.com/llvm/llvm-project/commit/1c64c414ed6a7ba2973f881a380d322adb5767a2 DIFF: https://github.com/llvm/llvm-project/commit/1c64c414ed6a7ba2973f881a380d322adb5767a2.diff L

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

jansvoboda11 added inline comments. Comment at: clang/tools/libclang/CXFile.h:18 +inline CXFile makeCXFile(OptionalFileEntryRef FE) { + return CXFile(FE ? &FE->getMapEntry() : nullptr); +} uabelho wrote: > Gcc warns here: > ``` > ../../clang/tools/libclang/CXFil

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin updated this revision to Diff 532853. yronglin added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153296/new/ https://reviews.llvm.org/D153296 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/switch.cpp

[clang] 36d5034 - [clang][NFC] Drop alignment in builtin-nondeterministic-value test

Author: ManuelJBrito Date: 2023-06-20T11:38:37+01:00 New Revision: 36d50348a8b12db01d786c5fa3d0ed7a911e1f68 URL: https://github.com/llvm/llvm-project/commit/36d50348a8b12db01d786c5fa3d0ed7a911e1f68 DIFF: https://github.com/llvm/llvm-project/commit/36d50348a8b12db01d786c5fa3d0ed7a911e1f68.diff

[PATCH] D152547: [clang][NFC] Drop alignment in builtin-nondeterministic-value test

This revision was automatically updated to reflect the committed changes. Closed by commit rG36d50348a8b1: [clang][NFC] Drop alignment in builtin-nondeterministic-value test (authored by ManuelJBrito). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

hans added a comment. We're seeing assertion failures in Chromium too. Reproducer for x86_64 Linux here: https://bugs.chromium.org/p/chromium/issues/detail?id=1456288#c2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llv

[clang] 6bea833 - Revert "Reland "[DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)" (2)"

Author: Vladislav Dzhidzhoev Date: 2023-06-20T13:08:47+02:00 New Revision: 6bea8331f9e09ba94a225c65becd4224a1a473af URL: https://github.com/llvm/llvm-project/commit/6bea8331f9e09ba94a225c65becd4224a1a473af DIFF: https://github.com/llvm/llvm-project/commit/6bea8331f9e09ba94a225c65becd4224a1a473a

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev added a comment. Thank you for reports! I've reverted it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D153330: [include-cleaner] Ignore the ParmVarDecl itself in WalkAST.cpp

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: kristof.beyls. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. This will fix a false positive where a ParamVarDecl happend to be the same na

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg created this revision. massberg added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. In C++20 some

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

sammccall added a comment. Thanks, this looks pretty good! > I'm not sure if I the hover test which is added in this patch is the right > one, > but at least is passed with this patch and fails without it :) This is nice to have, but you add a unittest to FindTargetTest too? That's the most di

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg updated this revision to Diff 532867. massberg added a comment. Fix test name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153331/new/ https://reviews.llvm.org/D153331 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn updated this revision to Diff 532868. hnrklssn marked 4 inline comments as done. hnrklssn added a comment. Added back regex matchers for anonymous global values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/ https://reviews.llvm

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added a comment. In D148216#4434171 , @nikic wrote: > There are some test failures. > > I believe there is one bug with the handling of unnamed globals. Previously > we produced this: > > ; NOTE: Assertions have been autogenerated by utils/upd

[PATCH] D153330: [include-cleaner] Ignore the ParmVarDecl itself in WalkAST.cpp

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:219 +// as they don't contribute to the main-file #include. +if (isa(VD)) + return true

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

arsenm added a comment. I think this may not hard break mesa. I believe mesa bypasses the intrinsic creation API, and just declares the string name of the intrinsic. The type name mangling suffix is technically irrelevant, and as long as you use a consistent type with a consistent suffix things

[clang-tools-extra] 149f309 - [include-cleaner] Ignore the ParmVarDecl itself in WalkAST.cpp

Author: Haojian Wu Date: 2023-06-20T14:26:55+02:00 New Revision: 149f309f50cd981ed320c948f772aa571eaa9afa URL: https://github.com/llvm/llvm-project/commit/149f309f50cd981ed320c948f772aa571eaa9afa DIFF: https://github.com/llvm/llvm-project/commit/149f309f50cd981ed320c948f772aa571eaa9afa.diff LO

[PATCH] D153330: [include-cleaner] Ignore the ParmVarDecl itself in WalkAST.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG149f309f50cd: [include-cleaner] Ignore the ParmVarDecl itself in WalkAST.cpp (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D153330?vs=532863&id=532870#toc Repository: rG LLV

[clang] 8784b6a - [Clang] Allow bitcode linking when the input is LLVM-IR

Author: Joseph Huber Date: 2023-06-20T08:02:58-05:00 New Revision: 8784b6a8540f4a333690e7233587859f1d82f620 URL: https://github.com/llvm/llvm-project/commit/8784b6a8540f4a333690e7233587859f1d82f620 DIFF: https://github.com/llvm/llvm-project/commit/8784b6a8540f4a333690e7233587859f1d82f620.diff

[clang] efacdfc - [LinkerWrapper] Support linking vendor bitcode late

Author: Joseph Huber Date: 2023-06-20T08:02:59-05:00 New Revision: efacdfc235e327341d2b8a733d9963fb526cf17b URL: https://github.com/llvm/llvm-project/commit/efacdfc235e327341d2b8a733d9963fb526cf17b DIFF: https://github.com/llvm/llvm-project/commit/efacdfc235e327341d2b8a733d9963fb526cf17b.diff

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

This revision was automatically updated to reflect the committed changes. Closed by commit rG8784b6a8540f: [Clang] Allow bitcode linking when the input is LLVM-IR (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152391/new/ https

[PATCH] D152442: [LinkerWrapper] Support linking vendor bitcode late

This revision was automatically updated to reflect the committed changes. Closed by commit rGefacdfc235e3: [LinkerWrapper] Support linking vendor bitcode late (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152442/new/ https://r

[PATCH] D153338: [clang-format] vim integration: Mention python3 variant of bindings

jsilvanus created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. jsilvanus requested review of this revision. Herald added a comment. NOTE: Clang-Format Team Automa

[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

sepavloff created this revision. sepavloff added reviewers: rjmccall, aaron.ballman, arsenm, kpn, qiucf, efriedma. Herald added a project: All. sepavloff requested review of this revision. Herald added a subscriber: wdng. Herald added a project: clang. Builtin function `__builtin_isfpclass` now c

[PATCH] D153340: [include-cleaner] Add an IgnoreHeaders flag to the command-line tool.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D153340 Files: clang-tools-extra/include-cleaner/tes

[PATCH] D153248: [clangd] Use resolveTypeToRecordDecl() to resolve the type of a base specifier during heuristic resolution

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. OK, fair enough. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153248/new/ https://reviews.llvm.org/D153248 ___

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:131 return HighlightingKind::Interface; - if (isa(D)) + if (isa(D)) return HighlightingKind::Namespace; kadircet wrote: > let's do this in a separate change,

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

nlopes added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPULateCodeGenPrepare.cpp:213 + +Value *Result = UndefValue::get(Ty); +for (int i = 0; i < EC; i += 1 + is16Bit) { Please use poison wherever possible. In this case it seems it's just a

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPULateCodeGenPrepare.cpp:209 +bool is16Bit = +(EltType->isIntegerTy() && EltType->getIntegerBitWidth() == 16) || +(EltType->isHalfTy()); isIntegerTy(16). Also, just check the

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

arsenm added inline comments. Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.readlane.ll:5 +declare i16 @llvm.amdgcn.readlane.i16(i16, i32) #0 +declare half @llvm.amdgcn.readlane.f16(half, i32) #0 +declare float @llvm.amdgcn.readlane.f32(float, i32) #0 arsenm w

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg updated this revision to Diff 532921. massberg added a comment. Add test to FindTargetTests and extend test in HoverTests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153331/new/ https://reviews.llvm.org/D153331 Files: clang-tools-ext

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg marked 2 inline comments as done. massberg added a comment. Thanks for the comments, I have added an additional test to FindTargetTest. See also my other comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:4051 +TEST(Hover, RewrittenBinaryOperato

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:648 + {"bool operator==(const Foo &) const noexcept = default", +Re

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, tbaeder, cjdb, shafik. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. Now that clang supports printing of multiple lines of code snippet in diagnostics, source rang

[clang] bca11ba - [clang-format] Add InsertNewlineAtEOF to .clang-format files

Author: Owen Pan Date: 2023-06-20T08:30:09-07:00 New Revision: bca11bafba9788dd80135b76a187c5f00e64f735 URL: https://github.com/llvm/llvm-project/commit/bca11bafba9788dd80135b76a187c5f00e64f735 DIFF: https://github.com/llvm/llvm-project/commit/bca11bafba9788dd80135b76a187c5f00e64f735.diff LOG:

[PATCH] D153208: [clang-format] Add InsertNewlineAtEOF to .clang-format files

This revision was automatically updated to reflect the committed changes. Closed by commit rGbca11bafba97: [clang-format] Add InsertNewlineAtEOF to .clang-format files (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153208/new/

[PATCH] D153362: [clang][DebugInfo] Emit DW_AT_defaulted for defaulted C++ member functions

Michael137 created this revision. Michael137 added reviewers: dblaikie, aprantl. Herald added a subscriber: hiraditya. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch impl

[PATCH] D153362: [clang][DebugInfo] Emit DW_AT_defaulted for defaulted C++ member functions

Michael137 updated this revision to Diff 532952. Michael137 added a comment. Herald added a subscriber: ormris. - remove redundant includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153362/new/ https://reviews.llvm.org/D153362 Files: clang/l

[PATCH] D153205: [clang-format] Add new block type ListInit

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/FormatToken.cpp:79 bool FormatToken::opensBlockOrBlockTypeList(const FormatStyle &Style) const { + auto bk = getBlockKind(); // C# Does not indent object initialisers as continuations. Hazard

[PATCH] D153205: [clang-format] Add new block type ListInit

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25511 + // Designated initializers. + verifyFormat("int LongVariable[1] = {\n" + "[0] = 1000, [1] = 2000\n" nit [2] Repos

[PATCH] D153205: [clang-format] Add new block type ListInit

MyDeveloperDay added a comment. In principle I like this as its annoyed me for years Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153205/new/ https://reviews.llvm.org/D153205 ___ cfe-commits mailing lis

[PATCH] D153363: [clang][analyzer] No end-of-file when seek to file begin.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D153362: [clang][DebugInfo] Emit DW_AT_defaulted for defaulted C++ member functions

Michael137 updated this revision to Diff 532957. Michael137 added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153362/new/ https://reviews.llvm.org/D153362 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenC

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

egorzhdan added a comment. @compnerd @martong would you be OK with merging this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92797/new/ https://reviews.llvm.org/D92797 ___ cfe-commits mailing lis

[PATCH] D151963: [clang][NFC] Remove trailing whitespaces and enforce it in lib, include and docs

paulkirth accepted this revision. paulkirth added a comment. Herald added a subscriber: wangpc. Also LGTM for the changes in MisExpect.rst, modulo feedback from @erichkeane. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151963/new/ https://reviews.

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

schittir added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:887 + else { +assert(DeepestParsedCaseStmt && "DeepestParsedCaseStmt cannot be null"); Actions.ActOnCaseStmtBody(DeepestParsedCaseStmt, Case.get()); Fznamznon wrote:

[PATCH] D153235: [RISCV] Change the type of argument to clz and ctz from ZiZi/WiWi to iUZi/iUWi

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153235/new/ https://reviews.llvm.org/D153235 ___

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall created this revision. Herald added subscribers: martong, mgrang, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is the first step in untangling

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

ilya-biryukov added a comment. As mentioned in the GH issue, I think this change looks fine. But I would suggest waiting for feedback from @rsmith to ensure there isn't a reason for cleanups being removed that we are missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo updated this revision to Diff 532964. VitaNuo marked 8 inline comments as done. VitaNuo added a comment. Herald added a subscriber: javed.absar. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152900/new/ https://revi

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:393-395 +const auto *FileEntry = SM.getFileEntryForID(FID); +for (const auto *Export : PI.getExporters(FileEntry, SM.getFileManager())) + return toURI(E

[PATCH] D153205: [clang-format] Add new block type ListInit

gedare added a comment. In D153205#4431235 , @HazardyKnusperkeks wrote: > You add a lot of checks and I honestly can't say if it does not affect other > code that is not covered by the tests. Not much I can do about that. I guess it is worth noting tha

[PATCH] D153205: [clang-format] Add new block type ListInit

gedare updated this revision to Diff 532967. gedare added a comment. Do not use temporary variable for getBlockKind(). Fix test case syntax errors. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153205/new/ https://reviews.llvm.org/D

[PATCH] D142994: [UsersManual] Add llvm-progen as an alternative tool for AutoFDO profile generation.

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142994/new/ https://reviews.llvm.org/D142994 _

[PATCH] D153369: [OpenMP] Always apply target declarations to canonical definitions

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, tra, ABataev, carlo.bertolli. Herald added subscribers: sunshaoce, guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, jplehr, ss

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6784 + if (II->getInterestingIdentifierID() != 0) +NewTD->addAttr(AvailableOnlyInDefaultEvalMethodAttr::Create(Context)); } Please switch over the interesting identifiers he

[clang-tools-extra] 6fe9cfe - [clangd] Use resolveTypeToRecordDecl() to resolve the type of a base specifier during heuristic resolution

Author: Nathan Ridge Date: 2023-06-20T13:40:26-04:00 New Revision: 6fe9cfe4137bc140c909850c26b52e9406495566 URL: https://github.com/llvm/llvm-project/commit/6fe9cfe4137bc140c909850c26b52e9406495566 DIFF: https://github.com/llvm/llvm-project/commit/6fe9cfe4137bc140c909850c26b52e9406495566.diff

[PATCH] D153248: [clangd] Use resolveTypeToRecordDecl() to resolve the type of a base specifier during heuristic resolution

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fe9cfe4137b: [clangd] Use resolveTypeToRecordDecl() to resolve the type of a base specifier… (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

sunfish added a comment. In D150803#4419436 , @sbc100 wrote: > Did you mean to comment on the old PR? This new PR doesn't propose either > "jspi" or "async", but adds that ability to define custom attributes.. since > that was deemed more flexible and

[PATCH] D153370: [RISCV] Add support for custom instructions for Sifive S76.

garvitgupta08 created this revision. garvitgupta08 added reviewers: asb, apazos, jrtc27. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, z

[PATCH] D152953: [clang-tidy] Introduce fuchsia-global-variables check

Caslyn created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, abrachet, phosek, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. Caslyn updated this revision to Diff 531489. Caslyn added a comment. Caslyn updated this revision to Diff 531932. Caslyn upda

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5510f0b8f4b1: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction… (authored by eopXD). Repository: rG LLVM Github Monore

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ed668ad9321: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1528

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 532996. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/include/clang/Basic/riscv_vector.td clang/include

[PATCH] D153369: [OpenMP] Always apply target declarations to canonical definitions

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:23099 +CD->addAttr(A); if (ASTMutationListener *ML = Context.getASTMutationListener()) ML->DeclarationMarkedOpenMPDeclareTarget(D, A); Need to use M

[PATCH] D153369: [OpenMP] Always apply target declarations to canonical definitions

jhuber6 updated this revision to Diff 533000. jhuber6 added a comment. Adding AST mutation listener to the other modified declaration to signal that it was changed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153369/new/ https://reviews.llvm.org

[PATCH] D153369: [OpenMP] Always apply target declarations to canonical definitions

jhuber6 updated this revision to Diff 533002. jhuber6 added a comment. Fix logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153369/new/ https://reviews.llvm.org/D153369 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/AST/dump.cpp Index: c

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6784 + if (II->getInterestingIdentifierID() != 0) +NewTD->addAttr(AvailableOnlyInDefaultEvalMethodAttr::Create(Context)); } rjmccall wrote: > Please switch over the interest

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

brendandahl added a comment. @aaron.ballman or @erichkeane Did you want to re-review after that latest changes (more generic attribute) or are things good to go? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D1

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm updated this revision to Diff 533007. arsenm marked an inline comment as done. arsenm added a comment. Keep fixing documentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233 Files: clang/docs/LanguageExtensions.rst clang/docs/Rel

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

hoy added a comment. Hello, I'm seeing a build failure that seems related to this patch. I'm seeing the patch has been relanded and reverted a couple times and not sure where it is right now. Can you please confirm if the failure is related and fixed? Thanks. 2023-06-20T05:19:14.441-07:00] Std

[PATCH] D153281: [flang] add -flang-experimental-polymorphism flag to flang-new

awarzynski accepted this revision. awarzynski added a comment. LGTM, thanks David! Could you also add a test in https://github.com/llvm/llvm-project/blob/main/flang/test/Driver/frontend-forwarding.f90? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

  1   2   >