[clang] adece4e - [clang-format][NFC] Remove superfluous code in UnwrappedLineParser

2023-08-01 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-01T13:31:24-07:00 New Revision: adece4e452e88f47e1b2b7971286906ae5246fb8 URL: https://github.com/llvm/llvm-project/commit/adece4e452e88f47e1b2b7971286906ae5246fb8 DIFF: https://github.com/llvm/llvm-project/commit/adece4e452e88f47e1b2b7971286906ae5246fb8.diff LOG:

[PATCH] D156643: [clang-format][NFC] Remove superfluous code in UnwrappedLineParser

2023-08-01 Thread Owen Pan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGadece4e452e8: [clang-format][NFC] Remove superfluous code in UnwrappedLineParser (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156643/

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

2023-08-01 Thread Nikolas Klauser via Phabricator via cfe-commits
philnik added a comment. @aaron.ballman I think what @danlark means is that when building clang against a libc++ which has debug assertions enabled, the clang tests he mentioned result in an assertion firing within libc++. i.e. the libc++ debug mode catches the non-strict weak ordering that it

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

2023-08-01 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:290 + "encoding prefix '%0' on an unevaluated string literal has no effect" + "%select{| and is incompatible with c++2c}1">, + InGroup>; aaron.ballman wro

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

2023-08-01 Thread Paul Robinson via Phabricator via cfe-commits
probinson added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1761 + S.FFDiag(Loc, diag::note_constexpr_invalid_cast) + << static_cast(Kind) << S.Current->getRange(OpPC); + return false; Would you mind changing this cast from `uint8_t` to `uns

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

2023-08-01 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:3270-3339 +// Instantiate packed data members. +if (FieldDecl *Field = dyn_cast(Member); +Field && isa(Field->getType().getTypePtr())) { + QualType PatternType = Field->getType

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

2023-08-01 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:290 + "encoding prefix '%0' on an unevaluated string literal has no effect" + "%select{| and is incompatible with c++2c}1">, + InGroup>; hubert.reinterpretcast wrote: >

[clang] 400da11 - [clang-format] Fix braced initializer with templated base class

2023-08-01 Thread Owen Pan via cfe-commits
Author: Galen Elias Date: 2023-08-01T13:53:22-07:00 New Revision: 400da115c58ae19445cfdc871a3f559f160fc5c6 URL: https://github.com/llvm/llvm-project/commit/400da115c58ae19445cfdc871a3f559f160fc5c6 DIFF: https://github.com/llvm/llvm-project/commit/400da115c58ae19445cfdc871a3f559f160fc5c6.diff L

[PATCH] D156705: [clang-format] Fix braced initializer formatting with templated base class initializer

2023-08-01 Thread Owen Pan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG400da115c58a: [clang-format] Fix braced initializer with templated base class (authored by galenelias, committed by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

2023-08-01 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. I think the test we want is a set of classes and virtuaal fuc In D155809#4551686 , @philnik wrote: > @aaron.ballman I think what @danlark means is that when building clang > against a libc++ which has debug assertions enabled,

[clang] 51a014c - [Clang][CodeGen] `__builtin_alloca`s should care about address spaces

2023-08-01 Thread Alex Voicu via cfe-commits
Author: Alex Voicu Date: 2023-08-01T21:55:36+01:00 New Revision: 51a014cb2d9c6f8303f9b11ffc035d69cbeb9e21 URL: https://github.com/llvm/llvm-project/commit/51a014cb2d9c6f8303f9b11ffc035d69cbeb9e21 DIFF: https://github.com/llvm/llvm-project/commit/51a014cb2d9c6f8303f9b11ffc035d69cbeb9e21.diff LO

[PATCH] D156539: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces too

2023-08-01 Thread Alex Voicu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. AlexVlx marked an inline comment as done. Closed by commit rG51a014cb2d9c: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces (authored by AlexVlx).

[PATCH] D155870: [Clang][CodeGen] Another follow-up for `vtable`, `typeinfo` et al. are globals

2023-08-01 Thread Alex Voicu via Phabricator via cfe-commits
AlexVlx added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155870/new/ https://reviews.llvm.org/D155870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

2023-08-01 Thread Jon Roelofs via Phabricator via cfe-commits
jroelofs updated this revision to Diff 546219. jroelofs added a comment. Rebase. Avoid the dependency on D156735 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105671/new/ https://reviews.llvm.org/D105671 Files:

[PATCH] D156718: [ASanStableABI][Driver] Stop linking to asan dylib when stable abi is enabled

2023-08-01 Thread Roy Sundahl via Phabricator via cfe-commits
rsundahl accepted this revision. rsundahl added a comment. This revision is now accepted and ready to land. This looks good to me. Thanks for the additional clean-up @thetruestblue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156718/new/ https://reviews.llvm.org/D156718 _

[PATCH] D156474: [-Wunsafe-buffer-usage][NFC] Slightly refactor and optimize the code

2023-08-01 Thread Rashmi Mudduluru via Phabricator via cfe-commits
t-rasmud added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2179 + if (FixItsForVariable.count(GrpMate)) +FinalFixItsForVariable[Var].insert(FinalFixItsForVariable[Var].end(), + FixItsForVariable[GrpM

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

2023-08-01 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/docs/ReleaseNotes.rst:74-76 +- ``structs``, ``unions``, and ``arrays`` that are const may now be used as + constant expressions. This change is more consistent with the behavior of + GCC. Note to self: I

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

2023-08-01 Thread Danila Kutenin via Phabricator via cfe-commits
danlark added a comment. In D155809#4551721 , @cor3ntin wrote: > I think the test we want is a set of classes and virtuaal fuc > > In D155809#4551686 , @philnik wrote: > >> @aaron.ballman I think what @danlark mea

[PATCH] D156474: [-Wunsafe-buffer-usage][NFC] Slightly refactor and optimize the code

2023-08-01 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1143 + // order is deterministic: + CompareNode> + byVar; ziqingluo-90 wrote: > To make the order of variables in every group deterministic. Would it make sen

[PATCH] D156474: [-Wunsafe-buffer-usage][NFC] Slightly refactor and optimize the code

2023-08-01 Thread Rashmi Mudduluru via Phabricator via cfe-commits
t-rasmud added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1143 + // order is deterministic: + CompareNode> + byVar; NoQ wrote: > ziqingluo-90 wrote: > > To make the order of variables in every group deterministi

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

2023-08-01 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. I glanced at the patch. The code seems reasonable. Comment at: clang/test/lit.cfg.py:383 -# The llvm-nm tool supports an environment variable "OBJECT_MODE" on AIX OS, which +# Some tool support an environment variable "OBJECT_MODE" on AIX OS, which

[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

2023-08-01 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. > We also are tied to OpenCL semantic of future versions. This is what I would like to avoid aliasing to OpenCL and then starting to change it in a way that is not conforming or documented. Maybe there is a need for something like an address space for the group of rel

[PATCH] D156474: [-Wunsafe-buffer-usage][NFC] Slightly refactor and optimize the code

2023-08-01 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1143 + // order is deterministic: + CompareNode> + byVar; t-rasmud wrote: > NoQ wrote: > > ziqingluo-90 wrote: > > > To make the order of variables in every g

[PATCH] D156743: clang/OpenCL: Add inline implementations of sqrt in builtin header

2023-08-01 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:832 + +inline float __ovld __cnfn sqrt(float __x) { + return __builtin_elementwise_sqrt(__x); Is this a generic implementation enough? Would some targets not need to do something dif

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

2023-08-01 Thread Zenong Zhang via Phabricator via cfe-commits
SlaterLatiao updated this revision to Diff 546257. SlaterLatiao added a comment. - Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156546/new/ https://reviews.llvm.org/D156546 Files: clang/lib/Sema/SemaTemplateInstantiate.

[clang] 82b94a9 - Fix the linting problems in UnsafeBufferUsage.cpp

2023-08-01 Thread via cfe-commits
Author: Amirreza Ashouri Date: 2023-08-01T16:17:40-07:00 New Revision: 82b94a9f7be9474acd0a950ce521c439057066be URL: https://github.com/llvm/llvm-project/commit/82b94a9f7be9474acd0a950ce521c439057066be DIFF: https://github.com/llvm/llvm-project/commit/82b94a9f7be9474acd0a950ce521c439057066be.di

[PATCH] D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1.

2023-08-01 Thread Ziqing Luo via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82b94a9f7be9: Fix the linting problems in UnsafeBufferUsage.cpp (authored by AMP999, committed by ziqingluo-90). Changed prior to commit: https://

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

2023-08-01 Thread Zenong Zhang via Phabricator via cfe-commits
SlaterLatiao marked an inline comment as done. SlaterLatiao added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:3289-3290 + Fields.push_back(PackedField); + if (NewMember->isInvalidDecl()) +Instantiation->setInvalidDecl(); +

[PATCH] D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1.

2023-08-01 Thread Ziqing Luo via Phabricator via cfe-commits
ziqingluo-90 added a comment. Hi @AMP999 I have committed this patch on behalf of you. Unfortunately, I cannot amend an old commit for you as it will cause rewriting a bunch of the history. I made a correction message along with the commit. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

2023-08-01 Thread Artem Labazov via Phabricator via cfe-commits
artem updated this revision to Diff 546261. artem added a comment. Fixed comments and failing test. Added a new compiler-rt test for ubsan CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/Cod

[PATCH] D156762: [-Wunsafe-buffer-usage][NFC] Refactor `getFixIts`---where fix-its are generated

2023-08-01 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. I really like this! Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2178 + // `FixItsForVariable` will map each variable to a set of fix-its directly + // associated to the variable itself. Fix-its of distict variables in + // `FixItsForVariable` a

[PATCH] D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1.

2023-08-01 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Looks like rG910450a28ba9c has independently addressed both issues. But at least we had a chance to deal with the injustice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

2023-08-01 Thread Eduard Zingerman via Phabricator via cfe-commits
eddyz87 added a comment. Hi @dblaikie Thank you for the detailed response! > So you get some bunch of annotations from the BTFTagAttributedType, then you > build the underlying type (which might already be built/needed/fine because > it's used without attributes in other places/needs to exist

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

2023-08-01 Thread Artem Labazov via Phabricator via cfe-commits
artem updated this revision to Diff 546269. artem added a comment. typo fix CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CodeGenFunction.h clang/test/CodeGen/PowerPC/builtins-pp

[PATCH] D156762: [-Wunsafe-buffer-usage][NFC] Refactor `getFixIts`---where fix-its are generated

2023-08-01 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2219 + // cannot be fixed... + eraseVarsForUnfixableGroupMates(FixItsForVariable, VarGrpMgr); + // Now `FixItsForVariable` gets further reduced: a variable is in Architecturally sp

[PATCH] D156762: [-Wunsafe-buffer-usage][NFC] Refactor `getFixIts`---where fix-its are generated

2023-08-01 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2219 + // cannot be fixed... + eraseVarsForUnfixableGroupMates(FixItsForVariable, VarGrpMgr); + // Now `FixItsForVariable` gets further reduced: a variable is in NoQ wrote: > Archi

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

2023-08-01 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. I think another option could be to do this in SemaChecking.cpp where we implement __builtin_riscv_ntl_load and __builtin_riscv_ntl_store. We already do custom type checking there. We could detect the missing argument and give it a default. Repository: rG LLVM G

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

2023-08-01 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. OOo down to ±300, I love this!! I'll take a closer look tomorrow. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1891-1892 + for (unsigned i = 0; i < NumParms; i++) { +if (!ParmsMask[i]) + continue; + Speaking of [[ https://

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

2023-08-01 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. Please update llvm/docs/RISCVUsage.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 ___ cfe-commits mailing list cfe-commits@li

[clang] ed83797 - [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

2023-08-01 Thread Jon Roelofs via cfe-commits
Author: Jon Roelofs Date: 2023-08-01T18:02:00-07:00 New Revision: ed83797f3cbfc8fb2a1af63542f97d7ec1d5505a URL: https://github.com/llvm/llvm-project/commit/ed83797f3cbfc8fb2a1af63542f97d7ec1d5505a DIFF: https://github.com/llvm/llvm-project/commit/ed83797f3cbfc8fb2a1af63542f97d7ec1d5505a.diff L

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

2023-08-01 Thread Jon Roelofs via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGed83797f3cbf: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn. (authored by jroelofs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105671/new

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

2023-08-01 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:233 +def uimm10 : Operand, ImmLeaf(Imm);}]> { + let ParserMatchClass = UImmAsmOperand<10>; Is this used? Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo

[PATCH] D156718: [ASanStableABI][Driver] Stop linking to asan dylib when stable abi is enabled

2023-08-01 Thread Mariusz Borsa via Phabricator via cfe-commits
wrotki accepted this revision. wrotki added a comment. Yes, it looks good. I downloaded the patch and ran the test - had some doubts about 'otool -L %t |grep -q "dynamic.dylib"' - but verified with other ASAN tests binaries and convinced myself that it's the right thing to do. CHANGES SINCE L

[PATCH] D156806: [Modules] Add test for merging of template member parent

2023-08-01 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156806/new/ https://reviews.llvm.org/D156806 ___ cfe-commits mailing list cfe-comm

[PATCH] D156771: [clang][hexagon] Handle library path arguments earlier

2023-08-01 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. (After D156363 , newer tests can use `-### -Werror` instead of `-fdriver-only -v -Werror` :) ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156771/new/ https://reviews.llvm.org/D156771 _

[clang] 1c10667 - [AST] Simplify Type::isSizelessBuiltinType(). NFC.

2023-08-01 Thread Jim Lin via cfe-commits
Author: Jim Lin Date: 2023-08-02T10:46:42+08:00 New Revision: 1c1066797c5bb56616dc485b596fd40d5f03ece2 URL: https://github.com/llvm/llvm-project/commit/1c1066797c5bb56616dc485b596fd40d5f03ece2 DIFF: https://github.com/llvm/llvm-project/commit/1c1066797c5bb56616dc485b596fd40d5f03ece2.diff LOG:

[PATCH] D156686: [AST] Simplify Type::isSizelessBuiltinType(). NFC.

2023-08-01 Thread Jim Lin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1c1066797c5b: [AST] Simplify Type::isSizelessBuiltinType(). NFC. (authored by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156686/new/ https://review

[PATCH] D155661: [clang][ASTImporter] Fix friend class template import within dependent context

2023-08-01 Thread Ding Fei via Phabricator via cfe-commits
danix800 added a comment. In D155661#4550340 , @balazske wrote: > The fix looks OK, but the test could be improved and cleaned up (for example > `FromClass` is the same as `FromD` in the test, and DeclContext is not > checked, can be done like in the te

[PATCH] D156201: [ASTImporter] Fix corrupted RecordLayout introduced by circular referenced fields

2023-08-01 Thread Ding Fei via Phabricator via cfe-commits
danix800 added a comment. In D156201#4551464 , @aaron.ballman wrote: > LGTM! > > In D156201#4551332 , @danix800 > wrote: > >> In D156201#4551270 , @steakhal >> wrote: >

[PATCH] D156693: [clang][ASTImporter]Skip check friend template declaration in VisitClassTemplateDecl

2023-08-01 Thread Qizhi Hu via Phabricator via cfe-commits
jcsxky updated this revision to Diff 546301. jcsxky added a comment. update patch for pass unittests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156693/new/ https://reviews.llvm.org/D156693 Files: clang/lib/AST/ASTImporter.cpp clang/test/Ana

[PATCH] D156749: [modules] Fix error about the same module being defined in different .pcm files when using VFS overlays.

2023-08-01 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. In D156749#4551596 , @jansvoboda11 wrote: > What are the performance implications of making VFS overlays part of the > context hash? I don't have specific measurements but for Xcode projects different targets have different VF

[clang] 5f2157f - [clang][ASTImporter] Fix friend class template import within dependent context

2023-08-01 Thread via cfe-commits
Author: dingfei Date: 2023-08-02T11:21:09+08:00 New Revision: 5f2157f8fcaede27ccf4ab215fcb1a4725a36b2a URL: https://github.com/llvm/llvm-project/commit/5f2157f8fcaede27ccf4ab215fcb1a4725a36b2a DIFF: https://github.com/llvm/llvm-project/commit/5f2157f8fcaede27ccf4ab215fcb1a4725a36b2a.diff LOG:

[clang] 91b7952 - [ASTImporter] Fix corrupted RecordLayout caused by circular referenced fields

2023-08-01 Thread via cfe-commits
Author: dingfei Date: 2023-08-02T11:21:10+08:00 New Revision: 91b7952afc82f90e7b810701d9d5c776a8e21688 URL: https://github.com/llvm/llvm-project/commit/91b7952afc82f90e7b810701d9d5c776a8e21688 DIFF: https://github.com/llvm/llvm-project/commit/91b7952afc82f90e7b810701d9d5c776a8e21688.diff LOG:

[PATCH] D155661: [clang][ASTImporter] Fix friend class template import within dependent context

2023-08-01 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5f2157f8fcae: [clang][ASTImporter] Fix friend class template import within dependent context (authored by dingfei ). Changed prior to commit: https://reviews.llvm.org/D155661?vs=545913&

[PATCH] D156201: [ASTImporter] Fix corrupted RecordLayout introduced by circular referenced fields

2023-08-01 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG91b7952afc82: [ASTImporter] Fix corrupted RecordLayout caused by circular referenced fields (authored by dingfei ). Changed prior to commit: https://reviews.llvm.org/D156201?vs=546127&

[PATCH] D96744: clang-format IncludeBlocks: Regroup determination of "main" for framework-style includes fix

2023-08-01 Thread Conrad Poelman via Phabricator via cfe-commits
poelmanc abandoned this revision. poelmanc added a comment. Herald added a project: All. We eventually updated our coding standards and our fairly massive code base to change only the very top "main" include from `#include ` to `#include "Foo.h"`. For all include statements after that, we still

[PATCH] D156693: [clang][ASTImporter]Skip check friend template declaration in VisitClassTemplateDecl

2023-08-01 Thread Qizhi Hu via Phabricator via cfe-commits
jcsxky updated this revision to Diff 546309. jcsxky added a comment. update patch for pass unittests and test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156693/new/ https://reviews.llvm.org/D156693 Files: clang/lib/AST/ASTImporter.cpp clang

[PATCH] D156771: [clang][hexagon] Handle library path arguments earlier

2023-08-01 Thread Brian Cain via Phabricator via cfe-commits
bcain updated this revision to Diff 546314. bcain added a comment. Changed test to use `-Werror -###` instead of `-fdriver-only -v -Werror`. Fixed indentation / `clang-format`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156771/new/ https://revi

[PATCH] D155647: [RISCV] Add C intrinsics for scalar crypto

2023-08-01 Thread Craig Topper via Phabricator via cfe-commits
craig.topper updated this revision to Diff 546315. craig.topper added a comment. Add riscv_bitmanip.h to cover all of Zbb and Zbkb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155647/new/ https://reviews.llvm.org/D155647 Files: clang/lib/Header

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

2023-08-01 Thread Erick Velez via Phabricator via cfe-commits
evelez7 updated this revision to Diff 546317. evelez7 marked 4 inline comments as done. evelez7 added a comment. Address review feedback, add tests, and small refactors. - Add tests for destructors, constructors, and conversion methods. - Remove redundant check-nots in existing tests. - Properly

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

2023-08-01 Thread Erick Velez via Phabricator via cfe-commits
evelez7 added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:770 +template <> +struct has_function_signature : public std::true_type {}; + dang wrote: > Does `CXXInstanceMethodRecord` need one of these as well? `CXXInstanceMethodRecord` inherit

[clang] 244fd4d - [RISCV] Run mem2reg on more scalar C builtin tests to remove allocas and simplify checks. NFC

2023-08-01 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2023-08-01T22:10:54-07:00 New Revision: 244fd4dfc56a0d59655c65adac6a7258114b8af2 URL: https://github.com/llvm/llvm-project/commit/244fd4dfc56a0d59655c65adac6a7258114b8af2 DIFF: https://github.com/llvm/llvm-project/commit/244fd4dfc56a0d59655c65adac6a7258114b8af2.diff

[PATCH] D156851: [RISCV] Merge rv32 and rv64 Zvb* intrinsic tests. NFC

2023-08-01 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision. craig.topper added reviewers: asb, wangpc, kito-cheng, reames. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer0

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

2023-08-01 Thread Erick Velez via Phabricator via cfe-commits
evelez7 updated this revision to Diff 546323. evelez7 added a comment. Add test for overloaded operator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557 Files: clang/include/clang/ExtractAPI/API.h cla

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

2023-08-01 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:1972 +// Control Flow Integerity +include "RISCVInstrInfoZicfiss.td" Put this with the other RISCVInstrInfoZi* files under "Integer" Comment at: llvm/lib/

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

2023-08-01 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 546324. BeMg added a comment. Use semacheck and CGBuiltin to support overload version functionY Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156221/new/ https://reviews.llvm.org/D156221 Files: clang/lib/CodeGe

[clang] 99b5474 - [Modules] Add test for merging of template member parent

2023-08-01 Thread Jonas Hahnfeld via cfe-commits
Author: Jonas Hahnfeld Date: 2023-08-02T08:16:46+02:00 New Revision: 99b54743106bae89217c3591ec7461266dbd00a4 URL: https://github.com/llvm/llvm-project/commit/99b54743106bae89217c3591ec7461266dbd00a4 DIFF: https://github.com/llvm/llvm-project/commit/99b54743106bae89217c3591ec7461266dbd00a4.diff

[PATCH] D156806: [Modules] Add test for merging of template member parent

2023-08-01 Thread Jonas Hahnfeld via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG99b54743106b: [Modules] Add test for merging of template member parent (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156806/new/ htt

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

2023-08-01 Thread Jim Lin via Phabricator via cfe-commits
Jim added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZicfiss.td:33 +let Uses = [SSP] in { +let hasSideEffects = 0, mayLoad = 1, mayStore = 0 in +class RV_SSPop _rd, bits<5> _rs1, string opcodestr, string argstr> : Two `let` lines can be merg

<    1   2   3