[PATCH] D157179: [clang-format] Currectly handle PCIS_CurrentLine with no column limit

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Fixes https://github.com/llvm/llvm-project/issues/63519. Reposito

[PATCH] D157180: [clang-tidy] Exclude class/struct scope variables from cppcoreguidelines-avoid-non-const-global-variables

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp, ccotter. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D157181: [clang-tidy] Re-add cppcoreguidelines-macro-to-enum alias

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp. Herald added subscribers: jeroen.dobbelaere, shchenz, kbarton, xazax.hun, nemanjai. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D157182: [clang-tidy][NFC] Update documentation for hicpp-avoid-goto

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Add info in check lis

[PATCH] D157185: [clang-tidy] Fix false-positives in performanc-noexcept-swap

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp, AMS21. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Enforce a stri

[PATCH] D157188: [clang-tidy] Add bugprone-new-bool-conversion

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detects cases where t

[PATCH] D157190: [clang-tidy] Fixed false-negative in readability-identifier-naming

PiotrZSL created this revision. PiotrZSL added reviewers: carlosgalvezp, njames93. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Issue were cased by c

[PATCH] D157190: [clang-tidy] Fixed false-negative in readability-identifier-naming

PiotrZSL updated this revision to Diff 547475. PiotrZSL edited the summary of this revision. PiotrZSL added a comment. Properly handle situation when class is forward-declared as struct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157190/new/ htt

[PATCH] D156993: [clang] Error on substitution failure within lambda body inside a requires-expression

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156993/new/ https://reviews.llvm.org/D156993 __

[PATCH] D157191: Improve dumps of attributes

giulianobelinassi created this revision. Herald added subscribers: s.egerton, simoncook, asb. Herald added a reviewer: aaron.ballman. Herald added a project: All. giulianobelinassi requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, wangpc,

[PATCH] D157191: Improve dumps of attributes

giulianobelinassi abandoned this revision. giulianobelinassi added a comment. This was open by mistake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157191/new/ https://reviews.llvm.org/D157191 ___ cfe-

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi updated this revision to Diff 547477. giulianobelinassi added a comment. Herald added subscribers: wangpc, s.egerton, simoncook, asb. - Use tblgen to generate table of attributes that can or must be print on the left side of the Decl. - Use LLVM_MARK_AS_BITMASK_ENUM on AttrPrint

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi added a comment. Hello, It took me a while, but here it is the newer version of the patch with the tablegen stuff. Please reach to me if something needs to be changed in this regard. This also improves the readability of declarations of variables that have a parenthesis cons

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin added a comment. Interesting case that crashes the compiler, stack overflow cpp struct T{}; struct C { operator T (this int); operator int(); }; void foo(C c) { T d = c; } Not completely sure that this is supposed to be covered by https://eel.is/c++draft

[PATCH] D157188: [clang-tidy] Add bugprone-new-bool-conversion

Eugene.Zelenko added a comment. Shouldn't C-style allocation be checked too? Same for custom allocators via configuration option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157188/new/ https://reviews.llvm.org/D157188 _

[PATCH] D157188: [clang-tidy] Add bugprone-new-bool-conversion

Eugene.Zelenko added a comment. Same for file, threads and other resources allocation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157188/new/ https://reviews.llvm.org/D157188 ___ cfe-commits mailing l

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 547483. ccotter added a comment. - Check nullptr - Add tests for rbegin/crbegin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clang-tidy/

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter marked 3 inline comments as done. ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/loop-convert-basic.cpp:484 } // Tests to verify the proper use of auto where the init variable type and the PiotrZSL wro

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher accepted this revision. QuillPusher added a comment. This revision is now accepted and ready to land. Thanks for the updates, look OK to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156858/new/ https://reviews.llvm.org/D156858

[PATCH] D157188: [clang-tidy] Add bugprone-new-bool-conversion

PiotrZSL added a comment. In D157188#4563105 , @Eugene.Zelenko wrote: > Shouldn't C-style allocation be checked too? Same for custom allocators via > configuration option. In theory it could, but in such case name of check would need to change... Rep

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

PiotrZSL accepted this revision. PiotrZSL added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D157188: [clang-tidy] Add bugprone-new-bool-conversion

Eugene.Zelenko added a comment. In D157188#4563139 , @PiotrZSL wrote: > In D157188#4563105 , > @Eugene.Zelenko wrote: > >> Shouldn't C-style allocation be checked too? Same for custom allocators via >> configura

[PATCH] D157182: [clang-tidy][NFC] Update documentation for hicpp-avoid-goto

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157182/new/ https://reviews.llvm.org/D157182

[PATCH] D157181: [clang-tidy] Re-add cppcoreguidelines-macro-to-enum alias

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. Strange, it seems the alias was never fully added? https://reviews.llvm.org/D117522 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

carlosgalvezp added a comment. In D145138#4561799 , @PiotrZSL wrote: > Test are failing, and I do not think that converting c-strings into > std::array is a good idea +1, they should typically be `char const*` instead. Repository: rG LLVM Github

[PATCH] D157178: [clang-tidy] Fix inline namespaces in llvm-namespace-comment

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157178/new/ https://reviews.llvm.org/D157178 _

[PATCH] D157180: [clang-tidy] Exclude class/struct scope variables from cppcoreguidelines-avoid-non-const-global-variables

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157180/new/ https://reviews.llvm.org/D157180

[PATCH] D157185: [clang-tidy] Fix false-positives in performanc-noexcept-swap

carlosgalvezp accepted this revision. carlosgalvezp added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/performance/NoexceptSwapCheck.cpp:22 Finder->addMatcher( - functionDecl(unless(isDeleted()), hasName("swap

[PATCH] D157190: [clang-tidy] Fixed false-negative in readability-identifier-naming

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, minor question that can be fixed post-review unless you want to discuss further! Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/iden

[PATCH] D157190: [clang-tidy] Fixed false-negative in readability-identifier-naming

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming.cpp:716 +// CHECK-FIXES: {{^}}class CClassWithForwardDecl { +class class_with_forward_decl { + int __value; carlosgalvezp wrote: > Nit: shouldn'

[PATCH] D157181: [clang-tidy] Re-add cppcoreguidelines-macro-to-enum alias

PiotrZSL added a comment. In D157181#4563147 , @carlosgalvezp wrote: > Strange, it seems the alias was never fully added? > https://reviews.llvm.org/D117522 Looks like, still I dont know what to do with release notes, add alias "again" there, dont chan

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

junaire added a comment. I want to clarify: We offer two features: 1. capture the execution results and bring it back to the compiled program. 2. dump the captured value (value printing/automatic printf) and all the parsing, ast transform and balabala, these are all implementation details. The

[PATCH] D157181: [clang-tidy] Re-add cppcoreguidelines-macro-to-enum alias

carlosgalvezp added a comment. In D157181#4563170 , @PiotrZSL wrote: > In D157181#4563147 , @carlosgalvezp > wrote: > >> Strange, it seems the alias was never fully added? >> https://reviews.llvm.org/D117522 > >

[clang-tools-extra] 36daf35 - Add missing clangSerialization dependency for include-cleaner unittests

Author: Simon Pilgrim Date: 2023-08-05T17:13:08+01:00 New Revision: 36daf3532d91bb3e61d631edceea77ebb8417801 URL: https://github.com/llvm/llvm-project/commit/36daf3532d91bb3e61d631edceea77ebb8417801 DIFF: https://github.com/llvm/llvm-project/commit/36daf3532d91bb3e61d631edceea77ebb8417801.diff

[PATCH] D157174: [clang][Interp] Convert logical binop operands to bool

tbaeder updated this revision to Diff 547495. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157174/new/ https://reviews.llvm.org/D157174 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/c.c Index: clang/test/AST/Interp/c.c ===

[PATCH] D156693: [clang][ASTImporter]Skip check friend template declaration in VisitClassTemplateDecl

jcsxky added a comment. In D156693#4560110 , @balazske wrote: > The summary tells nothing about what is the real problem to fix here. In the > lit test I see that an error message is displayed, this causes the test > failure. The problem is that the str

[PATCH] D157078: [include-cleaner] Handle files with unnamed buffers

RKSimon added a comment. In D157078#4562788 , @tylanphear wrote: > Seeing the link error downstream. I think clangSerialization needs to be > added to the link libraries. Should be fixed by 36daf3532d91bb

[PATCH] D157195: [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the do while statement

yronglin created this revision. Herald added a project: All. yronglin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: yrong Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157195 Files: clang/lib/Parse/

[clang-tools-extra] 166372e - [clang-tidy] Fix inline namespaces in llvm-namespace-comment

Author: Piotr Zegar Date: 2023-08-05T16:47:48Z New Revision: 166372e0bd2db5de459fc9d4be7ea9873ce983f4 URL: https://github.com/llvm/llvm-project/commit/166372e0bd2db5de459fc9d4be7ea9873ce983f4 DIFF: https://github.com/llvm/llvm-project/commit/166372e0bd2db5de459fc9d4be7ea9873ce983f4.diff LOG: [

[clang-tools-extra] ee2b765 - [clang-tidy][NFC] Update documentation for hicpp-avoid-goto

Author: Piotr Zegar Date: 2023-08-05T16:47:49Z New Revision: ee2b765cdd5ba28055fde25487139f2f1f7c6fb2 URL: https://github.com/llvm/llvm-project/commit/ee2b765cdd5ba28055fde25487139f2f1f7c6fb2 DIFF: https://github.com/llvm/llvm-project/commit/ee2b765cdd5ba28055fde25487139f2f1f7c6fb2.diff LOG: [

[PATCH] D157178: [clang-tidy] Fix inline namespaces in llvm-namespace-comment

This revision was automatically updated to reflect the committed changes. Closed by commit rG166372e0bd2d: [clang-tidy] Fix inline namespaces in llvm-namespace-comment (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157178/new/

[clang-tools-extra] 3e2ed57 - [clang-tidy] Exclude class/struct scope variables from cppcoreguidelines-avoid-non-const-global-variables

Author: Piotr Zegar Date: 2023-08-05T16:47:49Z New Revision: 3e2ed5701b7e0a5f5b2f0d248fe82f78e0e07267 URL: https://github.com/llvm/llvm-project/commit/3e2ed5701b7e0a5f5b2f0d248fe82f78e0e07267 DIFF: https://github.com/llvm/llvm-project/commit/3e2ed5701b7e0a5f5b2f0d248fe82f78e0e07267.diff LOG: [

[PATCH] D157182: [clang-tidy][NFC] Update documentation for hicpp-avoid-goto

This revision was automatically updated to reflect the committed changes. Closed by commit rGee2b765cdd5b: [clang-tidy][NFC] Update documentation for hicpp-avoid-goto (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157182/new/

[PATCH] D157180: [clang-tidy] Exclude class/struct scope variables from cppcoreguidelines-avoid-non-const-global-variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e2ed5701b7e: [clang-tidy] Exclude class/struct scope variables from cppcoreguidelines-avoid… (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D157180?vs=547457&id=547499#toc R

[PATCH] D156693: [clang][ASTImporter]Skip check friend template declaration in VisitClassTemplateDecl

jcsxky updated this revision to Diff 547501. jcsxky edited the summary of this revision. jcsxky added a comment. update diff: ignore compare depth in friend class template Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156693/new/ https://reviews.ll

[PATCH] D154646: Fix some typos in comments: evalute -> evaluate (NFC)

SuperSodaSea added a comment. I don't have commit access, so if anyone could help commit this patch for me, I would appreciate it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154646/new/ https://reviews.llvm.org/D154646 ___ cfe-commits mai

[PATCH] D157078: [include-cleaner] Handle files with unnamed buffers

tylanphear added a comment. In D157078#4563212 , @RKSimon wrote: > In D157078#4562788 , @tylanphear > wrote: > >> Seeing the link error downstream. I think clangSerialization needs to be >> added to the link lib

[PATCH] D157185: [clang-tidy] Fix false-positives in performanc-noexcept-swap

PiotrZSL updated this revision to Diff 547502. PiotrZSL added a comment. Rebase, add comments, make more strict for method (must be non-const) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157185/new/ https://reviews.llvm.org/D157185 Files: clan

[PATCH] D157190: [clang-tidy] Fixed false-negative in readability-identifier-naming

PiotrZSL updated this revision to Diff 547503. PiotrZSL added a comment. Rebase + make tests more simple Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157190/new/ https://reviews.llvm.org/D157190 Files: clang-tools-extra/clang-tidy/readability/I

[PATCH] D157181: [clang-tidy] Re-add cppcoreguidelines-macro-to-enum alias

PiotrZSL updated this revision to Diff 547504. PiotrZSL added a comment. Add release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157181/new/ https://reviews.llvm.org/D157181 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGu

[PATCH] D156693: [clang][ASTImporter]Skip check friend template depth

jcsxky updated this revision to Diff 547505. jcsxky added a comment. clean unittest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156693/new/ https://reviews.llvm.org/D156693 Files: clang/include/clang/AST/ASTStructuralEquivalence.h clang/lib/

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher requested changes to this revision. QuillPusher added a comment. This revision now requires changes to proceed. Thanks @junaire for the clarification, following is the updated document structure: 1. Capture Execution Results - How the Feature works - more details - Implementati

[clang] 58a71c6 - [clang-format] Handle "// clang-format on" for SeparateDefinitionBlocks

Author: Owen Pan Date: 2023-08-05T12:31:27-07:00 New Revision: 58a71c66db85f65bb6cdefe314f62318b95e9fc4 URL: https://github.com/llvm/llvm-project/commit/58a71c66db85f65bb6cdefe314f62318b95e9fc4 DIFF: https://github.com/llvm/llvm-project/commit/58a71c66db85f65bb6cdefe314f62318b95e9fc4.diff LOG:

[PATCH] D156971: [clang-format] Handle "// clang-format on" for SeparateDefinitionBlocks

This revision was automatically updated to reflect the committed changes. Closed by commit rG58a71c66db85: [clang-format] Handle "// clang-format on" for SeparateDefinitionBlocks (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D88299: [clang-format] Add MacroUnexpander.

owenpan added a comment. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. @klimek can you have a look at https://github.com/llvm/llvm-project/issues/64275? Comment at: clang/lib/Format/MacroCallReconstructor.cpp:223 + } + assert(!ActiveExpansions.

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter marked an inline comment as done. ccotter added a comment. All done on my end - @PiotrZSL if you're good would you mind landing this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 __

[PATCH] D154550: [clang-format] Allow empty loops on a single line.

gedare added a comment. In D154550#4562061 , @owenpan wrote: > In D154550#4529346 , @gedare wrote: > >> In D154550#4526386 , @owenpan >> wrote: >> >>> Like `while (a);`,

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/NoSuspendWithLockCheck.cpp:24-26 + hasType(recordDecl(hasAnyName( + "::std::unique_lock", "::std::lock_guard", +

[PATCH] D154550: [clang-format] Allow empty loops on a single line.

gedare added a comment. In D154550#4562061 , @owenpan wrote: > In D154550#4529346 , @gedare wrote: > >> In D154550#4526386 , @owenpan >> wrote: >> >>> Like `while (a);`,

[PATCH] D157197: [clang][CodeGen][OpenMP] Fix if-clause for 'target teams loop'

ddpagan created this revision. ddpagan added a reviewer: ABataev. ddpagan added projects: clang, OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a project: All. ddpagan requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jpl

[PATCH] D157140: [clang][Sema][OpenMP] Fix capture region for 'target teams loop'

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15410 break; +case OMPD_target_teams_loop: + // This is equivalent to 'target teams distribute parallel for' with Need to have capture region for parallel, no? Repository:

[PATCH] D157197: [clang][CodeGen][OpenMP] Fix if-clause for 'target teams loop'

ABataev added a comment. Add the reference to openmp spec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157197/new/ https://reviews.llvm.org/D157197 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a1f8ef8a7aa: [clang-tidy] Support begin/end free functions in modernize-loop-convert (authored by ccotter, committed by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D140760?vs=547483&id

[clang-tools-extra] 6a1f8ef - [clang-tidy] Support begin/end free functions in modernize-loop-convert

Author: Chris Cotter Date: 2023-08-05T20:55:48Z New Revision: 6a1f8ef8a7aaefea80ef0bc7c6c462a96215b50e URL: https://github.com/llvm/llvm-project/commit/6a1f8ef8a7aaefea80ef0bc7c6c462a96215b50e DIFF: https://github.com/llvm/llvm-project/commit/6a1f8ef8a7aaefea80ef0bc7c6c462a96215b50e.diff LOG:

[PATCH] D157188: [clang-tidy] Add bugprone-new-bool-conversion

chandlerc added a comment. In D157188#4563143 , @Eugene.Zelenko wrote: > In D157188#4563139 , @PiotrZSL > wrote: > >> In D157188#4563105 , >> @Eugene.Zelenko wrote: >>

[PATCH] D157197: [clang][CodeGen][OpenMP] Fix if-clause for 'target teams loop'

ddpagan updated this revision to Diff 547515. ddpagan added a comment. Added reference to relevant portion of the OpenMP 5.2 specification. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157197/new/ https://reviews.llvm.org/D157197 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/tes

[PATCH] D157197: [clang][CodeGen][OpenMP] Fix if-clause for 'target teams loop'

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1564 + // Any if-clause associated with expansion for 'target teams loop' should + // apply to target region only. OpenMP 5.2 [3.4, if Clause, Semantics, 15-18] + if (S.getDirectiveKind() != OMPD_tar

[PATCH] D157200: [clang][Interp] Visit Logical-not operand as bool

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `invBool` op here expects a bool operand, but in C

[PATCH] D157197: [clang][CodeGen][OpenMP] Fix if-clause for 'target teams loop'

ddpagan added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1564 + // Any if-clause associated with expansion for 'target teams loop' should + // apply to target region only. OpenMP 5.2 [3.4, if Clause, Semantics, 15-18] + if (S.getDirectiveKind() != OMPD_tar

[clang-tools-extra] 3d80103 - [clang-tidy][NFC] Fix link in documentation

Author: Piotr Zegar Date: 2023-08-06T05:16:22Z New Revision: 3d8010363895bd063a2d33172a07985b4c9b97ee URL: https://github.com/llvm/llvm-project/commit/3d8010363895bd063a2d33172a07985b4c9b97ee DIFF: https://github.com/llvm/llvm-project/commit/3d8010363895bd063a2d33172a07985b4c9b97ee.diff LOG: [

[PATCH] D157185: [clang-tidy] Fix false-positives in performanc-noexcept-swap

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/NoexceptSwapCheck.cpp:31 + // Match function with 2 arguments, both are non-const references to same type + // and return void void swap(Type&, Type&) + auto FunctionMatcher = allOf( ---

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

yichi170 created this revision. Herald added a project: All. yichi170 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157201 Files: clang/include/clang/Sema/Sema.h clang/

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

tbaeder added a comment. You're missing tests. Comment at: clang/lib/Sema/SemaExpr.cpp:16696-16697 + + IdentifierInfo *II = RD->getIdentifier(); + if (II == OC.U.IdentInfo && OC.isQualifier) +continue; Repository: rG LLVM Github Monorepo

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

cor3ntin added a comment. Thanks a lot for working on this. Can you add tests (to `clang/test/SemaCXX/offsetof.cpp`)? The change will also need an entry in `clang/docs/ReleaseNotes.rst` , in the "C++ Language Changes" section Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157188: [clang-tidy] Add bugprone-allocation-bool-conversion

PiotrZSL updated this revision to Diff 547523. PiotrZSL retitled this revision from "[clang-tidy] Add bugprone-new-bool-conversion" to "[clang-tidy] Add bugprone-allocation-bool-conversion". PiotrZSL edited the summary of this revision. PiotrZSL added a comment. Change check anme, add configurat