jyknight wrote:
> You'll get different results depending on whether the input is implicitly
> flushed in fcmp vs. not in the is.fpclass
This sounds intuitively like the sort of semantics-breaking optimization which
is expected from `-ffast-math`. If the only issues are things like getting a
s
ldionne wrote:
Woah, I just checked Xcode 15.2 and you are totally right, it contains
`clang-1500.1.0.2.5` which still has the behavior reversed from upstream. Sorry
for the confusion, I assumed it was out in recent Xcodes cause the change was
made a while back, but it looks like this change s
jwanggit86 wrote:
@t-tye Code has been updated based on your feedback. Pls take a look.
https://github.com/llvm/llvm-project/pull/79236
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Cyndy Ishida
Date: 2024-02-05T14:14:21-08:00
New Revision: ae9e1fd2edb6eb11dfd6816d1e9013e39e21aa04
URL:
https://github.com/llvm/llvm-project/commit/ae9e1fd2edb6eb11dfd6816d1e9013e39e21aa04
DIFF:
https://github.com/llvm/llvm-project/commit/ae9e1fd2edb6eb11dfd6816d1e9013e39e21aa04.diff
dmpolukhin wrote:
@ldionne what about fixing upstream behavior to match actual system compiler
behavior now and when/as soon as we have new behavior in Apple compiler fix it
again in newer clang versions? Moreover as I pointed out Apple compiler
behavior is problematic for clang-tools and clan
https://github.com/alexey-bataev updated
https://github.com/llvm/llvm-project/pull/78976
>From 391145a2d04873ef84c4f1083fe9b9fcdbb3b940 Mon Sep 17 00:00:00 2001
From: Alexey Bataev
Date: Mon, 22 Jan 2024 14:13:51 +
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
@@ -2466,6 +2504,15 @@ Value *ScalarExprEmitter::VisitCastExpr(CastExpr *CE) {
case CK_IntToOCLSampler:
return CGF.CGM.createOpenCLIntToSamplerConversion(E, CGF);
+ case CK_HLSLVectorTruncation: {
+assert(DestTy->isVectorType() && "Expected dest type to be vector ty
@@ -1843,13 +1843,86 @@ bool Sema::IsFunctionConversion(QualType FromType,
QualType ToType,
return true;
}
+/// Determine whether the conversion from FromType to ToType is a valid
+/// floating point conversion.
+///
+static bool IsFloatingPointConversion(Sema &S, QualType
@@ -361,6 +361,9 @@ CAST_OPERATION(AddressSpaceConversion)
// Convert an integer initializer to an OpenCL sampler.
CAST_OPERATION(IntToOCLSampler)
+// Truncate a vector type (HLSL only).
+CAST_OPERATION(HLSLVectorTruncation)
rjmccall wrote:
Unfortunately, we
@@ -2414,9 +2420,41 @@ Value *ScalarExprEmitter::VisitCastExpr(CastExpr *CE) {
return EmitScalarConversion(Visit(E), E->getType(), DestTy,
CE->getExprLoc(), Opts);
}
- case CK_IntegralToFloating:
- case CK_FloatingToIntegral:
- case CK_F
rjmccall wrote:
Argh, sorry for the slow response.
https://github.com/llvm/llvm-project/pull/71098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jcranmer-intel wrote:
> (Sidenote: "dynamic" isn't even
> [documented](https://clang.llvm.org/docs/UsersManual.html#cmdoption-fdenormal-fp-math)).
It's not a selectable enum of the Clang `-fdenormal-fp-math` flag, but it is
one for the LLVM function attribute `denormal-fp-math`.
https://githu
topperc wrote:
Will https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/417 be
implemented in a separate patch?
https://github.com/llvm/llvm-project/pull/68075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
Author: Shafik Yaghmour
Date: 2024-02-05T14:40:07-08:00
New Revision: a7bc9cb6ffa91ff0ebabc45c0c7263c7c2c3a4de
URL:
https://github.com/llvm/llvm-project/commit/a7bc9cb6ffa91ff0ebabc45c0c7263c7c2c3a4de
DIFF:
https://github.com/llvm/llvm-project/commit/a7bc9cb6ffa91ff0ebabc45c0c7263c7c2c3a4de.dif
https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/80730
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -538,11 +565,254 @@ std::optional checkName(const NamedDecl
&RenameDecl,
Conflict->getLocation().printToString(ASTCtx.getSourceManager())};
}
}
- if (Result)
+ if (Result) {
InvalidNameMetric.record(1, toString(Result->K));
+return makeError(*Re
ZijunZhaoCCK wrote:
> This broke the wasi-threads target: `clang: error: version 'threads' in
> target triple 'wasm32-unknown-wasi-threads' is invalid`
Because `threads` is not in EnvironmentType list:
https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/TargetParser/Triple.h#L231
https://github.com/bhamiltoncx approved this pull request.
Looks good. Can you add one more test, please?
https://github.com/llvm/llvm-project/pull/80628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
@@ -0,0 +1,3 @@
+// RUN: clang-format -dump-config 2>&1 | FileCheck %s
bhamiltoncx wrote:
Can you also add a test with `clang-format --assume-filename=foo.m -dump-config
2>&1 | FileCheck %s`?
It should result in `Language: ObjC`.
https://github.com/llvm/llvm-
https://github.com/bhamiltoncx edited
https://github.com/llvm/llvm-project/pull/80628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -538,11 +565,254 @@ std::optional checkName(const NamedDecl
&RenameDecl,
Conflict->getLocation().printToString(ASTCtx.getSourceManager())};
}
}
- if (Result)
+ if (Result) {
InvalidNameMetric.record(1, toString(Result->K));
+return makeError(*Re
@@ -508,24 +513,46 @@ static bool mayBeValidIdentifier(llvm::StringRef Ident) {
!isAsciiIdentifierStart(Ident.front(), AllowDollar))
return false;
for (char C : Ident) {
+if (AllowColon && C == ':')
ahoppen wrote:
Oh, I just assumed that the fi
@@ -1051,6 +1052,145 @@ CodeGenFunction::emitFlexibleArrayMemberSize(const Expr
*E, unsigned Type,
return Builder.CreateSelect(Cmp, Res, ConstantInt::get(ResType, 0,
IsSigned));
}
+namespace {
+
+/// \p StructBaseExpr returns the base \p Expr with a structure or union type
https://github.com/bwendling edited
https://github.com/llvm/llvm-project/pull/80256
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bwendling edited
https://github.com/llvm/llvm-project/pull/80256
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AdamMagierFOSS edited
https://github.com/llvm/llvm-project/pull/80515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AdamMagierFOSS updated
https://github.com/llvm/llvm-project/pull/80515
>From 4e1c37ae83dec050fc9b7aa172db01fa0b2b6d68 Mon Sep 17 00:00:00 2001
From: Adam Magier
Date: Sat, 3 Feb 2024 00:38:54 +0100
Subject: [PATCH 1/2] [clang][CodeGen][UBSan] Fixing shift-exponent generation
@@ -0,0 +1,36 @@
+// RUN: %clang_cc1 %s -O0 -fsanitize=shift-exponent -emit-llvm -o - |
FileCheck %s
AdamMagierFOSS wrote:
Sounds good, thank you for the recommendation!
https://github.com/llvm/llvm-project/pull/80515
___
@@ -4121,6 +4121,13 @@ Value *ScalarExprEmitter::GetWidthMinusOneValue(Value*
LHS,Value* RHS) {
Ty = cast(VT->getElementType());
else
Ty = cast(LHS->getType());
+ // Testing with small _BitInt types has shown that Ty->getBitwidth() - 1
AdamMagierFOS
@@ -0,0 +1,36 @@
+// RUN: %clang_cc1 %s -O0 -fsanitize=shift-exponent -emit-llvm -o - |
FileCheck %s
+
+// Checking that the code generation is using the unextended/untruncated
+// exponent values and capping the values accordingly
+
+// CHECK-LABEL: define{{.*}} i32 @test_left_v
AdamMagierFOSS wrote:
> > One thing I'll preemptively address is I didn't know where to put the new
> > unit testing - creating a separate file seems a little heavy handed but I
> > see that there's a test for UBSan shift generation
> > (`clang/test/CodeGen/ubsan-shift.c`) and one for UBSan +
@@ -1051,6 +1052,145 @@ CodeGenFunction::emitFlexibleArrayMemberSize(const Expr
*E, unsigned Type,
return Builder.CreateSelect(Cmp, Res, ConstantInt::get(ResType, 0,
IsSigned));
}
+namespace {
+
+/// \p StructBaseExpr returns the base \p Expr with a structure or union type
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e296cedcd686e24fee75756185669f1bb3b47fdd
c3be3ebd7a8ae57d319eedbb97ab85324c814db2 --
glandium wrote:
We stumbled upon this downstream because we have jobs building wasi-sdk with
clang-trunk, and wasi-sdk builds some things with that target. It apparently
comes from https://github.com/WebAssembly/wasi-libc/pull/381
https://github.com/llvm/llvm-project/pull/78655
___
glandium wrote:
There's apparently also wasm32-wasi-preview2 and wasm32-wasi-pthread, which I
suppose are equally broken by this change.
https://github.com/llvm/llvm-project/pull/78655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
https://github.com/topperc created
https://github.com/llvm/llvm-project/pull/80760
In an LTO build, we don't set the ELF attributes to indicate what extensions
were compiled with. The target CPU/Attrs in RISCVTargetMachine do not get set
for an LTO build. Each function gets a target-cpu/featur
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-codegen
Author: Craig Topper (topperc)
Changes
In an LTO build, we don't set the ELF attributes to indicate what extensions
were compiled with. The target CPU/Attrs in RISCVTargetMachine do not get set
for an LTO build.
llvmbot wrote:
@llvm/pr-subscribers-backend-risc-v
Author: Craig Topper (topperc)
Changes
In an LTO build, we don't set the ELF attributes to indicate what extensions
were compiled with. The target CPU/Attrs in RISCVTargetMachine do not get set
for an LTO build. Each function gets a targ
@@ -108,3 +109,22 @@ int computed_with_lambda = [] {
return result;
}();
#endif
+
+#if __cplusplus >= 201703L
+namespace DynamicFileScopeLiteral {
+// This covers the case where we have a file-scope compound literal with a
+// non-constant initializer in C++. Previously, we h
https://github.com/AdamMagierFOSS edited
https://github.com/llvm/llvm-project/pull/80515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AdamMagierFOSS updated
https://github.com/llvm/llvm-project/pull/80515
>From 4e1c37ae83dec050fc9b7aa172db01fa0b2b6d68 Mon Sep 17 00:00:00 2001
From: Adam Magier
Date: Sat, 3 Feb 2024 00:38:54 +0100
Subject: [PATCH 1/3] [clang][CodeGen][UBSan] Fixing shift-exponent generation
https://github.com/PiJoules created
https://github.com/llvm/llvm-project/pull/80763
None
>From faf74616efab09e59aade180ce44b68e04259e0e Mon Sep 17 00:00:00 2001
From: Leonard Chan
Date: Mon, 5 Feb 2024 14:55:34 -0800
Subject: [PATCH 1/2] [llvm] Fix assertion error where we didn't check fixed
llvmbot wrote:
@llvm/pr-subscribers-debuginfo
Author: None (PiJoules)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/80763.diff
4 Files Affected:
- (modified) clang/include/clang/AST/Type.h (+7)
- (modified) clang/lib/Sema/SemaOverload.cpp (+4-1)
- (modified) clang
https://github.com/PiJoules updated
https://github.com/llvm/llvm-project/pull/80763
>From 81e2325ee9600e6a41de51fc26963147617f4ad6 Mon Sep 17 00:00:00 2001
From: Leonard Chan
Date: Mon, 5 Feb 2024 15:33:09 -0800
Subject: [PATCH] [Clang] Diagnose improper fixed point conversions in C++
---
cla
andykaylor wrote:
I don't know anything about how non-x86 targets implement DAZ/FTZ, but for
x86-based targets, I think trying to make any assumptions about the setting is
bound to be wrong. In theory, it's part of the floating-point environment and
shouldn't be modified during execution unles
ZijunZhaoCCK wrote:
> There's apparently also wasm32-wasi-preview2 and wasm32-wasi-pthread, which I
> suppose are equally broken by this change.
Yes, I think so. I think adding these environment types in wasi-libc repo could
help fix those errors.
https://github.com/llvm/llvm-project/pull/786
https://github.com/AntonBikineev created
https://github.com/llvm/llvm-project/pull/80765
The existing attribute works only for loop headers. This can unfortunately be
quite limiting, especially as a protection against the "Jump Conditional Code
Erratum" [0] (for example, if there is an unalign
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: Anton Bikineev (AntonBikineev)
Changes
The existing attribute works only for loop headers. This can unfortunately be
quite limiting, especially as a protection against the "Jump Conditional Code
Erratum" [0] (for example, if there i
glandium wrote:
> Yes, I think so. I think adding these environment types in wasi-libc repo
> could help fix those errors.
WDYM?
https://github.com/llvm/llvm-project/pull/78655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a7bc9cb6ffa91ff0ebabc45c0c7263c7c2c3a4de
ff8cf4e87473dec2e3f55114cb92ae5a63d9488c --
https://github.com/AntonBikineev updated
https://github.com/llvm/llvm-project/pull/80765
>From 99d2cc55fb952361b1fe04e2c21dcb5b04f11d47 Mon Sep 17 00:00:00 2001
From: Anton Bikineev
Date: Mon, 5 Feb 2024 12:24:17 +0100
Subject: [PATCH] [clang] Support per-function [[clang::code_align(N)]]
attr
MaskRay wrote:
> > There's apparently also wasm32-wasi-preview2 and wasm32-wasi-pthread, which
> > I suppose are equally broken by this change.
>
> Yes, I think so. I think adding these environment types in wasi-libc repo
> could help fix those errors.
If wasm can arbitrary environment types,
Author: Joseph Huber
Date: 2024-02-05T17:58:19-06:00
New Revision: dbed89814e5b9ba25a349a5b9acf4a7164e33834
URL:
https://github.com/llvm/llvm-project/commit/dbed89814e5b9ba25a349a5b9acf4a7164e33834
DIFF:
https://github.com/llvm/llvm-project/commit/dbed89814e5b9ba25a349a5b9acf4a7164e33834.diff
https://github.com/jhuber6 closed
https://github.com/llvm/llvm-project/pull/80741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/80768
None
>From 4e10436ddd55f1b1bed2bb99856e1101b9462117 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 5 Feb 2024 16:07:09 -0800
Subject: [PATCH] Fix a crash in clang::isGetterOfRefCounted by checking
nullptr
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Ryosuke Niwa (rniwa)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/80768.diff
2 Files Affected:
- (modified) clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp (+8-6)
- (added) clang/test/Analys
andykaylor wrote:
> > (Sidenote: "dynamic" isn't even
> > [documented](https://clang.llvm.org/docs/UsersManual.html#cmdoption-fdenormal-fp-math)).
>
> It's not a selectable enum of the Clang `-fdenormal-fp-math` flag, but it is
> one for the LLVM function attribute `denormal-fp-math`.
This is
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 6ce03ff3fef8fb6fa9afe8eb22c6d98bced26d48
4e10436ddd55f1b1bed2bb99856e1101b9462117 --
https://github.com/bjope approved this pull request.
LG
https://github.com/llvm/llvm-project/pull/80515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AntonBikineev updated
https://github.com/llvm/llvm-project/pull/80765
>From 88151098d3087f95d3a5b652309a12fb2e9f757e Mon Sep 17 00:00:00 2001
From: Anton Bikineev
Date: Mon, 5 Feb 2024 12:24:17 +0100
Subject: [PATCH] [clang] Support per-function [[clang::code_align(N)]]
attr
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/80768
>From f9f11843c2d09775de20d47dc71c5e482a1ff8b4 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 5 Feb 2024 16:07:09 -0800
Subject: [PATCH] Fix a crash in clang::isGetterOfRefCounted by checking
nullptr in try
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/80519
>From 6ab5ba3f970eaaea542fbed09cae17d3666df6b3 Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Sat, 3 Feb 2024 00:18:42 +
Subject: [PATCH 1/2] wip
---
clang/lib/AST/Expr.cpp | 12
@@ -108,3 +109,22 @@ int computed_with_lambda = [] {
return result;
}();
#endif
+
+#if __cplusplus >= 201703L
+namespace DynamicFileScopeLiteral {
+// This covers the case where we have a file-scope compound literal with a
+// non-constant initializer in C++. Previously, we h
rnk wrote:
> Also in the issue: #80510 you pointed out a crash bug. We should have the bug
> covered in the test case as well.
I think that is covered by the existing test case, instead of crashing, we now
reject with an error. In the future if we want to align with GCC as you
suggest, we'll
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/80519
>From 6ab5ba3f970eaaea542fbed09cae17d3666df6b3 Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Sat, 3 Feb 2024 00:18:42 +
Subject: [PATCH 1/3] wip
---
clang/lib/AST/Expr.cpp | 12
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 820f244aa92f11292e59440c9bc5afbdec395b20
c630eee1f930c87d2c461de92271c02de220b290 --
rapidsna wrote:
> It's generally not a good idea to use sugar to represent constructs that are
> semantically significant: anything that uses the canonical type will throw it
> away. We try to avoid throwing away sugar in most cases, but we aren't always
> successful.
> It's possible there ar
ZijunZhaoCCK wrote:
> > > There's apparently also wasm32-wasi-preview2 and wasm32-wasi-pthread,
> > > which I suppose are equally broken by this change.
> >
> >
> > Yes, I think so. I think adding these environment types in wasi-libc repo
> > could help fix those errors.
>
> If wasm can arbi
https://github.com/ilovepi approved this pull request.
Thank you for this. I expect this to be a big help w/ the various target
features bugs we've seen in LTO builds.
I'm surprised only 1 test file needed the metadata updated as a result of this
change.
https://github.com/llvm/llvm-project/p
topperc wrote:
> I'm surprised only 1 test file needed the metadata updated as a result of
> this change.
Maybe other tests are better about using regexes to hide the numbers?
https://github.com/llvm/llvm-project/pull/80760
___
cfe-commits mailing li
https://github.com/aheejin created
https://github.com/llvm/llvm-project/pull/80775
This adds tests for `generic` cpu configuration. We had tests for `mvp` and
`bleeding-edge` configs but not `generic`.
>From dbb74ca85ef047260a2820f6d470448279ea44f4 Mon Sep 17 00:00:00 2001
From: Heejin Ahn
Da
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Heejin Ahn (aheejin)
Changes
This adds tests for `generic` cpu configuration. We had tests for `mvp` and
`bleeding-edge` configs but not `generic`.
---
Full diff: https://github.com/llvm/llvm-project/pull/80775.diff
2 Files Affec
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Heejin Ahn (aheejin)
Changes
This adds tests for `generic` cpu configuration. We had tests for `mvp` and
`bleeding-edge` configs but not `generic`.
---
Full diff: https://github.com/llvm/llvm-project/pull/80775.diff
2 Files Affected:
-
jrtc27 wrote:
My thoughts on this in the past have been:
1. target-abi should really be a target-independent thing we record; its
meaning depends on the target, but the ABI exists throughout LLVM as a concept
regardless of the target
2. module-level target features in general likely should be
https://github.com/aheejin updated
https://github.com/llvm/llvm-project/pull/80775
>From dbb74ca85ef047260a2820f6d470448279ea44f4 Mon Sep 17 00:00:00 2001
From: Heejin Ahn
Date: Tue, 6 Feb 2024 00:51:40 +
Subject: [PATCH 1/2] [WebAssembly] Add tests for generic CPU config
This adds tests f
https://github.com/PiJoules created
https://github.com/llvm/llvm-project/pull/80781
None
>From 916a10f1cebbb339dec98bd18c945b63991190f1 Mon Sep 17 00:00:00 2001
From: Leonard Chan
Date: Mon, 5 Feb 2024 17:58:08 -0800
Subject: [PATCH] [clang] Add zero-initialization for fixed point types
---
Author: Younan Zhang
Date: 2024-02-06T09:59:16+08:00
New Revision: 2c2d291b4568381999442e47fc77f949f19be0bc
URL:
https://github.com/llvm/llvm-project/commit/2c2d291b4568381999442e47fc77f949f19be0bc
DIFF:
https://github.com/llvm/llvm-project/commit/2c2d291b4568381999442e47fc77f949f19be0bc.diff
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/80594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (PiJoules)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/80781.diff
2 Files Affected:
- (modified) clang/lib/AST/ExprConstant.cpp (+4)
- (added) clang/test/CodeGenCXX/fixed-point-zero-init.cpp (+9)
`
drodriguez wrote:
I agree with Dmitry in that it would be preferred to have the system compiler
behaviour until the system compiler actually changes.
I have tried again with Xcode 14.3.1 (released almost 1 year ago), which
includes `include/c++/v1` side by side with the compiler, and for it, p
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff cf401f72e1b5aa6be0719ab45c95c10ea06bec9a
916a10f1cebbb339dec98bd18c945b63991190f1 --
@@ -538,11 +565,254 @@ std::optional checkName(const NamedDecl
&RenameDecl,
Conflict->getLocation().printToString(ASTCtx.getSourceManager())};
}
}
- if (Result)
+ if (Result) {
InvalidNameMetric.record(1, toString(Result->K));
+return makeError(*Re
https://github.com/ZijunZhaoCCK created
https://github.com/llvm/llvm-project/pull/80783
Add isWasm() check for here:
https://github.com/llvm/llvm-project/pull/78655#issuecomment-1928075569
>From 84506beecc20a064a5c895cf5c04135118da6606 Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Tue, 6 Feb
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (ZijunZhaoCCK)
Changes
Add isWasm() check for here:
https://github.com/llvm/llvm-project/pull/78655#issuecomment-1928075569
---
Full diff: https://github.com/llvm/llvm-project/pull/80783.diff
1 Files Affected:
- (modified) clang/l
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: None (ZijunZhaoCCK)
Changes
Add isWasm() check for here:
https://github.com/llvm/llvm-project/pull/78655#issuecomment-1928075569
---
Full diff: https://github.com/llvm/llvm-project/pull/80783.diff
1 Files Affected:
- (modified)
brad0 wrote:
Ping.
https://github.com/llvm/llvm-project/pull/75841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jkorous-apple created
https://github.com/llvm/llvm-project/pull/80787
Debug notes for unclaimed DeclRefExpr should report any DRE of an unsafe
variable that is not covered by a Fixable (i. e. fixit for the particular AST
pattern isn't implemented for whatever reason). Curren
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (jkorous-apple)
Changes
Debug notes for unclaimed DeclRefExpr should report any DRE of an unsafe
variable that is not covered by a Fixable (i. e. fixit for the particular AST
pattern isn't implemented for whatever reason). Currently
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 8f80df0f52c4294d23d0510b01be6d6491714058
90e7145fe0133828b4abc16730b9786fc68df8b9 --
@@ -248,10 +248,11 @@ X86_FEATURE_COMPAT(AVXVNNIINT16,"avxvnniint16",
0)
X86_FEATURE_COMPAT(SM3, "sm3",0)
X86_FEATURE_COMPAT(SHA512, "sha512", 0)
X86_FEATURE_COMPAT(SM4, "sm4",
@@ -61,6 +61,7 @@ void testArraySubscripts(int *p, int **pp) {
);
int a[10]; // expected-warning{{'a' is an unsafe buffer that does
not perform bounds checks}}
+// expected-note@-1{{change type of 'a' to
'std::array' to harden it}}
@@ -248,10 +248,11 @@ X86_FEATURE_COMPAT(AVXVNNIINT16,"avxvnniint16",
0)
X86_FEATURE_COMPAT(SM3, "sm3",0)
X86_FEATURE_COMPAT(SHA512, "sha512", 0)
X86_FEATURE_COMPAT(SM4, "sm4",
@@ -1612,6 +1613,14 @@
// RUN: -o - | FileCheck --check-prefix=CHECK-SUPM-EXT %s
// CHECK-SUPM-EXT: __riscv_supm 8000{{$}}
+// RUN: %clang --target=riscv32 -menable-experimental-extensions \
+// RUN: -march=rv32i_ssqosid1p0 -E -dM %s \
+// RUN: -o - | FileCheck --check-p
@@ -1612,6 +1613,14 @@
// RUN: -o - | FileCheck --check-prefix=CHECK-SUPM-EXT %s
// CHECK-SUPM-EXT: __riscv_supm 8000{{$}}
+// RUN: %clang --target=riscv32 -menable-experimental-extensions \
+// RUN: -march=rv32i_ssqosid1p0 -E -dM %s \
+// RUN: -o - | FileCheck --check-p
@@ -1612,6 +1613,14 @@
// RUN: -o - | FileCheck --check-prefix=CHECK-SUPM-EXT %s
// CHECK-SUPM-EXT: __riscv_supm 8000{{$}}
+// RUN: %clang --target=riscv32 -menable-experimental-extensions \
+// RUN: -march=rv32i_ssqosid1p0 -E -dM %s \
+// RUN: -o - | FileCheck --check-p
@@ -0,0 +1,9 @@
+// RUN: %clang_cc1 -ffixed-point -S -emit-llvm %s -o - | FileCheck %s
+
+// CHECK: @_ZL1a = internal constant [2 x i32] zeroinitializer
+constexpr _Accum a[2] = {};
MaskRay wrote:
Consider a `test/AST/` test like `static_assert(a[0] == 0 && a[0]
https://github.com/evelez7 created
https://github.com/llvm/llvm-project/pull/80801
Require a template argument list after an identifier prefixed by the template
keyword. Introduced by [CWG
96](https://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#96). Current
wording of [temp.names] i
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Erick Velez (evelez7)
Changes
Require a template argument list after an identifier prefixed by the template
keyword. Introduced by [CWG
96](https://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#96).
Current wording of [temp.names
WenleiHe wrote:
> > > I don't understand, if you're saying the profile is accurate, then those
> > > functions are actually cold, so we should be able to mark them as optsize?
> >
> >
> > Accurate is not black or white. The current heuristic requires certain
> > level of accuracy to be effect
https://github.com/jcsxky created
https://github.com/llvm/llvm-project/pull/80802
Try to fix [issue](https://github.com/llvm/llvm-project/issues/76674)
When transform a lambda expression which is declared in an unevaluated context,
`isInstantiationDependentType()` and `isVariablyModifiedType()`
301 - 400 of 415 matches
Mail list logo
