[clang] [clang] Turn -Wenum-constexpr-conversion into a hard error (PR #102364)

2024-08-09 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: Thanks for the review and the info @thesamesam ! AFAICS the MPL issue is fixed on trunk, targeting release 1.86. About Pycuda, it's also stemming from MPL according to the build logs. So it seems to me the solution to these projects is too "just" bump to the newer MPL ver

[clang] [clang] Avoid triggering vtable instantiation for C++23 constexpr dtor (PR #102605)

2024-08-09 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/102605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Avoid triggering vtable instantiation for C++23 constexpr dtor (PR #102605)

2024-08-09 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/102605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Avoid triggering vtable instantiation for C++23 constexpr dtor (PR #102605)

2024-08-09 Thread via cfe-commits
@@ -7042,12 +7042,38 @@ void Sema::CheckCompletedCXXClass(Scope *S, CXXRecordDecl *Record) { } } +bool EffectivelyConstexprDestructor = true; +// Avoid triggering vtable instantiation due to a dtor that is not +// "effectively constexpr" for better compa

[clang] [clang][analyzer] Bring checker alpha.security.MmapWriteExec out of alpha package (PR #102636)

2024-08-09 Thread Balázs Kéri via cfe-commits
https://github.com/balazske created https://github.com/llvm/llvm-project/pull/102636 None From 11e871ab17c119c71b8ef4bbcd3b186ec0e9a14f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Fri, 9 Aug 2024 17:41:46 +0200 Subject: [PATCH] [clang][analyzer] Bring checker alpha

[clang] [clang][analyzer] Bring checker alpha.security.MmapWriteExec out of alpha package (PR #102636)

2024-08-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Balázs Kéri (balazske) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/102636.diff 3 Files Affected: - (modified) clang/docs/analyzer/checkers.rst (+16-16) - (modified) clang/include/clang/StaticAnalyzer/Checkers/Chec

[clang] [clang][analyzer] Bring checker alpha.security.MmapWriteExec out of alpha package (PR #102636)

2024-08-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balázs Kéri (balazske) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/102636.diff 3 Files Affected: - (modified) clang/docs/analyzer/checkers.rst (+16-16) - (modified) clang/include/clang/StaticAnal

[clang] [llvm] [llvm][support] Implement tracing virtual file system (PR #88326)

2024-08-09 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/88326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang-tidy] bugprone-implicit-widening ignores unsigned consts (PR #101073)

2024-08-09 Thread Chris Warner via cfe-commits
@@ -569,7 +573,8 @@ class Expr : public ValueStmt { /// Note: This does not perform the implicit conversions required by C++11 /// [expr.const]p5. bool isCXX11ConstantExpr(const ASTContext &Ctx, APValue *Result = nullptr, - SourceLocation *Loc =

[clang] [clang-tools-extra] [clang-tidy] bugprone-implicit-widening ignores unsigned consts (PR #101073)

2024-08-09 Thread Chris Warner via cfe-commits
cwarner-8702 wrote: > There should definitely be a test in the clang side of things to ensure > correct handling of the Expr::getIntegerConstantExpr method with this new > parameter 100% agree. What would be a good way to verify handling of it when the flag shouldn't the compiled output? ht

[clang] [Arm][AArch64][Clang] Respect function's branch protection attributes. (PR #101978)

2024-08-09 Thread Daniel Kiss via cfe-commits
DanielKristofKiss wrote: /cherry-pick 9e9fa00 https://github.com/llvm/llvm-project/pull/101978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix Handling of Init Capture with Parameter Packs in LambdaScopeForCallOperatorInstantiationRAII (PR #100766)

2024-08-09 Thread Yanzuo Liu via cfe-commits
@@ -712,22 +712,30 @@ bool Sema::addInstantiatedCapturesToScope( auto AddSingleCapture = [&](const ValueDecl *CapturedPattern, unsigned Index) { ValueDecl *CapturedVar = LambdaClass->getCapture(Index)->getCapturedVar(); -if (CapturedVar->

[clang] [Arm][AArch64][Clang] Respect function's branch protection attributes. (PR #101978)

2024-08-09 Thread via cfe-commits
llvmbot wrote: >/cherry-pick 9e9fa00 Error: Command failed due to missing milestone. https://github.com/llvm/llvm-project/pull/101978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a serious bug in `git clang-format -f` (PR #102629)

2024-08-09 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/102629 >From 9b71b289feb75cdc6d67a6ac696ff0ba7969549d Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 9 Aug 2024 08:15:43 -0700 Subject: [PATCH 1/3] [clang-format] Fix a serious bug in `git clang-format -f` With the

[clang] 2f8f58d - [IR] Add method to GlobalVariable to change type of initializer. (#102553)

2024-08-09 Thread via cfe-commits
Author: Eli Friedman Date: 2024-08-09T09:22:40-07:00 New Revision: 2f8f58dd17a11934e8c8ec212b6474f76fb18e61 URL: https://github.com/llvm/llvm-project/commit/2f8f58dd17a11934e8c8ec212b6474f76fb18e61 DIFF: https://github.com/llvm/llvm-project/commit/2f8f58dd17a11934e8c8ec212b6474f76fb18e61.diff

[clang] [llvm] [IR] Add method to GlobalVariable to change type of initializer. (PR #102553)

2024-08-09 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic closed https://github.com/llvm/llvm-project/pull/102553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-09 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl updated https://github.com/llvm/llvm-project/pull/102521 >From 6546428805b52f1b6f350193ab08ff027892710f Mon Sep 17 00:00:00 2001 From: "Joel E. Denny" Date: Thu, 8 Aug 2024 15:02:04 -0400 Subject: [PATCH 1/7] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-09 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl edited https://github.com/llvm/llvm-project/pull/102521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PAC] Add support for __ptrauth type qualifier (PR #100830)

2024-08-09 Thread Akira Hatanaka via cfe-commits
ahatanak wrote: I'll try to come up with an RFC for the qualifier today. https://github.com/llvm/llvm-project/pull/100830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Arm][AArch64][Clang] Respect function's branch protection attributes. (PR #101978)

2024-08-09 Thread Rose Silicon via cfe-commits
RSilicon wrote: Who here can add milestones? https://github.com/llvm/llvm-project/pull/101978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Arm][AArch64][Clang] Respect function's branch protection attributes. (PR #101978)

2024-08-09 Thread Rose Silicon via cfe-commits
RSilicon wrote: > 9e9fa00 It has a merge conflict too, but one that is trivial so I can make my own PR. https://github.com/llvm/llvm-project/pull/101978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [Arm][AArch64][Clang] Respect function's branch protection attributes. (PR #101978)

2024-08-09 Thread Rose Silicon via cfe-commits
RSilicon wrote: https://github.com/llvm/llvm-project/pull/102646 https://github.com/llvm/llvm-project/pull/101978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm-lit] Replace Shell Substitutions with lit Syntax for Environmen… (PR #102647)

2024-08-09 Thread via cfe-commits
https://github.com/Harini0924 created https://github.com/llvm/llvm-project/pull/102647 …t Variables This patch updates the llvm-lit clang tests by replacing shell command substitutions with lit-compatible syntax for setting and referencing environment variables. Specifically, the use of shell

[clang] [llvm-lit] Replace Shell Substitutions with lit Syntax for Environmen… (PR #102647)

2024-08-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: None (Harini0924) Changes …t Variables This patch updates the llvm-lit clang tests by replacing shell command substitutions with lit-compatible syntax for setting and referencing environment variables. Specifically, the use of she

[clang] [llvm-lit] Replace Shell Substitutions with lit Syntax for Environmen… (PR #102647)

2024-08-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Harini0924) Changes …t Variables This patch updates the llvm-lit clang tests by replacing shell command substitutions with lit-compatible syntax for setting and referencing environment variables. Specifically, the use of shell-styl

[clang] [llvm-lit] Replace Shell Substitutions with lit Syntax for Environmen… (PR #102647)

2024-08-09 Thread via cfe-commits
https://github.com/Harini0924 edited https://github.com/llvm/llvm-project/pull/102647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm-lit] Use lit Syntax for Environment Variables on Clang (PR #102647)

2024-08-09 Thread via cfe-commits
https://github.com/Harini0924 edited https://github.com/llvm/llvm-project/pull/102647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm-lit] Use lit Syntax for Environment Variables on Clang (PR #102647)

2024-08-09 Thread via cfe-commits
https://github.com/Harini0924 edited https://github.com/llvm/llvm-project/pull/102647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a serious bug in `git clang-format -f` (PR #102629)

2024-08-09 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/102629 >From 9b71b289feb75cdc6d67a6ac696ff0ba7969549d Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 9 Aug 2024 08:15:43 -0700 Subject: [PATCH 1/4] [clang-format] Fix a serious bug in `git clang-format -f` With the

[clang] [llvm-lit] Use lit Syntax for Environment Variables on Clang (PR #102647)

2024-08-09 Thread via cfe-commits
https://github.com/Harini0924 updated https://github.com/llvm/llvm-project/pull/102647 >From 658af04b25dfdb00d418936d576d13f301ffe0e6 Mon Sep 17 00:00:00 2001 From: Harini Date: Tue, 6 Aug 2024 04:40:30 + Subject: [PATCH 1/2] [llvm-lit] Replace Shell Substitutions with lit Syntax for Envir

[clang] [llvm-lit] Use lit Syntax for Environment Variables in Clang subproject (PR #102647)

2024-08-09 Thread via cfe-commits
https://github.com/Harini0924 edited https://github.com/llvm/llvm-project/pull/102647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [hmaptool] Add JSON dump option (PR #102648)

2024-08-09 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai created https://github.com/llvm/llvm-project/pull/102648 The idea is that the output of `hmaptool dump --json` can be fed directly back to `hmaptool write` for easy round-tripping. >From 140a930607b34d2795defee00bbac59baf4c23c5 Mon Sep 17 00:00:00 2001 From: Shoaib M

[clang] [llvm-lit] Use lit Syntax for Environment Variables in Clang subproject (PR #102647)

2024-08-09 Thread via cfe-commits
Harini0924 wrote: CC: @ilovepi @petrhosek https://github.com/llvm/llvm-project/pull/102647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm-lit] Use lit Syntax for Environment Variables in Clang subproject (PR #102647)

2024-08-09 Thread via cfe-commits
https://github.com/Harini0924 edited https://github.com/llvm/llvm-project/pull/102647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [hmaptool] Add JSON dump option (PR #102648)

2024-08-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Shoaib Meenai (smeenai) Changes The idea is that the output of `hmaptool dump --json` can be fed directly back to `hmaptool write` for easy round-tripping. --- Full diff: https://github.com/llvm/llvm-project/pull/102648.diff 1 Files Aff

[clang] [llvm-lit] Use lit Syntax for Environment Variables in Clang subproject (PR #102647)

2024-08-09 Thread via cfe-commits
https://github.com/Harini0924 edited https://github.com/llvm/llvm-project/pull/102647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WIP][Clang] Add __builtin_get_counted_by builtin (PR #102549)

2024-08-09 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: So the idea here is that if the struct in question uses counted_by, you automatically set the count... and if, for whatever reason, the compiler can't find the corresponding field, you just throw away the count? That seems like an terrifying API; it's impossible to predic

[clang] [PAC] Add support for __ptrauth type qualifier (PR #100830)

2024-08-09 Thread Anton Korobeynikov via cfe-commits
asl wrote: > Was there an RFC for this? I ask because it's introducing another qualifier > and that has broad impacts on things beyond Clang like libc++, etc so we > really need buy-in from a wider range of the community than will likely see > this PR. Just my 2 cents from downstream experien

[clang] 1ea0865 - [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (#102521)

2024-08-09 Thread via cfe-commits
Author: Joel E. Denny Date: 2024-08-09T13:39:29-04:00 New Revision: 1ea0865dd6faf99ae25f22161c2aeb65ff9505c0 URL: https://github.com/llvm/llvm-project/commit/1ea0865dd6faf99ae25f22161c2aeb65ff9505c0 DIFF: https://github.com/llvm/llvm-project/commit/1ea0865dd6faf99ae25f22161c2aeb65ff9505c0.diff

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-09 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl closed https://github.com/llvm/llvm-project/pull/102521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-09 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: Thanks for the review. https://github.com/llvm/llvm-project/pull/102521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PAC] Add support for __ptrauth type qualifier (PR #100830)

2024-08-09 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > @rjmccall sent an RFC for upstreaming pointer authentication work to llvm-dev > in 2019, which mentions the `__ptrauth` qualifier. > https://discourse.llvm.org/t/rfc-pointer-authentication-for-arm64e/53433 > > I don't think we sent an RFC for adding support for the `__ptr

[clang] [llvm] Return available function types for BindingDecls. (PR #102196)

2024-08-09 Thread Samira Bazuzi via cfe-commits
bazuzi wrote: Any additional questions on this @mizvekov? https://github.com/llvm/llvm-project/pull/102196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Trivial refactoring of region invalidation (PR #102456)

2024-08-09 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/102456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Return available function types for BindingDecls. (PR #102196)

2024-08-09 Thread via cfe-commits
cor3ntin wrote: Nice tests, thanks. Do you need me to merge for you? https://github.com/llvm/llvm-project/pull/102196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [Static analyzer]: add initial support for builtin overflow (PR #102602)

2024-08-09 Thread Pavel Skripkin via cfe-commits
@@ -50,6 +101,44 @@ class BuiltinFunctionChecker : public Checker { } // namespace +void BuiltinFunctionChecker::HandleOverflowBuiltin(const CallEvent &Call, + CheckerContext &C, +

[clang] [clang-tools-extra] [clang-tidy] Add support for bsl::optional (PR #101450)

2024-08-09 Thread Chris Cotter via cfe-commits
https://github.com/ccotter updated https://github.com/llvm/llvm-project/pull/101450 >From f7e7681db6ad83878fd00cf250047c98b1b4f051 Mon Sep 17 00:00:00 2001 From: Chris Cotter Date: Tue, 23 Jul 2024 10:30:54 -0400 Subject: [PATCH 1/3] [clang-tidy] Add support for bsl::optional --- clang-tools-

[clang] [libclang/python] Fix bug in `SourceRange.__contains__`, add tests (PR #101802)

2024-08-09 Thread Vlad Serebrennikov via cfe-commits
@@ -386,6 +386,10 @@ def __contains__(self, other): # same file, in between lines if self.start.line < other.line < self.end.line: return True +# between columns in one-liner range +elif self.start.line == other.line == self.end.line:

[clang] [clang-tools-extra] [clang-tidy] Add support for bsl::optional (PR #101450)

2024-08-09 Thread Chris Cotter via cfe-commits
https://github.com/ccotter updated https://github.com/llvm/llvm-project/pull/101450 >From f7e7681db6ad83878fd00cf250047c98b1b4f051 Mon Sep 17 00:00:00 2001 From: Chris Cotter Date: Tue, 23 Jul 2024 10:30:54 -0400 Subject: [PATCH 1/3] [clang-tidy] Add support for bsl::optional --- clang-tools-

[clang] [clang][analyzer] Bring alpha.security.MmapWriteExec checker out of alpha package (PR #102636)

2024-08-09 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/102636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Bring alpha.security.MmapWriteExec checker out of alpha package (PR #102636)

2024-08-09 Thread Balazs Benics via cfe-commits
steakhal wrote: Have you checked the quality of the reports? https://github.com/llvm/llvm-project/pull/102636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Wire -fptrauth-returns to "ptrauth-returns" fn attribute. (PR #102416)

2024-08-09 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha updated https://github.com/llvm/llvm-project/pull/102416 >From 41061b347b7d0fa862f65896d4fc155cb0b791ba Mon Sep 17 00:00:00 2001 From: Ahmed Bougacha Date: Fri, 24 May 2024 20:24:26 -0700 Subject: [PATCH 1/2] [clang] Wire -fptrauth-returns to "ptrauth-returns" f

[clang] [llvm-lit] Use lit Syntax for Environment Variables in Clang subproject (PR #102647)

2024-08-09 Thread Paul Kirth via cfe-commits
@@ -87,12 +87,13 @@ /// -gcc has lowest priority so -gcc /// on PATH beats default triple in program path -// RUN: DEFAULT_TRIPLE=`%t/clang --version | grep "Target:" | cut -d ' ' -f2` -// RUN: touch %t/$DEFAULT_TRIPLE-gcc && chmod +x %t/$DEFAULT_TRIPLE-gcc -// RUN: touch %t/%

[clang] [llvm-lit] Use lit Syntax for Environment Variables in Clang subproject (PR #102647)

2024-08-09 Thread Paul Kirth via cfe-commits
@@ -87,12 +87,13 @@ /// -gcc has lowest priority so -gcc /// on PATH beats default triple in program path -// RUN: DEFAULT_TRIPLE=`%t/clang --version | grep "Target:" | cut -d ' ' -f2` -// RUN: touch %t/$DEFAULT_TRIPLE-gcc && chmod +x %t/$DEFAULT_TRIPLE-gcc -// RUN: touch %t/%

[clang] [analyzer][NFC] Improve documentation of `invalidateRegion` methods (PR #102477)

2024-08-09 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. LGTM. Do you plan to apply more refactors to invalidation and Store? I'm asking because currently we experiment with a complete Store rewrite - touching there invalidation as well. https://github.com/llvm/llvm-project/pull/102477 _

[clang] [DebugInfo][RemoveDIs] Use iterator-inserters in clang (PR #102006)

2024-08-09 Thread Sergei Barannikov via cfe-commits
https://github.com/s-barannikov edited https://github.com/llvm/llvm-project/pull/102006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DebugInfo][RemoveDIs] Use iterator-inserters in clang (PR #102006)

2024-08-09 Thread Sergei Barannikov via cfe-commits
https://github.com/s-barannikov commented: A couple of remarks in case this patch gets reverted. https://github.com/llvm/llvm-project/pull/102006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [DebugInfo][RemoveDIs] Use iterator-inserters in clang (PR #102006)

2024-08-09 Thread Sergei Barannikov via cfe-commits
@@ -293,20 +293,26 @@ void CodeGenFunction::initFullExprCleanupWithFlag(RawAddress ActiveFlag) { void EHScopeStack::Cleanup::anchor() {} static void createStoreInstBefore(llvm::Value *value, Address addr, - llvm::Instruction *beforeInst, +

[clang] [DebugInfo][RemoveDIs] Use iterator-inserters in clang (PR #102006)

2024-08-09 Thread Sergei Barannikov via cfe-commits
@@ -293,20 +293,26 @@ void CodeGenFunction::initFullExprCleanupWithFlag(RawAddress ActiveFlag) { void EHScopeStack::Cleanup::anchor() {} static void createStoreInstBefore(llvm::Value *value, Address addr, - llvm::Instruction *beforeInst, +

[clang] [clang] Wire -fptrauth-returns to "ptrauth-returns" fn attribute. (PR #102416)

2024-08-09 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha updated https://github.com/llvm/llvm-project/pull/102416 >From 41061b347b7d0fa862f65896d4fc155cb0b791ba Mon Sep 17 00:00:00 2001 From: Ahmed Bougacha Date: Fri, 24 May 2024 20:24:26 -0700 Subject: [PATCH 1/3] [clang] Wire -fptrauth-returns to "ptrauth-returns" f

[clang] [clang] Wire -fptrauth-returns to "ptrauth-returns" fn attribute. (PR #102416)

2024-08-09 Thread Ahmed Bougacha via cfe-commits
ahmedbougacha wrote: > @ahmedbougacha Non-blocking nit: you might want to add a test in > clang/test/CodeGen/ptrauth-function-attributes.c (like you have for auth > traps in https://github.com/llvm/llvm-project/pull/102417) Oh yeah that's certainly required; I think I dropped it accidentally

[clang] 2eb6e30 - [clang] Wire -fptrauth-returns to "ptrauth-returns" fn attribute. (#102416)

2024-08-09 Thread via cfe-commits
Author: Ahmed Bougacha Date: 2024-08-09T11:49:50-07:00 New Revision: 2eb6e30fe83ccce3cf01e596e73fa6385facd44b URL: https://github.com/llvm/llvm-project/commit/2eb6e30fe83ccce3cf01e596e73fa6385facd44b DIFF: https://github.com/llvm/llvm-project/commit/2eb6e30fe83ccce3cf01e596e73fa6385facd44b.diff

[clang] [clang] Wire -fptrauth-returns to "ptrauth-returns" fn attribute. (PR #102416)

2024-08-09 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha closed https://github.com/llvm/llvm-project/pull/102416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA] Emit used function list in deterministic order. (PR #102661)

2024-08-09 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B created https://github.com/llvm/llvm-project/pull/102661 Fixes https://github.com/llvm/llvm-project/issues/101560 >From 6ee0add21bd2a9b25d28640c91de2fc6dab7fa72 Mon Sep 17 00:00:00 2001 From: Artem Belevich Date: Fri, 9 Aug 2024 11:51:23 -0700 Subject: [PATCH] [CUDA]

[clang] [CUDA] Emit used function list in deterministic order. (PR #102661)

2024-08-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Artem Belevich (Artem-B) Changes Fixes https://github.com/llvm/llvm-project/issues/101560 --- Full diff: https://github.com/llvm/llvm-project/pull/102661.diff 1 Files Affected: - (modified) clang/lib/CodeGen/CodeGenModule.cpp (+

[clang] [CUDA] Emit used function list in deterministic order. (PR #102661)

2024-08-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Artem Belevich (Artem-B) Changes Fixes https://github.com/llvm/llvm-project/issues/101560 --- Full diff: https://github.com/llvm/llvm-project/pull/102661.diff 1 Files Affected: - (modified) clang/lib/CodeGen/CodeGenModule.cpp (+3) ``

[clang] [clang][analyzer] Remove array bounds check from PointerSubChecker (PR #102580)

2024-08-09 Thread Balazs Benics via cfe-commits
=?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: https://github.com/steakhal approved this pull request. I haven't really checked the PR, but we don't map the PointerSub checker to any rules. Maybe, after it's out of alpha we will come back and check if it makes sense for us :) Thank you wo

[clang] [clang][rtsan] Introduce realtime sanitizer codegen and driver (PR #102622)

2024-08-09 Thread Chris Apple via cfe-commits
https://github.com/cjappl updated https://github.com/llvm/llvm-project/pull/102622 >From 00d75e70c55e1e0c0b57a6402a9d02604a35dba6 Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Wed, 24 Jul 2024 14:25:44 -0700 Subject: [PATCH 1/2] [clang][rtsan] Introduce realtime sanitizer codegen and driver

[clang] [clang][rtsan] Introduce realtime sanitizer codegen and driver (PR #102622)

2024-08-09 Thread Chris Apple via cfe-commits
@@ -845,6 +845,12 @@ void CodeGenFunction::StartFunction(GlobalDecl GD, QualType RetTy, if (SanOpts.has(SanitizerKind::ShadowCallStack)) Fn->addFnAttr(llvm::Attribute::ShadowCallStack); + if (SanOpts.has(SanitizerKind::Realtime)) { +for (const FunctionEffectWithCon

[clang] [llvm] Return available function types for BindingDecls. (PR #102196)

2024-08-09 Thread Samira Bazuzi via cfe-commits
bazuzi wrote: Yes, thanks! https://github.com/llvm/llvm-project/pull/102196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lld] [llvm] [mlir] [CMake] Remove EXPORT_SYMBOLS_FOR_PLUGINS from #102138 (PR #102396)

2024-08-09 Thread Jake Egan via cfe-commits
jakeegan wrote: Thanks for the build fix! However we are now seeing a test failure that seems to be related https://lab.llvm.org/buildbot/#/builders/64/builds/643/steps/6/logs/FAIL__LLVM-Unit__DynamicLibraryTests_DynamicLibrar https://github.com/llvm/llvm-project/pull/102396 ___

[clang] e5697d7 - Return available function types for BindingDecls. (#102196)

2024-08-09 Thread via cfe-commits
Author: Samira Bazuzi Date: 2024-08-09T21:09:55+02:00 New Revision: e5697d7f99b441064a4e4c3c27c2fc8e5d2784c0 URL: https://github.com/llvm/llvm-project/commit/e5697d7f99b441064a4e4c3c27c2fc8e5d2784c0 DIFF: https://github.com/llvm/llvm-project/commit/e5697d7f99b441064a4e4c3c27c2fc8e5d2784c0.diff

[clang] [llvm] Return available function types for BindingDecls. (PR #102196)

2024-08-09 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/102196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA] Emit used function list in deterministic order. (PR #102661)

2024-08-09 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B updated https://github.com/llvm/llvm-project/pull/102661 >From 0f3944e1c12baa958f52c3c015a0cf5f9aeff1ed Mon Sep 17 00:00:00 2001 From: Artem Belevich Date: Fri, 9 Aug 2024 11:51:23 -0700 Subject: [PATCH] [CUDA] Emit used function list in deterministic order. Fixes ht

[clang] [libcxx] [Clang] Implement CWG2137 (list-initialization from objects of the same type) (PR #94355)

2024-08-09 Thread Yuxuan Chen via cfe-commits
yuxuanchen1997 wrote: A noob question but I wanted to make sure that this patch actually intended to reject program like this one? ``` #include #include class K { public: template K(const std::vector& v) { static_assert(!std::is_same::value, "Error!"); } }; void foo(std::vector&

[clang] [APINotes] Support C++ tag conformances to Swift protocols (PR #102664)

2024-08-09 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan created https://github.com/llvm/llvm-project/pull/102664 This allows adding a Clang attribute `swift_attr("conforms_to:ModuleName.ProtocolName")` to C++ structs via API Notes. The Swift compiler respects this attribute when importing C++ types into Swift by autom

[clang] [APINotes] Support C++ tag conformances to Swift protocols (PR #102664)

2024-08-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Egor Zhdan (egorzhdan) Changes This allows adding a Clang attribute `swift_attr("conforms_to:ModuleName.ProtocolName")` to C++ structs via API Notes. The Swift compiler respects this attribute when importing C++ types into Swift by auto

[clang] [clang-format] Change BinPackParameters to an enum to add a BreakAlways (PR #101882)

2024-08-09 Thread via cfe-commits
VolatileAcorn wrote: > If adding Leave is not trivial, we can support it in another patch. I couldn't see a simple way to implement Leave, but it's possible I've missed something. > Have you given any thought about [#53190 > (comment)](https://github.com/llvm/llvm-project/issues/53190#issueco

[clang] [clang-format] Change BinPackParameters to an enum to add a BreakAlways (PR #101882)

2024-08-09 Thread via cfe-commits
VolatileAcorn wrote: > Whilst I can understand BinPackParameters being deprecated, as its one of the > original options I do worry a little about just how much impact such a > deprecation might have... it needs to be completely seemless because there is > ALOT of documentation references to it

[clang] [APINotes] Support C++ tag conformances to Swift protocols (PR #102664)

2024-08-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff fb7028237bac1dccd328b6c3150e50e222a0879b 32d62daa94c30b1ddf95fc78e48866c8d4633bbb --e

[clang] [clang] Implement -fptrauth-auth-traps. (PR #102417)

2024-08-09 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha updated https://github.com/llvm/llvm-project/pull/102417 >From 241ecf478c0cc0e929ffef3532cc2cb625781a71 Mon Sep 17 00:00:00 2001 From: Ahmed Bougacha Date: Fri, 9 Aug 2024 12:26:20 -0700 Subject: [PATCH] [clang] Enable pointer authentication auth-failure traps.

[clang] d179acd - [clang] Implement -fptrauth-auth-traps. (#102417)

2024-08-09 Thread via cfe-commits
Author: Ahmed Bougacha Date: 2024-08-09T12:32:01-07:00 New Revision: d179acd0484bac30c5ebbbed4d29a4734d92ac93 URL: https://github.com/llvm/llvm-project/commit/d179acd0484bac30c5ebbbed4d29a4734d92ac93 DIFF: https://github.com/llvm/llvm-project/commit/d179acd0484bac30c5ebbbed4d29a4734d92ac93.diff

[clang] [clang] Implement -fptrauth-auth-traps. (PR #102417)

2024-08-09 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha closed https://github.com/llvm/llvm-project/pull/102417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Wire -fptrauth-returns to "ptrauth-returns" fn attribute. (PR #102416)

2024-08-09 Thread Anton Korobeynikov via cfe-commits
asl wrote: /cherry-pick 2eb6e30fe83ccce3cf01e596e73fa6385facd44b https://github.com/llvm/llvm-project/pull/102416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Wire -fptrauth-returns to "ptrauth-returns" fn attribute. (PR #102416)

2024-08-09 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl milestoned https://github.com/llvm/llvm-project/pull/102416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement -fptrauth-auth-traps. (PR #102417)

2024-08-09 Thread Anton Korobeynikov via cfe-commits
asl wrote: /cherry-pick d179acd0484bac30c5ebbbed4d29a4734d92ac93 https://github.com/llvm/llvm-project/pull/102417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement -fptrauth-auth-traps. (PR #102417)

2024-08-09 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl milestoned https://github.com/llvm/llvm-project/pull/102417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Wire -fptrauth-returns to "ptrauth-returns" fn attribute. (PR #102416)

2024-08-09 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#102670 https://github.com/llvm/llvm-project/pull/102416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement -fptrauth-auth-traps. (PR #102417)

2024-08-09 Thread via cfe-commits
llvmbot wrote: Failed to cherry-pick: d179acd0484bac30c5ebbbed4d29a4734d92ac93 https://github.com/llvm/llvm-project/actions/runs/10324823761 Please manually backport the fix and push it to your github fork. Once this is done, please create a [pull request](https://github.com/llvm/llvm-proje

[clang] [clang-tools-extra] [flang] [lld] [llvm] [mlir] [CMake] Remove EXPORT_SYMBOLS_FOR_PLUGINS from #102138 (PR #102396)

2024-08-09 Thread Steven Wu via cfe-commits
cachemeifyoucan wrote: @jakeegan I will create a PR to restore this target to the previous configuration but it would be good to figure out what flags/setting were different that caused that failure for you. https://github.com/llvm/llvm-project/pull/102396 _

[clang] [llvm] workflows/release-binaries: Enable flang builds on Windows (PR #101344)

2024-08-09 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/101344 >From a39c6d5e3decabab87ff9360851981123ff962d7 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Wed, 31 Jul 2024 07:36:48 -0700 Subject: [PATCH 1/5] workflows/release-binaries: Enable flang builds on Windows

[clang] [clang] [Static analyzer]: add initial support for builtin overflow (PR #102602)

2024-08-09 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/102602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [Static analyzer]: add initial support for builtin overflow (PR #102602)

2024-08-09 Thread Balazs Benics via cfe-commits
https://github.com/steakhal requested changes to this pull request. Looks pretty good! However, for this to land, we need to try harder to prevent state-splits. We must prove in more cases (at least in simple symbolic cases) that no overflow can happen. But in principle, I like that we do a sp

[clang] [clang] [Static analyzer]: add initial support for builtin overflow (PR #102602)

2024-08-09 Thread Balazs Benics via cfe-commits
@@ -21,16 +21,67 @@ #include "clang/StaticAnalyzer/Core/PathSensitive/CallDescription.h" #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h" #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" +#include "clang/StaticAnalyzer/Core/PathSensitive/Checker

[clang] [clang] [Static analyzer]: add initial support for builtin overflow (PR #102602)

2024-08-09 Thread Balazs Benics via cfe-commits
@@ -0,0 +1,65 @@ +// RUN: %clang_analyze_cc1 -triple x86_64-unknown-unknown -verify %s \ +// RUN: -analyzer-checker=core,debug.ExprInspection + +#define NULL ((void *)0) +#define INT_MAX __INT_MAX__ + +void clang_analyzer_dump_int(int); + +void test1(void) +{ + int res; +

[clang] [clang] [Static analyzer]: add initial support for builtin overflow (PR #102602)

2024-08-09 Thread Balazs Benics via cfe-commits
@@ -50,6 +101,44 @@ class BuiltinFunctionChecker : public Checker { } // namespace +void BuiltinFunctionChecker::HandleOverflowBuiltin(const CallEvent &Call, + CheckerContext &C, +

[clang] [clang] [Static analyzer]: add initial support for builtin overflow (PR #102602)

2024-08-09 Thread Balazs Benics via cfe-commits
@@ -21,16 +21,67 @@ #include "clang/StaticAnalyzer/Core/PathSensitive/CallDescription.h" #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h" #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" +#include "clang/StaticAnalyzer/Core/PathSensitive/Checker

[clang] [clang] [Static analyzer]: add initial support for builtin overflow (PR #102602)

2024-08-09 Thread Balazs Benics via cfe-commits
@@ -0,0 +1,65 @@ +// RUN: %clang_analyze_cc1 -triple x86_64-unknown-unknown -verify %s \ +// RUN: -analyzer-checker=core,debug.ExprInspection + +#define NULL ((void *)0) +#define INT_MAX __INT_MAX__ + +void clang_analyzer_dump_int(int); + +void test1(void) +{ + int res; + +

[clang] [clang] [Static analyzer]: add initial support for builtin overflow (PR #102602)

2024-08-09 Thread Balazs Benics via cfe-commits
@@ -278,6 +278,23 @@ int *mallocRegion(void) { return mem; } +int *custom_calloc(size_t a, size_t b) { + size_t res; + if (__builtin_mul_overflow(a, b, &res)) +return 0; + + return malloc(res); +} + +int *mallocRegionOverflow(void) { + int *mem = (int*)custom_calloc(

[clang] [clang] [Static analyzer]: add initial support for builtin overflow (PR #102602)

2024-08-09 Thread Balazs Benics via cfe-commits
@@ -21,16 +21,67 @@ #include "clang/StaticAnalyzer/Core/PathSensitive/CallDescription.h" #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h" #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" +#include "clang/StaticAnalyzer/Core/PathSensitive/Checker

<    1   2   3   4   5   >