[clang] [clang] constexpr built-in fma function. (PR #113020)

2024-10-21 Thread via cfe-commits
c8ef wrote: Dear reviewers, would you please take another look? @tbaederr @philnik777 https://github.com/llvm/llvm-project/pull/113020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Diagnose invalid declrefs differently if we've... (PR #113140)

2024-10-21 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/113140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Emit error for duplicate mangled names within a lambda (PR #107581)

2024-10-21 Thread Kerry McLaughlin via cfe-commits
https://github.com/kmclaughlin-arm updated https://github.com/llvm/llvm-project/pull/107581 >From 1e6f25c517d8d1adeeaf59f826141efdcad8f05a Mon Sep 17 00:00:00 2001 From: Kerry McLaughlin Date: Fri, 6 Sep 2024 10:13:33 + Subject: [PATCH 1/6] [Clang] Emit error for duplicate mangled names wit

[clang] [OpenCL] Add cl_ext_image_unorm_int_2_101010_EXT extension (PR #113145)

2024-10-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sven van Haastregt (svenvh) Changes Add the defines for the `cl_ext_image_unorm_int_2_101010_EXT` extension. --- Full diff: https://github.com/llvm/llvm-project/pull/113145.diff 2 Files Affected: - (modified) clang/lib/Headers/opencl-c-

[clang] [clang] constexpr built-in fma function. (PR #113020)

2024-10-21 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: Ah, it's #88978 https://github.com/llvm/llvm-project/pull/113020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AArch64] Fix Pure Scalables Types argument passing and return (PR #112747)

2024-10-21 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov updated https://github.com/llvm/llvm-project/pull/112747 >From c2f223d84c18498f3cbe1582b006b0d4c52999aa Mon Sep 17 00:00:00 2001 From: Momchil Velikov Date: Thu, 17 Oct 2024 14:04:05 +0100 Subject: [PATCH 1/4] [Clang][AArch64] Fix Pure Scalables Types argument

[clang] [Clang][AArch64] Fix Pure Scalables Types argument passing and return (PR #112747)

2024-10-21 Thread Momchil Velikov via cfe-commits
@@ -353,6 +427,17 @@ AArch64ABIInfo::classifyArgumentType(QualType Ty, bool IsVariadic, nullptr, true, Align); } + // In AAPCS named arguments of a Pure Scalable Type are passed expanded in + // registers, or indirectly if there are not enough registers. + if (Ki

[clang] [llvm] [Clang] Fix argument extensions in CGBlocks.cpp (PR #111740)

2024-10-21 Thread Jonas Paulsson via cfe-commits
JonPsson1 wrote: Ping! I'd love to get this check enabled by default after fixing the issues I see... This is the only one for Objective-C (the second one here came up after fixing the first one). https://github.com/llvm/llvm-project/pull/111740 __

[clang] [flang] [libclc] [llvm] [AMDGPU] Add a new target for gfx1153 (PR #113138)

2024-10-21 Thread Jay Foad via cfe-commits
https://github.com/jayfoad approved this pull request. LGTM. The compiler currently treats it as identical to gfx1152, right? https://github.com/llvm/llvm-project/pull/113138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [clang] Add covariance tests that make sure we return an error when return value is different in pointer / lvalue ref / rvalue ref (PR #112853)

2024-10-21 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: Can you merge `main` into your branch? I think that should fix the CI failures. https://github.com/llvm/llvm-project/pull/112853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] [PAC][Driver] Add `-faarch64-jump-table-hardening` flag (PR #113149)

2024-10-21 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 edited https://github.com/llvm/llvm-project/pull/113149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [mlir] [IR] Introduce `U` to `DataLayout` to represent undesirable address space if a target has it (PR #108786)

2024-10-21 Thread Alex Voicu via cfe-commits
AlexVlx wrote: > > More specifically, how do you expect Clang to figure this out when e.g. > > compiling C++ for some AS rich target that decided to default to something > > odd > > I do not expect clang to be using the datalayout to decide anything. That is > not really the purpose of the da

[clang] [flang] [libclc] [llvm] [AMDGPU] Add a new target for gfx1153 (PR #113138)

2024-10-21 Thread Shilei Tian via cfe-commits
@@ -46,7 +46,7 @@ set(all_amdgpu_architectures "gfx700;gfx701;gfx801;gfx803;gfx900;gfx902;gfx906" "gfx908;gfx90a;gfx90c;gfx940;gfx941;gfx942;gfx1010" "gfx1030;gfx1031;gfx1032;gfx1033;gfx1034;gfx1035"

[clang] [flang] [libclc] [llvm] [AMDGPU] Add a new target for gfx1153 (PR #113138)

2024-10-21 Thread Shilei Tian via cfe-commits
https://github.com/shiltian approved this pull request. https://github.com/llvm/llvm-project/pull/113138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [libclc] [llvm] [AMDGPU] Add a new target for gfx1153 (PR #113138)

2024-10-21 Thread Joseph Huber via cfe-commits
@@ -46,7 +46,7 @@ set(all_amdgpu_architectures "gfx700;gfx701;gfx801;gfx803;gfx900;gfx902;gfx906" "gfx908;gfx90a;gfx90c;gfx940;gfx941;gfx942;gfx1010" "gfx1030;gfx1031;gfx1032;gfx1033;gfx1034;gfx1035"

[clang] [llvm] [ARM] Fix -mno-omit-leaf-frame-pointer flag doesn't works on 32-bit ARM (PR #109628)

2024-10-21 Thread David Spickett via cfe-commits
DavidSpickett wrote: FYI we found an issue with this when testing lldb - https://github.com/llvm/llvm-project/issues/113154 No clear indication yet whether this change uncovered an existing problem, or has caused a new one. https://github.com/llvm/llvm-project/pull/109628

[clang] [clang] Make -fveclib={ArmPL, SLEEF} imply -fno-math-errno (PR #112580)

2024-10-21 Thread Benjamin Maxwell via cfe-commits
@@ -2960,6 +2969,12 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, } for (const Arg *A : Args) { +auto CheckMathErrnoForVecLib = +llvm::make_scope_exit([&, MathErrnoBeforeArg = MathErrno] { + if (NoMathErrnoWasImpliedB

[clang] [llvm] [ci] Write test results to unique file names (PR #113160)

2024-10-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: David Spickett (DavidSpickett) Changes In this patch I'm using a new lit option so that the pipeline writes many results files, one for each time lit is run: ``` --use-unique-output-file-name When enabled, lit will add a unique element t

[clang] [llvm] [ci] Write test results to unique file names (PR #113160)

2024-10-21 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113160 >From 950796f7294617709ead792ed322772e7f8205fd Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 1/2] [ci] Write test results to unique file names In this

[clang] [flang] [libclc] [llvm] [AMDGPU] Add a new target for gfx1153 (PR #113138)

2024-10-21 Thread Jay Foad via cfe-commits
@@ -603,26 +610,30 @@ Generic processor code objects are versioned. See :ref:`amdgpu-generic-processor - ``gfx1103`` work-item within this family. - ``gfx1150``

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-21 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree closed https://github.com/llvm/llvm-project/pull/111723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

2024-10-21 Thread Abhina Sree via cfe-commits
abhina-sree wrote: Closing this because an alternative solution was implemented here https://github.com/llvm/llvm-project/pull/111723 https://github.com/llvm/llvm-project/pull/110661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

2024-10-21 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree closed https://github.com/llvm/llvm-project/pull/110661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add covariance tests that make sure we return an error when return value is different in pointer / lvalue ref / rvalue ref (PR #112853)

2024-10-21 Thread Boaz Brickner via cfe-commits
https://github.com/bricknerb updated https://github.com/llvm/llvm-project/pull/112853 >From b1ffbf6b7a59d1e57dccf8b9fab32c2c7d599058 Mon Sep 17 00:00:00 2001 From: Boaz Brickner Date: Mon, 21 Oct 2024 13:07:37 +0200 Subject: [PATCH 1/2] [clang] Add covariance tests that make sure we return an

[clang] [clang] Add covariance tests that make sure we return an error when return value is different in pointer / lvalue ref / rvalue ref (PR #112853)

2024-10-21 Thread Boaz Brickner via cfe-commits
bricknerb wrote: > You should write a test in `clang/test/CXX/drs/cwg0xx.cpp`, possibly by > moving the test you've written there. While doing that, you should follow the > example of other tests in that file, which includes the way `expected` > directives are written, and the presence of `//

[clang] [lldb] [clang][RecordLayoutBuilder] Be stricter about inferring packed-ness in ExternalLayouts (PR #97443)

2024-10-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/97443 >From 38b7837bcc5da9e89778191654f9552ebccacbd5 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 2 Jul 2024 18:43:34 +0200 Subject: [PATCH 1/3] [clang][RecordLayoutBuilder] Be stricter about inferring pa

[clang-tools-extra] [clang-tidy] Create a check for signed and unsigned integers comparison (PR #113144)

2024-10-21 Thread via cfe-commits
https://github.com/qt-tatiana created https://github.com/llvm/llvm-project/pull/113144 - modernize-use-integer-sign-comparison check performs comparisons between signed and unsigned integer types mathematically correct. If C++20 is supported the check replaces integers comparisons to std::cmp_

[clang] [analyzer] Add alpha.cplusplus.BoundsInformation checker (PR #112784)

2024-10-21 Thread Gábor Horváth via cfe-commits
@@ -0,0 +1,199 @@ +//== BoundsInformationChecker.cpp - bounds information checker --*- C++ -*--==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang][HIP] Deprecate the AMDGCN_WAVEFRONT_SIZE macros (PR #112849)

2024-10-21 Thread Shilei Tian via cfe-commits
https://github.com/shiltian commented: Just a heads up, this change is gonna break some OpenMP tests, specifically those prefix with `ompx`. https://github.com/llvm/llvm-project/pull/112849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] [Clang][HIP] Deprecate the AMDGCN_WAVEFRONT_SIZE macros (PR #112849)

2024-10-21 Thread Joseph Huber via cfe-commits
jhuber6 wrote: I made https://github.com/llvm/llvm-project/pull/113156 to hopefully address the OpenMP issue. We use it in the runtime itself for a lot of stuff so removing it would definitely break that. The function call here matches what NVIDIA provides via PTX. I think we should have an op

[clang] [clang] Add covariance tests that make sure we return an error when return value is different in pointer / lvalue ref / rvalue ref (PR #112853)

2024-10-21 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > clang/www/make_cxx_dr_status seems to generate a lot of unrelated changes, so > perhaps a separate pull request would make sense if we want to update > cxx_dr_status.html. Ignore other changes; just include the one that updates CWG960 status. I'll update the rest as an NFC cha

[clang] 46dc91e - [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (#111723)

2024-10-21 Thread via cfe-commits
Author: Abhina Sree Date: 2024-10-21T08:20:22-04:00 New Revision: 46dc91e7d9a1b6dd0144e628519d06954b7b4e53 URL: https://github.com/llvm/llvm-project/commit/46dc91e7d9a1b6dd0144e628519d06954b7b4e53 DIFF: https://github.com/llvm/llvm-project/commit/46dc91e7d9a1b6dd0144e628519d06954b7b4e53.diff L

[clang] [flang] [flang] integrate the option -flang-experimental-integer-overflow into -fno-wrapv (PR #110063)

2024-10-21 Thread Yusuke MINATO via cfe-commits
https://github.com/yus3710-fj updated https://github.com/llvm/llvm-project/pull/110063 >From 934a116155c63fdad76096faa4edd3a9c19ff5d8 Mon Sep 17 00:00:00 2001 From: Yusuke MINATO Date: Thu, 19 Sep 2024 14:44:49 +0900 Subject: [PATCH] [flang] integrate the option -flang-experimental-integer-ove

[clang] [Clang][Builtin] add __builtin_exit (PR #74803)

2024-10-21 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 closed https://github.com/llvm/llvm-project/pull/74803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Builtin] add __builtin_exit (PR #74803)

2024-10-21 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: Closing, since it seems to be abandoned. https://github.com/llvm/llvm-project/pull/74803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenCL] Add cl_ext_image_unorm_int_2_101010_EXT extension (PR #113145)

2024-10-21 Thread Sven van Haastregt via cfe-commits
svenvh wrote: Extension specification: https://github.com/KhronosGroup/OpenCL-Docs/pull/1223 https://github.com/llvm/llvm-project/pull/113145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [OpenCL] Add cl_ext_image_unorm_int_2_101010_EXT extension (PR #113145)

2024-10-21 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/113145 Add the defines for the `cl_ext_image_unorm_int_2_101010_EXT` extension. >From 168a54775bb876094fe90ef89cab66b8cc08e4f3 Mon Sep 17 00:00:00 2001 From: Sven van Haastregt Date: Mon, 21 Oct 2024 11:19:13 +0100 Sub

[clang] [lldb] [clang][RecordLayoutBuilder] Be stricter about inferring packed-ness in ExternalLayouts (PR #97443)

2024-10-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 commented: gentle ping @efriedma-quic mind taking another look? Latest iteration skips over empty fields that overlap. https://github.com/llvm/llvm-project/pull/97443 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang-tools-extra] [clang-tidy] Create a check for signed and unsigned integers comparison (PR #113144)

2024-10-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: None (qt-tatiana) Changes - modernize-use-integer-sign-comparison check performs comparisons between signed and unsigned integer types mathematically correct. If C++20 is supported the check replaces integers comparisons to std::cmp_

[clang-tools-extra] [clang-tidy] Create a check for signed and unsigned integers comparison (PR #113144)

2024-10-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: None (qt-tatiana) Changes - modernize-use-integer-sign-comparison check performs comparisons between signed and unsigned integer types mathematically correct. If C++20 is supported the check replaces integers comparisons to st

[clang] 159f253 - [clang][bytecode] Diagnose invalid declrefs differently if we've... (#113140)

2024-10-21 Thread via cfe-commits
Author: Timm Baeder Date: 2024-10-21T12:07:09+02:00 New Revision: 159f25301763215ffc49c3c3aa6cb8095a990b41 URL: https://github.com/llvm/llvm-project/commit/159f25301763215ffc49c3c3aa6cb8095a990b41 DIFF: https://github.com/llvm/llvm-project/commit/159f25301763215ffc49c3c3aa6cb8095a990b41.diff L

[clang] [clang] constexpr built-in fma function. (PR #113020)

2024-10-21 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: This is definitely a requirement to implement this, but we also have to make the non-`__builtin_`-prefixed versions `constexpr`, since libc++ doesn't control their definitions. I'm pretty sure there was a PR that does this for some math function, but I can't find it right now

[clang-tools-extra] [clang-tidy] Create a check for signed and unsigned integers comparison (PR #113144)

2024-10-21 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] [PAC][ELF][AArch64] Support signed personality function pointer (PR #113148)

2024-10-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo Author: Daniil Kovalev (kovdan01) Changes If function pointer signing is enabled, sign personality function pointer stored in `.DW.ref.__gxx_personality_v0` section with IA key, 0x7EAD = `ptrauth_string_discriminator("personality")` constant

[clang] [flang] [libclc] [llvm] [AMDGPU] Add a new target for gfx1153 (PR #113138)

2024-10-21 Thread Carl Ritson via cfe-commits
perlfu wrote: > The compiler currently treats it as identical to gfx1152, right? Correct. https://github.com/llvm/llvm-project/pull/113138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [flang] [flang] Integrate the option -flang-experimental-integer-overflow into -fno-wrapv (PR #110063)

2024-10-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yusuke MINATO (yus3710-fj) Changes nsw is added to do-variable increment when -fno-wrapv is enabled as GFortran seems to do. Therefore, the option introduced by #91579 isn't necessary any more. Note that the feature of -flang-experimental

[clang] [flang] [flang] Integrate the option -flang-experimental-integer-overflow into -fno-wrapv (PR #110063)

2024-10-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Yusuke MINATO (yus3710-fj) Changes nsw is added to do-variable increment when -fno-wrapv is enabled as GFortran seems to do. Therefore, the option introduced by #91579 isn't necessary any more. Note that the feature of -flang-exper

[clang] [flang] [flang] Integrate the option -flang-experimental-integer-overflow into -fno-wrapv (PR #110063)

2024-10-21 Thread Yusuke MINATO via cfe-commits
https://github.com/yus3710-fj edited https://github.com/llvm/llvm-project/pull/110063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Integrate the option -flang-experimental-integer-overflow into -fno-wrapv (PR #110063)

2024-10-21 Thread Yusuke MINATO via cfe-commits
https://github.com/yus3710-fj ready_for_review https://github.com/llvm/llvm-project/pull/110063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add covariance tests that make sure we return an error when return value is different in pointer / lvalue ref / rvalue ref (PR #112853)

2024-10-21 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/112853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add covariance tests that make sure we return an error when return value is different in pointer / lvalue ref / rvalue ref (PR #112853)

2024-10-21 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: I left suggestions for one of the errors you're expecting. You should apply those to the rest of expected directives. https://github.com/llvm/llvm-project/pull/112853 ___ cfe-commits mailing list cfe-commits@lists

[clang] [clang] Add covariance tests that make sure we return an error when return value is different in pointer / lvalue ref / rvalue ref (PR #112853)

2024-10-21 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: Do you even need to change anything in this file now? https://github.com/llvm/llvm-project/pull/112853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] [clang] Add covariance tests that make sure we return an error when return value is different in pointer / lvalue ref / rvalue ref (PR #112853)

2024-10-21 Thread Vlad Serebrennikov via cfe-commits
@@ -93,6 +93,38 @@ struct B : A { } // namespace example2 } // namespace cwg952 +namespace cwg960 { // cwg960: 2.8 +struct a {}; +class A { +#if __cplusplus >= 201103L + // Check lvalue ref vs rvalue ref vs pointer. + virtual a& rvalue_ref(); + virtual a&& lvalue_ref(); +

[clang] [clang] Add covariance tests that make sure we return an error when return value is different in pointer / lvalue ref / rvalue ref (PR #112853)

2024-10-21 Thread Vlad Serebrennikov via cfe-commits
@@ -93,6 +93,38 @@ struct B : A { } // namespace example2 } // namespace cwg952 +namespace cwg960 { // cwg960: 2.8 +struct a {}; +class A { +#if __cplusplus >= 201103L + // Check lvalue ref vs rvalue ref vs pointer. + virtual a& rvalue_ref(); + virtual a&& lvalue_ref(); +

[clang] [clang] Add covariance tests that make sure we return an error when return value is different in pointer / lvalue ref / rvalue ref (PR #112853)

2024-10-21 Thread Vlad Serebrennikov via cfe-commits
@@ -93,6 +93,38 @@ struct B : A { } // namespace example2 } // namespace cwg952 +namespace cwg960 { // cwg960: 2.8 Endilll wrote: ```suggestion namespace cwg960 { // cwg960: 3.0 ``` https://godbolt.org/z/o77989zM7 https://github.com/llvm/llvm-project/pull/11

[clang] [clang] Add covariance tests that make sure we return an error when return value is different in pointer / lvalue ref / rvalue ref (PR #112853)

2024-10-21 Thread Boaz Brickner via cfe-commits
https://github.com/bricknerb updated https://github.com/llvm/llvm-project/pull/112853 >From b1ffbf6b7a59d1e57dccf8b9fab32c2c7d599058 Mon Sep 17 00:00:00 2001 From: Boaz Brickner Date: Mon, 21 Oct 2024 13:07:37 +0200 Subject: [PATCH 1/6] [clang] Add covariance tests that make sure we return an

[clang] [clang] Add covariance tests that make sure we return an error when return value is different in pointer / lvalue ref / rvalue ref (PR #112853)

2024-10-21 Thread Boaz Brickner via cfe-commits
@@ -93,6 +93,38 @@ struct B : A { } // namespace example2 } // namespace cwg952 +namespace cwg960 { // cwg960: 2.8 +struct a {}; +class A { +#if __cplusplus >= 201103L + // Check lvalue ref vs rvalue ref vs pointer. + virtual a& rvalue_ref(); + virtual a&& lvalue_ref(); +

[clang] [clang] Add covariance tests that make sure we return an error when return value is different in pointer / lvalue ref / rvalue ref (PR #112853)

2024-10-21 Thread Boaz Brickner via cfe-commits
@@ -93,6 +93,38 @@ struct B : A { } // namespace example2 } // namespace cwg952 +namespace cwg960 { // cwg960: 2.8 +struct a {}; +class A { +#if __cplusplus >= 201103L + // Check lvalue ref vs rvalue ref vs pointer. + virtual a& rvalue_ref(); + virtual a&& lvalue_ref(); +

[clang] [clang] Add covariance tests that make sure we return an error when return value is different in pointer / lvalue ref / rvalue ref (PR #112853)

2024-10-21 Thread Boaz Brickner via cfe-commits
bricknerb wrote: > > clang/www/make_cxx_dr_status seems to generate a lot of unrelated changes, > > so perhaps a separate pull request would make sense if we want to update > > cxx_dr_status.html. > > Ignore other changes; just include the one that updates CWG960 status. I'll > update the res

[clang] [clang] Add covariance tests that make sure we return an error when return value is different in pointer / lvalue ref / rvalue ref (PR #112853)

2024-10-21 Thread Boaz Brickner via cfe-commits
@@ -93,6 +93,38 @@ struct B : A { } // namespace example2 } // namespace cwg952 +namespace cwg960 { // cwg960: 2.8 bricknerb wrote: Thanks! Done. https://github.com/llvm/llvm-project/pull/112853 ___ cfe-commits mai

[clang] [llvm] APFloat: Fix maxnum and minnum with sNaN (PR #112854)

2024-10-21 Thread Matt Arsenault via cfe-commits
@@ -582,7 +582,46 @@ TEST(APFloatTest, MinNum) { APFloat zp(0.0); APFloat zn(-0.0); EXPECT_EQ(-0.0, minnum(zp, zn).convertToDouble()); - EXPECT_EQ(-0.0, minnum(zn, zp).convertToDouble()); + + APInt intPayload_89ab(64, 0x89ab); arsenm wrote: Can / shoul

[clang] [llvm] APFloat: Fix maxnum and minnum with sNaN (PR #112854)

2024-10-21 Thread Matt Arsenault via cfe-commits
@@ -15338,16 +15338,11 @@ bool FloatExprEvaluator::VisitCallExpr(const CallExpr *E) { case Builtin::BI__builtin_fmaxl: case Builtin::BI__builtin_fmaxf16: case Builtin::BI__builtin_fmaxf128: { -// TODO: Handle sNaN. APFloat RHS(0.); if (!EvaluateFloat(E->get

[clang] [PAC][Driver] Add `-faarch64-jump-table-hardening` flag (PR #113149)

2024-10-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Daniil Kovalev (kovdan01) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/113149.diff 8 Files Affected: - (modified) clang/include/clang/Basic/LangOptions.def (+1) - (modified) clang/include/clang/Basic/PointerAuthOpt

[clang] [PAC][Driver] Add `-faarch64-jump-table-hardening` flag (PR #113149)

2024-10-21 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 ready_for_review https://github.com/llvm/llvm-project/pull/113149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PAC][Driver] Add `-faarch64-jump-table-hardening` flag (PR #113149)

2024-10-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Daniil Kovalev (kovdan01) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/113149.diff 8 Files Affected: - (modified) clang/include/clang/Basic/LangOptions.def (+1) - (modified) clang/include/clang/Basic/Pointe

[clang] [compiler-rt] [lld] [llvm] [Coverage][WebAssembly] Add initial support for WebAssembly/WASI (PR #111332)

2024-10-21 Thread Zequan Wu via cfe-commits
ZequanWu wrote: Oh, I see, there are windows version of `flock` in `WindowsMMap.h`, and this new macro `COMPILER_RT_HAS_FLOCK` is defined here: [for linux](https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/profile/CMakeLists.txt#L41-L50) https://github.com/llvm/llvm-project/pull/1

[clang] [AMDGPU] Allow overload of __builtin_amdgcn_mov/update_dpp (PR #112447)

2024-10-21 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec updated https://github.com/llvm/llvm-project/pull/112447 >From 761b3e21748dd3a7b53cd0ead745943213317eb4 Mon Sep 17 00:00:00 2001 From: Stanislav Mekhanoshin Date: Tue, 15 Oct 2024 15:23:28 -0700 Subject: [PATCH 1/7] [AMDGPU] Allow overload of __builtin_amdgcn_mov/up

[clang] [compiler-rt] [llvm] [FMV][AArch64] Unify features memtag and memtag2. (PR #112511)

2024-10-21 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/112511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AArch64] Fix Pure Scalables Types argument passing and return (PR #112747)

2024-10-21 Thread Eli Friedman via cfe-commits
@@ -0,0 +1,338 @@ +// RUN: %clang_cc1 -O3 -triple aarch64 -target-feature +sve -target-feature +sve2p1 -mvscale-min=1 -mvscale-max=1 -emit-llvm -o - %s | FileCheck %s --check-prefixes=CHECK,CHECK-AAPCS +// RUN: %clang_cc1 -O3 -triple arm64-apple-

[clang] [compiler-rt] [llvm] [FMV][AArch64] Unify features memtag and memtag2. (PR #112511)

2024-10-21 Thread Alexandros Lamprineas via cfe-commits
labrinea wrote: Ping. https://github.com/llvm/llvm-project/pull/112511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Add soft-float ABI (PR #84146)

2024-10-21 Thread Shafik Yaghmour via cfe-commits
shafik wrote: This is also linked to this clang-19 regression: https://github.com/llvm/llvm-project/issues/110914 https://github.com/llvm/llvm-project/pull/84146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] Thread Safety Analysis: Support passing scoped locks between functions with appropriate annotations (PR #110523)

2024-10-21 Thread Aaron Puchert via cfe-commits
https://github.com/aaronpuchert approved this pull request. This looks great! Let's wait a bit for the other reviewers, but otherwise I'm ready to merge it. https://github.com/llvm/llvm-project/pull/110523 ___ cfe-commits mailing list cfe-commits@list

[clang] [compiler-rt] [lld] [llvm] [Coverage][WebAssembly] Add initial support for WebAssembly/WASI (PR #111332)

2024-10-21 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: perhaps the `flock` cmake check doesn't work on windows for some reason? maybe wrong include? https://github.com/llvm/llvm-project/pull/111332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [compiler-rt] [llvm] [FMV][AArch64] Unify features memtag and memtag2. (PR #112511)

2024-10-21 Thread Alexandros Lamprineas via cfe-commits
labrinea wrote: Thanks! https://github.com/llvm/llvm-project/pull/112511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Allow overload of __builtin_amdgcn_mov/update_dpp (PR #112447)

2024-10-21 Thread Matt Arsenault via cfe-commits
arsenm wrote: > I actually wish a better way to have overloaded builtins in clang. I do not > believe any user of these builtins is expecting that a wide integer will be > silently truncated, and any fp will go through fptosi and backwards after, > like we do now. Yes, C was a mistake http

[clang] Add CHECK-LABEL to avoid source tree path sensitivity in test (PR #112461)

2024-10-21 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. Could also consider checking for `ret void` instead, as that's more flexible if someone were to add another test case later in the file. This seems fine too though. https://github.com/llvm/llvm-project/pull/112461 __

[clang] [Concepts] Add regression test for #99036 (PR #113137)

2024-10-21 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/113137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AArch64] Fix Pure Scalables Types argument passing and return (PR #112747)

2024-10-21 Thread Eli Friedman via cfe-commits
@@ -0,0 +1,338 @@ +// RUN: %clang_cc1 -O3 -triple aarch64 -target-feature +sve -target-feature +sve2p1 -mvscale-min=1 -mvscale-max=1 -emit-llvm -o - %s | FileCheck %s --check-prefixes=CHECK,CHECK-AAPCS +// RUN: %clang_cc1 -O3 -triple arm64-apple-

[clang] [compiler-rt] [lld] [llvm] [Coverage][WebAssembly] Add initial support for WebAssembly/WASI (PR #111332)

2024-10-21 Thread Zequan Wu via cfe-commits
ZequanWu wrote: Given there's already an implementation of `flock` in `compiler-rt/lib/profile/WindowsMMap.c`. Setting `COMPILER_RT_TARGET_HAS_FLOCK` according to this https://github.com/llvm/llvm-project/blob/7dc2542ac24fcae89dfd179fa58c4ec4fb959e2b/compiler-rt/lib/profile/CMakeLists.txt#L41-

[clang-tools-extra] [clang-tidy] Fix for cppcoreguidelines-pro-type-union-access if memLoc is invalid (PR #104540)

2024-10-21 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank edited https://github.com/llvm/llvm-project/pull/104540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix for cppcoreguidelines-pro-type-union-access if memLoc is invalid (PR #104540)

2024-10-21 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank approved this pull request. LGTM! Minus alphabetical ordering in release notes. I'll merge this tomorrow to give time to others just in case. FWIW this issue actually triggers a crash/assertion failure when those are enabled: ``` clang-tidy: clang-tools-extra/clang-

[clang-tools-extra] [clang-tidy] Fix for cppcoreguidelines-pro-type-union-access if memLoc is invalid (PR #104540)

2024-10-21 Thread Nicolas van Kempen via cfe-commits
@@ -141,6 +141,10 @@ New check aliases Changes in existing checks ^^ +- Fixed :doc:`cppcoreguidelines-pro-type-union-access + ` check to + report a location even when the member location is not valid. nicovank wrote: Order alphabetic

[clang] [clang][bytecode] Create dummy pointers for non-reference DeclRefExprs (PR #113202)

2024-10-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes ... with non-constant initializers. --- Full diff: https://github.com/llvm/llvm-project/pull/113202.diff 5 Files Affected: - (modified) clang/lib/AST/ByteCode/Compiler.cpp (+39-37) - (modified) clang/lib/

[clang] [clang][bytecode] Create dummy pointers for non-reference DeclRefExprs (PR #113202)

2024-10-21 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/113202 ... with non-constant initializers. >From c7bf46114ffe0b35c3e73e4c956d84e71b2db14f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 21 Oct 2024 18:36:37 +0200 Subject: [PATCH] [clang][by

[clang] [compiler-rt] [llvm] [FMV][AArch64] Unify features memtag and memtag2. (PR #112511)

2024-10-21 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea updated https://github.com/llvm/llvm-project/pull/112511 >From ae0d1f894f15d0af299210bb617dbaf905797a39 Mon Sep 17 00:00:00 2001 From: Alexandros Lamprineas Date: Tue, 15 Oct 2024 17:43:25 +0100 Subject: [PATCH] [FMV][AArch64] Unify features memtag and memtag2. If w

[clang] [TBAA] Extend pointer TBAA to pointers of non-builtin types. (PR #110569)

2024-10-21 Thread Florian Hahn via cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/110569 >From c9c80249a09dbfae6287904777b6d3032ff688cb Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Mon, 30 Sep 2024 10:12:01 +0100 Subject: [PATCH 1/3] [TBAA] Extend pointer TBAA to pointers of non-builtin types.

[clang] [llvm] [Clang] Match MSVC handling of duplicate header search paths in Microsoft compatibility modes. (PR #105738)

2024-10-21 Thread Tom Honermann via cfe-commits
tahonermann wrote: @zygoloid, > On the fourth hand, IIRC the choice of whether header search for a relative > path looks in the directory of includers as well as the directory of the > current file already depends on `-fms-compatibility`, and this seems sort of > similar. I confirmed the sear

[clang] [llvm] [HLSL] Re-implement countbits with the correct return type (PR #113189)

2024-10-21 Thread Brian Favela via cfe-commits
@@ -705,66 +705,74 @@ float4 cosh(float4); #ifdef __HLSL_ENABLE_16_BIT _HLSL_AVAILABILITY(shadermodel, 6.2) -_HLSL_BUILTIN_ALIAS(__builtin_elementwise_popcount) -int16_t countbits(int16_t); bfavela wrote: Sorry I missed the earlier PR where this was added, bu

[clang] [clang-tools-extra] [clang][dataflow] Cache accessors for bugprone-unchecked-optional-access (PR #112605)

2024-10-21 Thread Jan Voung via cfe-commits
https://github.com/jvoung updated https://github.com/llvm/llvm-project/pull/112605 >From 57a913c8870b338fa127f323be65fda972d65a96 Mon Sep 17 00:00:00 2001 From: Jan Voung Date: Wed, 16 Oct 2024 19:38:45 + Subject: [PATCH 1/3] [clang][dataflow] Cache accessors for bugprone-unchecked-optiona

[clang] [clang-tools-extra] [clang][dataflow] Cache accessors for bugprone-unchecked-optional-access (PR #112605)

2024-10-21 Thread Jan Voung via cfe-commits
@@ -523,6 +544,99 @@ void transferCallReturningOptional(const CallExpr *E, setHasValue(*Loc, State.Env.makeAtomicBoolValue(), State.Env); } +void handleConstMemberCall(const CallExpr *CE, + dataflow::RecordStorageLocation *RecordLoc, +

[clang] [clang-tools-extra] [clang][dataflow] Cache accessors for bugprone-unchecked-optional-access (PR #112605)

2024-10-21 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ae778ae7ce72219270c30d5c8b3d88c9a4803f81 38ee8196fd5e4440604d50a6b4bfce4371348b78 --e

[clang] [clang] Make -fveclib={ArmPL, SLEEF} imply -fno-math-errno (PR #112580)

2024-10-21 Thread Paul Walker via cfe-commits
https://github.com/paulwalker-arm approved this pull request. https://github.com/llvm/llvm-project/pull/112580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Catch missing format attributes (PR #105479)

2024-10-21 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovichtec updated https://github.com/llvm/llvm-project/pull/105479 From 2bda7fec2d78679f7f981f13ad612684d208d6c6 Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribute

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-10-21 Thread kadir çetinkaya via cfe-commits
@@ -85,19 +85,20 @@ class PrerequisiteModules { /// different versions and different source files. class ModulesBuilder { kadircet wrote: can we just introduce a new helper class ```cpp class ModulesBuilder { ... private: class ModuleFileCache; std::unique_

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-10-21 Thread kadir çetinkaya via cfe-commits
@@ -85,19 +85,20 @@ class PrerequisiteModules { /// different versions and different source files. class ModulesBuilder { public: - ModulesBuilder(const GlobalCompilationDatabase &CDB) : CDB(CDB) {} + ModulesBuilder() = default; + virtual ~ModulesBuilder() = default; Mo

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-10-21 Thread kadir çetinkaya via cfe-commits
@@ -338,17 +460,129 @@ ModulesBuilder::buildPrerequisiteModulesFor(PathRef File, return std::move(RequiredModules); } -bool StandalonePrerequisiteModules::canReuse( +ReusableModulesBuilder::ModuleBuildingSharedOwner +ReusableModulesBuilder::getOrCreateModuleBuildingOwner(Str

[clang] [clang] Lifetimebound in assignment operator should work for non-gsl annotated types. (PR #113180)

2024-10-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes This issue is identified during the discussion of [this comment](https://github.com/llvm/llvm-project/issues/112234#issuecomment-2426102198). There will be no release note for this fix as it is a follow-up to [

[clang] [compiler-rt] [llvm] [rtsan][llvm][NFC] Rename sanitize_realtime_unsafe attr to sanitize_realtime_blocking (PR #113155)

2024-10-21 Thread Chris Apple via cfe-commits
https://github.com/cjappl approved this pull request. LGTM - would love some eyes from more established folks to make sure we are not breaking any bw-compatability foo, and seeing as this spans the tree a bit. Definitely I am for this change, I think the attr is more clear this way, and we cau

[clang] [clang] Lifetimebound in assignment operator should work for non-gsl annotated types. (PR #113180)

2024-10-21 Thread Haojian Wu via cfe-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/113180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-10-21 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet requested changes to this pull request. https://github.com/llvm/llvm-project/pull/106683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >