malcolm.parsons added inline comments.
Comment at: include/clang/Sema/DeclSpec.h:1314
for (unsigned I = 0; I < NumParams; ++I) {
-delete Params[I].DefaultArgTokens;
-Params[I].DefaultArgTokens = nullptr;
+Params[I].DefaultArgTokens.release();
malcolm.parsons resigned from this revision.
malcolm.parsons removed a reviewer: malcolm.parsons.
malcolm.parsons added a comment.
In https://reviews.llvm.org/D26418#590476, @nkakuev wrote:
> On a second thought, ignoring note locations might be a good enough solution
> for me.
> How should I d
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, alexfh, flx.
malcolm.parsons added a subscriber: cfe-commits.
An addition to the move-constructor-init check was duplicating the
modernize-pass-by-value check.
Remove the additional check and UseCERTSemantics op
malcolm.parsons added a comment.
In https://reviews.llvm.org/D26453#590636, @flx wrote:
> Is the modernize-pass-by-value check configurable in a way to only trigger
> when copied constructor arguments are not moved?
No; good idea.
https://reviews.llvm.org/D26453
__
malcolm.parsons updated this revision to Diff 77358.
malcolm.parsons added a comment.
Update comment in performance-unnecessary-value-param check.
https://reviews.llvm.org/D26453
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/misc/MoveConstructorInitCheck.cpp
clang-tidy/misc/MoveCon
malcolm.parsons updated this revision to Diff 77371.
malcolm.parsons updated the summary for this revision.
malcolm.parsons added a comment.
Add ValuesOnly option to modernize-pass-by-value.
https://reviews.llvm.org/D26453
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/misc/MoveConstr
malcolm.parsons updated this revision to Diff 77456.
malcolm.parsons added a comment.
Store new option.
https://reviews.llvm.org/D26453
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/misc/MoveConstructorInitCheck.cpp
clang-tidy/misc/MoveConstructorInitCheck.h
clang-tidy/modernize/
On 9 November 2016 at 18:50, Devin Coughlin wrote:
> We agree that this is a valuable checker and are committed to getting it out
> of alpha. This check is in alpha because:
>
> a) The diagnostic experience is not very good. It reports a call path
> directly in the diagnostic message (for examp
malcolm.parsons added inline comments.
Comment at: clang-tidy/google/GlobalNamesCheck.cpp:96
+// main() should be in the global namespace.
+if (FDecl->isMain())
+ return;
Should `isMSVCRTEntryPoint()` be checked too?
https://reviews.llvm.org/D23130
Author: malcolm.parsons
Date: Thu Nov 10 10:19:17 2016
New Revision: 286466
URL: http://llvm.org/viewvc/llvm-project?rev=286466&view=rev
Log:
[clang-tidy] Add missing meta refresh for cert-msc30-c doc. NFC
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/cert-msc30-c.rst
Modified: cl
Author: malcolm.parsons
Date: Thu Nov 10 10:46:59 2016
New Revision: 286472
URL: http://llvm.org/viewvc/llvm-project?rev=286472&view=rev
Log:
[clang-tidy] Add modernize-use-equals-delete check
Summary: Fixes PR27872
Reviewers: klimek, hokein, alexfh, aaron.ballman
Subscribers: Prazek, Eugene.Ze
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286472: [clang-tidy] Add modernize-use-equals-delete check
(authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26138?vs=76971&id=77500#toc
Repository:
rL LLVM
https://r
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, alexfh, angelgarcia.
malcolm.parsons added a subscriber: cfe-commits.
Herald added a subscriber: mgorny.
https://reviews.llvm.org/D26511
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/Moder
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58
"modernize-use-bool-literals");
-CheckFactories.registerCheck("modernize-use-default");
+
CheckFactories.registerCheck("modernize-use-equals-default");
CheckFa
malcolm.parsons added a comment.
In https://reviews.llvm.org/D26511#592665, @Prazek wrote:
> It is introduced because of "modernize-use-delete" was too ambiguous because
> of operator delete, so it was changed to "modernize-use-equals-delete". But
> this case is not ambiguous at all, so I don't
malcolm.parsons updated this revision to Diff 77615.
malcolm.parsons added a comment.
Fix sorting.
Mention in release notes.
https://reviews.llvm.org/D26511
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseDefaultCheck.cpp
c
malcolm.parsons accepted this revision.
malcolm.parsons added a reviewer: malcolm.parsons.
malcolm.parsons added a comment.
This revision is now accepted and ready to land.
Your email went in my spam folder.
LGTM.
Will commit later.
https://reviews.llvm.org/D26435
On 11 November 2016 at 20:29, Artem Dergachev via cfe-commits
wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=286628&view=rev
> Log:
> [ASTMatchers] Fix a typo in cStyleCastExpr() docs. NFC.
>
> Modified:
> cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
Please change docs/LibASTMatch
malcolm.parsons requested changes to this revision.
malcolm.parsons added a comment.
This revision now requires changes to proceed.
Expected Passes: 4977
Expected Failures : 18
Unsupported Tests : 25
Unexpected Failures: 5037
Needs more work?
https://reviews.llvm.org/D26435
___
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, alexfh.
malcolm.parsons added a subscriber: cfe-commits.
Duplicate fixes were being created for explicit template instantiations
of out-of-line constructors or destructors.
Fixes PR30921.
https://reviews.llvm
malcolm.parsons added a subscriber: malcolm.parsons.
Comment at: docs/clang-tidy/checks/misc-sizeof-expression.rst:16
@@ +15,3 @@
+A common mistake is to query the ``sizeof`` of an integer literal. This is
+equivalent to query the size of it's type (probably ``int``). The intent o
301 - 321 of 321 matches
Mail list logo
